| Message ID | 20230927040438.5589-1-rdunlap@infradead.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp2618180vqu;
Wed, 27 Sep 2023 06:11:14 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IF1S8bE0fA3zntnpO37oO9iT7riHE86mAt0+jTz95ENjzoJe8rC8uQrRRHIyMEF7sy978le
X-Received: by 2002:a17:902:e809:b0:1c6:e8d:29d5 with SMTP id
u9-20020a170902e80900b001c60e8d29d5mr1962618plg.45.1695820274268;
Wed, 27 Sep 2023 06:11:14 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1695820274; cv=none;
d=google.com; s=arc-20160816;
b=XsB8Qx87y6On6HyIX9puuZs0yY7Cilfkp+CT4THEbbEWyo/qigOaDQSr84Wu2a8c5j
jLxf7MizRv60cwh8iv2mAX6WtKBBTRdYV5+8IVbaTAyDuu3ynhHlsUIaGF0MzSSocuOf
aMsSxx6cgx9y4D0apnGdg3C43sAudJmKCfgHYc+4E4SmuW91MStWDiTxaexUdX2NME1V
EkRQFBSMH7MyBz5c1fai+f/XKxPOM0qWbInT0OroIHRIWkhnRyZK97w94mjqCLdSDauf
2ACNn/HFa4P6ut+lR44ZYVjI9DedHCe5s4SXYYJW3378eWMywPXbTnEFupAX8P+WZuDL
eLGw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=0sZh/1s4l1Ej7E2RoqMSJQhDf2+cTCJZ1+N95YJfSho=;
fh=W+xfWYlBn5cCb4NtVIHR2m/pi9K95oDM24wnJJvgY2w=;
b=JgLeF2l6+n53fYj9W4LlokMcEq8LYvBdjj/deYfnUj56OgIh6VJHZKNgsus0BbX5PV
nDjXXsucZtAljo6X0ODeJeQo2DfRUZYdubPRMimWqGcbK3FZ3hGSXpNZ4qP99xiP7VDI
L4tghbNSFJF8VpYNOVjg/7iBGPTjN6NoAOhPkws6n3l9AAa8jHD4SXEAshJ/Z8Eg5hA5
AU5u8mfxWTvx8BtXUYVA2ZGYmqEFI2m6/ZWLpxSxAMqXg3bLELwSaqxEyejjBZwuykOP
eHi5+Psyh1ijKRaqUn2Om4H5Sg1v1InUNQk0BgqrD2kBJRmqYLjxUnV+EKbhPyoKo9De
aj1Q==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@infradead.org header.s=bombadil.20210309
header.b=Hx+UgjtA;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:7 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7])
by mx.google.com with ESMTPS id
x12-20020a170902ec8c00b001c43ff69d93si16843255plg.324.2023.09.27.06.11.13
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 27 Sep 2023 06:11:14 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:7 as permitted sender)
client-ip=2620:137:e000::3:7;
Authentication-Results: mx.google.com;
dkim=pass header.i=@infradead.org header.s=bombadil.20210309
header.b=Hx+UgjtA;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:7 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by snail.vger.email (Postfix) with ESMTP id D32B3807755F;
Tue, 26 Sep 2023 21:45:17 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229838AbjI0EpF (ORCPT <rfc822;pwkd43@gmail.com> + 26 others);
Wed, 27 Sep 2023 00:45:05 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40252 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229837AbjI0EoG (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 27 Sep 2023 00:44:06 -0400
Received: from bombadil.infradead.org (bombadil.infradead.org
[IPv6:2607:7c80:54:3::133])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9FA928FAF;
Tue, 26 Sep 2023 21:04:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:
Content-ID:Content-Description:In-Reply-To:References;
bh=0sZh/1s4l1Ej7E2RoqMSJQhDf2+cTCJZ1+N95YJfSho=;
b=Hx+UgjtAV11KKFXDxGhATPwGNT
b0OUgyX7gCCNuifMBEGniABLHrnyeyrZQuDVFIne1FSfftgNZkYs0k2iXGgpWmfeM+LNpXAt5hBgY
WW802GGb6L0zRnmyaJnMSMdqI709gS2f+nrZTXO+YHMyu56drt8osVQMaFevCJFjg9sRBCTL9hybF
LYfzw5akqpyr2+SPcNqrsXw7/seDeusDz9WFxGWGqa0Zy0JyurdEbgWBmL2WOIrY7qjeVspMsjY9O
CCtr8hesAX38GGMEcMvMMsMiyy/CTDlAPdiIHPLufg55Rn2+IN3B9dEIdJli+mp+eY1c6Pc5fvJF8
CyKy9GyA==;
Received: from [50.53.46.231] (helo=bombadil.infradead.org)
by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux))
id 1qlLmw-00HUyf-2k;
Wed, 27 Sep 2023 04:04:38 +0000
From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
kernel test robot <lkp@intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev
Subject: [PATCH] media: sunxi: a83-mips-csi2: also select GENERIC_PHY
Date: Tue, 26 Sep 2023 21:04:38 -0700
Message-ID: <20230927040438.5589-1-rdunlap@infradead.org>
X-Mailer: git-send-email 2.42.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]);
Tue, 26 Sep 2023 21:45:17 -0700 (PDT)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1778196440056302797
X-GMAIL-MSGID: 1778196440056302797
|
| Series |
media: sunxi: a83-mips-csi2: also select GENERIC_PHY
|
|
Commit Message
Randy Dunlap
Sept. 27, 2023, 4:04 a.m. UTC
When selecting GENERIC_PHY_MIPI_DPHY, also select GENERIC_PHY to
prevent kconfig warnings:
WARNING: unmet direct dependencies detected for GENERIC_PHY_MIPI_DPHY
Depends on [n]: GENERIC_PHY [=n]
Selected by [y]:
- VIDEO_SUN8I_A83T_MIPI_CSI2 [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && VIDEO_DEV [=y] && (ARCH_SUNXI || COMPILE_TEST [=y]) && PM [=y] && COMMON_CLK [=y] && RESET_CONTROLLER [=y]
Fixes: 94d7fd9692b5 ("media: sunxi: Depend on GENERIC_PHY_MIPI_DPHY")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Closes: lore.kernel.org/r/ZQ/WS8HC1A3F0Qn8@rli9-mobl
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Samuel Holland <samuel@sholland.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-sunxi@lists.linux.dev
---
drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig | 1 +
1 file changed, 1 insertion(+)
Comments
Hi Randy, Thanks for the patch. On Tue, Sep 26, 2023 at 09:04:38PM -0700, Randy Dunlap wrote: > When selecting GENERIC_PHY_MIPI_DPHY, also select GENERIC_PHY to > prevent kconfig warnings: > > WARNING: unmet direct dependencies detected for GENERIC_PHY_MIPI_DPHY > Depends on [n]: GENERIC_PHY [=n] > Selected by [y]: > - VIDEO_SUN8I_A83T_MIPI_CSI2 [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && VIDEO_DEV [=y] && (ARCH_SUNXI || COMPILE_TEST [=y]) && PM [=y] && COMMON_CLK [=y] && RESET_CONTROLLER [=y] > > Fixes: 94d7fd9692b5 ("media: sunxi: Depend on GENERIC_PHY_MIPI_DPHY") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Closes: lore.kernel.org/r/ZQ/WS8HC1A3F0Qn8@rli9-mobl > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Sakari Ailus <sakari.ailus@linux.intel.com> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > Cc: linux-media@vger.kernel.org > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: Jernej Skrabec <jernej.skrabec@gmail.com> > Cc: Samuel Holland <samuel@sholland.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-sunxi@lists.linux.dev > --- > drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff -- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig > --- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig > +++ b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig > @@ -8,6 +8,7 @@ config VIDEO_SUN8I_A83T_MIPI_CSI2 > select VIDEO_V4L2_SUBDEV_API > select V4L2_FWNODE > select REGMAP_MMIO > + select GENERIC_PHY Could GENERIC_PHY_MIPI_DPHY select GENERIC_PHY instead of depending it? There seem to be a few other drivers that appear to have the same issue. > select GENERIC_PHY_MIPI_DPHY > help > Support for the Allwinner A83T MIPI CSI-2 controller and D-PHY.
On 9/27/23 03:48, Sakari Ailus wrote: > Hi Randy, > > Thanks for the patch. > > On Tue, Sep 26, 2023 at 09:04:38PM -0700, Randy Dunlap wrote: >> When selecting GENERIC_PHY_MIPI_DPHY, also select GENERIC_PHY to >> prevent kconfig warnings: >> >> WARNING: unmet direct dependencies detected for GENERIC_PHY_MIPI_DPHY >> Depends on [n]: GENERIC_PHY [=n] >> Selected by [y]: >> - VIDEO_SUN8I_A83T_MIPI_CSI2 [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && VIDEO_DEV [=y] && (ARCH_SUNXI || COMPILE_TEST [=y]) && PM [=y] && COMMON_CLK [=y] && RESET_CONTROLLER [=y] >> >> Fixes: 94d7fd9692b5 ("media: sunxi: Depend on GENERIC_PHY_MIPI_DPHY") >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >> Reported-by: kernel test robot <lkp@intel.com> >> Closes: lore.kernel.org/r/ZQ/WS8HC1A3F0Qn8@rli9-mobl >> Cc: Arnd Bergmann <arnd@arndb.de> >> Cc: Sakari Ailus <sakari.ailus@linux.intel.com> >> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> >> Cc: linux-media@vger.kernel.org >> Cc: Chen-Yu Tsai <wens@csie.org> >> Cc: Jernej Skrabec <jernej.skrabec@gmail.com> >> Cc: Samuel Holland <samuel@sholland.org> >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-sunxi@lists.linux.dev >> --- >> drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff -- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig >> --- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig >> +++ b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig >> @@ -8,6 +8,7 @@ config VIDEO_SUN8I_A83T_MIPI_CSI2 >> select VIDEO_V4L2_SUBDEV_API >> select V4L2_FWNODE >> select REGMAP_MMIO >> + select GENERIC_PHY > > Could GENERIC_PHY_MIPI_DPHY select GENERIC_PHY instead of depending it? Yes, I don't see why not. Let's see what the PHY framework people have to say about it. Vinod, Kishon, do you see any reason that GENERIC_PHY_MIPI_DPHY could not select GENERIC_PHY instead of depending on it? > There seem to be a few other drivers that appear to have the same issue. Yes, I see 4 others that have the same issue. >> select GENERIC_PHY_MIPI_DPHY >> help >> Support for the Allwinner A83T MIPI CSI-2 controller and D-PHY. > ~Randy
diff -- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig --- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig +++ b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig @@ -8,6 +8,7 @@ config VIDEO_SUN8I_A83T_MIPI_CSI2 select VIDEO_V4L2_SUBDEV_API select V4L2_FWNODE select REGMAP_MMIO + select GENERIC_PHY select GENERIC_PHY_MIPI_DPHY help Support for the Allwinner A83T MIPI CSI-2 controller and D-PHY.