| Message ID | 20230927173245.2151083-3-andreas@kemnade.info |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp2827828vqu;
Wed, 27 Sep 2023 11:44:21 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IG2YWYSuZbXbxFxys1DPNKxQDfqs6MYlPfOg1U8/R4aZyI9FqAcpXGfeGBoc3zzleP+GHZX
X-Received: by 2002:a05:6358:52cf:b0:134:d45b:7dd1 with SMTP id
z15-20020a05635852cf00b00134d45b7dd1mr3735242rwz.21.1695840261432;
Wed, 27 Sep 2023 11:44:21 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1695840261; cv=none;
d=google.com; s=arc-20160816;
b=v2wPxQvhxa4VeDC8oakY4x+/5dzoprGlSDpCw6sHRs0xv4cNCU+roilXBe0QbdgDup
djvnc/g5Il3gpgQs44jg8gGKzZ6dm4x5pPPo0LwS+eTOO5VuGOPUi50JHhInW1lDoM80
HNbdUqCjRdvpKTfqRTjHLfal4ltLxfIHizjmBo4vNAnlO2IQ+6mlys8mICdz+PUMWUdO
pSzj0TcNCjsxp6su6eMJTQ8D/bvasw3KzGQP3r0uhwifToPWjOo4U6RqpX6mGYFdEaeM
DYN1JXbBeqOMnnstf6Tv69rOQx4aFWkuNZ6Q71XhOU6D+b+3M8M/SZnyOX9IH4dg8FOy
zs1Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:to:from;
bh=KlQx05gLKhGAmh+2+rwrHS9TnewJIEq8mEgqYuUQfwA=;
fh=uVMhKb/P8+EizzubcPWcViM8LxVsgVlwKzTll1iXK0Y=;
b=wzBUszh61GazAIs/clO6SPH/hwtcsFvi+p6Dw+AOQJfEQclL/zyOUMlyYmbBOsQ6RQ
RgzKLKBZxCLzlqGw6tQf1upqVvqPI461Ujs5FebQxjyUQOi4sVpk2jINplTHUipDLiwa
n/fd9sY+G42DNrCU0UUKWw8jYk77E5AON9dSngTXqn0aBgIpHhfjuiqhTIN6ffXB6EgD
NhcltQl7T8YdBo/Ef1V/Jf6hDrM6UVCTVKzr4lQ5JHcz0dsi1M36WPl8e03Eyo8JutQ5
Z3ZvYALGeX6A6be9Zj43ktZxRM+aPSEyARKlulGgEb2VbqO2LbL5AJmWBBjZJqChksg0
u1UQ==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:7 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7])
by mx.google.com with ESMTPS id
132-20020a63018a000000b0055fce913d52si15648087pgb.761.2023.09.27.11.44.21
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 27 Sep 2023 11:44:21 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:7 as permitted sender)
client-ip=2620:137:e000::3:7;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:7 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by snail.vger.email (Postfix) with ESMTP id 0C4DF8218E53;
Wed, 27 Sep 2023 10:33:15 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229561AbjI0RdF (ORCPT <rfc822;ruipengqi7@gmail.com> + 20 others);
Wed, 27 Sep 2023 13:33:05 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55334 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229460AbjI0RdD (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 27 Sep 2023 13:33:03 -0400
Received: from mail.andi.de1.cc (mail.andi.de1.cc
[IPv6:2a02:c205:3004:2154::1])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76B2EEB;
Wed, 27 Sep 2023 10:33:00 -0700 (PDT)
Received: from p200300ccff4287001a3da2fffebfd33a.dip0.t-ipconnect.de
([2003:cc:ff42:8700:1a3d:a2ff:febf:d33a] helo=aktux)
by mail.andi.de1.cc with esmtpsa (TLS1.3) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
(Exim 4.94.2)
(envelope-from <andreas@kemnade.info>)
id 1qlYP2-004Exz-51; Wed, 27 Sep 2023 19:32:47 +0200
Received: from andi by aktux with local (Exim 4.96)
(envelope-from <andreas@kemnade.info>)
id 1qlYP1-0091bM-1L;
Wed, 27 Sep 2023 19:32:47 +0200
From: Andreas Kemnade <andreas@kemnade.info>
To: jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
bcousson@baylibre.com, tony@atomide.com, andreas@kemnade.info,
chenhuiz@axis.com, jean-baptiste.maneyrol@tdk.com,
andy.shevchenko@gmail.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: [PATCH v3 2/3] iio: imu: mpu6050: add level shifter flag
Date: Wed, 27 Sep 2023 19:32:44 +0200
Message-Id: <20230927173245.2151083-3-andreas@kemnade.info>
X-Mailer: git-send-email 2.39.2
In-Reply-To: <20230927173245.2151083-1-andreas@kemnade.info>
References: <20230927173245.2151083-1-andreas@kemnade.info>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,
RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]);
Wed, 27 Sep 2023 10:33:15 -0700 (PDT)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1778217397686720222
X-GMAIL-MSGID: 1778217397686720222
|
| Series |
ARM: omap: omap4-embt2ws: Add IMU on control unit
|
|
Commit Message
Andreas Kemnade
Sept. 27, 2023, 5:32 p.m. UTC
Some boards fail in magnetometer probe if level shifter flag is not set, definition was found in the vendor Linux kernel v3.0. Signed-off-by: Andreas Kemnade <andreas@kemnade.info> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> --- drivers/iio/imu/inv_mpu6050/inv_mpu_aux.c | 13 +++++++++++++ drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 3 +++ drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 1 + 3 files changed, 17 insertions(+)
Comments
Hello, looks good for me. Acked-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> Thanks, JB From: Andreas Kemnade <andreas@kemnade.info> Sent: Wednesday, September 27, 2023 19:32 To: jic23@kernel.org <jic23@kernel.org>; lars@metafoo.de <lars@metafoo.de>; robh+dt@kernel.org <robh+dt@kernel.org>; krzysztof.kozlowski+dt@linaro.org <krzysztof.kozlowski+dt@linaro.org>; conor+dt@kernel.org <conor+dt@kernel.org>; bcousson@baylibre.com <bcousson@baylibre.com>; tony@atomide.com <tony@atomide.com>; andreas@kemnade.info <andreas@kemnade.info>; chenhuiz@axis.com <chenhuiz@axis.com>; Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com>; andy.shevchenko@gmail.com <andy.shevchenko@gmail.com>; linux-iio@vger.kernel.org <linux-iio@vger.kernel.org>; devicetree@vger.kernel.org <devicetree@vger.kernel.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; linux-omap@vger.kernel.org <linux-omap@vger.kernel.org> Subject: [PATCH v3 2/3] iio: imu: mpu6050: add level shifter flag Some boards fail in magnetometer probe if level shifter flag is not set, definition was found in the vendor Linux kernel v3. 0. Signed-off-by: Andreas Kemnade <andreas@ kemnade. info> Reviewed-by: Andy Shevchenko <andy. shevchenko@ gmail. com> ZjQcmQRYFpfptBannerStart This Message Is From an External Sender This message came from outside your organization. ZjQcmQRYFpfptBannerEnd Some boards fail in magnetometer probe if level shifter flag is not set, definition was found in the vendor Linux kernel v3.0. Signed-off-by: Andreas Kemnade <andreas@kemnade.info> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> --- drivers/iio/imu/inv_mpu6050/inv_mpu_aux.c | 13 +++++++++++++ drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 3 +++ drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 1 + 3 files changed, 17 insertions(+) diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_aux.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_aux.c index 7327e5723f961..8a7f2911905af 100644 --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_aux.c +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_aux.c @@ -71,6 +71,19 @@ int inv_mpu_aux_init(const struct inv_mpu6050_state *st) unsigned int val; int ret; + /* + * Code based on the vendor Linux kernel v3.0, + * the exact meaning is unknown. + */ + if (st->chip_type == INV_MPU9150) { + unsigned int mask = BIT(7); + + val = st->level_shifter ? mask : 0; + ret = regmap_update_bits(st->map, 0x1, mask, val); + if (ret) + return ret; + } + /* configure i2c master */ val = INV_MPU6050_BITS_I2C_MST_CLK_400KHZ | INV_MPU6050_BIT_WAIT_FOR_ES; diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c index 29f906c884bd8..3fbeef1a70186 100644 --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c @@ -17,6 +17,7 @@ #include <linux/regulator/consumer.h> #include <linux/pm.h> #include <linux/pm_runtime.h> +#include <linux/property.h> #include <linux/iio/common/inv_sensors_timestamp.h> #include <linux/iio/iio.h> @@ -1495,6 +1496,8 @@ int inv_mpu_core_probe(struct regmap *regmap, int irq, const char *name, st->irq = irq; st->map = regmap; + st->level_shifter = device_property_read_bool(dev, + "invensense,level-shifter"); pdata = dev_get_platdata(dev); if (!pdata) { result = iio_read_mount_matrix(dev, &st->orientation); diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h index ed5a96e78df05..7eba1439c8093 100644 --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h @@ -203,6 +203,7 @@ struct inv_mpu6050_state { s32 magn_raw_to_gauss[3]; struct iio_mount_matrix magn_orient; unsigned int suspended_sensors; + bool level_shifter; u8 *data; };
On Wed, 27 Sep 2023 19:08:31 +0000 Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com> wrote: > Hello, > > looks good for me. > > Acked-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> Applied patches 1 and 2 to the togreg branch of iio.git which I will initially push out as testing to let 0-day poke at it, Thanks, Jonathan > > Thanks, > JB > > > From: Andreas Kemnade <andreas@kemnade.info> > Sent: Wednesday, September 27, 2023 19:32 > To: jic23@kernel.org <jic23@kernel.org>; lars@metafoo.de <lars@metafoo.de>; robh+dt@kernel.org <robh+dt@kernel.org>; krzysztof.kozlowski+dt@linaro.org <krzysztof.kozlowski+dt@linaro.org>; conor+dt@kernel.org <conor+dt@kernel.org>; bcousson@baylibre.com <bcousson@baylibre.com>; tony@atomide.com <tony@atomide.com>; andreas@kemnade.info <andreas@kemnade.info>; chenhuiz@axis.com <chenhuiz@axis.com>; Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com>; andy.shevchenko@gmail.com <andy.shevchenko@gmail.com>; linux-iio@vger.kernel.org <linux-iio@vger.kernel.org>; devicetree@vger.kernel.org <devicetree@vger.kernel.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; linux-omap@vger.kernel.org <linux-omap@vger.kernel.org> > Subject: [PATCH v3 2/3] iio: imu: mpu6050: add level shifter flag > > Some boards fail in magnetometer probe if level shifter flag is not set, definition was found in the vendor Linux kernel v3. 0. Signed-off-by: Andreas Kemnade <andreas@ kemnade. info> Reviewed-by: Andy Shevchenko <andy. shevchenko@ gmail. com> > ZjQcmQRYFpfptBannerStart > This Message Is From an External Sender > This message came from outside your organization. > > ZjQcmQRYFpfptBannerEnd > Some boards fail in magnetometer probe if level shifter flag is not set, > definition was found in the vendor Linux kernel v3.0. > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > --- > drivers/iio/imu/inv_mpu6050/inv_mpu_aux.c | 13 +++++++++++++ > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 3 +++ > drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 1 + > 3 files changed, 17 insertions(+) > > diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_aux.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_aux.c > index 7327e5723f961..8a7f2911905af 100644 > --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_aux.c > +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_aux.c > @@ -71,6 +71,19 @@ int inv_mpu_aux_init(const struct inv_mpu6050_state *st) > unsigned int val; > int ret; > > + /* > + * Code based on the vendor Linux kernel v3.0, > + * the exact meaning is unknown. > + */ > + if (st->chip_type == INV_MPU9150) { > + unsigned int mask = BIT(7); > + > + val = st->level_shifter ? mask : 0; > + ret = regmap_update_bits(st->map, 0x1, mask, val); > + if (ret) > + return ret; > + } > + > /* configure i2c master */ > val = INV_MPU6050_BITS_I2C_MST_CLK_400KHZ | > INV_MPU6050_BIT_WAIT_FOR_ES; > diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c > index 29f906c884bd8..3fbeef1a70186 100644 > --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c > +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c > @@ -17,6 +17,7 @@ > #include <linux/regulator/consumer.h> > #include <linux/pm.h> > #include <linux/pm_runtime.h> > +#include <linux/property.h> > > #include <linux/iio/common/inv_sensors_timestamp.h> > #include <linux/iio/iio.h> > @@ -1495,6 +1496,8 @@ int inv_mpu_core_probe(struct regmap *regmap, int irq, const char *name, > st->irq = irq; > st->map = regmap; > > + st->level_shifter = device_property_read_bool(dev, > + "invensense,level-shifter"); > pdata = dev_get_platdata(dev); > if (!pdata) { > result = iio_read_mount_matrix(dev, &st->orientation); > diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h > index ed5a96e78df05..7eba1439c8093 100644 > --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h > +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h > @@ -203,6 +203,7 @@ struct inv_mpu6050_state { > s32 magn_raw_to_gauss[3]; > struct iio_mount_matrix magn_orient; > unsigned int suspended_sensors; > + bool level_shifter; > u8 *data; > }; >
diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_aux.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_aux.c index 7327e5723f961..8a7f2911905af 100644 --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_aux.c +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_aux.c @@ -71,6 +71,19 @@ int inv_mpu_aux_init(const struct inv_mpu6050_state *st) unsigned int val; int ret; + /* + * Code based on the vendor Linux kernel v3.0, + * the exact meaning is unknown. + */ + if (st->chip_type == INV_MPU9150) { + unsigned int mask = BIT(7); + + val = st->level_shifter ? mask : 0; + ret = regmap_update_bits(st->map, 0x1, mask, val); + if (ret) + return ret; + } + /* configure i2c master */ val = INV_MPU6050_BITS_I2C_MST_CLK_400KHZ | INV_MPU6050_BIT_WAIT_FOR_ES; diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c index 29f906c884bd8..3fbeef1a70186 100644 --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c @@ -17,6 +17,7 @@ #include <linux/regulator/consumer.h> #include <linux/pm.h> #include <linux/pm_runtime.h> +#include <linux/property.h> #include <linux/iio/common/inv_sensors_timestamp.h> #include <linux/iio/iio.h> @@ -1495,6 +1496,8 @@ int inv_mpu_core_probe(struct regmap *regmap, int irq, const char *name, st->irq = irq; st->map = regmap; + st->level_shifter = device_property_read_bool(dev, + "invensense,level-shifter"); pdata = dev_get_platdata(dev); if (!pdata) { result = iio_read_mount_matrix(dev, &st->orientation); diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h index ed5a96e78df05..7eba1439c8093 100644 --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h @@ -203,6 +203,7 @@ struct inv_mpu6050_state { s32 magn_raw_to_gauss[3]; struct iio_mount_matrix magn_orient; unsigned int suspended_sensors; + bool level_shifter; u8 *data; };