| Message ID | 20230927-docs-cc-reviewer-v1-1-2af46ceb2d3c@weissschuh.net |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp2855121vqu;
Wed, 27 Sep 2023 12:31:26 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IHXNSXLjYEAf7CuqDBCeU9gulnMTeeer85/NOFZedWMZMP3YvEHqG7H2oki9m/ojfy4X7ND
X-Received: by 2002:a17:902:b90c:b0:1c5:b855:38f with SMTP id
bf12-20020a170902b90c00b001c5b855038fmr2505165plb.24.1695843086464;
Wed, 27 Sep 2023 12:31:26 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1695843086; cv=none;
d=google.com; s=arc-20160816;
b=sJ9JE4yY7F2JChPAL1Mi7Jo2CqpkTPRLenZlyYlUHLwRaqCglpN08cXuLgM3juMz76
ehRjIkFaCsMALNGk8rsBkEqNPud4k6tF9xGpi2PqQ+rWBDYzaLu1l9YZgVDnT03hoHFn
eNxDOiFadFzHCV4qpM3locOJ94F/QoK599i6xHeYbXGeGec6A6HDxPFND6O6uPK75yOZ
nvO9TsVFSWXZwCz9HBD4eHM0f4XkTG5Vss2Y9AOGmEa34hceFVxHF0EPAnghDM1eFw0n
aa8dfg07zLWsPqGNeJtcsduroCx7Lha2UW/zykFnnGyOgXVwKs3xIlRveziyQfzGvfRW
WAtw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:cc:to:message-id:content-transfer-encoding
:mime-version:subject:date:from:dkim-signature;
bh=QqeAVJ8XTvFIU1dEKSY6t3Rs/RJtCzJe1qTUC30pd7A=;
fh=Ye5jxIiBVR2ZtPBINLEsUiUGCEzvTZcDjiV6YcaQRtY=;
b=B1X9Jkqyi1G7MR2yUlcCHLEKOtUCpGtpemqQXdmUFxTnilqC6u6L4KBVfn/+d/8W+q
gso6sTlzcASsQnR2FqFE5n26gVB3Qiqz43CMW8iPte/XGbcDistu/S90i6s3kkNFn0y4
BUffS8enM8Pb30JC7wdhHq2VrnxYdkNol5dzmmuqjEYELLWt1ITrlCv+0ukGR/8jFI0I
p9LTsZZSewh8xfR0NctOvAoVUNo2yvcdp/Ty9Q8jiPR/qHESRdSnnwXlY8mPbGpzjRx5
lCXOhBQnVZPOXtZGoUkbkDD6l5UVZbuL0MpEpCU1MkYF8TOxiq5o1tfE5HUHoJEg627L
koKA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@weissschuh.net header.s=mail header.b=UfKTNzBq;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:6 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6])
by mx.google.com with ESMTPS id
o13-20020a170902d4cd00b001b3d6c68bd1si2983596plg.643.2023.09.27.12.31.26
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 27 Sep 2023 12:31:26 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:6 as permitted sender)
client-ip=2620:137:e000::3:6;
Authentication-Results: mx.google.com;
dkim=pass header.i=@weissschuh.net header.s=mail header.b=UfKTNzBq;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:6 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by pete.vger.email (Postfix) with ESMTP id 7A09580BA432;
Wed, 27 Sep 2023 11:52:43 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229592AbjI0Sw3 (ORCPT <rfc822;ruipengqi7@gmail.com> + 20 others);
Wed, 27 Sep 2023 14:52:29 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40012 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229437AbjI0Sw2 (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 27 Sep 2023 14:52:28 -0400
Received: from todd.t-8ch.de (todd.t-8ch.de [IPv6:2a01:4f8:c010:41de::1])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 103D4F4;
Wed, 27 Sep 2023 11:52:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net;
s=mail; t=1695840744;
bh=8oZRiC8TvCCvbc1U3s09oWhk9JsHYoBMdt9cosRWsYM=;
h=From:Date:Subject:To:Cc:From;
b=UfKTNzBqFvwTJs2Pwg4V20sG3VT8gvUMR6av4BWW2rXDtje/mTHc9piC6RREUTJDe
g4QNSItmcjQVRmyJ2mM/VgrmKkS8gWwvDJGij3KebLhlsezGogEYq3EKHbrAc/6Z2h
AxHqNRo7gbrTpAOwu9o/dmNmqyWYKWhfYAK/YlPU=
From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>
Date: Wed, 27 Sep 2023 20:52:21 +0200
Subject: [PATCH] docs: submitting-patches: encourage direct notifications
to reviewers
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Message-Id: <20230927-docs-cc-reviewer-v1-1-2af46ceb2d3c@weissschuh.net>
X-B4-Tracking: v=1; b=H4sIAOR5FGUC/x2MQQqAIBBFryKzbsAUirpKtDAdazYaChWId89aP
v77r0CmxJRhFgUSXZw5hgZ9J8AeJuyE7BqDkkrLSQ3oos1oLX4y3ZSwDZsetTReaWi3M5Hn508
ua60vldVHM2IAAAA=
To: Jonathan Corbet <corbet@lwn.net>
Cc: workflows@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
=?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>
X-Mailer: b4 0.12.3
X-Developer-Signature: v=1; a=ed25519-sha256; t=1695840741; l=1607;
i=linux@weissschuh.net; s=20221212; h=from:subject:message-id;
bh=8oZRiC8TvCCvbc1U3s09oWhk9JsHYoBMdt9cosRWsYM=;
b=MnRSaxqNEAbHX1QM+QeisRMxytq2IWJcRAbTtPLCweS9V5xyi6EpajjQePm3w+NO2XQyO60Wv
CTyCnhRYc6oCgMpoJblHJw8yM9hwZiBgy66btUojD74RSR6MgFJ4l7M
X-Developer-Key: i=linux@weissschuh.net; a=ed25519;
pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw=
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]);
Wed, 27 Sep 2023 11:52:43 -0700 (PDT)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1778220360406234262
X-GMAIL-MSGID: 1778220360406234262
|
| Series |
docs: submitting-patches: encourage direct notifications to reviewers
|
|
Commit Message
Thomas Weißschuh
Sept. 27, 2023, 6:52 p.m. UTC
Reviewers may not receive new versions of patches via the lists.
Without a directed notification to them they might miss those new
versions.
This is frustrating for the patch developers as they don't receive their
earned Reviewed-by.
It is also frustrating for the reviewers, as they might think their
review got ignored or they have to dig up new versions from the archive
manually.
So encourage patch submitters to make sure that all reviewers get
notified also when no Reviewed-by was issued yet.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
Documentation/process/submitting-patches.rst | 2 ++
1 file changed, 2 insertions(+)
---
base-commit: 633b47cb009d09dc8f4ba9cdb3a0ca138809c7c7
change-id: 20230926-docs-cc-reviewer-023b3730af23
Best regards,
Comments
NAK. This does not scale. Please read the mailinglist, that's the whole point of having it.
On Thu, Sep 28, 2023 at 02:13:35AM -0700, Christoph Hellwig wrote: > NAK. > > This does not scale. Please read the mailinglist, that's the whole > point of having it. Can lei help here, would there be a way to match on new versions of a series based on who was in the mail thread for previous versions ?
Hi Christoph, On 2023-09-28 02:13:35-0700, Christoph Hellwig wrote: > NAK. That's honestly surprising. I mentioned this process in various reviews before and nobody had issues with it so far. > This does not scale. Could you elaborate in which way it doesn't scale? > Please read the mailinglist, that's the whole > point of having it. When reviewing things in various subsystem this would require reading all of LKML, which is impractical. The goal of this patch was to make life easier for occasional reviewers. If it negatively impacts the maintainers then that's not gonna work. Thomas
On Fri, Sep 29, 2023 at 09:24:57AM +0200, Thomas Weißschuh wrote: > > This does not scale. > > Could you elaborate in which way it doesn't scale? If I send a modest cross-subsystem series it often touches 20+ subsystems. Between mailing lists and maintainers that's usually already 60+ recipients. If you now add a another 2-3 maintainers we're just going to hit limits in mail servers. > > Please read the mailinglist, that's the whole > > point of having it. > > When reviewing things in various subsystem this would require reading > all of LKML, which is impractical. Works with your maintainers to have useful lists for their subsystems. That's again the point.
On Sun, 01 Oct 2023, Christoph Hellwig <hch@infradead.org> wrote: > On Fri, Sep 29, 2023 at 09:24:57AM +0200, Thomas Weißschuh wrote: >> > This does not scale. >> >> Could you elaborate in which way it doesn't scale? > > If I send a modest cross-subsystem series it often touches 20+ > subsystems. Between mailing lists and maintainers that's usually > already 60+ recipients. If you now add a another 2-3 maintainers > we're just going to hit limits in mail servers. I thought this was about adding people who have commented on previous versions to Cc. That's usually a very limited number. BR, Jani.
On Mon, Oct 02, 2023 at 10:36:01AM +0300, Jani Nikula wrote: > On Sun, 01 Oct 2023, Christoph Hellwig <hch@infradead.org> wrote: > > On Fri, Sep 29, 2023 at 09:24:57AM +0200, Thomas Weißschuh wrote: > >> > This does not scale. > >> > >> Could you elaborate in which way it doesn't scale? > > > > If I send a modest cross-subsystem series it often touches 20+ > > subsystems. Between mailing lists and maintainers that's usually > > already 60+ recipients. If you now add a another 2-3 maintainers > > we're just going to hit limits in mail servers. > > I thought this was about adding people who have commented on previous > versions to Cc. That's usually a very limited number. Oh, that absolutely makes sense. But maybe we need to stop overloading the term reviewer :)
On 2023-10-02 01:50:11-0700, Christoph Hellwig wrote: > On Mon, Oct 02, 2023 at 10:36:01AM +0300, Jani Nikula wrote: > > On Sun, 01 Oct 2023, Christoph Hellwig <hch@infradead.org> wrote: > > > On Fri, Sep 29, 2023 at 09:24:57AM +0200, Thomas Weißschuh wrote: > > >> > This does not scale. > > >> > > >> Could you elaborate in which way it doesn't scale? > > > > > > If I send a modest cross-subsystem series it often touches 20+ > > > subsystems. Between mailing lists and maintainers that's usually > > > already 60+ recipients. If you now add a another 2-3 maintainers > > > we're just going to hit limits in mail servers. > > > > I thought this was about adding people who have commented on previous > > versions to Cc. That's usually a very limited number. > > Oh, that absolutely makes sense. But maybe we need to stop overloading > the term reviewer :) Thanks Jani for fixing the misunderstanding! I'll try to find some better wording.
diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst index efac910e2659..8dca82dfcd69 100644 --- a/Documentation/process/submitting-patches.rst +++ b/Documentation/process/submitting-patches.rst @@ -327,6 +327,8 @@ politely and address the problems they have pointed out. When sending a next version, add a ``patch changelog`` to the cover letter or to individual patches explaining difference against previous submission (see :ref:`the_canonical_patch_format`). +Notify reviewers and other involved people about new versions of your patch by +adding them to the patches CC list. See Documentation/process/email-clients.rst for recommendations on email clients and mailing list etiquette.