Message ID | 20230929084209.3033093-4-quic_ipkumar@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp3966869vqu; Fri, 29 Sep 2023 04:56:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEMfXCagHZG/VDSjGvSqGSkgn8yR9zR+tyVPrVPzp5UsQGM/mub2Nh83QInV5pmGbY7sbfm X-Received: by 2002:a9d:6b86:0:b0:6bd:11b:39bf with SMTP id b6-20020a9d6b86000000b006bd011b39bfmr3802992otq.4.1695988584306; Fri, 29 Sep 2023 04:56:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695988584; cv=none; d=google.com; s=arc-20160816; b=OTbxfwZTkey2QZ763DE1BI3zWiJRMWz9xIwIz0yIFlJdI59EA9XyxkkIbStuAU/Bpr yDphLOTHOnxI0cTeAlt+10N4cBj/V69Hq/38KcrBGDsZ5R/fkZ0uzTDQ0gNR6wvAc+u8 /dhdGcqm2VIHB3F5oB7uD0Rmw6zYfF1NgcP3yOiPhtIuwjeHQ7q7rGdqBYqw0qjeKopk rzYJEkkNs6CBgai6UrKIUiRUNKSjMa/Cs5PL/2ZT69Sm/MaAUTmjY+FRaSI2OKZiFkoa sDzpiOWWAC/0AiZju/WZlrhm67cK+PeYCqCyXzfgRszKyTrHLNfPt8ZCbY/9SgKk/lvQ UAjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=nB0FggN8J+ivI3SuN9O6qu/MgW9HIfMXTdvR1pgz8BQ=; fh=/y3C3YtKy84M5cSpQOYdVWwJq454ogwAI2SrqSRafB8=; b=ztVfXX85Cz3hco//+YZfUvXkM9n61PBAEP8vJ4hpZ69IUJNEnQuZcf5HN/TI5m09ld bdKArgqNTsishFcmln3r2pYLYGh1TfQfuAkS7quzam35BA88DYGEFBqiYqbhOXiYt256 po0Bk3qUbnAc1d6dUQAG4nm0P5Nl839fONddUY3AqO0QrjnNIdmC+tD55fV8FjV7pTRf nhYjcrsqbthgTm9WIQdFfSsDeP3EP5E05oXjnlw+zTAPDeJ+ajT7dBct5jwLrvh3+kw9 DBVZgHixeAlVP4ZgNKAwtpFgEyXoNA626Ha1PdvQd+TGSj/aMpHzaYYVG1I7c3x1uYwO ElNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="jkyZv/Wc"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id q187-20020a632ac4000000b00577a083624csi20223864pgq.89.2023.09.29.04.56.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Sep 2023 04:56:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="jkyZv/Wc"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id DDEFF83D0EDE; Fri, 29 Sep 2023 01:44:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232938AbjI2Ino (ORCPT <rfc822;pwkd43@gmail.com> + 20 others); Fri, 29 Sep 2023 04:43:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232911AbjI2In3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 29 Sep 2023 04:43:29 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8907CE3; Fri, 29 Sep 2023 01:43:27 -0700 (PDT) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38T7Urv3027510; Fri, 29 Sep 2023 08:43:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=qcppdkim1; bh=nB0FggN8J+ivI3SuN9O6qu/MgW9HIfMXTdvR1pgz8BQ=; b=jkyZv/WcnQ6FbHJOs+UjTSd7MFQHW9oem+4HfoNr327tF7kSQPuBCvPgVyviZnIymvHS DSF5X9CWWS9zmi4IcfWoZxZewvjXLmH68o3IeOOp5t4tgpZw7moQHCj9siMKzjb9Oi1q /lUFOf5W6Q+NH7LtohBBlgdyhMi9+TQPKX4B2sob73J/bcan4N3QTqq0V4d1Ifgb5+dy fj3WBOyG46QS1DUhmvg7Wf5qKCLc6C49v3fY0nKgcc2dh7JuVByCAf73wB4llhKKbFDr tEPsVSAscCNEVi3gGPi0dumr+OAmq3kcXMJ8cmUKDKpfxhCSE6JHDPgXM/wEZZMs3edJ Ew== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3tdqmv8d9b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Sep 2023 08:43:02 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38T8h2cC027673 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Sep 2023 08:43:02 GMT Received: from hu-ipkumar-blr.qualcomm.com (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Fri, 29 Sep 2023 01:42:52 -0700 From: Praveenkumar I <quic_ipkumar@quicinc.com> To: <agross@kernel.org>, <andersson@kernel.org>, <konrad.dybcio@linaro.org>, <vkoul@kernel.org>, <kishon@kernel.org>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>, <gregkh@linuxfoundation.org>, <catalin.marinas@arm.com>, <will@kernel.org>, <p.zabel@pengutronix.de>, <geert+renesas@glider.be>, <arnd@arndb.de>, <neil.armstrong@linaro.org>, <nfraprado@collabora.com>, <u-kumar1@ti.com>, <peng.fan@nxp.com>, <quic_wcheng@quicinc.com>, <quic_varada@quicinc.com>, <linux-arm-msm@vger.kernel.org>, <linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org> CC: <quic_kathirav@quicinc.com>, <quic_nsekar@quicinc.com>, <quic_srichara@quicinc.com> Subject: [PATCH 3/8] arm64: dts: qcom: ipq5332: Add USB Super-Speed PHY node Date: Fri, 29 Sep 2023 14:12:04 +0530 Message-ID: <20230929084209.3033093-4-quic_ipkumar@quicinc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230929084209.3033093-1-quic_ipkumar@quicinc.com> References: <20230929084209.3033093-1-quic_ipkumar@quicinc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 8jRScBPWSqRMlnJCF3T2QGnUlZKIeR1P X-Proofpoint-ORIG-GUID: 8jRScBPWSqRMlnJCF3T2QGnUlZKIeR1P X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-09-29_07,2023-09-28_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=519 spamscore=0 bulkscore=0 mlxscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 impostorscore=0 clxscore=1015 adultscore=0 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2309290074 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 29 Sep 2023 01:44:03 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778372925538324490 X-GMAIL-MSGID: 1778372925538324490 |
Series |
Enable USB3 for Qualcomm IPQ5332
|
|
Commit Message
Praveenkumar I
Sept. 29, 2023, 8:42 a.m. UTC
Add USB Super-Speed UNIPHY node and populate the phandle on
gcc node for the parent clock map.
Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
---
arch/arm64/boot/dts/qcom/ipq5332.dtsi | 25 ++++++++++++++++++++++++-
1 file changed, 24 insertions(+), 1 deletion(-)
Comments
On 29.09.2023 10:42, Praveenkumar I wrote: > Add USB Super-Speed UNIPHY node and populate the phandle on > gcc node for the parent clock map. > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > --- > arch/arm64/boot/dts/qcom/ipq5332.dtsi | 25 ++++++++++++++++++++++++- > 1 file changed, 24 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > index d3fef2f80a81..b08ffd8c094e 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > @@ -158,6 +158,29 @@ usbphy0: phy@7b000 { > status = "disabled"; > }; > > + usbphy1: phy@4b0000 { > + compatible = "qcom,ipq5332-usb-uniphy"; > + reg = <0x4b0000 0x800>; Please pad the address part to 8 hex digits with leading zeroes. > + > + clocks = <&gcc GCC_PCIE3X1_PHY_AHB_CLK>, > + <&gcc GCC_USB0_PHY_CFG_AHB_CLK>, > + <&gcc GCC_USB0_PIPE_CLK>; > + clock-names = "ahb", > + "cfg_ahb", > + "pipe"; > + > + resets = <&gcc GCC_USB0_PHY_BCR>; Looks like there's a double space after '=' Konrad
On 9/29/2023 6:26 PM, Konrad Dybcio wrote: > On 29.09.2023 10:42, Praveenkumar I wrote: >> Add USB Super-Speed UNIPHY node and populate the phandle on >> gcc node for the parent clock map. >> >> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/ipq5332.dtsi | 25 ++++++++++++++++++++++++- >> 1 file changed, 24 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi >> index d3fef2f80a81..b08ffd8c094e 100644 >> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi >> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi >> @@ -158,6 +158,29 @@ usbphy0: phy@7b000 { >> status = "disabled"; >> }; >> >> + usbphy1: phy@4b0000 { >> + compatible = "qcom,ipq5332-usb-uniphy"; >> + reg = <0x4b0000 0x800>; > Please pad the address part to 8 hex digits with leading zeroes. Sure, will add. > >> + >> + clocks = <&gcc GCC_PCIE3X1_PHY_AHB_CLK>, >> + <&gcc GCC_USB0_PHY_CFG_AHB_CLK>, >> + <&gcc GCC_USB0_PIPE_CLK>; >> + clock-names = "ahb", >> + "cfg_ahb", >> + "pipe"; >> + >> + resets = <&gcc GCC_USB0_PHY_BCR>; > Looks like there's a double space after '=' Sure, will remove the extra space. -- Thanks, Praveenkumar > > Konrad
On 29/09/2023 11:42, Praveenkumar I wrote: > Add USB Super-Speed UNIPHY node and populate the phandle on > gcc node for the parent clock map. > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > --- > arch/arm64/boot/dts/qcom/ipq5332.dtsi | 25 ++++++++++++++++++++++++- > 1 file changed, 24 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > index d3fef2f80a81..b08ffd8c094e 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > @@ -158,6 +158,29 @@ usbphy0: phy@7b000 { > status = "disabled"; > }; > > + usbphy1: phy@4b0000 { Are there other USB PHYs on this platform? > + compatible = "qcom,ipq5332-usb-uniphy"; > + reg = <0x4b0000 0x800>; > + > + clocks = <&gcc GCC_PCIE3X1_PHY_AHB_CLK>, > + <&gcc GCC_USB0_PHY_CFG_AHB_CLK>, > + <&gcc GCC_USB0_PIPE_CLK>; > + clock-names = "ahb", > + "cfg_ahb", > + "pipe"; > + > + resets = <&gcc GCC_USB0_PHY_BCR>; > + > + #clock-cells = <0>; > + clock-output-names = "usb0_pipe_clk_src"; I'm not sure, what is the best approach her. For QMP USB and PCIe PHYs we had to use fixed names historically. On the other hand for QMP DP clocks we are fine with the generated names. I'd prefer the latter case. > + > + qcom,phy-usb-mux-sel = <&tcsr 0x10540>; > + > + #phy-cells = <0>; > + > + status = "disabled"; > + }; > + > qfprom: efuse@a4000 { > compatible = "qcom,ipq5332-qfprom", "qcom,qfprom"; > reg = <0x000a4000 0x721>; > @@ -200,7 +223,7 @@ gcc: clock-controller@1800000 { > <&sleep_clk>, > <0>, > <0>, > - <0>; > + <&usbphy1>; > }; > > tcsr_mutex: hwlock@1905000 {
On 9/30/2023 10:52 PM, Dmitry Baryshkov wrote: > On 29/09/2023 11:42, Praveenkumar I wrote: >> Add USB Super-Speed UNIPHY node and populate the phandle on >> gcc node for the parent clock map. >> >> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/ipq5332.dtsi | 25 ++++++++++++++++++++++++- >> 1 file changed, 24 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi >> b/arch/arm64/boot/dts/qcom/ipq5332.dtsi >> index d3fef2f80a81..b08ffd8c094e 100644 >> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi >> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi >> @@ -158,6 +158,29 @@ usbphy0: phy@7b000 { >> status = "disabled"; >> }; >> + usbphy1: phy@4b0000 { > > Are there other USB PHYs on this platform? No. Only two USB PHYs. > >> + compatible = "qcom,ipq5332-usb-uniphy"; >> + reg = <0x4b0000 0x800>; >> + >> + clocks = <&gcc GCC_PCIE3X1_PHY_AHB_CLK>, >> + <&gcc GCC_USB0_PHY_CFG_AHB_CLK>, >> + <&gcc GCC_USB0_PIPE_CLK>; >> + clock-names = "ahb", >> + "cfg_ahb", >> + "pipe"; >> + >> + resets = <&gcc GCC_USB0_PHY_BCR>; >> + >> + #clock-cells = <0>; >> + clock-output-names = "usb0_pipe_clk_src"; > > I'm not sure, what is the best approach her. For QMP USB and PCIe PHYs > we had to use fixed names historically. On the other hand for QMP DP > clocks we are fine with the generated names. I'd prefer the latter case. Sure, will use the generated names. > >> + >> + qcom,phy-usb-mux-sel = <&tcsr 0x10540>; >> + >> + #phy-cells = <0>; >> + >> + status = "disabled"; >> + }; >> + >> qfprom: efuse@a4000 { >> compatible = "qcom,ipq5332-qfprom", "qcom,qfprom"; >> reg = <0x000a4000 0x721>; >> @@ -200,7 +223,7 @@ gcc: clock-controller@1800000 { >> <&sleep_clk>, >> <0>, >> <0>, >> - <0>; >> + <&usbphy1>; >> }; >> tcsr_mutex: hwlock@1905000 { > -- Thanks, Praveenkumar
diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi index d3fef2f80a81..b08ffd8c094e 100644 --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi @@ -158,6 +158,29 @@ usbphy0: phy@7b000 { status = "disabled"; }; + usbphy1: phy@4b0000 { + compatible = "qcom,ipq5332-usb-uniphy"; + reg = <0x4b0000 0x800>; + + clocks = <&gcc GCC_PCIE3X1_PHY_AHB_CLK>, + <&gcc GCC_USB0_PHY_CFG_AHB_CLK>, + <&gcc GCC_USB0_PIPE_CLK>; + clock-names = "ahb", + "cfg_ahb", + "pipe"; + + resets = <&gcc GCC_USB0_PHY_BCR>; + + #clock-cells = <0>; + clock-output-names = "usb0_pipe_clk_src"; + + qcom,phy-usb-mux-sel = <&tcsr 0x10540>; + + #phy-cells = <0>; + + status = "disabled"; + }; + qfprom: efuse@a4000 { compatible = "qcom,ipq5332-qfprom", "qcom,qfprom"; reg = <0x000a4000 0x721>; @@ -200,7 +223,7 @@ gcc: clock-controller@1800000 { <&sleep_clk>, <0>, <0>, - <0>; + <&usbphy1>; }; tcsr_mutex: hwlock@1905000 {