Message ID | 20230929084209.3033093-7-quic_ipkumar@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp3992719vqu; Fri, 29 Sep 2023 05:36:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHvtXNlwMsfJSlrw8thdaMOksSb/joz2OOFbpyFZhPrWytijrHCv41TevWODwUvfMVlhuFE X-Received: by 2002:a17:903:181:b0:1c1:f27e:a55a with SMTP id z1-20020a170903018100b001c1f27ea55amr4062617plg.46.1695990982212; Fri, 29 Sep 2023 05:36:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695990982; cv=none; d=google.com; s=arc-20160816; b=uVu/uN/gh1F55uHac6mrTzQkDG+HiMj8Lw7rFm0XMijF6QuWYfebP81KSEKLy4YJo4 pk59ZThn4x/ikh8n31LYGrLUvosh5yGOf6v8DnQiKbR92Us6dYO9+nK3Va028tV8LMGn Ov4y0zXGnviQutOjslqXLGFrBOy6h2jiDXjgZBUJe1kHvtCEH7FxIpUMF8tQjG86zCEK 66nGoxNzdmJ7ooPgOEgy9AERtFPGkgSiExbjPRR4I8XAZ8XUTLeuRsUJ+3lIZgS2AUJj sKmAfRnp3f0IUE7eLhw1P8I+/k2G1mkxxEXfMDJWyMyJyObJ8m0Dy7GyhYemMS0aX6sw dYJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HusXIEVAr7kVQVL5wbvM38WphrwhI8AOSMhhv/PasUI=; fh=/y3C3YtKy84M5cSpQOYdVWwJq454ogwAI2SrqSRafB8=; b=OLIdEh4pO2WPXyz7MYe3s8P1X/yKzCHsQWkzyYv/X2MncdCQMcednKnx/1q0tmGiHh fUZLKqSP+qpepBVg5hpikJP17LBo4OhvWsc9yDla7F3gy0/nOuYGk4n2j/CUNjd0/jav VPCcK4Ykm+jlVAd/ZVWLaJ+ldDzZk3/omFE76WE/VYEpJfKts7WZOMRVAWlmwxqZjVmh D3a8VqQmMQlbIcTF+Q6p2iXS3y7E1CWS+aWaW9O0BB1GKENmVX23sJbXCOIsHktaTYW2 7BIrw+E5a299x8EuGK78M8w2/2qtKd1vfNoR57vZP3etaFqo07qZAa1544P1gWhxgZ5u 7vDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=J4uYqfrU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id kg3-20020a170903060300b001c3f6dbe2bdsi19720165plb.105.2023.09.29.05.36.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Sep 2023 05:36:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=J4uYqfrU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id D0B1A807CF77; Fri, 29 Sep 2023 01:45:41 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232901AbjI2IoZ (ORCPT <rfc822;pwkd43@gmail.com> + 20 others); Fri, 29 Sep 2023 04:44:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232889AbjI2In5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 29 Sep 2023 04:43:57 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E8D8CE8; Fri, 29 Sep 2023 01:43:51 -0700 (PDT) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38T7rQop001201; Fri, 29 Sep 2023 08:43:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=qcppdkim1; bh=HusXIEVAr7kVQVL5wbvM38WphrwhI8AOSMhhv/PasUI=; b=J4uYqfrUREfoWpFbk9C2bFggRmPAcKgIXL3kMvjgxLcHKpIoGK1pBpHFX50AqDI7qfih EGlncJTwTDMWwfcfnIUqUIj1PSbRfKvW1mr+Bc+gAG29BlIq9mYjq1okSgU0JG5vpWrx Z8TXGEKKIsppuQhrjA9JxI+nZxsn5bJVFST1Dv80i5tyIISniBSonAWjOllTa7nmXDVH iwte1P7MU1BKNwQsMCpS1bpS8tPmlOya3tQTdykudKFuLTAcUVP270PNtCkJv56uHP86 KDy0uWq9BkdjxUYeTkQak3sdnHDA0CDz7H0c7VXgb3OBF+Y0jDWntTj/XxEC+sATTb3f WA== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3td24uaw1r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Sep 2023 08:43:32 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38T8hVdQ027987 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Sep 2023 08:43:31 GMT Received: from hu-ipkumar-blr.qualcomm.com (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Fri, 29 Sep 2023 01:43:21 -0700 From: Praveenkumar I <quic_ipkumar@quicinc.com> To: <agross@kernel.org>, <andersson@kernel.org>, <konrad.dybcio@linaro.org>, <vkoul@kernel.org>, <kishon@kernel.org>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>, <gregkh@linuxfoundation.org>, <catalin.marinas@arm.com>, <will@kernel.org>, <p.zabel@pengutronix.de>, <geert+renesas@glider.be>, <arnd@arndb.de>, <neil.armstrong@linaro.org>, <nfraprado@collabora.com>, <u-kumar1@ti.com>, <peng.fan@nxp.com>, <quic_wcheng@quicinc.com>, <quic_varada@quicinc.com>, <linux-arm-msm@vger.kernel.org>, <linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org> CC: <quic_kathirav@quicinc.com>, <quic_nsekar@quicinc.com>, <quic_srichara@quicinc.com> Subject: [PATCH 6/8] arm64: dts: qcom: ipq5332: Add Super-Speed UNIPHY in USB node Date: Fri, 29 Sep 2023 14:12:07 +0530 Message-ID: <20230929084209.3033093-7-quic_ipkumar@quicinc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230929084209.3033093-1-quic_ipkumar@quicinc.com> References: <20230929084209.3033093-1-quic_ipkumar@quicinc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: eX1_OL9dx0rVcDQxRkNa4-JyfQ0snj8_ X-Proofpoint-ORIG-GUID: eX1_OL9dx0rVcDQxRkNa4-JyfQ0snj8_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-09-29_07,2023-09-28_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 mlxscore=0 mlxlogscore=697 adultscore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2309290074 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 29 Sep 2023 01:45:41 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778375440274661235 X-GMAIL-MSGID: 1778375440274661235 |
Series |
Enable USB3 for Qualcomm IPQ5332
|
|
Commit Message
Praveenkumar I
Sept. 29, 2023, 8:42 a.m. UTC
Add UNIPHY node in USB to support Super-speed. As the SS PHY has
pipe clock, removed "qcom,select-utmi-as-pipe-clk" flag.
Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
---
arch/arm64/boot/dts/qcom/ipq5332.dtsi | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
Comments
On 29.09.2023 10:42, Praveenkumar I wrote: > Add UNIPHY node in USB to support Super-speed. As the SS PHY has > pipe clock, removed "qcom,select-utmi-as-pipe-clk" flag. > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > --- Patches 6 and 7 should be swapped, otherwise you may get no USB with this commit. Incremental patches must not break functionality, unless it is truly inevitable. Konrad
On 9/29/2023 6:44 PM, Konrad Dybcio wrote: > On 29.09.2023 10:42, Praveenkumar I wrote: >> Add UNIPHY node in USB to support Super-speed. As the SS PHY has >> pipe clock, removed "qcom,select-utmi-as-pipe-clk" flag. >> >> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> >> --- > Patches 6 and 7 should be swapped, otherwise you may get no > USB with this commit. Incremental patches must not break > functionality, unless it is truly inevitable. Understood. Will swap the 6 and 7 patches in the update. -- Thanks, Praveenkumar > > Konrad
On 29/09/2023 16:31, Praveenkumar I wrote: > > > On 9/29/2023 6:44 PM, Konrad Dybcio wrote: >> On 29.09.2023 10:42, Praveenkumar I wrote: >>> Add UNIPHY node in USB to support Super-speed. As the SS PHY has >>> pipe clock, removed "qcom,select-utmi-as-pipe-clk" flag. >>> >>> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> >>> --- >> Patches 6 and 7 should be swapped, otherwise you may get no >> USB with this commit. Incremental patches must not break >> functionality, unless it is truly inevitable. > Understood. Will swap the 6 and 7 patches in the update. But just swapping the patches will not work, the patch for the board file will break compilation. I think you have to squash them. > > -- > Thanks, > Praveenkumar >> >> Konrad >
On 29/09/2023 11:42, Praveenkumar I wrote: > Add UNIPHY node in USB to support Super-speed. As the SS PHY has > pipe clock, removed "qcom,select-utmi-as-pipe-clk" flag. > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > --- > arch/arm64/boot/dts/qcom/ipq5332.dtsi | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > index 1813b9fa4bb5..8fe4e45bfc18 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > @@ -349,8 +349,6 @@ usb: usb@8af8800 { > > resets = <&gcc GCC_USB_BCR>; > > - qcom,select-utmi-as-pipe-clk; > - > #address-cells = <1>; > #size-cells = <1>; > ranges; > @@ -363,8 +361,8 @@ usb_dwc: usb@8a00000 { > clocks = <&gcc GCC_USB0_MOCK_UTMI_CLK>; > clock-names = "ref"; > interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>; > - phy-names = "usb2-phy"; > - phys = <&usbphy0>; > + phy-names = "usb2-phy", "usb3-phy"; > + phys = <&usbphy0>, <&usbphy1>; Ah, I see now. Maybe usbphy_ss_0 or something like that would be a better label for this PHY. I'd expect usbphy1 to be used for other host than usbphy0. > tx-fifo-resize; > snps,is-utmi-l1-suspend; > snps,hird-threshold = /bits/ 8 <0x0>;
On 9/30/2023 10:56 PM, Dmitry Baryshkov wrote: > On 29/09/2023 16:31, Praveenkumar I wrote: >> >> >> On 9/29/2023 6:44 PM, Konrad Dybcio wrote: >>> On 29.09.2023 10:42, Praveenkumar I wrote: >>>> Add UNIPHY node in USB to support Super-speed. As the SS PHY has >>>> pipe clock, removed "qcom,select-utmi-as-pipe-clk" flag. >>>> >>>> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> >>>> --- >>> Patches 6 and 7 should be swapped, otherwise you may get no >>> USB with this commit. Incremental patches must not break >>> functionality, unless it is truly inevitable. >> Understood. Will swap the 6 and 7 patches in the update. > > But just swapping the patches will not work, the patch for the board > file will break compilation. I think you have to squash them. I think swapping will work as the PHY node in the base dtsi added separately in patch 3. If compilation fails, will squash them. - Praveenkumar > >> >> -- >> Thanks, >> Praveenkumar >>> >>> Konrad >> >
On 9/30/2023 10:57 PM, Dmitry Baryshkov wrote: > On 29/09/2023 11:42, Praveenkumar I wrote: >> Add UNIPHY node in USB to support Super-speed. As the SS PHY has >> pipe clock, removed "qcom,select-utmi-as-pipe-clk" flag. >> >> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/ipq5332.dtsi | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi >> b/arch/arm64/boot/dts/qcom/ipq5332.dtsi >> index 1813b9fa4bb5..8fe4e45bfc18 100644 >> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi >> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi >> @@ -349,8 +349,6 @@ usb: usb@8af8800 { >> resets = <&gcc GCC_USB_BCR>; >> - qcom,select-utmi-as-pipe-clk; >> - >> #address-cells = <1>; >> #size-cells = <1>; >> ranges; >> @@ -363,8 +361,8 @@ usb_dwc: usb@8a00000 { >> clocks = <&gcc GCC_USB0_MOCK_UTMI_CLK>; >> clock-names = "ref"; >> interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>; >> - phy-names = "usb2-phy"; >> - phys = <&usbphy0>; >> + phy-names = "usb2-phy", "usb3-phy"; >> + phys = <&usbphy0>, <&usbphy1>; > > Ah, I see now. Maybe usbphy_ss_0 or something like that would be a > better label for this PHY. I'd expect usbphy1 to be used for other > host than usbphy0. Sure, will change it. > >> tx-fifo-resize; >> snps,is-utmi-l1-suspend; >> snps,hird-threshold = /bits/ 8 <0x0>; > -- Thanks, Praveenkumar
diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi index 1813b9fa4bb5..8fe4e45bfc18 100644 --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi @@ -349,8 +349,6 @@ usb: usb@8af8800 { resets = <&gcc GCC_USB_BCR>; - qcom,select-utmi-as-pipe-clk; - #address-cells = <1>; #size-cells = <1>; ranges; @@ -363,8 +361,8 @@ usb_dwc: usb@8a00000 { clocks = <&gcc GCC_USB0_MOCK_UTMI_CLK>; clock-names = "ref"; interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>; - phy-names = "usb2-phy"; - phys = <&usbphy0>; + phy-names = "usb2-phy", "usb3-phy"; + phys = <&usbphy0>, <&usbphy1>; tx-fifo-resize; snps,is-utmi-l1-suspend; snps,hird-threshold = /bits/ 8 <0x0>;