Message ID | 20221110214729.ls5ixav5kxpeftk7@device |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp399902wru; Thu, 10 Nov 2022 14:08:28 -0800 (PST) X-Google-Smtp-Source: AMsMyM7pMr7KxRXnpRS4WzDUY3AAsiWqSb3nll64yhFgcfBTe2MSPeXvqumfjUUfVgk4PnlWCvgS X-Received: by 2002:a63:b4d:0:b0:46e:baf4:ab7a with SMTP id a13-20020a630b4d000000b0046ebaf4ab7amr3624984pgl.37.1668118108609; Thu, 10 Nov 2022 14:08:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668118108; cv=none; d=google.com; s=arc-20160816; b=lNlR/er7/fkO4/TBg4h8ZrHkV1i633uP5gxmBFuhRVYk0iT4vNB6dzaSIvmnbhlRT/ JqRhGsPPkFJDvoF4+fIRW2ToY27Al19HYXpLGC3I3zYE24k/0fZ1rwgvDPTeo0t1K5Rp fwy93nh6AHPdmYAMWPFQCRRgPSjuOmxAN2rFFEeWJXfH5W9oFQyjvEc8ldcUFIWORuWo wxC/By4mjtgBi2W+KsIZVztE+ZOxuf3SsD2KrO0tbCgV1XTmYBAloOLlnRLuiTxFU6Ac sPC3XqqHbqfQ4Kf6pMqJKEZ3r+0UNzDyVuPLGCP0j4Yjg82GLvAXtko1V3kZHaR7Gywr 5JvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=3ymZrbAW2jfHPexAz0opjqbMaod87+bluVLghydFElo=; b=WbbOhHVcB4hEyJ612k5wBTVwCWgrrNzfiIrIO7F0rhYarHmhKcf4pjVtOVULXqUXYL Hc/wJ3oHszU3J90nQWR0Avknt+5K4CCpoQ7fkHN1MbwA0sUOU3ITEEiMqVg2OKAefSoj bHQNhQuWjbNdDu/LD5N7OQClBqrIQKXaAM0RwdLbyjwblR5Yd9OKi2od7qGShqTNdHxa h+O144crZosBoytEG4r7dNHhRic8apjlNNAvZzPxTnNx+AQUMUzM7RAPxBhfCnka/cH+ 0ekUPPs0TCdAf72fyy8cPdtjhwfzMRRjgxnI1yuYz+CNVbLtlq7jPuokY3+W5XibXbi8 aS5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@pgazz.com header.s=mail header.b=MAE9NJeu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=pgazz.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e22-20020a637456000000b0046ea4ef43d2si381120pgn.378.2022.11.10.14.08.14; Thu, 10 Nov 2022 14:08:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@pgazz.com header.s=mail header.b=MAE9NJeu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=pgazz.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231567AbiKJVrf (ORCPT <rfc822;winker.wchi@gmail.com> + 99 others); Thu, 10 Nov 2022 16:47:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbiKJVrd (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 10 Nov 2022 16:47:33 -0500 Received: from box.opentheblackbox.net (box.opentheblackbox.net [IPv6:2600:3c02::f03c:92ff:fee2:82bc]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9F7945A2C; Thu, 10 Nov 2022 13:47:31 -0800 (PST) Received: from authenticated-user (box.opentheblackbox.net [172.105.151.37]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.opentheblackbox.net (Postfix) with ESMTPSA id DB1DD3EBA5; Thu, 10 Nov 2022 16:47:30 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pgazz.com; s=mail; t=1668116851; bh=sn8BqdoR2X8FcNsynZZXapa7cThUJZkv2dbIQQBL4pQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MAE9NJeu6YQkQvts3qhVrv2Hkgyoz0ewmyzowsEMBWGoowUMjWONTC0VD0/bPZ9vZ RbvelwAmmSkw+vNcvrmDO/J36oOkaXcvIKxOhRJd3cj40ilOsEqZyvA35TxkFUoYrM NS66AnexegCyeM6PeZHQ2cirMHIn4+PX7poL5FKMgj1NWbspYxPZm5oK+5gdS1xOVf x0TspcVDsIb5b/LWYefEYLI9Is2OFOVGnlvabnin3rNaYztD1uV2GqNl0juGa1GzQ7 HRpQO9V0YkKzy9DqfGujQgwfZDATs7u5B/aO2j909rhqFW49kqE9rZhFhWQHLgkkm+ 1CNW2qIWxA3Jw== Date: Thu, 10 Nov 2022 16:47:29 -0500 From: Paul Gazzillo <paul@pgazz.com> To: Jonathan Cameron <jic23@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Shreeya Patel <shreeya.patel@collabora.com>, Zhigang Shi <Zhigang.Shi@liteon.com>, Dmitry Osipenko <dmitry.osipenko@collabora.com> Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/1]: iio: light: rpr0521: add missing Kconfig dependencies Message-ID: <20221110214729.ls5ixav5kxpeftk7@device> References: <20221110144448.wexu6neb67krqhla@device> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221110144448.wexu6neb67krqhla@device> X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_SBL_CSS,RCVD_IN_XBL, SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749122164183680419?= X-GMAIL-MSGID: =?utf-8?q?1749148613651993088?= |
Series |
[v2,1/1] : iio: light: rpr0521: add missing Kconfig dependencies
|
|
Commit Message
Paul Gazzillo
Nov. 10, 2022, 9:47 p.m. UTC
Fix an implicit declaration of function error for rpr0521 under some configs
When CONFIG_RPR0521 is enabled without CONFIG_IIO_TRIGGERED_BUFFER,
the build results in "implicit declaration of function" errors, e.g.,
drivers/iio/light/rpr0521.c:434:3: error: implicit declaration of function
'iio_trigger_poll_chained' [-Werror=implicit-function-declaration]
434 | iio_trigger_poll_chained(data->drdy_trigger0);
| ^~~~~~~~~~~~~~~~~~~~~~~~
This fix adds select dependencies to RPR0521's configuration declaration.
Signed-off-by: Paul Gazzillo <paul@pgazz.com>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=216678
---
V1 -> V2: Cleaned up commit message per reviewer comments and added link
to bug report.
drivers/iio/light/Kconfig | 2 ++
1 file changed, 2 insertions(+)
Comments
On Thu, Nov 10, 2022 at 04:47:29PM -0500, Paul Gazzillo wrote: > Fix an implicit declaration of function error for rpr0521 under some configs > > When CONFIG_RPR0521 is enabled without CONFIG_IIO_TRIGGERED_BUFFER, > the build results in "implicit declaration of function" errors, e.g., > drivers/iio/light/rpr0521.c:434:3: error: implicit declaration of function > 'iio_trigger_poll_chained' [-Werror=implicit-function-declaration] > 434 | iio_trigger_poll_chained(data->drdy_trigger0); > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > This fix adds select dependencies to RPR0521's configuration declaration. > > Signed-off-by: Paul Gazzillo <paul@pgazz.com> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216678 No need to create a bugzilla report on such tiny issues that do actually not affect the working configurations. FWIW, Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > V1 -> V2: Cleaned up commit message per reviewer comments and added link > to bug report. > > drivers/iio/light/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig > index 7cf6e8490123..0d4447df7200 100644 > --- a/drivers/iio/light/Kconfig > +++ b/drivers/iio/light/Kconfig > @@ -293,6 +293,8 @@ config RPR0521 > tristate "ROHM RPR0521 ALS and proximity sensor driver" > depends on I2C > select REGMAP_I2C > + select IIO_BUFFER > + select IIO_TRIGGERED_BUFFER > help > Say Y here if you want to build support for ROHM's RPR0521 > ambient light and proximity sensor device. > -- > 2.25.1
On 11/11/2022, Andy Shevchenko wrote: > On Thu, Nov 10, 2022 at 04:47:29PM -0500, Paul Gazzillo wrote: > > Fix an implicit declaration of function error for rpr0521 under some configs > > > > When CONFIG_RPR0521 is enabled without CONFIG_IIO_TRIGGERED_BUFFER, > > the build results in "implicit declaration of function" errors, e.g., > > drivers/iio/light/rpr0521.c:434:3: error: implicit declaration of function > > 'iio_trigger_poll_chained' [-Werror=implicit-function-declaration] > > 434 | iio_trigger_poll_chained(data->drdy_trigger0); > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > > > This fix adds select dependencies to RPR0521's configuration declaration. > > > > Signed-off-by: Paul Gazzillo <paul@pgazz.com> > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216678 > > No need to create a bugzilla report on such tiny issues that do actually not > affect the working configurations. Understood. Thanks for your help! > > FWIW, > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > --- > > V1 -> V2: Cleaned up commit message per reviewer comments and added link > > to bug report. > > > > drivers/iio/light/Kconfig | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig > > index 7cf6e8490123..0d4447df7200 100644 > > --- a/drivers/iio/light/Kconfig > > +++ b/drivers/iio/light/Kconfig > > @@ -293,6 +293,8 @@ config RPR0521 > > tristate "ROHM RPR0521 ALS and proximity sensor driver" > > depends on I2C > > select REGMAP_I2C > > + select IIO_BUFFER > > + select IIO_TRIGGERED_BUFFER > > help > > Say Y here if you want to build support for ROHM's RPR0521 > > ambient light and proximity sensor device. > > -- > > 2.25.1 > > -- > With Best Regards, > Andy Shevchenko Best, Paul
On Fri, 11 Nov 2022 10:25:39 -0500 Paul Gazzillo <paul@pgazz.com> wrote: > On 11/11/2022, Andy Shevchenko wrote: > > On Thu, Nov 10, 2022 at 04:47:29PM -0500, Paul Gazzillo wrote: > > > Fix an implicit declaration of function error for rpr0521 under some configs > > > > > > When CONFIG_RPR0521 is enabled without CONFIG_IIO_TRIGGERED_BUFFER, > > > the build results in "implicit declaration of function" errors, e.g., > > > drivers/iio/light/rpr0521.c:434:3: error: implicit declaration of function > > > 'iio_trigger_poll_chained' [-Werror=implicit-function-declaration] > > > 434 | iio_trigger_poll_chained(data->drdy_trigger0); > > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > > > > > This fix adds select dependencies to RPR0521's configuration declaration. > > > > > > Signed-off-by: Paul Gazzillo <paul@pgazz.com> > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216678 > > > > No need to create a bugzilla report on such tiny issues that do actually not > > affect the working configurations. > > Understood. Thanks for your help! I wonder why it has taken so long for this build issue to get reported? Ah well. This is missing a fixes tag. I added Fixes: e12ffd241c00 ("iio: light: rpr0521 triggered buffer") Applied to the fixes-togreg branch of iio.git. Thanks, Jonathan > > > > > FWIW, > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > > --- > > > V1 -> V2: Cleaned up commit message per reviewer comments and added link > > > to bug report. > > > > > > drivers/iio/light/Kconfig | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig > > > index 7cf6e8490123..0d4447df7200 100644 > > > --- a/drivers/iio/light/Kconfig > > > +++ b/drivers/iio/light/Kconfig > > > @@ -293,6 +293,8 @@ config RPR0521 > > > tristate "ROHM RPR0521 ALS and proximity sensor driver" > > > depends on I2C > > > select REGMAP_I2C > > > + select IIO_BUFFER > > > + select IIO_TRIGGERED_BUFFER > > > help > > > Say Y here if you want to build support for ROHM's RPR0521 > > > ambient light and proximity sensor device. > > > -- > > > 2.25.1 > > > > -- > > With Best Regards, > > Andy Shevchenko > > Best, > Paul
On 11/12/2022, Jonathan Cameron wrote: > On Fri, 11 Nov 2022 10:25:39 -0500 > Paul Gazzillo <paul@pgazz.com> wrote: > > > On 11/11/2022, Andy Shevchenko wrote: > > > On Thu, Nov 10, 2022 at 04:47:29PM -0500, Paul Gazzillo wrote: > > > > Fix an implicit declaration of function error for rpr0521 under some configs > > > > > > > > When CONFIG_RPR0521 is enabled without CONFIG_IIO_TRIGGERED_BUFFER, > > > > the build results in "implicit declaration of function" errors, e.g., > > > > drivers/iio/light/rpr0521.c:434:3: error: implicit declaration of function > > > > 'iio_trigger_poll_chained' [-Werror=implicit-function-declaration] > > > > 434 | iio_trigger_poll_chained(data->drdy_trigger0); > > > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > > > > > > > This fix adds select dependencies to RPR0521's configuration declaration. > > > > > > > > Signed-off-by: Paul Gazzillo <paul@pgazz.com> > > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216678 > > > > > > No need to create a bugzilla report on such tiny issues that do actually not > > > affect the working configurations. > > > > Understood. Thanks for your help! > > I wonder why it has taken so long for this build issue to get reported? > There seem to be lots of combinations of configuration options that don't get tested or even built (understandably, given the enormous number of options), leaving Kconfig with an incomplete picture of dependencies. There's just too many to test, though if users are only using some predefined .config files (or testers are using only allyesconfig) they may not encounter these corner cases that slip through Kconfig (and maybe these cases aren't really very high impact). Our team's been researching how to better test across configurations; one of our tools for finding unmet Kconfig dependency bugs (kismet) is now being run by Intel's kernel test robot, but we're also working on how to improve run-time testing as well, and I ran across a configuration that triggered this build error. In case you're interested, here's our current tooling: https://github.com/paulgazz/kmax Let me know if you have any related painpoints that this work might help with. I work in academia with funding that encourages open-sourcing the results, so it's great to have real-world problems that can provide a tangible benefit. > Ah well. This is missing a fixes tag. I added > Fixes: e12ffd241c00 ("iio: light: rpr0521 triggered buffer") Thank you! > > Applied to the fixes-togreg branch of iio.git. > > Thanks, > > Jonathan > > > > > > > > > > > FWIW, > > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > > > > --- > > > > V1 -> V2: Cleaned up commit message per reviewer comments and added link > > > > to bug report. > > > > > > > > drivers/iio/light/Kconfig | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig > > > > index 7cf6e8490123..0d4447df7200 100644 > > > > --- a/drivers/iio/light/Kconfig > > > > +++ b/drivers/iio/light/Kconfig > > > > @@ -293,6 +293,8 @@ config RPR0521 > > > > tristate "ROHM RPR0521 ALS and proximity sensor driver" > > > > depends on I2C > > > > select REGMAP_I2C > > > > + select IIO_BUFFER > > > > + select IIO_TRIGGERED_BUFFER > > > > help > > > > Say Y here if you want to build support for ROHM's RPR0521 > > > > ambient light and proximity sensor device. > > > > -- > > > > 2.25.1 > > > > > > -- > > > With Best Regards, > > > Andy Shevchenko > > > > Best, > > Paul
diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig index 7cf6e8490123..0d4447df7200 100644 --- a/drivers/iio/light/Kconfig +++ b/drivers/iio/light/Kconfig @@ -293,6 +293,8 @@ config RPR0521 tristate "ROHM RPR0521 ALS and proximity sensor driver" depends on I2C select REGMAP_I2C + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help Say Y here if you want to build support for ROHM's RPR0521 ambient light and proximity sensor device.