ACPI: Enable FPDT on arm64

Message ID 20221109174720.203723-1-jeremy.linton@arm.com
State New
Headers
Series ACPI: Enable FPDT on arm64 |

Commit Message

Jeremy Linton Nov. 9, 2022, 5:47 p.m. UTC
  FPDT provides some boot timing records useful for analyzing
parts of the UEFI boot stack. Given the existing code works
on arm64, and allows reading the values without utilizing
/dev/mem it seems like a good idea to turn it on.

Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
 Documentation/arm64/acpi_object_usage.rst | 2 +-
 drivers/acpi/Kconfig                      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
  

Comments

Sudeep Holla Nov. 14, 2022, 4:12 p.m. UTC | #1
On Wed, Nov 09, 2022 at 11:47:20AM -0600, Jeremy Linton wrote:
> FPDT provides some boot timing records useful for analyzing
> parts of the UEFI boot stack. Given the existing code works
> on arm64, and allows reading the values without utilizing
> /dev/mem it seems like a good idea to turn it on.
>

FWIW, this looks good to me.

Acked-by: Sudeep Holla <sudeep.holla@arm.com>

Hi Rafael,

Just saw this marked as "Handled Elsewhere", do you prefer to be merged
via arm64 or other tree ? This doesn't have any arm64 changes, just Kconfig
and doc changes. Let us know.
  
Rafael J. Wysocki Nov. 14, 2022, 4:16 p.m. UTC | #2
On Mon, Nov 14, 2022 at 5:12 PM Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> On Wed, Nov 09, 2022 at 11:47:20AM -0600, Jeremy Linton wrote:
> > FPDT provides some boot timing records useful for analyzing
> > parts of the UEFI boot stack. Given the existing code works
> > on arm64, and allows reading the values without utilizing
> > /dev/mem it seems like a good idea to turn it on.
> >
>
> FWIW, this looks good to me.
>
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
>
> Hi Rafael,
>
> Just saw this marked as "Handled Elsewhere", do you prefer to be merged
> via arm64 or other tree ? This doesn't have any arm64 changes, just Kconfig
> and doc changes. Let us know.

There is arm64 in the subject, though, so I think it belongs there.
  
Will Deacon Nov. 14, 2022, 6 p.m. UTC | #3
On Mon, Nov 14, 2022 at 05:16:59PM +0100, Rafael J. Wysocki wrote:
> On Mon, Nov 14, 2022 at 5:12 PM Sudeep Holla <sudeep.holla@arm.com> wrote:
> >
> > On Wed, Nov 09, 2022 at 11:47:20AM -0600, Jeremy Linton wrote:
> > > FPDT provides some boot timing records useful for analyzing
> > > parts of the UEFI boot stack. Given the existing code works
> > > on arm64, and allows reading the values without utilizing
> > > /dev/mem it seems like a good idea to turn it on.
> > >
> >
> > FWIW, this looks good to me.
> >
> > Acked-by: Sudeep Holla <sudeep.holla@arm.com>
> >
> > Hi Rafael,
> >
> > Just saw this marked as "Handled Elsewhere", do you prefer to be merged
> > via arm64 or other tree ? This doesn't have any arm64 changes, just Kconfig
> > and doc changes. Let us know.
> 
> There is arm64 in the subject, though, so I think it belongs there.

Okey doke, I'll grab 'em.

Cheers!

Will
  
Will Deacon Nov. 14, 2022, 7:34 p.m. UTC | #4
On Wed, 9 Nov 2022 11:47:20 -0600, Jeremy Linton wrote:
> FPDT provides some boot timing records useful for analyzing
> parts of the UEFI boot stack. Given the existing code works
> on arm64, and allows reading the values without utilizing
> /dev/mem it seems like a good idea to turn it on.
> 
> 

Applied to arm64 (for-next/acpi), thanks!

[1/1] ACPI: Enable FPDT on arm64
      https://git.kernel.org/arm64/c/c2465f95c4e7

Cheers,
  

Patch

diff --git a/Documentation/arm64/acpi_object_usage.rst b/Documentation/arm64/acpi_object_usage.rst
index 0609da73970b..484ef9676653 100644
--- a/Documentation/arm64/acpi_object_usage.rst
+++ b/Documentation/arm64/acpi_object_usage.rst
@@ -163,7 +163,7 @@  FPDT   Section 5.2.23 (signature == "FPDT")
 
        **Firmware Performance Data Table**
 
-       Optional, not currently supported.
+       Optional, useful for boot performance profiling.
 
 GTDT   Section 5.2.24 (signature == "GTDT")
 
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 473241b5193f..1cc11d2a2a88 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -90,7 +90,7 @@  config ACPI_SPCR_TABLE
 
 config ACPI_FPDT
 	bool "ACPI Firmware Performance Data Table (FPDT) support"
-	depends on X86_64
+	depends on X86_64 || ARM64
 	help
 	  Enable support for the Firmware Performance Data Table (FPDT).
 	  This table provides information on the timing of the system