diff mbox series

[V2,2/2] arm64: dts: Add watchdog node for Amlogic C3 SoCs

Message ID 20230926055512.2355390-3-huqiang.qin@amlogic.com
State New
Headers
Series Add watchdog support for Amlogic C3 SoCs |

Commit Message

Huqiang Qin Sept. 26, 2023, 5:55 a.m. UTC 
  Add watchdog device.

Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com>
---

V1 -> V2: Increase compatibles of C3 watchdog.

 arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Conor Dooley Sept. 26, 2023, 8:03 a.m. UTC | #1 
On Tue, Sep 26, 2023 at 01:55:12PM +0800, Huqiang Qin wrote:
> Add watchdog device.
> 
> Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com>
> ---
> 
> V1 -> V2: Increase compatibles of C3 watchdog.
> 
>  arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
> index 998f5050795c..2ad1f8eef199 100644
> --- a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
> @@ -81,6 +81,12 @@ apb4: bus@fe000000 {
>  			#size-cells = <2>;
>  			ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
>  
> +			watchdog@2100 {
> +				compatible = "amlogic,c3-wdt", "amlogic,t7-wdt";

Does this pass dtbs_check?
The binding patch doesn't seem to permit this combo..

> +				reg = <0x0 0x2100 0x0 0x10>;
> +				clocks = <&xtal>;
> +			};
> +
>  			periphs_pinctrl: pinctrl@4000 {
>  				compatible = "amlogic,c3-periphs-pinctrl";
>  				#address-cells = <2>;
> -- 
> 2.42.0
>
Huqiang Qin Sept. 27, 2023, 5:59 a.m. UTC | #2 
On 2023/9/26 16:03, Conor Dooley wrote:
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
>> @@ -81,6 +81,12 @@ apb4: bus@fe000000 {
>>  			#size-cells = <2>;
>>  			ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
>>  
>> +			watchdog@2100 {
>> +				compatible = "amlogic,c3-wdt", "amlogic,t7-wdt";
> Does this pass dtbs_check?
> The binding patch doesn't seem to permit this combo..
> 

Ah... I ran dtbs_check again, and there is indeed
`watchdog@2100: compatible: ['amlogic,c3-wdt', 'amlogic,t7-wdt'] is too long`
in the output.

I'll correct it in the next version, thanks for pointing it out.


Best regards,
Huqiang Qin
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
index 998f5050795c..2ad1f8eef199 100644
--- a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
+++ b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
@@ -81,6 +81,12 @@  apb4: bus@fe000000 {
 			#size-cells = <2>;
 			ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
 
+			watchdog@2100 {
+				compatible = "amlogic,c3-wdt", "amlogic,t7-wdt";
+				reg = <0x0 0x2100 0x0 0x10>;
+				clocks = <&xtal>;
+			};
+
 			periphs_pinctrl: pinctrl@4000 {
 				compatible = "amlogic,c3-periphs-pinctrl";
 				#address-cells = <2>;