Message ID | 20230925074131.10133-1-ming.qian@nxp.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6359:6f87:b0:13f:353d:d1ed with SMTP id tl7csp1131427rwb; Mon, 25 Sep 2023 07:11:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFK3JjWBz8mjU4AxbuRxXSfX8FR9X4SlQSNnr63LuXs/MUPKPCqo/I+Y3/mRMUt3AXpdeiK X-Received: by 2002:a05:6358:7e81:b0:143:810c:3803 with SMTP id o1-20020a0563587e8100b00143810c3803mr6802555rwn.4.1695651088876; Mon, 25 Sep 2023 07:11:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1695651088; cv=pass; d=google.com; s=arc-20160816; b=yxH1fAEqaPoYJELXk7W2XcztzenPI93Ell5C5LpAS6d/KCI2CVCE9bnwdbWXxNKzFC 7npPnVdV7LSAFi5meYcb4rJb80D6R4Qd42aaFmvhqk9xp4N4pJo0iPL0uVAto5arnfcm q795HGQSWM1uwpQzicAo6+XbQS5WOT6V+e2NtQl0/wZcCxTmHlvL4Z4N1I6nWpxlxmpd 0dLpekpcQA15xmEO4dI8f/42wILzZcN74nQk2rXVApRfNSKp6sKkxtd5LW4lSJWP/wFI aFRvY999vm1YX2A8mgk9yCNH8n21Q7MmND2vyIGrRzU6t1sGfG47JDhVyZpeVlGHI6kt By9A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :message-id:date:subject:cc:to:from:dkim-signature; bh=/Cz0ga+f/D+gXGXJyWWMdxP/dfG05Spg63Yu835pajU=; fh=UU68I5YO4VdQ5I+IVkM0Qh5bAObkOO+8rIsAGfEuozM=; b=yzrfpIvI2ZyB1bXfgjX3BYvvgmKFsOjwScmNRSp2b9dJXxRugZqYQVozBtDSqIn0ut chlDkltxvUHA5iyNovsKUL2VE1HBf1KE2ViXECHxN3jG7oJGgffMEggNlJVQ3XGE2N18 tdbw63tQboz3mjPPXo5ogIvgtsjakCdhIb3rl1FLOpJHsKKPWWS/8OaslUqRgKvrlxdD E8HyCeciVNGtmBqdtHM9Pmqu7pmoQETUkFrTOt7IzBEzlc9BjqkmFDaZiWn5x+t6iD2D YRiUDka4b9jCMsaylwA8tCBEJ2CoPzgILvfyDxJT4fNLQri9eGE1kU7d+PHyqHFeuU3n 6XMA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=YbC+f7RI; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id p19-20020a639513000000b005824bad8f81si3109008pgd.853.2023.09.25.07.11.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 07:11:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=YbC+f7RI; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 58D6A807C570; Mon, 25 Sep 2023 00:42:12 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229561AbjIYHmF (ORCPT <rfc822;ezelljr.billy@gmail.com> + 30 others); Mon, 25 Sep 2023 03:42:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232253AbjIYHmE (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 25 Sep 2023 03:42:04 -0400 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2068.outbound.protection.outlook.com [40.107.241.68]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 658CEE3; Mon, 25 Sep 2023 00:41:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Annb5OLt1bPVlDsFGcJV2A/CHZsA7KNAYfGlYKA13hWcO7HVmeLJ9LuQjdGLi+1Pd5m/lqJ/JIWQP2YpdTPH0vzfYxhmDHeiWA9fK7DDobO+dCgwZ6gU+eDi3Ed+dw4eE8HCpaf5eXB7M1HC9MBfu7dLP+VfVhmbGNmuT2b6K7Nsfx1gh7wQ2LFmOGk9Nk8VaO7Z7Hq0iBRPThnvYgsjCOM3TyMP41Q6onz/GPa2vZNGRQH63lkE4w5kpigPmGsf9tX/JXpdWsz8Y/WMuK1+ZIg9n+L99KDL4M2yh4TnIDMEx22ugtyuf9vGX8aLLfKgmUh8IZQiIEdEIcthpzuyZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/Cz0ga+f/D+gXGXJyWWMdxP/dfG05Spg63Yu835pajU=; b=WiCxrXWfUMJEZDVIAYmT43aoVpfBeHk4VHePHOVxGEzXPxnM+2e1MvLYig1xvvsk55sTmzhQypuCERA8GHPC58uFzH9qSQgv8T3RRqOXWg64ZBqlO0rPwDMnTxe6CbmDgSi5RcOd0+0OuLh8a2b4N1LqtWEGlm6DFE8VIF9Htsix1J99+mnOLKDwcr+V/w5Mg4k6/zqX1PxoN0XhqvjlGBxh8X1LnMf2MUXbJTNzXR/ZnVubR7IYGYLN9m5xmA8ZPaKZTA1ftWMMPUc48Ws8AwUdyG07T8m+Fv8VIvA7Tkq5K44APKXHq9LBb87XMKlA7fPQcQZvIA4NeBobXJB0zA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/Cz0ga+f/D+gXGXJyWWMdxP/dfG05Spg63Yu835pajU=; b=YbC+f7RI5IixwoDKvqZq8WJNvatuJIJnAKos6gbTQ1vbnHDxdG2UEu26+4Gqgnfv1bUcsbXlnvMvmG7ucHZkJeySSj6pTL4kr//PhcCO+kteOTI62qF9+q7ASPLhFe7mQzH4SRl5yGSZUgK5QrvKYqLnMya0qdeexhqzCB96h5s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB6341.eurprd04.prod.outlook.com (2603:10a6:20b:d8::14) by DB9PR04MB8218.eurprd04.prod.outlook.com (2603:10a6:10:24a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Mon, 25 Sep 2023 07:41:54 +0000 Received: from AM6PR04MB6341.eurprd04.prod.outlook.com ([fe80::71e6:21de:ecb2:560f]) by AM6PR04MB6341.eurprd04.prod.outlook.com ([fe80::71e6:21de:ecb2:560f%4]) with mapi id 15.20.6813.027; Mon, 25 Sep 2023 07:41:54 +0000 From: Ming Qian <ming.qian@nxp.com> To: mirela.rabulea@oss.nxp.com, robh+dt@kernel.org, shawnguo@kernel.org Cc: krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, xiahong.bao@nxp.com, eagle.zhou@nxp.com, tao.jiang_2@nxp.com, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 1/2] arm64: dts: imx8-ss-img: Assign slot for imx jpeg encoder/decoder Date: Mon, 25 Sep 2023 15:41:30 +0800 Message-Id: <20230925074131.10133-1-ming.qian@nxp.com> X-Mailer: git-send-email 2.38.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SI2PR02CA0028.apcprd02.prod.outlook.com (2603:1096:4:195::8) To AM6PR04MB6341.eurprd04.prod.outlook.com (2603:10a6:20b:d8::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6341:EE_|DB9PR04MB8218:EE_ X-MS-Office365-Filtering-Correlation-Id: 796e50a0-c195-4c15-60ef-08dbbd9ae37c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ku+E82jYaisEdUzVV030WEY7ymItABceY4VTUSXB2gAnB0TbkIUUCygpNcjUMH9rZuvugUAGooklAhvpg/+l5ayazLy3/8SKiH12ja9maYBXsaaOJx8P5soGV11YdABxuFNusJ8Oc1ExSo3ZWtLL8r1WHQXvbUARKltS2hKSvH7WhgNKpET710qXE5PIX1umpmXB4r+g7LvPyr23WGxEH61asO/jnL4Y04O03n6LKx9TQCooC5yEFIY60nR/4q+q+WOymZoLTVvU7FI2ibJlSbeYy64RzcfDgM+d6APNh2BoGfc10fC9ZV8YifOmBG96mH+mzWsaWUUg47u52P/OpUmEc7Ps2sEnIUUG145GU11nxcKa4awgyNUxSEEv9hUVr39USNKxY7OiFvzQaFyknvrjFv5q9ElAvPkph+qmDrAzDoAqpJlpqgPFuJuBKg3dq9XYKmAsvwFxmgJB79QraabfBd7VB+7NZuVo53Fv/EaoINLi1iLjpWg1jJVBBDMnSU0t4sfjddoBqQW/DXaZ27InmrSVwAgJqkM6NdqGAZAjsZOZrUPuSLdT5HBT4vSb9UKLNnBY3pWGwc4YmuDdv5Av+cdo1qNh8M8WEVeBp1S9ZcQOFnylc81M/oPwy8/q X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6341.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(346002)(366004)(396003)(376002)(136003)(230922051799003)(451199024)(1800799009)(186009)(316002)(7416002)(41300700001)(26005)(2906002)(5660300002)(8676002)(478600001)(66556008)(44832011)(66476007)(66946007)(4326008)(8936002)(6486002)(6666004)(6506007)(52116002)(6512007)(36756003)(1076003)(2616005)(83380400001)(38100700002)(38350700002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: LNMiqKQBJSLQ39AikKqZtCcT1cF1DwZ6ZWRe4zIS7v9JIS3qVLNGlvgJpc/Yf1cUy4ubHmYxo6QKUfKPBxpkSPALHc8z9y57VffQ37OQRQ7CENwg3+TYJBs1U3mnY2orJVQqSdGpGFjSL53CCVywrZWy8LKL1pbDdO1WNGZD5oawFzJBB09JmGdhHsPxRkV3K+6Cdh5pqT+V7Tg8G8hGmyzEdSqXWiVMi2Ek95zbeisQq3vl/g5OGuSknEBgqFCFD+PI6PFwHb1U/PII16kIjV6j2H43W8S/UiXGz78pnKoYZ7wh39dlTjJZYb2nP9jCsUMNzaqv65FYCcn/P+0LuKHBNZgOyrTTpd7C64AOzQBE32+oguVTKX8Vo4hV7nHLE0AGfS80ujeNM2VTeGRAQh86twSc3qFrqjc8hJ532vgp9uxb4DM699xxrOLbWvYvCZndLqAP2wtrUfuikKH4Z+/6TClvi/OvdNCRF60Q2yXtpfsJDR59h3nQOaCoo/Pcr+LkphJAiwQNbsAUgbMg6pdcaPjNfUREUdVDLIWZiui5nSe01L6ZZbdSzBt8lIGpYBRiplC5015As1rEbdHWIgksMcrypYG+qgNtsAGaaz+wbLU3gG/9K2ggXrj/HuPqC+kgT/9T4HDQwZK8IhAs256IVF/Pwy+pS+XzYTNMZycB3/BiyYnoFMstxb2yRd+Fu1+YGJOc9rS+8Gl2bv6Nisgske11zSCQ25xY+PSs2KeDzkATUIo9MnuZW7m2o5s7mYwTPEVhcsqrGTl/8PaBRNCePfD8XQ4oo0QAh2cxj0LFqlwStyY9OEc3NxvaEsrjY7QzTc39Sm/sYys/vLpZ/z7DlrTMChaa76g9C+YU0fhmpU388MltWXd14C/C2ARdaWkvOjHOI6Sqfy5+QbqDBgLdko4v12AKILay9AFnlTK8otyQea8zl8WEI7UgplVYUgnIBX2yAUPpFuRRlc5mslnBCn2rtETKPCQOvUbgAWIl4YyF3LF7yJBqF05Y6DPIItYsrywkca5OMn1HkoVWpMIhH3FhUQNctSpSJEYk7hgjOYFnkR60u0rwMV0Y31g4BUbaSSDldVX7rgIid3HS3z1XMsY04Dpqnoqj0E/xqDgwZ2a+mJUUYGPpJkq1BQK7lDN3rCSpqqUU2e9SJjbsiV/2eOeqBk27Rhei5S+oIUv/E4Fkb/YYOOxiOdw8k7JPSkEzCAYeSR46a3y4oSBVlRndS74gFi/jmEvVhXyQLzAcDxCqihy0Jd1qFJlhJt+hRN6Ovz35uYjdHm1o/O7GySpMgWkEpWxNYXFVgLoQEa3ZGvRy8Ek3D60HnCh/keCXI0XlIUqR/MAQYbEn6pUy/Zgi2h5RBpbVylqr5oND+aw7lpEfu4wVjb7zbvS5iSo7E4co5eC/8QgMhmJOH14xDbSl3ARl8XvhxI5qxde9OvgVGmsq8dXeFMRM7uAb5t7Lz3zmZ449vBDwg2ZK426c1BUdTgouMfTxflVezGQooUBL2I6OZ7lHUuKxtwKh/GV131oD+4dYiCcvLqFFGOl3ImlH9HBJ9na5M8N2ZnrT3jzX6A2mLUXr/jBRlxYB60vK X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 796e50a0-c195-4c15-60ef-08dbbd9ae37c X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6341.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 07:41:54.4834 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jg7eqbj2rDN1Vg9jH+yycEyDcDEWukGBfAIFGH3CtIwlL+N9PqnY1Ak8XnNKKxJ69jzWbRXI62zhr1W5kjSIFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8218 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 25 Sep 2023 00:42:12 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778000539099139735 X-GMAIL-MSGID: 1778019035742114566 |
Series |
[v3,1/2] arm64: dts: imx8-ss-img: Assign slot for imx jpeg encoder/decoder
|
|
Commit Message
Ming Qian
Sept. 25, 2023, 7:41 a.m. UTC
There are total 4 slots available in the IP,
and we only need to use one slot in one os,
assign a single slot for imx jpeg device node,
configure interrupt and power domain only for 1 slot,
not for the all 4 slots.
Signed-off-by: Ming Qian <ming.qian@nxp.com>
---
.../arm64/boot/dts/freescale/imx8-ss-img.dtsi | 22 +++++--------------
1 file changed, 6 insertions(+), 16 deletions(-)
Comments
>From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >Sent: 2023年9月25日 16:02 >To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) ><mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; shawnguo@kernel.org >Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; >kernel@pengutronix.de; festevam@gmail.com; X.H. Bao ><xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang ><tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >Subject: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign slot for >imx jpeg encoder/decoder > >Caution: This is an external email. Please take care when clicking links or >opening attachments. When in doubt, report the message using the 'Report >this email' button > > >On 25/09/2023 09:41, Ming Qian wrote: >> There are total 4 slots available in the IP, and we only need to use >> one slot in one os, assign a single slot, configure interrupt and >> power domain only for 1 slot, not for the all 4 slots. > >No changelog and I do not see much of improvements. Do not ignore the >feedback but respond to it or fix the patch. Really, what happened here? > Hi Krzysztof, What do you mean wrap commit message? Do you mean line wrapped at 75 columns? - The body of the explanation, line wrapped at 75 columns, which will be copied to the permanent changelog to describe this patch. >Please wrap commit message according to Linux coding style / submission >process (neither too early nor over the limit): >https://elixir.b/ >ootlin.com%2Flinux%2Fv6.4- >rc1%2Fsource%2FDocumentation%2Fprocess%2Fsubmitting- >patches.rst%23L597&data=05%7C01%7Cming.qian%40nxp.com%7C9a78ca292 >a5744790db208dbbd9da8e3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0% >7C0%7C638312257061769802%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4w >LjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C% >7C%7C&sdata=gDnMim2nrLIQflmmGu6cahz0prZV9iKslevv208u06U%3D&reser >ved=0 > >> >> Signed-off-by: Ming Qian <ming.qian@nxp.com> >> --- >> .../bindings/media/nxp,imx8-jpeg.yaml | 42 ++++++++----------- >> 1 file changed, 18 insertions(+), 24 deletions(-) >> >> diff --git >> a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >> b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >> index 3d9d1db37040..df381b21336d 100644 >> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >> @@ -32,25 +32,29 @@ properties: >> maxItems: 1 >> >> interrupts: >> - description: | >> - There are 4 slots available in the IP, which the driver may use >> - If a certain slot is used, it should have an associated interrupt >> - The interrupt with index i is assumed to be for slot i >> - minItems: 1 # At least one slot is needed by the driver >> - maxItems: 4 # The IP has 4 slots available for use >> + description: >> + Interrupt number for slot >> + maxItems: 1 >> >> power-domains: >> description: >> List of phandle and PM domain specifier as documented in >> Documentation/devicetree/bindings/power/power_domain.txt >> - minItems: 2 # Wrapper and 1 slot >> - maxItems: 5 # Wrapper and 4 slots >> + minItems: 1 # VPUMIX >> + maxItems: 2 # Wrapper and 1 slot >> + >> + nxp,slot: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: Integer number of slot index used. >> + minimum: 0 >> + maximum: 3 > >Nothing explains what is a slot and nothing explains why do you need this >property. > >> >> required: >> - compatible >> - reg >> - interrupts >> - power-domains >> + - nxp,slot > >NAK, that's an ABI break. > >Best regards, >Krzysztof
On 25/09/2023 10:07, Ming Qian wrote: >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: 2023年9月25日 16:02 >> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) >> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; shawnguo@kernel.org >> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; >> kernel@pengutronix.de; festevam@gmail.com; X.H. Bao >> <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang >> <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >> Subject: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign slot for >> imx jpeg encoder/decoder >> >> Caution: This is an external email. Please take care when clicking links or >> opening attachments. When in doubt, report the message using the 'Report >> this email' button >> >> >> On 25/09/2023 09:41, Ming Qian wrote: >>> There are total 4 slots available in the IP, and we only need to use >>> one slot in one os, assign a single slot, configure interrupt and >>> power domain only for 1 slot, not for the all 4 slots. >> >> No changelog and I do not see much of improvements. Do not ignore the >> feedback but respond to it or fix the patch. Really, what happened here? >> > > Hi Krzysztof, > What do you mean wrap commit message? Do you mean line wrapped at 75 columns? > > - The body of the explanation, line wrapped at 75 columns, which will > be copied to the permanent changelog to describe this patch. I gave you clear link to the doc explaining this. What is unclear there? And you decide to ignore all the rest of the comments here as well? Best regards, Krzysztof
On 25/09/2023 10:13, Ming Qian wrote: >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: 2023年9月25日 16:10 >> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) >> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; shawnguo@kernel.org >> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; >> kernel@pengutronix.de; festevam@gmail.com; X.H. Bao >> <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang >> <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >> Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign slot >> for imx jpeg encoder/decoder >> >> Caution: This is an external email. Please take care when clicking links or >> opening attachments. When in doubt, report the message using the 'Report >> this email' button >> >> >> On 25/09/2023 10:07, Ming Qian wrote: >>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> Sent: 2023年9月25日 16:02 >>>> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) >>>> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; >> shawnguo@kernel.org >>>> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >>>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; >>>> kernel@pengutronix.de; festevam@gmail.com; X.H. Bao >>>> <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang >>>> <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >>>> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >>>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >>>> Subject: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: >>>> Assign slot for imx jpeg encoder/decoder >>>> >>>> Caution: This is an external email. Please take care when clicking >>>> links or opening attachments. When in doubt, report the message using >>>> the 'Report this email' button >>>> >>>> >>>> On 25/09/2023 09:41, Ming Qian wrote: >>>>> There are total 4 slots available in the IP, and we only need to use >>>>> one slot in one os, assign a single slot, configure interrupt and >>>>> power domain only for 1 slot, not for the all 4 slots. >>>> >>>> No changelog and I do not see much of improvements. Do not ignore the >>>> feedback but respond to it or fix the patch. Really, what happened here? >>>> >>> >>> Hi Krzysztof, >>> What do you mean wrap commit message? Do you mean line wrapped at >> 75 columns? >>> >>> - The body of the explanation, line wrapped at 75 columns, which will >>> be copied to the permanent changelog to describe this patch. >> >> I gave you clear link to the doc explaining this. What is unclear there? >> >> And you decide to ignore all the rest of the comments here as well? So this is still ignored? Can you respond to all my comments? >> >> Best regards, >> Krzysztof > > The link content is as below: > > - The body of the explanation, line wrapped at 75 columns, which will > be copied to the permanent changelog to describe this patch. > > I'm sorry that I didn’t get your point. Wrap your commit according to coding style. Best regards, Krzysztof
On 25/09/2023 10:20, Ming Qian wrote: >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: 2023年9月25日 16:14 >> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) >> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; shawnguo@kernel.org >> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; >> kernel@pengutronix.de; festevam@gmail.com; X.H. Bao >> <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang >> <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >> Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign slot >> for imx jpeg encoder/decoder >> >> Caution: This is an external email. Please take care when clicking links or >> opening attachments. When in doubt, report the message using the 'Report >> this email' button >> >> >> On 25/09/2023 10:13, Ming Qian wrote: >>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> Sent: 2023年9月25日 16:10 >>>> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) >>>> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; >> shawnguo@kernel.org >>>> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >>>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; >>>> kernel@pengutronix.de; festevam@gmail.com; X.H. Bao >>>> <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang >>>> <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >>>> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >>>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >>>> Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: >>>> Assign slot for imx jpeg encoder/decoder >>>> >>>> Caution: This is an external email. Please take care when clicking >>>> links or opening attachments. When in doubt, report the message using >>>> the 'Report this email' button >>>> >>>> >>>> On 25/09/2023 10:07, Ming Qian wrote: >>>>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>>>> Sent: 2023年9月25日 16:02 >>>>>> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) >>>>>> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; >>>> shawnguo@kernel.org >>>>>> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >>>>>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; >>>>>> s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; >>>>>> X.H. Bao <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; >>>>>> Tao Jiang <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >>>>>> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >>>>>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >>>>>> Subject: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: >>>>>> Assign slot for imx jpeg encoder/decoder >>>>>> >>>>>> Caution: This is an external email. Please take care when clicking >>>>>> links or opening attachments. When in doubt, report the message >>>>>> using the 'Report this email' button >>>>>> >>>>>> >>>>>> On 25/09/2023 09:41, Ming Qian wrote: >>>>>>> There are total 4 slots available in the IP, and we only need to >>>>>>> use one slot in one os, assign a single slot, configure interrupt >>>>>>> and power domain only for 1 slot, not for the all 4 slots. >>>>>> >>>>>> No changelog and I do not see much of improvements. Do not ignore >>>>>> the feedback but respond to it or fix the patch. Really, what happened >> here? >>>>>> >>>>> >>>>> Hi Krzysztof, >>>>> What do you mean wrap commit message? Do you mean line wrapped >> at >>>> 75 columns? >>>>> >>>>> - The body of the explanation, line wrapped at 75 columns, which will >>>>> be copied to the permanent changelog to describe this patch. >>>> >>>> I gave you clear link to the doc explaining this. What is unclear there? >>>> >>>> And you decide to ignore all the rest of the comments here as well? >> >> So this is still ignored? Can you respond to all my comments? >> >>>> >>>> Best regards, >>>> Krzysztof >>> >>> The link content is as below: >>> >>> - The body of the explanation, line wrapped at 75 columns, which will >>> be copied to the permanent changelog to describe this patch. >>> >>> I'm sorry that I didn’t get your point. >> >> Wrap >> your >> commit >> according >> to >> coding >> style. >> >> Best regards, >> Krzysztof > > Hi Krzysztof, > I opened your link about the Linux coding style / submission process, but I only find the following message: > > - The body of the explanation, line wrapped at 75 columns, which will > be copied to the permanent changelog to describe this patch. > > So I don't know what do you mean the coding style. Linked document explains what is a patch, how it is formatted. Just read entire doc, not one sentence. You keep ignoring my other comments all the time, so I will stop asking you to respond to them. Instead I will be NAK-ing your patches till you decide to respond. Best regards, Krzysztof
On 25/09/2023 10:48, Ming Qian wrote: > > Sorry again that I didn't response your every comments, I will avoid doing it again. > > And can you give a example how to improve the commit message. In vim: gq<ENTER>gq<ENTER>gq<ENTER> and so on, till you are happy. Best regards, Krzysztof
On Mon, Sep 25, 2023 at 08:48:01AM +0000, Ming Qian wrote: > >From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >Sent: 2023年9月25日 16:33 > >To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) > ><mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; shawnguo@kernel.org > >Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; > >mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; > >kernel@pengutronix.de; festevam@gmail.com; X.H. Bao > ><xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang > ><tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; > >devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- > >kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org > >Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign slot > >for imx jpeg encoder/decoder > > > >Caution: This is an external email. Please take care when clicking links or > >opening attachments. When in doubt, report the message using the 'Report > >this email' button > > > > > >On 25/09/2023 10:20, Ming Qian wrote: > >>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >>> Sent: 2023年9月25日 16:14 > >>> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) > >>> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; > >shawnguo@kernel.org > >>> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; > >>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; > >>> kernel@pengutronix.de; festevam@gmail.com; X.H. Bao > >>> <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang > >>> <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; > >>> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- > >>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org > >>> Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: > >>> Assign slot for imx jpeg encoder/decoder > >>> > >>> Caution: This is an external email. Please take care when clicking > >>> links or opening attachments. When in doubt, report the message using > >>> the 'Report this email' button > >>> > >>> > >>> On 25/09/2023 10:13, Ming Qian wrote: > >>>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >>>>> Sent: 2023年9月25日 16:10 > >>>>> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) > >>>>> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; > >>> shawnguo@kernel.org > >>>>> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; > >>>>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; > >>>>> s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; > >>>>> X.H. Bao <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; > >>>>> Tao Jiang <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; > >>>>> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- > >>>>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org > >>>>> Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: > >>>>> Assign slot for imx jpeg encoder/decoder > >>>>> > >>>>> Caution: This is an external email. Please take care when clicking > >>>>> links or opening attachments. When in doubt, report the message > >>>>> using the 'Report this email' button > >>>>> > >>>>> > >>>>> On 25/09/2023 10:07, Ming Qian wrote: > >>>>>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >>>>>>> Sent: 2023年9月25日 16:02 > >>>>>>> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) > >>>>>>> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; > >>>>> shawnguo@kernel.org > >>>>>>> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; > >>>>>>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; > >>>>>>> s.hauer@pengutronix.de; kernel@pengutronix.de; > >>>>>>> festevam@gmail.com; X.H. Bao <xiahong.bao@nxp.com>; Eagle Zhou > >>>>>>> <eagle.zhou@nxp.com>; Tao Jiang <tao.jiang_2@nxp.com>; > >>>>>>> dl-linux-imx <linux-imx@nxp.com>; devicetree@vger.kernel.org; > >>>>>>> linux-media@vger.kernel.org; linux- kernel@vger.kernel.org; > >>>>>>> linux-arm-kernel@lists.infradead.org > >>>>>>> Subject: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: > >>>>>>> Assign slot for imx jpeg encoder/decoder > >>>>>>> > >>>>>>> Caution: This is an external email. Please take care when > >>>>>>> clicking links or opening attachments. When in doubt, report the > >>>>>>> message using the 'Report this email' button > >>>>>>> > >>>>>>> > >>>>>>> On 25/09/2023 09:41, Ming Qian wrote: > >>>>>>>> There are total 4 slots available in the IP, and we only need to > >>>>>>>> use one slot in one os, assign a single slot, configure > >>>>>>>> interrupt and power domain only for 1 slot, not for the all 4 slots. > >>>>>>> > >>>>>>> No changelog and I do not see much of improvements. Do not ignore > >>>>>>> the feedback but respond to it or fix the patch. Really, what > >>>>>>> happened > >>> here? > >>>>>>> > >>>>>> > >>>>>> Hi Krzysztof, > >>>>>> What do you mean wrap commit message? Do you mean line > >wrapped > >>> at > >>>>> 75 columns? > >>>>>> > >>>>>> - The body of the explanation, line wrapped at 75 columns, which will > >>>>>> be copied to the permanent changelog to describe this patch. > >>>>> > >>>>> I gave you clear link to the doc explaining this. What is unclear there? > >>>>> > >>>>> And you decide to ignore all the rest of the comments here as well? > >>> > >>> So this is still ignored? Can you respond to all my comments? > >>> > >>>>> > >>>>> Best regards, > >>>>> Krzysztof > >>>> > >>>> The link content is as below: > >>>> > >>>> - The body of the explanation, line wrapped at 75 columns, which will > >>>> be copied to the permanent changelog to describe this patch. > >>>> > >>>> I'm sorry that I didn’t get your point. > >>> > >>> Wrap > >>> your > >>> commit > >>> according > >>> to > >>> coding > >>> style. > >>> > >>> Best regards, > >>> Krzysztof > >> > >> Hi Krzysztof, > >> I opened your link about the Linux coding style / submission process, but I > >only find the following message: > >> > >> - The body of the explanation, line wrapped at 75 columns, which will > >> be copied to the permanent changelog to describe this patch. > >> > >> So I don't know what do you mean the coding style. > > > > > >Linked document explains what is a patch, how it is formatted. Just read > >entire doc, not one sentence. > > > >You keep ignoring my other comments all the time, so I will stop asking you to > >respond to them. Instead I will be NAK-ing your patches till you decide to > >respond. > > > >Best regards, > >Krzysztof > > Hi Krzysztof, > I'm sorry that I make you unhappy, as I didn't know how to improve the commit message. > And your other comments about the change, I get your point, and prepare to improve in the next version. > > Sorry again that I didn't response your every comments, I will avoid doing it again. > > And can you give a example how to improve the commit message. 'git log' There are 10K+ examples every 2 months. Please talk to your NXP colleagues experienced with upsteam about how to write and submit patches upstream, and explain what Krzysztof has said if it is not clear. Rob
diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi index a90654155a88..3043c416c43e 100644 --- a/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi @@ -18,10 +18,7 @@ img_ipg_clk: clock-img-ipg { jpegdec: jpegdec@58400000 { reg = <0x58400000 0x00050000>; - interrupts = <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 310 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 311 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 312 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>; clocks = <&img_jpeg_dec_lpcg IMX_LPCG_CLK_0>, <&img_jpeg_dec_lpcg IMX_LPCG_CLK_4>; clock-names = "per", "ipg"; @@ -29,18 +26,13 @@ jpegdec: jpegdec@58400000 { <&img_jpeg_dec_lpcg IMX_LPCG_CLK_4>; assigned-clock-rates = <200000000>, <200000000>; power-domains = <&pd IMX_SC_R_MJPEG_DEC_MP>, - <&pd IMX_SC_R_MJPEG_DEC_S0>, - <&pd IMX_SC_R_MJPEG_DEC_S1>, - <&pd IMX_SC_R_MJPEG_DEC_S2>, - <&pd IMX_SC_R_MJPEG_DEC_S3>; + <&pd IMX_SC_R_MJPEG_DEC_S0>; + nxp,slot = <0>; }; jpegenc: jpegenc@58450000 { reg = <0x58450000 0x00050000>; - interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 307 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 308 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>; clocks = <&img_jpeg_enc_lpcg IMX_LPCG_CLK_0>, <&img_jpeg_enc_lpcg IMX_LPCG_CLK_4>; clock-names = "per", "ipg"; @@ -48,10 +40,8 @@ jpegenc: jpegenc@58450000 { <&img_jpeg_enc_lpcg IMX_LPCG_CLK_4>; assigned-clock-rates = <200000000>, <200000000>; power-domains = <&pd IMX_SC_R_MJPEG_ENC_MP>, - <&pd IMX_SC_R_MJPEG_ENC_S0>, - <&pd IMX_SC_R_MJPEG_ENC_S1>, - <&pd IMX_SC_R_MJPEG_ENC_S2>, - <&pd IMX_SC_R_MJPEG_ENC_S3>; + <&pd IMX_SC_R_MJPEG_ENC_S0>; + nxp,slot = <0>; }; img_jpeg_dec_lpcg: clock-controller@585d0000 {