diff mbox series

staging: media: omap4iss: correct cacheflush import

Message ID 20221113003347.93483-1-ian@linux.cowan.aero
State New
Headers
Series staging: media: omap4iss: correct cacheflush import |

Commit Message

Ian Cowan Nov. 13, 2022, 12:33 a.m. UTC 
  Correct the import for cacheflush from the asm directory to the linux
directory.

Signed-off-by: Ian Cowan <ian@linux.cowan.aero>
---
 drivers/staging/media/omap4iss/iss_video.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Laurent Pinchart Nov. 14, 2022, 2:06 p.m. UTC | #1 
Hi Ian,

Thank you for the patch.

On Sat, Nov 12, 2022 at 07:33:47PM -0500, Ian Cowan wrote:
> Correct the import for cacheflush from the asm directory to the linux
> directory.

Unless I'm mistaken, it looks like the header is actually not needed at
all.

> Signed-off-by: Ian Cowan <ian@linux.cowan.aero>
> ---
>  drivers/staging/media/omap4iss/iss_video.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/omap4iss/iss_video.c b/drivers/staging/media/omap4iss/iss_video.c
> index 842509dcfedf..9f08dd976a24 100644
> --- a/drivers/staging/media/omap4iss/iss_video.c
> +++ b/drivers/staging/media/omap4iss/iss_video.c
> @@ -7,6 +7,7 @@
>   * Author: Sergio Aguirre <sergio.a.aguirre@gmail.com>
>   */
>  
> +#include <linux/cacheflush.h>
>  #include <linux/clk.h>
>  #include <linux/mm.h>
>  #include <linux/pagemap.h>
> @@ -19,8 +20,6 @@
>  #include <media/v4l2-ioctl.h>
>  #include <media/v4l2-mc.h>
>  
> -#include <asm/cacheflush.h>
> -
>  #include "iss_video.h"
>  #include "iss.h"
>
Ian Cowan Nov. 14, 2022, 4:06 p.m. UTC | #2 
On Mon, Nov 14, 2022 at 04:06:50PM +0200, Laurent Pinchart wrote:
> Hi Ian,
> 
> Thank you for the patch.
> 
> On Sat, Nov 12, 2022 at 07:33:47PM -0500, Ian Cowan wrote:
> > Correct the import for cacheflush from the asm directory to the linux
> > directory.
> 
> Unless I'm mistaken, it looks like the header is actually not needed at
> all.

Good catch - it's not needed at all. I'll submit a patch momentarily
that removes it completely.

ian
diff mbox series

Patch

diff --git a/drivers/staging/media/omap4iss/iss_video.c b/drivers/staging/media/omap4iss/iss_video.c
index 842509dcfedf..9f08dd976a24 100644
--- a/drivers/staging/media/omap4iss/iss_video.c
+++ b/drivers/staging/media/omap4iss/iss_video.c
@@ -7,6 +7,7 @@ 
  * Author: Sergio Aguirre <sergio.a.aguirre@gmail.com>
  */
 
+#include <linux/cacheflush.h>
 #include <linux/clk.h>
 #include <linux/mm.h>
 #include <linux/pagemap.h>
@@ -19,8 +20,6 @@ 
 #include <media/v4l2-ioctl.h>
 #include <media/v4l2-mc.h>
 
-#include <asm/cacheflush.h>
-
 #include "iss_video.h"
 #include "iss.h"