[1/2] ARM: dts: st: href-tvk1281618: fix touchscreen VIO supply

Message ID 20230720115524.137944-1-krzysztof.kozlowski@linaro.org
State New
Headers
Series [1/2] ARM: dts: st: href-tvk1281618: fix touchscreen VIO supply |

Commit Message

Krzysztof Kozlowski July 20, 2023, 11:55 a.m. UTC
  According to bindings and Linux driver, there is no VDDIO but VIO
supply:

  ste-hrefprev60-tvk.dtb: synaptics@4b: Unevaluated properties are not allowed ('vddio-supply' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Linus Walleij Aug. 10, 2023, 7:54 a.m. UTC | #1
On Thu, Jul 20, 2023 at 1:55 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:

> According to bindings and Linux driver, there is no VDDIO but VIO
> supply:
>
>   ste-hrefprev60-tvk.dtb: synaptics@4b: Unevaluated properties are not allowed ('vddio-supply' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Patch applied!
Excellently shows how the schema files find real bugs in the DTS files!

Yours,
Linus Walleij
  
Krzysztof Kozlowski Sept. 24, 2023, 6:55 p.m. UTC | #2
On 10/08/2023 09:54, Linus Walleij wrote:
> On Thu, Jul 20, 2023 at 1:55 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> 
>> According to bindings and Linux driver, there is no VDDIO but VIO
>> supply:
>>
>>   ste-hrefprev60-tvk.dtb: synaptics@4b: Unevaluated properties are not allowed ('vddio-supply' was unexpected)
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Patch applied!
> Excellently shows how the schema files find real bugs in the DTS files!

It seems it is not in the linux-next (one month later). Shall I take it?

Best regards,
Krzysztof
  
Linus Walleij Sept. 25, 2023, 9:22 a.m. UTC | #3
On Sun, Sep 24, 2023 at 8:55 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:

> > Patch applied!
> > Excellently shows how the schema files find real bugs in the DTS files!
>
> It seems it is not in the linux-next (one month later). Shall I take it?

Ooops. Just me not keeping track of my TODO list as usual.
Sent a pull request now.

Yours,
Linus Walleij
  

Patch

diff --git a/arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi b/arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi
index 37e59403c01f..469e61c9a349 100644
--- a/arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi
+++ b/arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi
@@ -192,7 +192,7 @@  synaptics@4b {
 				#size-cells = <0>;
 				reg = <0x4b>;
 				vdd-supply = <&ab8500_ldo_aux1_reg>;
-				vddio-supply = <&db8500_vsmps2_reg>;
+				vio-supply = <&db8500_vsmps2_reg>;
 				pinctrl-names = "default";
 				pinctrl-0 = <&synaptics_tvk_mode>;
 				interrupt-parent = <&gpio2>;