Message ID | 20230922080421.35145-3-wsa+renesas@sang-engineering.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp5457810vqi; Fri, 22 Sep 2023 03:23:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGDCqGgNic4zkZpIA/adG/oWyLyS2nifb+8KzwABB0hLmBOLpM4N2lUTiNgqnPmn22GuZE9 X-Received: by 2002:a17:902:8209:b0:1c3:64f9:45ad with SMTP id x9-20020a170902820900b001c364f945admr6784491pln.48.1695378225736; Fri, 22 Sep 2023 03:23:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695378225; cv=none; d=google.com; s=arc-20160816; b=UVvRTxNA9AMlyqK5avHGUJFk4R0UdAvWpbWYApNS5Q56wIDAXRveo6RrHNoos50KfZ OKbcuOs9qmET93ED0XcF9kgOjeNmlQ8rkVvrTM9TIkCuTtnTZfK01zYo6xqarcYyimfO AQQfEB3rzEO4dpBcQ3xOPEsLcvaOd8tjeowhw4joZ486PcD8F3VaDmd7IzPbcz4YqjKS 69utGKOwg3mN3uexkHOFSp/dc3s5QaHNEq7bc3OYJVEEs3w9X3JOk5NFSXc/Vlby6H/i PVFNCYDiYOJ8TuxXdotVqZpu8oO8PVP8SeN5s6ZIYZdToEwYbnpn/OlocRt/+z6Z88+8 GOtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WAAxDZzPxYcCGm21BNyqSjh4x8SKsO8gvU5+0ZgsA/8=; fh=X2SUrmAWqIp69ecg1Mh8aUp6AilwvY3i1dB+TJrWbIU=; b=XHHXuLGl+kHFPAPFTy4tWNhlSZ5kYz7XiHcq9q+smjw7Kfw9vAnaNqnQ/61RO0CQaM cNnxOWYNZlkt4HBinGI2tcDJsvHvvRj/fMx2IOgLgK8jRH0JhMChf7ptXeNHQHvDisbe S7E4VMBVDvmIWobVTBn8cgr408xi78cixmwz6EyGD8meRHxs6zGs28SsYCs0wygkkh7x xm2078VT7zKxWtnnysBR8/u4Up4g2lt7z6qWnsoR45Lbi+sUHtecL32mlv1fS1MC6Zaw JhfK41pH2IpzlyayIbeeZW9u2BOAz4nungpFy6D2uOrDxPe4gtaXiWA6HK8uER5zqwUf ITtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sang-engineering.com header.s=k1 header.b=T0UiFeq1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id je11-20020a170903264b00b001bb9370760fsi3421537plb.90.2023.09.22.03.23.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 03:23:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@sang-engineering.com header.s=k1 header.b=T0UiFeq1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 82E948293CB8; Fri, 22 Sep 2023 01:06:08 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232124AbjIVIFx (ORCPT <rfc822;chrisfriedt@gmail.com> + 30 others); Fri, 22 Sep 2023 04:05:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232169AbjIVIFf (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 22 Sep 2023 04:05:35 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA000E55 for <linux-kernel@vger.kernel.org>; Fri, 22 Sep 2023 01:04:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=WAAxDZzPxYcCGm21BNyqSjh4x8SKsO8gvU5+0ZgsA/8=; b=T0UiFe q1th/GBTpGw+oKYS2+mS4LDfO9FUIzWlVBdF9TuuuVVP/qtjLSD41biuOPvvs+jn kEM74tbnZhqk1R44Nuk3Ap7SF+Gpim+aVxCl254VJe+dxzHAFFgqFcLidWWMtrzg F2rD8oq8dYrowr2XWsN+xOhjSHVz/Pol2tiJtt0AM9SXRf5CinVLQyl7rFgD54HL qErJ9iAml7MI4+RJdslcVhoiTDVsMnh8vlClBpqv0FJR2TUR+TTKxieo/vbHNrnA TpGkb1aaYAPhoP+x81twW0AOadF7Bps6jRCdNLHHvYQO/Jr5G/9WjnYxX112rQSC FjRgIk8qD/0e59dA== Received: (qmail 1310933 invoked from network); 22 Sep 2023 10:04:28 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 22 Sep 2023 10:04:28 +0200 X-UD-Smtp-Session: l3s3148p1@GEnEDu4FdMIujntX From: Wolfram Sang <wsa+renesas@sang-engineering.com> To: linux-renesas-soc@vger.kernel.org Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>, Jacopo Mondi <jacopo+renesas@jmondi.org>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, =?utf-8?q?Nik?= =?utf-8?q?las_S=C3=B6derlund?= <niklas.soderlund+renesas@ragnatech.se>, Mauro Carvalho Chehab <mchehab@kernel.org>, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] media: i2c: drop check because i2c_unregister_device() is NULL safe Date: Fri, 22 Sep 2023 10:04:19 +0200 Message-Id: <20230922080421.35145-3-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230922080421.35145-1-wsa+renesas@sang-engineering.com> References: <20230922080421.35145-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 22 Sep 2023 01:06:08 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777726237112089582 X-GMAIL-MSGID: 1777732918510244574 |
Series |
treewide: drop check because i2c_unregister_device() is NULL safe
|
|
Commit Message
Wolfram Sang
Sept. 22, 2023, 8:04 a.m. UTC
No need to check the argument of i2c_unregister_device() because the
function itself does it.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Build tested only. Please apply to your tree.
drivers/media/i2c/rdacm20.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Comments
On Fri, Sep 22, 2023 at 4:45 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > No need to check the argument of i2c_unregister_device() because the > function itself does it. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
On Fri, Sep 22, 2023 at 10:04:19AM +0200, Wolfram Sang wrote: > No need to check the argument of i2c_unregister_device() because the > function itself does it. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> I'll take this in my tree and send a pull request if Sakari doesn't pick up the patch himself. > --- > Build tested only. Please apply to your tree. > > drivers/media/i2c/rdacm20.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c > index f4e2e2f3972a..b4647bda8c21 100644 > --- a/drivers/media/i2c/rdacm20.c > +++ b/drivers/media/i2c/rdacm20.c > @@ -625,8 +625,7 @@ static int rdacm20_probe(struct i2c_client *client) > v4l2_ctrl_handler_free(&dev->ctrls); > error: > media_entity_cleanup(&dev->sd.entity); > - if (dev->sensor) > - i2c_unregister_device(dev->sensor); > + i2c_unregister_device(dev->sensor); > > dev_err(&client->dev, "probe failed\n"); >
diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c index f4e2e2f3972a..b4647bda8c21 100644 --- a/drivers/media/i2c/rdacm20.c +++ b/drivers/media/i2c/rdacm20.c @@ -625,8 +625,7 @@ static int rdacm20_probe(struct i2c_client *client) v4l2_ctrl_handler_free(&dev->ctrls); error: media_entity_cleanup(&dev->sd.entity); - if (dev->sensor) - i2c_unregister_device(dev->sensor); + i2c_unregister_device(dev->sensor); dev_err(&client->dev, "probe failed\n");