Message ID | 20230920004400.81091-1-yang.lee@linux.alibaba.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp3782169vqi; Tue, 19 Sep 2023 17:44:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHEy8ZwB32Xc0wywhvpovCM4Er9y/BhN5Xuw6gTVl0RXyw1d61mhBhmuBRqyrUrxqdgemVt X-Received: by 2002:a05:6a21:47ca:b0:15c:b7ba:6a4d with SMTP id as10-20020a056a2147ca00b0015cb7ba6a4dmr705766pzc.50.1695170691562; Tue, 19 Sep 2023 17:44:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695170691; cv=none; d=google.com; s=arc-20160816; b=nWQ4ePx5Nk7zmedZJvBgr9ZJRYiMo5Pr0jJou1O4ZsR6DFTxWF9mk12uWkkdc3KSDm 4X3grxZqxLGWCi4DxohBv8B2jDsb3NcoCVU9KfZZvdqjkhdLPygkb4OHoc503IGjvwm1 OfiNc9QD7rRpMTEFaEorscasTFcOh8nf8NU4p/YQSGniGTALyV9WC1F3gi+sWka9u/Rw X+FnT24rxN8xB1YDv+T6LNMV8/o51/FWc9+onpfN+PTlil1NQfRDkv6uhorTelk5UV4P fSimNFo81pGdpEIiN3X0u+FuB3BMw4OeAqkZPrCIoq8mMIZWIRanMwJTx14eew7RS5R6 60tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=8/xEj98yUvkzIroK8LZADBBQlKchUg3ee+PHjxzgSTs=; fh=56XDgu4eUDu5p6Yx3OWLgH/IEZQeorFvND5DJn+aVpk=; b=mtZq2owXrVM2wuVDRAywZE7Twspfo5SX+oQhw2yEXJuI0Muu5oM6aveIjlIaLUqgGJ I+Yd/nbrGZQSkekh74eg6MWinfLF0mNiDB5p9OYhZTlMioLQWldR/J+i2xpXJw90Moud 1hcl6cS51dbFN0VII+gGooB1AhCVJ3DTWdYyjrE/zZauN/+ydLUY4DCoWFQm6V0seuQI QQ+Vz1UX/vElWS3+ls5BpG7rt3ZWesopyXcGWvKTbzAoENe+og5Tjuz7LEkjhPj+aVSh ZOOTAVVOo8QFnzPLcgu18sNap/lp9OASKOMyup+FMwzmLD4lEqwx3w6rCKVgd9drPQWt aaFQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id cj11-20020a056a00298b00b0068a68d71b68si2795621pfb.216.2023.09.19.17.44.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 17:44:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 75411821ADAC; Tue, 19 Sep 2023 17:44:13 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231580AbjITAoM (ORCPT <rfc822;toshivichauhan@gmail.com> + 26 others); Tue, 19 Sep 2023 20:44:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230447AbjITAoL (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 19 Sep 2023 20:44:11 -0400 Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA3F2AB for <linux-kernel@vger.kernel.org>; Tue, 19 Sep 2023 17:44:04 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R451e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0VsStaA0_1695170641; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0VsStaA0_1695170641) by smtp.aliyun-inc.com; Wed, 20 Sep 2023 08:44:02 +0800 From: Yang Li <yang.lee@linux.alibaba.com> To: airlied@gmail.com, daniel@ffwll.ch, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yang Li <yang.lee@linux.alibaba.com> Subject: [PATCH -next] drm/bridge: clean up some inconsistent indentings Date: Wed, 20 Sep 2023 08:44:00 +0800 Message-Id: <20230920004400.81091-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 19 Sep 2023 17:44:13 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777515302886158189 X-GMAIL-MSGID: 1777515302886158189 |
Series |
[-next] drm/bridge: clean up some inconsistent indentings
|
|
Commit Message
Yang Li
Sept. 20, 2023, 12:44 a.m. UTC
drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c:336 dw_hdmi_cec_suspend() warn: inconsistent indenting
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Comments
NAK Personally I value maintaining a simple to follow `git blame` history over correcting indentation. Ideally bad indentation should never be committed in the first place. On Wed, Sep 20, 2023 at 2:44 AM Yang Li <yang.lee@linux.alibaba.com> wrote: > > drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c:336 dw_hdmi_cec_suspend() warn: inconsistent indenting > > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c > index 673661160e54..fe2ff4984fc5 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c > @@ -333,9 +333,9 @@ static int __maybe_unused dw_hdmi_cec_suspend(struct device *dev) > struct dw_hdmi_cec *cec = dev_get_drvdata(dev); > > /* store interrupt status/mask registers */ > - cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY); > - cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK); > - cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0); > + cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY); > + cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK); > + cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0); > > return 0; > } > -- > 2.20.1.7.g153144c >
On Mon, 25 Sep 2023, Robert Foss <rfoss@kernel.org> wrote: > NAK Feels a bit harsh. > Personally I value maintaining a simple to follow `git blame` history > over correcting indentation. > > Ideally bad indentation should never be committed in the first place. Agreed, but when that inevitably happens, do you really want it to be cast in stone? To me leaving bad indent (or style, or whatever) in place indicates we don't care, while the opposite is true. Maybe look into tooling that lets you easily git blame the parent commit of a line in git blame? (For example, in emacs vc-annotate, it's just a matter of hitting 'a'.) BR, Jani. > > On Wed, Sep 20, 2023 at 2:44 AM Yang Li <yang.lee@linux.alibaba.com> wrote: >> >> drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c:336 dw_hdmi_cec_suspend() warn: inconsistent indenting >> >> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> >> --- >> drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c >> index 673661160e54..fe2ff4984fc5 100644 >> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c >> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c >> @@ -333,9 +333,9 @@ static int __maybe_unused dw_hdmi_cec_suspend(struct device *dev) >> struct dw_hdmi_cec *cec = dev_get_drvdata(dev); >> >> /* store interrupt status/mask registers */ >> - cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY); >> - cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK); >> - cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0); >> + cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY); >> + cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK); >> + cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0); >> >> return 0; >> } >> -- >> 2.20.1.7.g153144c >>
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c index 673661160e54..fe2ff4984fc5 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c @@ -333,9 +333,9 @@ static int __maybe_unused dw_hdmi_cec_suspend(struct device *dev) struct dw_hdmi_cec *cec = dev_get_drvdata(dev); /* store interrupt status/mask registers */ - cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY); - cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK); - cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0); + cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY); + cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK); + cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0); return 0; }