diff mbox series

[RESEND,1/4] ARM: dts: qcom: apq8064: drop incorrect regulator-type

Message ID 20230924183914.51414-1-krzysztof.kozlowski@linaro.org
State New
Headers
Series [RESEND,1/4] ARM: dts: qcom: apq8064: drop incorrect regulator-type |

Commit Message

Krzysztof Kozlowski Sept. 24, 2023, 6:39 p.m. UTC 
  regulator-fixed does not have a "regulator-type" property:

  qcom-apq8064-ifc6410.dtb: regulator-ext-3p3v: Unevaluated properties are not allowed ('regulator-type' was unexpected)

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/qcom/qcom-apq8064-asus-nexus7-flo.dts | 1 -
 arch/arm/boot/dts/qcom/qcom-apq8064-ifc6410.dts         | 1 -
 2 files changed, 2 deletions(-)

Comments

Dmitry Baryshkov Sept. 24, 2023, 10:52 p.m. UTC | #1 
On Sun, 24 Sept 2023 at 21:39, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> regulator-fixed does not have a "regulator-type" property:
>
>   qcom-apq8064-ifc6410.dtb: regulator-ext-3p3v: Unevaluated properties are not allowed ('regulator-type' was unexpected)
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  arch/arm/boot/dts/qcom/qcom-apq8064-asus-nexus7-flo.dts | 1 -
>  arch/arm/boot/dts/qcom/qcom-apq8064-ifc6410.dts         | 1 -
>  2 files changed, 2 deletions(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Dmitry Baryshkov Sept. 24, 2023, 10:56 p.m. UTC | #2 
On Sun, 24 Sept 2023 at 21:39, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> GPIO keys and LEDs are not part of the SoC, so move them to top-level to
> fix dtbs_check warnings like:
>
>   qcom-ipq8064-rb3011.dtb: soc: gpio-keys: {'compatible': ['gpio-keys'], ... should not be valid under {'type': 'object'}
>         from schema $id: http://devicetree.org/schemas/simple-bus.yaml#
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../arm/boot/dts/qcom/qcom-ipq8064-rb3011.dts |  55 ++++----
>  arch/arm/boot/dts/qcom/qcom-ipq8064-v1.0.dtsi | 122 +++++++++---------
>  2 files changed, 88 insertions(+), 89 deletions(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Bjorn Andersson Sept. 28, 2023, 12:34 a.m. UTC | #3 
On Sun, 24 Sep 2023 20:39:11 +0200, Krzysztof Kozlowski wrote:
> regulator-fixed does not have a "regulator-type" property:
> 
>   qcom-apq8064-ifc6410.dtb: regulator-ext-3p3v: Unevaluated properties are not allowed ('regulator-type' was unexpected)
> 
> 

Applied, thanks!

[1/4] ARM: dts: qcom: apq8064: drop incorrect regulator-type
      commit: 686bca7bd170430d226c74337488088b1979bdbf
[2/4] ARM: dts: qcom: apq8060: drop incorrect regulator-type
      commit: 34c006f42cb15ac574c61859d07ae7a41ec04d84
[3/4] ARM: dts: qcom: mdm9615: populate vsdcc fixed regulator
      commit: 09f8ee81b6da5f76de8b83c8bfc4475b54e101e0
[4/4] ARM: dts: qcom: ipq8064: move keys and leds out of soc node
      commit: 2138c32af19740ab54bf5622890fe96ba3530b75

Best regards,
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/qcom/qcom-apq8064-asus-nexus7-flo.dts b/arch/arm/boot/dts/qcom/qcom-apq8064-asus-nexus7-flo.dts
index c57c27cd8a20..c0dd6399f597 100644
--- a/arch/arm/boot/dts/qcom/qcom-apq8064-asus-nexus7-flo.dts
+++ b/arch/arm/boot/dts/qcom/qcom-apq8064-asus-nexus7-flo.dts
@@ -36,7 +36,6 @@  ext_3p3v: regulator-ext-3p3v {
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
 		regulator-name = "ext_3p3v";
-		regulator-type = "voltage";
 		startup-delay-us = <0>;
 		gpio = <&tlmm_pinmux 77 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
diff --git a/arch/arm/boot/dts/qcom/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom/qcom-apq8064-ifc6410.dts
index 96307550523a..b0c5e7bd5e74 100644
--- a/arch/arm/boot/dts/qcom/qcom-apq8064-ifc6410.dts
+++ b/arch/arm/boot/dts/qcom/qcom-apq8064-ifc6410.dts
@@ -58,7 +58,6 @@  ext_3p3v: regulator-ext-3p3v {
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
 		regulator-name = "ext_3p3v";
-		regulator-type = "voltage";
 		startup-delay-us = <0>;
 		gpio = <&tlmm_pinmux 77 GPIO_ACTIVE_HIGH>;
 		enable-active-high;