Message ID | 20221111092457.10546-4-johan+linaro@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp637311wru; Fri, 11 Nov 2022 01:27:58 -0800 (PST) X-Google-Smtp-Source: AA0mqf6C62hTEc2YFdLkwBr090eWOfEMewslM/O3OI2U06/HKv1drRoDOaYnrd2YeMkcXHd1GwbF X-Received: by 2002:a17:907:c683:b0:787:8884:78df with SMTP id ue3-20020a170907c68300b00787888478dfmr1164547ejc.246.1668158877869; Fri, 11 Nov 2022 01:27:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668158877; cv=none; d=google.com; s=arc-20160816; b=YJBt+W5LEMZZXTe64n3Igf4fEKzIc8yY+LapnIRrLeBauuaLymJow9mquAq2xWIAMg CBX//twkXZc1KYSt4rCFque4N5sImxdKxwdIS2VRq3LFbsaF/UXUo7i5A+UalyXErUHS 2X58ajtAcrp8Va0uRziIn9Hux9D9v0o6CP0GTWOR3U4X1cafns99fpfl06iARUG/pzRv RURMnfLLlA+IF5iGNbbXcTTviATn6dzlhRD7xKlLP/NS66BJN0sNOcbvfjiuN5a/YI8A fLQCtYb9DJxlgCcsU5JhIHClcryenVi15Vsgmw2ECQyca2LSigQdb9mnHntt5lzHiSas J5yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=FBo0RLzcTntH1w79zZKj4yKOJNHrrDkEYUW3KBHdXlU=; b=As9rlGvgyq1NVlt8tfhdISx6pkvs9AtkCep+UFOiznZLKH7SYIxHicMxyzbAAV0kJg oS12+twO5dzHBLSqkQyPMBVITf2MvOouAId28l7iB79NkjTfWcfdfEHpqgWrCHAZeT6E TW6IiRQpNhis5UAPYKpd2yrLIybvPEEFlbsy4sOClr7e9Yzd6hhtVX5V2MhDpmBntJ5u 6GgoDvhIm297jUb203h4fu7R3DWRW3UucdLw+CycoKQN7o33s3I404N8X30O44C0g+9O oKSLJEojtJcWVDZbMjzRpZRrtrIeMajGE75nk/7kI90tpJRKBEkmu/Axj+l3g+QZ8qhu rQgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RnxqHSLD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e14-20020a17090658ce00b007707f83375bsi1679185ejs.945.2022.11.11.01.27.35; Fri, 11 Nov 2022 01:27:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RnxqHSLD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233825AbiKKJ05 (ORCPT <rfc822;winker.wchi@gmail.com> + 99 others); Fri, 11 Nov 2022 04:26:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233691AbiKKJ0T (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 11 Nov 2022 04:26:19 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97A16787B3; Fri, 11 Nov 2022 01:26:07 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4E277B824AC; Fri, 11 Nov 2022 09:26:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A855AC433D6; Fri, 11 Nov 2022 09:26:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668158764; bh=7Bn0peWH/hNf2LHrrVl+nLdZzch+rSC+IV1zbZGqVyE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RnxqHSLDge/pputrplShQtJ1am2b5islVQbmavRRh7YTzPLV12Qnm9Rlj2xx9zrD/ eQzWxLO0yLddDQtF78t7M4LQ9YPtHpH2TUZg8Jmgg0GuxNk0r8tv5Gs/itKc5E+Rvz Gb7r/pjfbomlfjyzKdZEkspXgg/3klc8rQLFhv7uFdRyKiAJZpvf3bTaP5+ZmfVu3r vHLMuAbyP5avRzjgtb56xNI1T2G7EwYqOBF9FWMzctRr19DE+1uI792hZqA5ylF+FK lmM5rLiDGRDQRSxAx2hXrpiiLwzdj8xsuwtr+i3+yHL1YHZpneofaeJk8hGXpE+zqR OeOyxhAmA1vbw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from <johan+linaro@kernel.org>) id 1otQI4-0002kt-OX; Fri, 11 Nov 2022 10:25:36 +0100 From: Johan Hovold <johan+linaro@kernel.org> To: Vinod Koul <vkoul@kernel.org> Cc: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold <johan+linaro@kernel.org> Subject: [PATCH 03/14] phy: qcom-qmp-combo: drop v4 reference-clock source Date: Fri, 11 Nov 2022 10:24:46 +0100 Message-Id: <20221111092457.10546-4-johan+linaro@kernel.org> X-Mailer: git-send-email 2.37.4 In-Reply-To: <20221111092457.10546-1-johan+linaro@kernel.org> References: <20221111092457.10546-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749191363572220989?= X-GMAIL-MSGID: =?utf-8?q?1749191363572220989?= |
Series |
phy: qcom-qmp-combo: fix sc8280xp binding (set 3/3)
|
|
Commit Message
Johan Hovold
Nov. 11, 2022, 9:24 a.m. UTC
The source clock for the reference clock should not be described by the
devicetree and instead this relationship should be modelled in the clock
driver.
Drop the management of the source clock from the driver for SC8180X and
SC8280XP. Note that support for the former is not yet in mainline.
Also note that the binding has never been updated to describe the v4
clocks for SC8180X.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 11/11/2022 12:24, Johan Hovold wrote: > The source clock for the reference clock should not be described by the > devicetree and instead this relationship should be modelled in the clock > driver. Do we have a fix for the gcc driver? > > Drop the management of the source clock from the driver for SC8180X and > SC8280XP. Note that support for the former is not yet in mainline. > > Also note that the binding has never been updated to describe the v4 > clocks for SC8180X. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > index 51a03ac05c91..e6c7cf723b19 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > @@ -947,7 +947,7 @@ static const char * const qmp_v3_phy_clk_l[] = { > }; > > static const char * const qmp_v4_phy_clk_l[] = { > - "aux", "ref_clk_src", "ref", "com_aux", > + "aux", "ref", "com_aux", > }; > > /* the primary usb3 phy on sm8250 doesn't have a ref clock */
On Sat, Nov 12, 2022 at 02:43:38PM +0300, Dmitry Baryshkov wrote: > On 11/11/2022 12:24, Johan Hovold wrote: > > The source clock for the reference clock should not be described by the > > devicetree and instead this relationship should be modelled in the clock > > driver. > > Do we have a fix for the gcc driver? Bjorn is preparing one, but there's no need to wait for that to be merged in this case (we have a ton of references on CXO, we need to get the binding fixed in 6.2, and some other reasons which Bjorn may be able to share soon). Johan
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c index 51a03ac05c91..e6c7cf723b19 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c @@ -947,7 +947,7 @@ static const char * const qmp_v3_phy_clk_l[] = { }; static const char * const qmp_v4_phy_clk_l[] = { - "aux", "ref_clk_src", "ref", "com_aux", + "aux", "ref", "com_aux", }; /* the primary usb3 phy on sm8250 doesn't have a ref clock */