diff mbox series

[06/18] mfd: max77650: Remove useless type_invert flag

Message ID	20221112151835.39059-7-aidanmacdonald.0x0@gmail.com
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Aidan MacDonald <aidanmacdonald.0x0@gmail.com> To: lee@kernel.org Cc: mani@kernel.org, cristian.ciocaltea@gmail.com, wens@csie.org, tharvey@gateworks.com, cw00.choi@samsung.com, krzysztof.kozlowski@linaro.org, brgl@bgdev.pl, mazziesaccount@gmail.com, orsonzhai@gmail.com, baolin.wang@linux.alibaba.com, zhang.lyra@gmail.com, jernej.skrabec@gmail.com, samuel@sholland.org, linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH 06/18] mfd: max77650: Remove useless type_invert flag Date: Sat, 12 Nov 2022 15:18:23 +0000 Message-Id: <20221112151835.39059-7-aidanmacdonald.0x0@gmail.com> In-Reply-To: <20221112151835.39059-1-aidanmacdonald.0x0@gmail.com> References: <20221112151835.39059-1-aidanmacdonald.0x0@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	mfd: Clean up deprecated regmap-irq functionality \| [00/18] mfd: Clean up deprecated regmap-irq functionality [01/18] mfd: 88pm800: Replace irqchip mask_invert with unmask_base [02/18] mfd: atc260x: Replace irqchip mask_invert with unmask_base [03/18] mfd: axp20x: Replace irqchip mask_invert with unmask_base [04/18] mfd: gateworks-gsc: Replace irqchip mask_invert with unmask_base [05/18] mfd: max14577: Replace irqchip mask_invert with unmask_base [06/18] mfd: max77650: Remove useless type_invert flag [07/18] mfd: max77693: Replace irqchip mask_invert with unmask_base [08/18] mfd: max77843: Drop useless mask_invert flag on irqchip [09/18] mfd: rn5t618: Replace irqchip mask_invert with unmask_base [10/18] mfd: rohm-bd71828: Replace irqchip mask_invert with unmask_base [11/18] mfd: rohm-bd718x7: Drop useless mask_invert flag on irqchip [12/18] mfd: rt5033: Replace irqchip mask_invert with unmask_base [13/18] mfd: rt5120: Replace irqchip mask_invert with unmask_base [14/18] mfd: sprd-sc27xx-spi: Replace irqchip mask_invert with unmask_base [15/18] mfd: stpmic1: Fix swapped mask/unmask in irq chip [16/18] mfd: sun4i-gpadc: Replace irqchip mask_invert with unmask_base [17/18] mfd: tps65090: Replace irqchip mask_invert with unmask_base [18/18] mfd: wcd934x: Convert irq chip to config regs

Commit Message

Aidan MacDonald Nov. 12, 2022, 3:18 p.m. UTC

  The type_invert flag does nothing when type_in_mask is set, and
it's part of deprecated functionality in regmap-irq. Remove it.

Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
---
 drivers/mfd/max77650.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Bartosz Golaszewski Nov. 14, 2022, 12:24 p.m. UTC | #1

On Sat, Nov 12, 2022 at 4:19 PM Aidan MacDonald
<aidanmacdonald.0x0@gmail.com> wrote:
>
> The type_invert flag does nothing when type_in_mask is set, and
> it's part of deprecated functionality in regmap-irq. Remove it.
>
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
> ---
>  drivers/mfd/max77650.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mfd/max77650.c b/drivers/mfd/max77650.c
> index 777485a33bc0..3c07fcdd9d07 100644
> --- a/drivers/mfd/max77650.c
> +++ b/drivers/mfd/max77650.c
> @@ -138,7 +138,6 @@ static const struct regmap_irq_chip max77650_irq_chip = {
>         .status_base            = MAX77650_REG_INT_GLBL,
>         .mask_base              = MAX77650_REG_INTM_GLBL,
>         .type_in_mask           = true,
> -       .type_invert            = true,
>         .init_ack_masked        = true,
>         .clear_on_unmask        = true,
>  };
> --
> 2.38.1
>

Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Lee Jones Nov. 16, 2022, 5:54 p.m. UTC | #2

On Sat, 12 Nov 2022, Aidan MacDonald wrote:

> The type_invert flag does nothing when type_in_mask is set, and
> it's part of deprecated functionality in regmap-irq. Remove it.
> 
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
> ---
>  drivers/mfd/max77650.c | 1 -
>  1 file changed, 1 deletion(-)

Applied, thanks.

diff mbox series

Patch

diff --git a/drivers/mfd/max77650.c b/drivers/mfd/max77650.c
index 777485a33bc0..3c07fcdd9d07 100644
--- a/drivers/mfd/max77650.c
+++ b/drivers/mfd/max77650.c
@@ -138,7 +138,6 @@  static const struct regmap_irq_chip max77650_irq_chip = {
 	.status_base		= MAX77650_REG_INT_GLBL,
 	.mask_base		= MAX77650_REG_INTM_GLBL,
 	.type_in_mask		= true,
-	.type_invert		= true,
 	.init_ack_masked	= true,
 	.clear_on_unmask	= true,
 };