Message ID | 20221111113635.4603-1-matthias.bgg@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp688414wru; Fri, 11 Nov 2022 03:38:52 -0800 (PST) X-Google-Smtp-Source: AA0mqf4HaZ9Ze33RfC/1SWZUoVewmVCDstBuw5xsOlfD65n/3+9A4xBiE3RKK7ioZGMPCjQsu4Kd X-Received: by 2002:a05:6a00:1a43:b0:562:5f71:d188 with SMTP id h3-20020a056a001a4300b005625f71d188mr2250616pfv.57.1668166732154; Fri, 11 Nov 2022 03:38:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668166732; cv=none; d=google.com; s=arc-20160816; b=p+sV8JmF1iMu+GcXEwSnMbIMlifwZKePozXysrovDe2b6KHG56vDabJUtzIJ1NYH72 bstWud298tZFKrcCJTBM5srOjp7U/31IPq0BUjWS4WJcK5LsJN8lkQzT3/R4tdzPQTnT 70AvZyg7/F+LnQGXSBP1JYEYtoxBqcyFFvaY1c8g/xEqBI5BFUPJTCykwSGn9U9yE1MV 66y7AJLALgzpbI0QroH6jURSSt3I+61ZO/eGWDaCPZoQfCUI8abBL5eRfDOwmpT2WcuT UnBlX0F9tSn/bEi2FwQ7JCjgMui9JcUhmAHD0l6lzD03Famlj5Qxzusqegsitbzlh9MT 1BCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=oGe1JFiwJ6Jd5hSrZL+y1PN9+LD6dER03c2pB+GbJLg=; b=0I+Lyq3uSLjP4VTFwMJEJvNIg9x3wZGX4WUeWQTU88O2SxieHMhv3Nw+yOoq3oe8um QhIQq5Ii4SfhuZFaDX5WvJHPCkAYAae9zMp5UyNU22JWHW1NwhOj7C094MOTRr7gjQ5A Cso6lOb6NnoQ84V6K0sCfMSuttFR91k0uWhHO3Ml86LLHrT5PvO/ahmPJxtskTQaWIkT NSMw3qqzc2YiI1kP3VCmAuis+axBSJ3zRIGdpPB6Jjs1lnkw4OeaZKQkziP1rLarHyHq cSZJo5xDGQXH9xi4a7V2eVoq/PnvUfMdW2SPyMX4c6i+mpEbhv475SgNQCaldrewJbuj IVPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="aV9KCEk/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v189-20020a632fc6000000b0047009d37d4fsi2157638pgv.755.2022.11.11.03.38.38; Fri, 11 Nov 2022 03:38:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="aV9KCEk/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233695AbiKKLiW (ORCPT <rfc822;winker.wchi@gmail.com> + 99 others); Fri, 11 Nov 2022 06:38:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232506AbiKKLhx (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 11 Nov 2022 06:37:53 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12BD687B3D; Fri, 11 Nov 2022 03:36:47 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B64DBB82510; Fri, 11 Nov 2022 11:36:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87287C433D7; Fri, 11 Nov 2022 11:36:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668166604; bh=3RaDnZ53pbckdRhlNF7hOhtOnoJFCOeiN6Pj8MvQ8c8=; h=From:To:Cc:Subject:Date:From; b=aV9KCEk/eelSsOvQGNfpWwxqxT3sdtc53rs06VUfQu+lfvmnlyWUqyFEAgahVZeae xeOxJyMMD851iGKgUL80M8BYAmss+6Kec7H2z5c9nMtE5pQ+29cz2uk80tyw8FJ+q9 QJRGOFNNOdsl52L7H0d4wO0n9wpF6CTGJFL3VOKRRQAEzCkicmLHOF36Nbjn6Z6hgf HouWlXWFbPAmrD5OSEo/rwVkHg6j+ROQs5emKIlQ/woGHL/qZWbo8lWHru3URUUjXY WX9qCoP46xs3Klu3QP64ckH11cpsp3dN8rLniuLVy42S8Em2HwVdK0i466Uhd3ohjj FcPwfLOnOupcw== From: matthias.bgg@kernel.org To: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, frank-w@public-files.de Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Matthias Brugger <mbrugger@suse.com> Subject: [PATCH] arm64: dts: mediatek: mt7986: Add SoC compatible Date: Fri, 11 Nov 2022 12:36:35 +0100 Message-Id: <20221111113635.4603-1-matthias.bgg@kernel.org> X-Mailer: git-send-email 2.38.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749199599159134459?= X-GMAIL-MSGID: =?utf-8?q?1749199599159134459?= |
Series |
arm64: dts: mediatek: mt7986: Add SoC compatible
|
|
Commit Message
Matthias Brugger
Nov. 11, 2022, 11:36 a.m. UTC
From: Matthias Brugger <mbrugger@suse.com> Missing SoC compatible in the board file causes dt bindings check. Signed-off-by: Matthias Brugger <mbrugger@suse.com> --- arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts | 2 +- arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-)
Comments
Il 11/11/22 12:36, matthias.bgg@kernel.org ha scritto: > From: Matthias Brugger <mbrugger@suse.com> > > Missing SoC compatible in the board file causes dt bindings check. > > Signed-off-by: Matthias Brugger <mbrugger@suse.com> > --- > arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts | 2 +- > arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts > index afe37b702eef9..0e3b603159477 100644 > --- a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts > +++ b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts > @@ -9,7 +9,7 @@ > > / { > model = "MediaTek MT7986a RFB"; > - compatible = "mediatek,mt7986a-rfb"; > + compatible = "mediatek,mt7986a-rfb", "mediatek,mt7986a"; > > aliases { > serial0 = &uart0; > diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi > index 72e0d9722e07a..1191ecf345a7d 100644 > --- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi > @@ -14,6 +14,8 @@ / { > #address-cells = <2>; > #size-cells = <2>; > > + compatible = "mediatek,mt7986a"; > + It's DTS that shall declare the machine compatible and it's expected that they all declare their own, so please drop this one. Also, while at it, the same should happen with mt7986b-rfb.dts: can you fix that one too? compatible = "mediatek,mt7986b-rfb", "mediatek,mt7986b"; Cheers, Angelo
On 14/11/2022 12:02, AngeloGioacchino Del Regno wrote: > Il 11/11/22 12:36, matthias.bgg@kernel.org ha scritto: >> From: Matthias Brugger <mbrugger@suse.com> >> >> Missing SoC compatible in the board file causes dt bindings check. >> >> Signed-off-by: Matthias Brugger <mbrugger@suse.com> >> --- >> arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts | 2 +- >> arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 2 ++ >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts >> b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts >> index afe37b702eef9..0e3b603159477 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts >> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts >> @@ -9,7 +9,7 @@ >> / { >> model = "MediaTek MT7986a RFB"; >> - compatible = "mediatek,mt7986a-rfb"; >> + compatible = "mediatek,mt7986a-rfb", "mediatek,mt7986a"; >> aliases { >> serial0 = &uart0; >> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi >> b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi >> index 72e0d9722e07a..1191ecf345a7d 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi >> @@ -14,6 +14,8 @@ / { >> #address-cells = <2>; >> #size-cells = <2>; >> + compatible = "mediatek,mt7986a"; >> + > > It's DTS that shall declare the machine compatible and it's expected that they > all declare their own, so please drop this one. SoC compatible should have a the compatible for it's SoC. But for style reasons it should be the first of the block, I'll fix that. > > Also, while at it, the same should happen with mt7986b-rfb.dts: can you fix that > one too? > > compatible = "mediatek,mt7986b-rfb", "mediatek,mt7986b"; Will do. Thanks, Matthias > > Cheers, > Angelo > >
diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts index afe37b702eef9..0e3b603159477 100644 --- a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts +++ b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts @@ -9,7 +9,7 @@ / { model = "MediaTek MT7986a RFB"; - compatible = "mediatek,mt7986a-rfb"; + compatible = "mediatek,mt7986a-rfb", "mediatek,mt7986a"; aliases { serial0 = &uart0; diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi index 72e0d9722e07a..1191ecf345a7d 100644 --- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi @@ -14,6 +14,8 @@ / { #address-cells = <2>; #size-cells = <2>; + compatible = "mediatek,mt7986a"; + clk40m: oscillator@0 { compatible = "fixed-clock"; clock-frequency = <40000000>;