diff mbox series

firmware: stratix10-svc: Fix IS_ERR() vs NULL check in stratix10_svc_drv_probe()

Message ID 20221114025921.1194834-1-cuigaosheng1@huawei.com
State New
Headers
Series firmware: stratix10-svc: Fix IS_ERR() vs NULL check in stratix10_svc_drv_probe() |

Commit Message

Gaosheng Cui Nov. 14, 2022, 2:59 a.m. UTC 
  The svc_create_memory_pool() returns an ERR_PTR() on failure, we should use
IS_ERR() to check the return value, and return it on failure.

Fixes: 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 drivers/firmware/stratix10-svc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Greg KH Nov. 14, 2022, 7:24 a.m. UTC | #1 
On Mon, Nov 14, 2022 at 10:59:21AM +0800, Gaosheng Cui wrote:
> The svc_create_memory_pool() returns an ERR_PTR() on failure, we should use
> IS_ERR() to check the return value, and return it on failure.

How was this found and tested?

thanks,

greg k-h
Gaosheng Cui Nov. 14, 2022, 11:11 a.m. UTC | #2 
> How was this found and tested?

Thanks for taking time to review this patch.
I found this through the cocci script, I made the patch based on the code logic,
but I have not tested it due to the lack of hardware devices.

On 2022/11/14 15:24, Greg KH wrote:
> On Mon, Nov 14, 2022 at 10:59:21AM +0800, Gaosheng Cui wrote:
>> The svc_create_memory_pool() returns an ERR_PTR() on failure, we should use
>> IS_ERR() to check the return value, and return it on failure.
> How was this found and tested?
>
> thanks,
>
> greg k-h
> .
Greg KH Nov. 14, 2022, 11:33 a.m. UTC | #3 
On Mon, Nov 14, 2022 at 07:11:16PM +0800, cuigaosheng wrote:
> > How was this found and tested?
> 
> Thanks for taking time to review this patch.
> I found this through the cocci script, I made the patch based on the code logic,
> but I have not tested it due to the lack of hardware devices.

As per our documentation, you have to explain how stuff like this is
found and tested.

thanks,

greg k-h
diff mbox series

Patch

diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c
index b4081f4d88a3..64e430c6f14a 100644
--- a/drivers/firmware/stratix10-svc.c
+++ b/drivers/firmware/stratix10-svc.c
@@ -1133,8 +1133,8 @@  static int stratix10_svc_drv_probe(struct platform_device *pdev)
 		return ret;
 
 	genpool = svc_create_memory_pool(pdev, sh_memory);
-	if (!genpool)
-		return -ENOMEM;
+	if (IS_ERR(genpool))
+		return PTR_ERR(genpool);
 
 	/* allocate service controller and supporting channel */
 	controller = devm_kzalloc(dev, sizeof(*controller), GFP_KERNEL);