diff mbox series

arm64: dts: qcom: pm8150l: Add wled node

Message ID 20230913185514.21840-1-danila@jiaxyga.com
State New
Headers
Series arm64: dts: qcom: pm8150l: Add wled node |

Commit Message

Danila Tikhonov Sept. 13, 2023, 6:55 p.m. UTC 
  WLED is used for controlling the backlight on some boards, add the node
for it.

Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
---
 arch/arm64/boot/dts/qcom/pm8150l.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Konrad Dybcio Sept. 13, 2023, 7:31 p.m. UTC | #1 
On 13.09.2023 20:55, Danila Tikhonov wrote:
> WLED is used for controlling the backlight on some boards, add the node
> for it.
> 
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
> ---
>  arch/arm64/boot/dts/qcom/pm8150l.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pm8150l.dtsi b/arch/arm64/boot/dts/qcom/pm8150l.dtsi
> index b1686e5777b8..ac08a09c64c2 100644
> --- a/arch/arm64/boot/dts/qcom/pm8150l.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8150l.dtsi
> @@ -132,5 +132,15 @@ pm8150l_lpg: pwm {
>  			status = "disabled";
>  		};
>  
> +		pm8150l_wled: leds@d800 {
> +			compatible = "qcom,pm8150l-wled";
> +			reg = <0xd800>, <0xd900>;
> +			interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>,
> +				     <0x5 0xd8 0x2 IRQ_TYPE_EDGE_RISING>;
> +			interrupt-names = "ovp", "short";
Could somebody confirm the second irq? It looks sane when
checking out similar blocks on older gens, but I have no
reference to confirm it's there on this one.

Konrad
Bjorn Andersson Sept. 20, 2023, 4:42 p.m. UTC | #2 
On Wed, Sep 13, 2023 at 09:55:14PM +0300, Danila Tikhonov wrote:
> WLED is used for controlling the backlight on some boards, add the node
> for it.
> 
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>

Reviewed-by: Bjorn Andersson <andersson@kernel.org>

Regards,
Bjorn

> ---
>  arch/arm64/boot/dts/qcom/pm8150l.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pm8150l.dtsi b/arch/arm64/boot/dts/qcom/pm8150l.dtsi
> index b1686e5777b8..ac08a09c64c2 100644
> --- a/arch/arm64/boot/dts/qcom/pm8150l.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8150l.dtsi
> @@ -132,5 +132,15 @@ pm8150l_lpg: pwm {
>  			status = "disabled";
>  		};
>  
> +		pm8150l_wled: leds@d800 {
> +			compatible = "qcom,pm8150l-wled";
> +			reg = <0xd800>, <0xd900>;
> +			interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>,
> +				     <0x5 0xd8 0x2 IRQ_TYPE_EDGE_RISING>;
> +			interrupt-names = "ovp", "short";
> +			label = "backlight";
> +
> +			status = "disabled";
> +		};
>  	};
>  };
> -- 
> 2.41.0
>
Bjorn Andersson Sept. 20, 2023, 5:13 p.m. UTC | #3 
On Wed, 13 Sep 2023 21:55:14 +0300, Danila Tikhonov wrote:
> WLED is used for controlling the backlight on some boards, add the node
> for it.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: pm8150l: Add wled node
      commit: 4a94b52a47f63fb6db44871f446d31c28ca89bb9

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/pm8150l.dtsi b/arch/arm64/boot/dts/qcom/pm8150l.dtsi
index b1686e5777b8..ac08a09c64c2 100644
--- a/arch/arm64/boot/dts/qcom/pm8150l.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8150l.dtsi
@@ -132,5 +132,15 @@  pm8150l_lpg: pwm {
 			status = "disabled";
 		};
 
+		pm8150l_wled: leds@d800 {
+			compatible = "qcom,pm8150l-wled";
+			reg = <0xd800>, <0xd900>;
+			interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>,
+				     <0x5 0xd8 0x2 IRQ_TYPE_EDGE_RISING>;
+			interrupt-names = "ovp", "short";
+			label = "backlight";
+
+			status = "disabled";
+		};
 	};
 };