Message ID | 20230915200938.never.767-kees@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp1303495vqi; Fri, 15 Sep 2023 13:32:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFH24nQKMBEwpjmKMfb82R3XPSVTeUmSehKWT0J+3tNOIG4OK1EV+QdaFGYHA6/0ID1/Hld X-Received: by 2002:a05:6a20:5488:b0:14c:a2e1:65fd with SMTP id i8-20020a056a20548800b0014ca2e165fdmr3931221pzk.9.1694809925814; Fri, 15 Sep 2023 13:32:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694809925; cv=none; d=google.com; s=arc-20160816; b=dxKK29ps6NlxfOtFnwffnqINitw4HFV9aZlyvcgjr968C7dAUjrhwlg3FieRSVIh1f shfoWjWvf7c9iD4UfkXkOfy9gWV4NcZMyae44ETSXPdTcC9e5qLmPFIk4U3sPnpcX5Kz urGcBC/3YkyXmfqJINpGaR67D+N6FzCB35tJXSst0GvNSLxZDFQtJG1TF+3UVL2g057m BQvmXkmqJrwZUvUSBFSTanuTNRQhYxoYSZAt7sgXOg9O2Xs0psQaCzmrdumLkF5z21nU hzyvA+fsUTEPLpf61RvuvPBStu1o8QKCltKJ7tgSJm0zK+PGndG8Gyz8N2VO1Ttr3+ZO Fcsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=5ZHgORBBG6ssjw++gZqBRejLJi1rVlKpyOxRrxxQwRA=; fh=r+hzNCJNjZBhBnwT56Rr+FsW7xZvUmXrASgy00ukr78=; b=KkCAcYAz+88Aqc5nJh+tbkHm4UJtUHdlaCYbGcweIUItqYkpWtDVoqNDTYBCfRYg6D gyUZlCkovrWTJo3lbA3Qxs0p9QiYo2GwsWJZbk+7RxIyWDf0x+hAvbLSqqVmUwIRhCgk lRuVn/7IMCitw2fpFJUqgCOYc+Lo0FOltCWcgERNmw6c9CiROOeTHn+NI5o4lI0b68H4 cp4lW6G7o/nkewMNf5LYvJrGWQua5naLSxJGXo/LVgutO/C9HyZ+vQVOp0ncWSeaLMWj bBYbgLo9vwYvYy7uRY0vyvjEKPFMkj62qvheMB8ISzKyJASJi84LGpCzVzByQNA10EMi Astw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=V4zH5uYJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id bq10-20020a056a000e0a00b0068a4dcc9cdesi3799205pfb.7.2023.09.15.13.32.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 13:32:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=V4zH5uYJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 32BA580879D5; Fri, 15 Sep 2023 13:10:58 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237113AbjIOUKS (ORCPT <rfc822;realc9580@gmail.com> + 29 others); Fri, 15 Sep 2023 16:10:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237234AbjIOUKD (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 15 Sep 2023 16:10:03 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4595F268F for <linux-kernel@vger.kernel.org>; Fri, 15 Sep 2023 13:09:41 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1c3bd829b86so21719745ad.0 for <linux-kernel@vger.kernel.org>; Fri, 15 Sep 2023 13:09:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1694808581; x=1695413381; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5ZHgORBBG6ssjw++gZqBRejLJi1rVlKpyOxRrxxQwRA=; b=V4zH5uYJ96kqSRMThjodMF7n2sx5xlhQePBTTHhGPEiUThkzPe++8I/HQf1/nAFv3t 6YAtzsLWpbMguGsgKZ2j2X62zB/KLFQWsVX59hAYqTtiFmpXTcNrIfgSdRHrPPeWSYuj UXEpfuz4sXh9f2aPJOvdeAdwtabIVg6wrUkk0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694808581; x=1695413381; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5ZHgORBBG6ssjw++gZqBRejLJi1rVlKpyOxRrxxQwRA=; b=YwP+BQYh4tHZmDdLpgzD0a1GXA6+AJMzsKzjVAmPTqB3x2h3JrTUOHYFllrygQEE4B X0bqprjXOO7a6QzyvaDqpU5AaJS9L8Hef4towPgBjDSMqQP8sruA7vrwWK3qMnLzku1O yg8T72pKr+6xvSOdN+zu7GPoyJIPDVC3Mo5OTAHPjsxpscdg2RWmiSKPUTJVEC5cNsY3 53RIdSCVHAzuDbSOVtHpXz6FhC2s3J95WSBCtKpYRX5zBVhS/cARlRCDUNGOb4QjfveO /LmBqMr2c29399Te5aZ7Ln3IlmslZ8lJ9VOnslphh4hcUjbkxXnjd+onlxUENFYTNKgr Nd/A== X-Gm-Message-State: AOJu0Ywoj1yZ2m1f4KBGh2FIDmG7LOlou1SquT1/ycyTIMXDCGg+uQEl +jd3g4FEM+NzdRUuQ0lCytwceg== X-Received: by 2002:a17:902:e551:b0:1c3:2c2f:1132 with SMTP id n17-20020a170902e55100b001c32c2f1132mr3059174plf.54.1694808580799; Fri, 15 Sep 2023 13:09:40 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id bb6-20020a170902bc8600b001bba7aab822sm3860053plb.5.2023.09.15.13.09.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 13:09:40 -0700 (PDT) From: Kees Cook <keescook@chromium.org> To: Pavel Machek <pavel@ucw.cz> Cc: Kees Cook <keescook@chromium.org>, Lee Jones <lee@kernel.org>, linux-leds@vger.kernel.org, Nathan Chancellor <nathan@kernel.org>, Nick Desaulniers <ndesaulniers@google.com>, Tom Rix <trix@redhat.com>, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Subject: [PATCH] leds: aw200xx: Annotate struct aw200xx with __counted_by Date: Fri, 15 Sep 2023 13:09:39 -0700 Message-Id: <20230915200938.never.767-kees@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1179; i=keescook@chromium.org; h=from:subject:message-id; bh=oTHqicaprD+Vk+cbEHwEFzQOqlE3AUBeMdwhjiKKmQg=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBlBLoCDhkOw9PWaCCHnBnbp9dycdVACHvMghQmR riWUgKv+YSJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCZQS6AgAKCRCJcvTf3G3A JnqhEACGDVxaxu8dnzElwrmWNW2wxsx2VYR6mDGkTxfDwLy87LhrnBCTw0r+OXID3WbnJlVuK3m URWF8Pexx9n6ZWJ28D+roMmuQSKIbnlzBUQgQapCyAejg26D6GHYrECLX/heZnh7C8ZO6a/5hLP T1XjoIpoWJep2Am0zWpUfj/9YJGdBTAQ4acT+pKsTJ0J3Eqvv2TIkxCw+vL4SdT9zuR0M7p7v3J DlgC0p3Gr82v+Rg9Gr9EZ4b/VvNYsRW+oilQ35/nECjgoRqNf1IsDegl25knsYnERkmh9rwgq7y 5RpxOjujCD+CUbDecn+SOtzMjvtNU5p481WLZc630Y4ALfXfqS/QXaEDIHTtZsyB0qY1BpP4jmR RnxOKUDFgoRbdJVbGma7Vd24Nn/88w4f9wnHOGvKgjHP9jxYrfRNXTijklmDmfgGZNvGYLofPDR FMZ6ul2puwRMBMGHihDZ23vzxaCyC8i4mCnMDENsAezK31ZYewWGRL69iNeSP2yUP6qXouEP5Em 28Nv9SB3ehqFuS5G406AVpx/VzO0uFzSdSIfWWlTo5YGRPxT7e/1ikQJTqnFltPV5F+s85hXIoW G1k68CTTTnouYvEyUyyoc3WN6Xqas51qFn+8fjRH1JKhfmn4G4Lf5deBvGZH3wp0lYG09fYF3lG Y7Sdq1O rZG2uD2Q== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 15 Sep 2023 13:10:58 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777137012945865300 X-GMAIL-MSGID: 1777137012945865300 |
Series |
leds: aw200xx: Annotate struct aw200xx with __counted_by
|
|
Commit Message
Kees Cook
Sept. 15, 2023, 8:09 p.m. UTC
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).
As found with Coccinelle[1], add __counted_by for struct aw200xx.
[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Lee Jones <lee@kernel.org>
Cc: linux-leds@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/leds/leds-aw200xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 9/15/23 14:09, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct aw200xx. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Pavel Machek <pavel@ucw.cz> > Cc: Lee Jones <lee@kernel.org> > Cc: linux-leds@vger.kernel.org > Signed-off-by: Kees Cook <keescook@chromium.org> Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org> Thanks
On Fri, 15 Sep 2023 13:09:39 -0700, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct aw200xx. > > [...] Applied, thanks! [1/1] leds: aw200xx: Annotate struct aw200xx with __counted_by commit: e43d6b679091d196d9ac7664035155ed4c9637cc -- Lee Jones [李琼斯]
diff --git a/drivers/leds/leds-aw200xx.c b/drivers/leds/leds-aw200xx.c index 691a743cc9b0..4d517cace3e7 100644 --- a/drivers/leds/leds-aw200xx.c +++ b/drivers/leds/leds-aw200xx.c @@ -112,7 +112,7 @@ struct aw200xx { struct mutex mutex; u32 num_leds; u32 display_rows; - struct aw200xx_led leds[]; + struct aw200xx_led leds[] __counted_by(num_leds); }; static ssize_t dim_show(struct device *dev, struct device_attribute *devattr,