[v1,1/1] mfd: vexpress-sysreg: Fix resource compound literal assignments
Commit Message
Since DEFINE_RES_*() macros were converted to provide a compound literal
the user doesn't need to repeat it. Moreover, it may not be compiled.
Fixes: 9c973ce7f9cf ("resource: Convert DEFINE_RES_NAMED() to be compound literal")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
Should go via Greg's tree where ioport.h has been changed.
drivers/mfd/vexpress-sysreg.c | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)
Comments
On Sun, Nov 13, 2022 at 09:10:27PM +0200, Andy Shevchenko wrote:
> Since DEFINE_RES_*() macros were converted to provide a compound literal
> the user doesn't need to repeat it. Moreover, it may not be compiled.
>
> Fixes: 9c973ce7f9cf ("resource: Convert DEFINE_RES_NAMED() to be compound literal")
Wrong git id, I have no idea where that came from :(
I'll go fix this up...
greg k-h
On Mon, Nov 14, 2022 at 10:02:02AM +0100, Greg Kroah-Hartman wrote:
> On Sun, Nov 13, 2022 at 09:10:27PM +0200, Andy Shevchenko wrote:
> > Since DEFINE_RES_*() macros were converted to provide a compound literal
> > the user doesn't need to repeat it. Moreover, it may not be compiled.
> >
> > Fixes: 9c973ce7f9cf ("resource: Convert DEFINE_RES_NAMED() to be compound literal")
>
> Wrong git id, I have no idea where that came from :(
Pfhh... I think it's my local one since it was never in Linux Next and
I forgot to specify your branch explicitly.
> I'll go fix this up...
Thank you!
On Sun, Nov 13, 2022 at 09:10:27PM +0200, Andy Shevchenko wrote:
> Since DEFINE_RES_*() macros were converted to provide a compound literal
> the user doesn't need to repeat it. Moreover, it may not be compiled.
>
> Fixes: 9c973ce7f9cf ("resource: Convert DEFINE_RES_NAMED() to be compound literal")
> Reported-by: kernel test robot <lkp@intel.com>
If not too late,
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
On Sun, 13 Nov 2022, Andy Shevchenko wrote:
> Since DEFINE_RES_*() macros were converted to provide a compound literal
> the user doesn't need to repeat it. Moreover, it may not be compiled.
>
> Fixes: 9c973ce7f9cf ("resource: Convert DEFINE_RES_NAMED() to be compound literal")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>
> Should go via Greg's tree where ioport.h has been changed.
I'm fine with it if Greg is:
Acked-by: Lee Jones <lee@kernel.org>
> drivers/mfd/vexpress-sysreg.c | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
@@ -61,35 +61,27 @@ static struct mfd_cell vexpress_sysreg_cells[] = {
.name = "basic-mmio-gpio",
.of_compatible = "arm,vexpress-sysreg,sys_led",
.num_resources = 1,
- .resources = (struct resource []) {
- DEFINE_RES_MEM_NAMED(SYS_LED, 0x4, "dat"),
- },
+ .resources = &DEFINE_RES_MEM_NAMED(SYS_LED, 0x4, "dat"),
.platform_data = &vexpress_sysreg_sys_led_pdata,
.pdata_size = sizeof(vexpress_sysreg_sys_led_pdata),
}, {
.name = "basic-mmio-gpio",
.of_compatible = "arm,vexpress-sysreg,sys_mci",
.num_resources = 1,
- .resources = (struct resource []) {
- DEFINE_RES_MEM_NAMED(SYS_MCI, 0x4, "dat"),
- },
+ .resources = &DEFINE_RES_MEM_NAMED(SYS_MCI, 0x4, "dat"),
.platform_data = &vexpress_sysreg_sys_mci_pdata,
.pdata_size = sizeof(vexpress_sysreg_sys_mci_pdata),
}, {
.name = "basic-mmio-gpio",
.of_compatible = "arm,vexpress-sysreg,sys_flash",
.num_resources = 1,
- .resources = (struct resource []) {
- DEFINE_RES_MEM_NAMED(SYS_FLASH, 0x4, "dat"),
- },
+ .resources = &DEFINE_RES_MEM_NAMED(SYS_FLASH, 0x4, "dat"),
.platform_data = &vexpress_sysreg_sys_flash_pdata,
.pdata_size = sizeof(vexpress_sysreg_sys_flash_pdata),
}, {
.name = "vexpress-syscfg",
.num_resources = 1,
- .resources = (struct resource []) {
- DEFINE_RES_MEM(SYS_MISC, 0x4c),
- },
+ .resources = &DEFINE_RES_MEM(SYS_MISC, 0x4c),
}
};