Message ID | 20230915121504.806672-2-quic_srichara@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp1053184vqi; Fri, 15 Sep 2023 06:38:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHcp35/f5U4QIQjLxH8yxcKG2+p6UJX2gP/dF3no/lNgze0RAmpM/ftCeY2rILC/EN2aS1t X-Received: by 2002:a05:6a00:158e:b0:68f:bd37:13df with SMTP id u14-20020a056a00158e00b0068fbd3713dfmr2220337pfk.16.1694785114913; Fri, 15 Sep 2023 06:38:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694785114; cv=none; d=google.com; s=arc-20160816; b=K9IoG54j+n2Q2qe0SQ2AQ8wcP4Grr99nW6YR/H1xprIVgINQ90nehBINBwEl4RpDj8 N1AI0jkSCHRs4TEIgkP682tozhOhPrT22lRF4Fdocje5GmYs/8SPHjr+vmX1cMmxVPNq 6en07QIqky1YZ3LAwor6B18YB7wuwdvFLEkOtPVsquIV6lni8oXcEh275/pQL5O7NlXx BMFu4RRvIfospyeXNqwg+NGAjNePfk4RKJ0jJ9GSb8hpcvjG9KrkcaiDeBHvydGLc+GF NjrgtygHhrR82lMfLxoE1Q2Ma8TImFYGHe8J2+105B5UOU3+OkHqdR1MHz3SXcc8xpn+ ZICg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=goGu9DoFW5xZSxMHHa/hQ84rHqaVmllKSc2ih5rLSpk=; fh=dOaw2PqmxVZTDVHEgD0EK3XNKxFmRSJS3QIL+0LrAqw=; b=jnmY/OjzvbQfIuf18yobHgA/cbbg107cxk3X5dZMZLZRAC6G42omQ0k0gnV7aLW/6M SBOA2nxArHObmn33U4J9c15eEwIbI97EFlmqiEFYwfgn4v5FqxqS4gQC24bjNLX8LcGg qCdz/D7vLyqGz0KaKyiKE0guR++JqdYaQqzOu7Pew+H9QTQ6jZuVviy7APQH8EoCEsGb DZEfF4Bnt6stS2yS+EgYT51lKLruNMS3bbUs5BUvOhvy+ZIg3hscvkrf9JDytb7p2N/t afNOW4jpvzeNpGkQeiztja8XevUUrT7KvRzqOjiw/sf3oDCzWkvVEUNdjrum9WYz8vdV +AoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=cBQmKJdU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id o9-20020a62cd09000000b0068e446dd4e7si3237740pfg.0.2023.09.15.06.38.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 06:38:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=cBQmKJdU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 9E19B81EE2DF; Fri, 15 Sep 2023 05:16:17 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234693AbjIOMP7 (ORCPT <rfc822;ruipengqi7@gmail.com> + 32 others); Fri, 15 Sep 2023 08:15:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234652AbjIOMP5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 15 Sep 2023 08:15:57 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D129C2121; Fri, 15 Sep 2023 05:15:46 -0700 (PDT) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38FBNGQ9008957; Fri, 15 Sep 2023 12:15:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=qcppdkim1; bh=goGu9DoFW5xZSxMHHa/hQ84rHqaVmllKSc2ih5rLSpk=; b=cBQmKJdUXBucnf1iLRHJhn3oNRXG4Ef5rdPogWvEagaDRo+4cjBcy7URDDuzEuPgtxqY SI970Bnbh4uTYkKvcpWWTu3titEaKyZkxUeyp3HIEUcM3rd+7ZUK7KlMRuBbzXp9xGpD 23gk5vOVTP4JoKjSqWPmcp7GehCcmukcE/U/G1kL1ejtrCnrbG4oJoRbJFekYYZcaNoK KaZY80Feu+rkdFdj1tiJWjTxkYAPf4skhHlwu2laJ6ncMAYMNvesR+jvso00ZBx3GHAu XuKmB8zFeipKE6pGXCSGu3MfoabkAvW9CM76iPdtpyLWPr6A0SSzV2EQSraVCHVAYbaX Ng== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t4g5tgvw4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Sep 2023 12:15:42 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38FCFfYN004513 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Sep 2023 12:15:41 GMT Received: from win-platform-upstream01.qualcomm.com (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Fri, 15 Sep 2023 05:15:36 -0700 From: Sricharan Ramabadhran <quic_srichara@quicinc.com> To: <krzysztof.kozlowski@linaro.org>, <agross@kernel.org>, <andersson@kernel.org>, <konrad.dybcio@linaro.org>, <srinivas.kandagatla@linaro.org>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>, <thara.gopinath@gmail.com>, <rafael@kernel.org>, <daniel.lezcano@linaro.org>, <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>, <dmitry.baryshkov@linaro.org>, <quic_srichara@quicinc.com> Subject: [PATCH V2 1/4] dt-bindings: thermal: qcom-tsens: Add ipq5018 compatible Date: Fri, 15 Sep 2023 17:45:01 +0530 Message-ID: <20230915121504.806672-2-quic_srichara@quicinc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230915121504.806672-1-quic_srichara@quicinc.com> References: <20230915121504.806672-1-quic_srichara@quicinc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: DSOgm1WqeqO2yL4oojFvakGOBfDssPkv X-Proofpoint-GUID: DSOgm1WqeqO2yL4oojFvakGOBfDssPkv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-15_08,2023-09-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 mlxlogscore=873 priorityscore=1501 adultscore=0 mlxscore=0 spamscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309150108 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 15 Sep 2023 05:16:17 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777110996357550346 X-GMAIL-MSGID: 1777110996357550346 |
Series |
Add support for IPQ5018 tsens
|
|
Commit Message
Sricharan Ramabadhran
Sept. 15, 2023, 12:15 p.m. UTC
IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt.
Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
---
[v2] Sorted the compatible and removed example
Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
1 file changed, 1 insertion(+)
Comments
On 15/09/2023 14:15, Sricharan Ramabadhran wrote: > IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt. > > Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> > --- > [v2] Sorted the compatible and removed example > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 15/09/2023 14:43, Krzysztof Kozlowski wrote: > On 15/09/2023 14:15, Sricharan Ramabadhran wrote: >> IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt. >> >> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> >> --- >> [v2] Sorted the compatible and removed example >> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> No, unreviewed. Your driver says it is not compatible with qcom,tsens-v1. This does not look right :/ Best regards, Krzysztof
On 9/15/2023 6:15 PM, Krzysztof Kozlowski wrote: > On 15/09/2023 14:43, Krzysztof Kozlowski wrote: >> On 15/09/2023 14:15, Sricharan Ramabadhran wrote: >>> IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt. >>> >>> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> >>> --- >>> [v2] Sorted the compatible and removed example >>> >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > No, unreviewed. Your driver says it is not compatible with > qcom,tsens-v1. This does not look right :/ > Yes it is V1 IP, but since there is no RPM, to enable the IP/SENSORS have to do those steps after calling init_common. Similar reason added a new feat as well in patch #2 as well. Hence for this, new compatible was required. Regards, Sricharan
On 19/09/2023 09:22, Sricharan Ramabadhran wrote: > > > On 9/15/2023 6:15 PM, Krzysztof Kozlowski wrote: >> On 15/09/2023 14:43, Krzysztof Kozlowski wrote: >>> On 15/09/2023 14:15, Sricharan Ramabadhran wrote: >>>> IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt. >>>> >>>> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> >>>> --- >>>> [v2] Sorted the compatible and removed example >>>> >>> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> No, unreviewed. Your driver says it is not compatible with >> qcom,tsens-v1. This does not look right :/ >> > > Yes it is V1 IP, but since there is no RPM, to enable the IP/SENSORS > have to do those steps after calling init_common. Similar reason > added a new feat as well in patch #2 as well. Hence for this, > new compatible was required. I dud not write about new or old compatible ("compatible" as noun). I wrote that it is not compatible ("compatible" as adjective) with v1. Best regards, Krzysztof
On 9/19/2023 6:02 PM, Krzysztof Kozlowski wrote: > On 19/09/2023 09:22, Sricharan Ramabadhran wrote: >> >> >> On 9/15/2023 6:15 PM, Krzysztof Kozlowski wrote: >>> On 15/09/2023 14:43, Krzysztof Kozlowski wrote: >>>> On 15/09/2023 14:15, Sricharan Ramabadhran wrote: >>>>> IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt. >>>>> >>>>> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> >>>>> --- >>>>> [v2] Sorted the compatible and removed example >>>>> >>>> >>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> >>> No, unreviewed. Your driver says it is not compatible with >>> qcom,tsens-v1. This does not look right :/ >>> >> >> Yes it is V1 IP, but since there is no RPM, to enable the IP/SENSORS >> have to do those steps after calling init_common. Similar reason >> added a new feat as well in patch #2 as well. Hence for this, >> new compatible was required. > > I dud not write about new or old compatible ("compatible" as noun). I > wrote that it is not compatible ("compatible" as adjective) with v1. > Ho, in that case, yes it is not compatible with V1 init and features because of 'no rpm'. So in that case, should this be documented as a separate version of 'V1 without rpm' ? Regards, Sricharan
On 19/09/2023 14:48, Sricharan Ramabadhran wrote: > > > On 9/19/2023 6:02 PM, Krzysztof Kozlowski wrote: >> On 19/09/2023 09:22, Sricharan Ramabadhran wrote: >>> >>> >>> On 9/15/2023 6:15 PM, Krzysztof Kozlowski wrote: >>>> On 15/09/2023 14:43, Krzysztof Kozlowski wrote: >>>>> On 15/09/2023 14:15, Sricharan Ramabadhran wrote: >>>>>> IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt. >>>>>> >>>>>> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> >>>>>> --- >>>>>> [v2] Sorted the compatible and removed example >>>>>> >>>>> >>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> >>>> No, unreviewed. Your driver says it is not compatible with >>>> qcom,tsens-v1. This does not look right :/ >>>> >>> >>> Yes it is V1 IP, but since there is no RPM, to enable the IP/SENSORS >>> have to do those steps after calling init_common. Similar reason >>> added a new feat as well in patch #2 as well. Hence for this, >>> new compatible was required. >> >> I dud not write about new or old compatible ("compatible" as noun). I >> wrote that it is not compatible ("compatible" as adjective) with v1. >> > > Ho, in that case, yes it is not compatible with V1 init and features > because of 'no rpm'. So in that case, should this be documented > as a separate version of 'V1 without rpm' ? It should not be mixed with regular v1, just as new entry there. I don't think fallback is needed - just use SoC specific compatible. Best regards, Krzysztof
On 9/19/2023 6:26 PM, Krzysztof Kozlowski wrote: > On 19/09/2023 14:48, Sricharan Ramabadhran wrote: >> >> >> On 9/19/2023 6:02 PM, Krzysztof Kozlowski wrote: >>> On 19/09/2023 09:22, Sricharan Ramabadhran wrote: >>>> >>>> >>>> On 9/15/2023 6:15 PM, Krzysztof Kozlowski wrote: >>>>> On 15/09/2023 14:43, Krzysztof Kozlowski wrote: >>>>>> On 15/09/2023 14:15, Sricharan Ramabadhran wrote: >>>>>>> IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt. >>>>>>> >>>>>>> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> >>>>>>> --- >>>>>>> [v2] Sorted the compatible and removed example >>>>>>> >>>>>> >>>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>>> >>>>> No, unreviewed. Your driver says it is not compatible with >>>>> qcom,tsens-v1. This does not look right :/ >>>>> >>>> >>>> Yes it is V1 IP, but since there is no RPM, to enable the IP/SENSORS >>>> have to do those steps after calling init_common. Similar reason >>>> added a new feat as well in patch #2 as well. Hence for this, >>>> new compatible was required. >>> >>> I dud not write about new or old compatible ("compatible" as noun). I >>> wrote that it is not compatible ("compatible" as adjective) with v1. >>> >> >> Ho, in that case, yes it is not compatible with V1 init and features >> because of 'no rpm'. So in that case, should this be documented >> as a separate version of 'V1 without rpm' ? > > It should not be mixed with regular v1, just as new entry there. I don't > think fallback is needed - just use SoC specific compatible. > ok, sure, will add in V3. Regards, Sricharan
diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml index 27e9e16e6455..c9586b2fbba4 100644 --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml @@ -39,6 +39,7 @@ properties: - description: v1 of TSENS items: - enum: + - qcom,ipq5018-tsens - qcom,msm8956-tsens - qcom,msm8976-tsens - qcom,qcs404-tsens