Message ID | 20230916001026.315-14-quic_wcheng@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp1450948vqi; Fri, 15 Sep 2023 20:08:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGv9XG5S9LPrMJ+wWzlw0bJJiPHHo81SjxBOAiKT7YSu2fDL6P5lEtK0EwQyV8EWjptToEb X-Received: by 2002:a05:6e02:128c:b0:34d:ee49:5114 with SMTP id y12-20020a056e02128c00b0034dee495114mr4276127ilq.23.1694833735791; Fri, 15 Sep 2023 20:08:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694833735; cv=none; d=google.com; s=arc-20160816; b=XUgqDdJ0LSQErbCe9FGtaPX/wudjiJDP+RYqJFy3lZQovzSHdrkqZ9k5jZEjT5BoT2 Ux6kDODRY8orB116+FX4rh7f1vkkG1At9HLGQYwM78vM00bS2drcVcagIbYZFyGY3Zza 07WzaEKcVckgsp16OFTTqE9t1O5MIe9KBAvgTPcMkekOlw2IESwjE+abeFpOflE2pklx SnghcjKCphCOxu45U2WfgFlroUj4F34OU37xsi79Gmmkv4NqPuU2aQ7yyOkraIbqgpsG P1Edd+8R0gR4SJ+WU0jKbOUVIS4JsQLWgGPHSDs8tejkEVrsLLn3fCuQKFf4L781BWb5 Dz6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=OQF7b9QgtG+XrfHB8YoGl3d3bHwtNZWp9D0tklgpySQ=; fh=MhCCCRx4c0AeUz43uLzZOKA4YzcBN2mk3tAWrRRVvW4=; b=vSqt9dq3fZPlJfLpuPmCvBVkPG7Dwsbk8nAIYRxNI62eJFlcztbJpeLwR15iVnR0v4 IvlKp9e3LTXY/B6UPMOCI6c778hzSSxbAURLIfctiL1IS8bkg7bHdf7i6v0BKUB1Exm+ 3XrcYkt4FvWG4yq1lOGE1BAsW0DQLhfkm+ceQD0RyliSrYTn3oipgPqiiL0lKZ0Yz7Oz 52OB4fMUyZIYlSK+OjC/fj9PUgoXLKOiFXKozlr0wLil9r0HQBbV9kk3PeZj2392BOz6 1Zd92INbNYNGNY16T3o5vUV2mYkUUq12mQvrT74evb12CnbmVNbmCQkyma0jyF/W/Qfs 5GAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=C39GUhqI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id ot2-20020a17090b3b4200b00274caaa057asi34052pjb.42.2023.09.15.20.08.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 20:08:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=C39GUhqI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 9A2EA83F533B; Fri, 15 Sep 2023 17:16:20 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238561AbjIPAMk (ORCPT <rfc822;realc9580@gmail.com> + 28 others); Fri, 15 Sep 2023 20:12:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238357AbjIPAL5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 15 Sep 2023 20:11:57 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73A16FB; Fri, 15 Sep 2023 17:11:45 -0700 (PDT) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38FNda4I006912; Sat, 16 Sep 2023 00:11:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=OQF7b9QgtG+XrfHB8YoGl3d3bHwtNZWp9D0tklgpySQ=; b=C39GUhqIpuznfP4Ft8skmtYvaq84YKKN1CCjS/hg8vfzgKv+/OUvqQosaSb18DOE/G5h w3tYXOo247lEv2p9A+fhD3i6qKw8zvdb2Fm0TFIPlCZkrHmvBA0L8FbIEwqU8VkbVZ1s KPf71GfLTNaHufjpH7uegdLopokYP4Kaeo0ePTQkfdNIX/dGyxwy3HwXunf+0Un0h5mX GqD0BgJ3OOvwwrWEVC4xuOCPccC7QuDjVBfKhIUljkR/v9SJDuEy7b8Fi0LWEYm6pY7m qLblwt8SNDEp2ymiXxw+EXUd6eC63A1rbzBF75p9BJ6w/7/9n4IPa/ZNrFGdQLnojBJP Uw== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t4g3gtd2b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 16 Sep 2023 00:11:08 +0000 Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38G0Aesh017084 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 16 Sep 2023 00:10:40 GMT Received: from hu-wcheng-lv.qualcomm.com (10.49.16.6) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Fri, 15 Sep 2023 17:10:40 -0700 From: Wesley Cheng <quic_wcheng@quicinc.com> To: <mathias.nyman@intel.com>, <gregkh@linuxfoundation.org>, <lgirdwood@gmail.com>, <broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>, <agross@kernel.org>, <andersson@kernel.org>, <konrad.dybcio@linaro.org>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>, <srinivas.kandagatla@linaro.org>, <bgoswami@quicinc.com>, <Thinh.Nguyen@synopsys.com> CC: <linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>, <alsa-devel@alsa-project.org>, <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>, Wesley Cheng <quic_wcheng@quicinc.com> Subject: [PATCH v6 13/33] dt-bindings: usb: dwc3: Add snps,num-hc-interrupters definition Date: Fri, 15 Sep 2023 17:10:06 -0700 Message-ID: <20230916001026.315-14-quic_wcheng@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230916001026.315-1-quic_wcheng@quicinc.com> References: <20230916001026.315-1-quic_wcheng@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: pVRhkiqFf_x8VfqIQROL1ZjZugVHdleF X-Proofpoint-ORIG-GUID: pVRhkiqFf_x8VfqIQROL1ZjZugVHdleF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-15_20,2023-09-15_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 mlxlogscore=733 phishscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 mlxscore=0 malwarescore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309160000 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 15 Sep 2023 17:16:20 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777156763974273159 X-GMAIL-MSGID: 1777161979710959007 |
Series |
Introduce QC USB SND audio offloading support
|
|
Commit Message
Wesley Cheng
Sept. 16, 2023, 12:10 a.m. UTC
Add a new definition for specifying how many XHCI secondary interrupters
can be allocated. XHCI in general can potentially support up to 1024
interrupters, which some uses may want to limit depending on how many
users utilize the interrupters.
Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
---
.../devicetree/bindings/usb/snps,dwc3.yaml | 13 +++++++++++++
1 file changed, 13 insertions(+)
Comments
On 16.09.2023 02:10, Wesley Cheng wrote: > Add a new definition for specifying how many XHCI secondary interrupters > can be allocated. XHCI in general can potentially support up to 1024 > interrupters, which some uses may want to limit depending on how many > users utilize the interrupters. > > Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com> > --- Any reason for a DWC3-specific property? Why not just use the XHCI-common one from patch 14 and error out if a value of more than 8 is found? Konrad
On Fri, Sep 15, 2023 at 05:43:45PM -0700, Wesley Cheng wrote: > Hi Konrad, > > On 9/15/2023 5:35 PM, Konrad Dybcio wrote: > > On 16.09.2023 02:10, Wesley Cheng wrote: > > > Add a new definition for specifying how many XHCI secondary interrupters > > > can be allocated. XHCI in general can potentially support up to 1024 > > > interrupters, which some uses may want to limit depending on how many > > > users utilize the interrupters. > > > > > > Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com> > > > --- > > Any reason for a DWC3-specific property? Why not just > > use the XHCI-common one from patch 14 and error out if > > a value of more than 8 is found? > > I'm pretty sure I said use the common one already... > > Not every XHCI plat user is going to be DWC3. In case DWC3 is used, the > DWC3 host driver is the one that populates and adds the XHCI plat device (no > separate device node for XHCI), so that requires the DWC3 host to also > populate properties for the XHCI device. (dwc3_host_init()) This binding references usb-xhci.yaml already, so any property from there is allowed. Linux needs to handle that regardless of what the driver structure/division looks like. Rob
Hi Rob, On 9/18/2023 1:19 PM, Rob Herring wrote: > On Fri, Sep 15, 2023 at 05:43:45PM -0700, Wesley Cheng wrote: >> Hi Konrad, >> >> On 9/15/2023 5:35 PM, Konrad Dybcio wrote: >>> On 16.09.2023 02:10, Wesley Cheng wrote: >>>> Add a new definition for specifying how many XHCI secondary interrupters >>>> can be allocated. XHCI in general can potentially support up to 1024 >>>> interrupters, which some uses may want to limit depending on how many >>>> users utilize the interrupters. >>>> >>>> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com> >>>> --- >>> Any reason for a DWC3-specific property? Why not just >>> use the XHCI-common one from patch 14 and error out if >>> a value of more than 8 is found? >>> > > I'm pretty sure I said use the common one already... > Yes, you mentioned that in the last rev. >> >> Not every XHCI plat user is going to be DWC3. In case DWC3 is used, the >> DWC3 host driver is the one that populates and adds the XHCI plat device (no >> separate device node for XHCI), so that requires the DWC3 host to also >> populate properties for the XHCI device. (dwc3_host_init()) > > This binding references usb-xhci.yaml already, so any property from > there is allowed. Linux needs to handle that regardless of what the > driver structure/division looks like. > Ok, understood. I will remove the need to have another DWC3 property and just use the XHCI one directly. Checks are already in place in the DWC3 parser to limit the interrupters if it exceeds 8. Thanks Wesley Cheng
diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml index a696f23730d3..596762ef9b9f 100644 --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml @@ -376,6 +376,19 @@ properties: items: enum: [1, 4, 8, 16, 32, 64, 128, 256] + snps,num-hc-interrupters: + description: + Defines the maximum number of XHCI host controller interrupters that can + be supported. The XHCI host controller has support to allocate multiple + event rings, which can be assigned to different clients/users. The DWC3 + controller has a maximum of 8 interrupters. If this is not defined then + the value will be defaulted to 1. This parameter is used only when + operating in host mode. + $ref: /schemas/types.yaml#/definitions/uint8 + minimum: 1 + maximum: 8 + default: 1 + port: $ref: /schemas/graph.yaml#/properties/port description: