diff mbox series

Add debug functions for REAL_VALUE_TYPE.

Message ID 20220922164752.2566043-1-aldyh@redhat.com
State Accepted, archived
Headers
Series Add debug functions for REAL_VALUE_TYPE. |

Checks

Context Check Description
snail/gcc-patches-check success Github commit url

Commit Message

Aldy Hernandez Sept. 22, 2022, 4:47 p.m. UTC 
  We currently have no way of dumping REAL_VALUE_TYPEs when debugging.

Tested on a gdb session examining the real value 10.0:

(gdb) p min
$9 = {cl = 1, decimal = 0, sign = 0, signalling = 0, canonical = 0, uexp = 4, sig = {0, 0, 11529215046068469760}}
(gdb) p debug (min)
0x0.ap+4

OK for trunk?

gcc/ChangeLog:

	* real.cc (debug): New.
---
 gcc/real.cc | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

Comments

Richard Biener Sept. 23, 2022, 6:54 a.m. UTC | #1 
On Thu, Sep 22, 2022 at 6:48 PM Aldy Hernandez via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> We currently have no way of dumping REAL_VALUE_TYPEs when debugging.
>
> Tested on a gdb session examining the real value 10.0:
>
> (gdb) p min
> $9 = {cl = 1, decimal = 0, sign = 0, signalling = 0, canonical = 0, uexp = 4, sig = {0, 0, 11529215046068469760}}
> (gdb) p debug (min)
> 0x0.ap+4
>
> OK for trunk?

I'd say the reference taking variant is enough (just remember to do
debug (*val)),
but OK (maybe simplify the pointer variant by forwarding instead of duplicating)

Richard.

>
> gcc/ChangeLog:
>
>         * real.cc (debug): New.
> ---
>  gcc/real.cc | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/gcc/real.cc b/gcc/real.cc
> index 73bbac645d9..a31b256a47b 100644
> --- a/gcc/real.cc
> +++ b/gcc/real.cc
> @@ -1900,6 +1900,22 @@ real_to_decimal (char *str, const REAL_VALUE_TYPE *r_orig, size_t buf_size,
>                             digits, crop_trailing_zeros, VOIDmode);
>  }
>
> +DEBUG_FUNCTION void
> +debug (const REAL_VALUE_TYPE *r)
> +{
> +  char s[60];
> +  real_to_hexadecimal (s, r, sizeof (s), 0, 1);
> +  fprintf (stderr, "%s\n", s);
> +}
> +
> +DEBUG_FUNCTION void
> +debug (const REAL_VALUE_TYPE &r)
> +{
> +  char s[60];
> +  real_to_hexadecimal (s, &r, sizeof (s), 0, 1);
> +  fprintf (stderr, "%s\n", s);
> +}
> +
>  /* Render R as a hexadecimal floating point constant.  Emit DIGITS
>     significant digits in the result, bounded by BUF_SIZE.  If DIGITS is 0,
>     choose the maximum for the representation.  If CROP_TRAILING_ZEROS,
> --
> 2.37.1
>
Aldy Hernandez Sept. 23, 2022, 7:01 a.m. UTC | #2 
On Fri, Sep 23, 2022 at 8:54 AM Richard Biener
<richard.guenther@gmail.com> wrote:
>
> On Thu, Sep 22, 2022 at 6:48 PM Aldy Hernandez via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
> >
> > We currently have no way of dumping REAL_VALUE_TYPEs when debugging.
> >
> > Tested on a gdb session examining the real value 10.0:
> >
> > (gdb) p min
> > $9 = {cl = 1, decimal = 0, sign = 0, signalling = 0, canonical = 0, uexp = 4, sig = {0, 0, 11529215046068469760}}
> > (gdb) p debug (min)
> > 0x0.ap+4
> >
> > OK for trunk?
>
> I'd say the reference taking variant is enough (just remember to do
> debug (*val)),

I added the pointer one because all of real.cc takes pointers
argument, but yeah...let's just nuke the pointer variant.  I hate that
we have various variants in VRP (my fault).

Thanks.
Aldy

> but OK (maybe simplify the pointer variant by forwarding instead of duplicating)
>
> Richard.
>
> >
> > gcc/ChangeLog:
> >
> >         * real.cc (debug): New.
> > ---
> >  gcc/real.cc | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/gcc/real.cc b/gcc/real.cc
> > index 73bbac645d9..a31b256a47b 100644
> > --- a/gcc/real.cc
> > +++ b/gcc/real.cc
> > @@ -1900,6 +1900,22 @@ real_to_decimal (char *str, const REAL_VALUE_TYPE *r_orig, size_t buf_size,
> >                             digits, crop_trailing_zeros, VOIDmode);
> >  }
> >
> > +DEBUG_FUNCTION void
> > +debug (const REAL_VALUE_TYPE *r)
> > +{
> > +  char s[60];
> > +  real_to_hexadecimal (s, r, sizeof (s), 0, 1);
> > +  fprintf (stderr, "%s\n", s);
> > +}
> > +
> > +DEBUG_FUNCTION void
> > +debug (const REAL_VALUE_TYPE &r)
> > +{
> > +  char s[60];
> > +  real_to_hexadecimal (s, &r, sizeof (s), 0, 1);
> > +  fprintf (stderr, "%s\n", s);
> > +}
> > +
> >  /* Render R as a hexadecimal floating point constant.  Emit DIGITS
> >     significant digits in the result, bounded by BUF_SIZE.  If DIGITS is 0,
> >     choose the maximum for the representation.  If CROP_TRAILING_ZEROS,
> > --
> > 2.37.1
> >
>
diff mbox series

Patch

diff --git a/gcc/real.cc b/gcc/real.cc
index 73bbac645d9..a31b256a47b 100644
--- a/gcc/real.cc
+++ b/gcc/real.cc
@@ -1900,6 +1900,22 @@  real_to_decimal (char *str, const REAL_VALUE_TYPE *r_orig, size_t buf_size,
 			    digits, crop_trailing_zeros, VOIDmode);
 }
 
+DEBUG_FUNCTION void
+debug (const REAL_VALUE_TYPE *r)
+{
+  char s[60];
+  real_to_hexadecimal (s, r, sizeof (s), 0, 1);
+  fprintf (stderr, "%s\n", s);
+}
+
+DEBUG_FUNCTION void
+debug (const REAL_VALUE_TYPE &r)
+{
+  char s[60];
+  real_to_hexadecimal (s, &r, sizeof (s), 0, 1);
+  fprintf (stderr, "%s\n", s);
+}
+
 /* Render R as a hexadecimal floating point constant.  Emit DIGITS
    significant digits in the result, bounded by BUF_SIZE.  If DIGITS is 0,
    choose the maximum for the representation.  If CROP_TRAILING_ZEROS,