Message ID | 20230914-vf610-gpio-v1-3-3ed418182a6a@nxp.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp125560vqi; Wed, 13 Sep 2023 22:28:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEEETe0EdYa4nvTnMWIGpIrEQBewz77tuvtEGgby0DedO+JanZ5C/qykoRRvyOAbO9Jidd2 X-Received: by 2002:a05:6a00:a90:b0:68a:4261:ab7f with SMTP id b16-20020a056a000a9000b0068a4261ab7fmr4806618pfl.31.1694669325916; Wed, 13 Sep 2023 22:28:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1694669325; cv=pass; d=google.com; s=arc-20160816; b=CrZZpYC/F3nTPHVR4ShApRAtUNKDzh0S9YPlbvRPvvywd4rV+imohAXsNnXJKFLypE /mXUPhPZnn0Vo8IaOtUmqu4UwryXaUusNpHldGGKv4yU7BVwfsF8H7MyDlvbeYa1+/qz OL4YRKU5qZKCHws17C6MYBxJnCC0eVymes6sxSZEEmUA77bOznJ7oP+t5X77OV1EoyVd IcbuIfRsMr+ftd+ydcDcRQgh8zqpDeD29k6OVdSo0Bkz/K/XtrtNJbTPQRL07rS0KOPg gQjnEX69l0+yo06E0ExZAMFR4hzRU7HlRq81Zol7Qcah/Fnb1+a0JZXItGq7JGhL3DjS Z03A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:cc:to:in-reply-to:references :message-id:content-transfer-encoding:subject:date:from :dkim-signature; bh=LOpglW9aCtWKW6qK8GvD0WlBW8UF3DcX8iYwwH+kxSY=; fh=COwI5EyG1DB6D28RaDWbFhDRTTyfVICzJ11TjDY7TVE=; b=RNPqxfWqCFqcPHLYFEtF8TLKn1ivoqARunTicJuWxmsOuWuNQ/p+1X4AZbQ7VCPflN te31nNU8tFVsfGCj1W2/6y416pV4IU1v3aMWapjj5AKJ7BtKxUlL2N511vKSNB3ojViA 1JOjF6OqtMwRGKoKYLvIrE1f/uGDzK9mYmm3O2710B28SZot2zjtK/mInQ39oD/hUwWf tEo/TqrYIzcN1C7BFuidxyCfWyVILcp0saYUqohRYynpkECmPrW7pnLjl2mroJMp85Jp MKUT+RMLeQ7juAWCgklBYBB1K9+p5Lmkdja6oCGYAx9ZQCkTVc/cCe/mofGhRASius8q AVFw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@NXP1.onmicrosoft.com header.s=selector2-NXP1-onmicrosoft-com header.b=SWw9dbOz; arc=pass (i=1 spf=pass spfdomain=oss.nxp.com dkim=pass dkdomain=oss.nxp.com dmarc=pass fromdomain=oss.nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id u26-20020a056a00099a00b0068a85532963si906790pfg.160.2023.09.13.22.28.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 22:28:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@NXP1.onmicrosoft.com header.s=selector2-NXP1-onmicrosoft-com header.b=SWw9dbOz; arc=pass (i=1 spf=pass spfdomain=oss.nxp.com dkim=pass dkdomain=oss.nxp.com dmarc=pass fromdomain=oss.nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id B846081ECCE4; Wed, 13 Sep 2023 19:17:31 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234298AbjINCQ7 (ORCPT <rfc822;chrisfriedt@gmail.com> + 35 others); Wed, 13 Sep 2023 22:16:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233828AbjINCQv (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 13 Sep 2023 22:16:51 -0400 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2074.outbound.protection.outlook.com [40.107.20.74]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44AD51FCE; Wed, 13 Sep 2023 19:16:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hsuzl+PUm5GS/Vs2c9GyDpt32FrPZ8L2HjvsjRsH86OM+hA0c0oLVco/y8Tvvb+Kd03pm8XJBSkj1SqcRky+lEhKD7IrKa54lMsGcSlt+l+6EVpq7KZ4UKKnSW88R9mBdPZm0TndyTMBpcoFSWu7d80J0a0QFFGeZ6kU/vu3ANbeV/6eBMqgEzlVhOm6LYSd9d5tJQv1btHpMXIg3Cnhqj6lAqACzGpDvetq1qshmzN8Xb+WpiqZ9thr9jcoeWezJkPIf2bvd/RAHL5GWgqUHeGv9tXxwjzzQH+ezHME4M8XOkymrwwVw1FNb5cWRKi9J4c4zloV4uvzMJCEwq2pOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LOpglW9aCtWKW6qK8GvD0WlBW8UF3DcX8iYwwH+kxSY=; b=LEoi6AaCZwyGSrzoCmEAq8fGLFYtMIHltLqANWyvMjsevKQZJRn8Y4FseOpdLm7NFuh4lOZVAALGGnc2grmxnTtvKHbS1ij5UAYe1kfGcWBtzf8KqKr0a6kPWR8vWRmX4trHMwFGTQ42BQBxRjxCPoEoD+9HcC1UuYMgTUQOqb7JOeYODOrWF1NWnmYdDYLF9Zh12p+SWaSaZkgJOYtwM01TlTlUE040HKNggdh3GRFmHITfUHihkGsmEOnD11YYwTTfaHu8Q9zz3v48p2sqD5hrUR8x8qT4tfJt9DMwBRyfYqHBZNr7S4j1HmxOkAZH7v3RKRi0kzlq0lYK7nBRTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LOpglW9aCtWKW6qK8GvD0WlBW8UF3DcX8iYwwH+kxSY=; b=SWw9dbOzGx2x5oNtC7D1GrQ2jhmfKfUarSCSG9p9ACR9ScaA/gs8m8DvIxZZPWnr4lVKxqkp5A0R+HSJYBcsdkR4U7hG9Of2CofThA4uJtYxdSDgqnELl8mADpXGXZdPS1vQEYVZM41GAti1emQfSQ14cwCqMO3K+3MnM5il+E0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PR3PR04MB7257.eurprd04.prod.outlook.com (2603:10a6:102:93::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.20; Thu, 14 Sep 2023 02:16:41 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::2b3:d8de:95c8:b28b]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::2b3:d8de:95c8:b28b%3]) with mapi id 15.20.6768.029; Thu, 14 Sep 2023 02:16:41 +0000 From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com> Date: Thu, 14 Sep 2023 10:20:59 +0800 Subject: [PATCH 3/5] gpio: vf610: add i.MX8ULP of_device_id entry Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230914-vf610-gpio-v1-3-3ed418182a6a@nxp.com> References: <20230914-vf610-gpio-v1-0-3ed418182a6a@nxp.com> In-Reply-To: <20230914-vf610-gpio-v1-0-3ed418182a6a@nxp.com> To: Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <brgl@bgdev.pl>, Andy Shevchenko <andy@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Stefan Agner <stefan@agner.ch>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com> Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan <peng.fan@nxp.com> X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1694658076; l=805; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=OPiuO3T0/WorjjvFLYLRoNgrADNWE9MHLlWso3afXeo=; b=vPdoE3SNxYa4yZPKCmzwOHv0PYauXLxUK1HDXi8Ib15F8YXSTmfRSShHVMqA/Fk4xTViYdeGh P7WoBhBDij2A1E4bUJiGKOymHARg+RY2u4nz0nhQ0fdVbaPwHQ8JDfx X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0053.apcprd02.prod.outlook.com (2603:1096:4:1f5::8) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PR3PR04MB7257:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e88fd03-f01e-4b83-5868-08dbb4c8a287 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ol8iJp5pzecQ4L6ddshosy2/Gpk+3NlCa7tFR5YtjzTzOsizgJ+hp2uzy0PVLVZqZiSilrOmdj8vvurbJa4jEOwt4YVpfHaHhtBWOLZm4AwaGoyiqYftOzvmrvXlzc7X7C1hTutmrIXDt1jhRLGU8k5Hx33HtFeeMf6JgyL5CBdur5taIsI0CdwUJsYd0DJpY50YvX5wwWxfSZ+sHRbgxHrbb7n2gX1iHVkgTVM4YhD6CFuDGVfo89yYHES+n07NDYQxJitSh6j3QRyfRA2NfP1pov1+UrR5eQFe9tySBoYNwYAkKaHaKFVH3zYVw+eYeaI7LOis1pb9rj2IqrQx245mcWKkMSpNMZh8NJwepLX6gb5+9BnlU9FZrK43EjQGQjzkR6p7T5LdLDkxq0dQJpH+TrecVE/uCgUNUtd50MsSWw7vSe+B3fF7fjUwr3P0dJ6qABg9HTQU7TU0PmQrPRjy6cCWvLSR6ulos8whP7LLvMiGDoqetO0rnFbXN9Q7XEkE9ziicpoI0Zb9PxEOGpfp/T2O9zCI9MJWPs1tBhwMOkHoEQMpEDsMrGfoD5+4IDP2Y/BQ92QxoZn+XN622Q/iY+CkU+vJ/6RcJKDW2fZci1u952j1Y8908hOpTyaPcK8nQn9SAW3oBNM+BQXqLA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(346002)(136003)(376002)(396003)(366004)(451199024)(1800799009)(186009)(4744005)(7416002)(2906002)(5660300002)(8676002)(8936002)(41300700001)(4326008)(66556008)(66476007)(26005)(66946007)(110136005)(316002)(478600001)(52116002)(6666004)(9686003)(6506007)(6486002)(6512007)(36756003)(921005)(38350700002)(86362001)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?0M+xv1b/ZWUaV7CP0+vxYdVzfSfO?= =?utf-8?q?0/h/j/ieOkZSV9SFCaL5E2CoPf8BWB+f2urv+YBb4j8pNHF91jImJn2rRjdFarrSf?= =?utf-8?q?/la5AOpNz03PjkTU5F7j+ceBZJZB2+NmdjnInufftP0iZL/POZI5HKLLD3Wu2r1Tt?= =?utf-8?q?usobkd4eVNRVfCeb9vOL8Wi+YfZMiyLbAd2z554DpPSQPJCwT5sVhYuPJefl1d0fg?= =?utf-8?q?rs6c2VQd3EiV6ntScl/Z3ExdjgBEAHacU/kXxKf3GDhGbDLI7djJH5oJWTPCz55Bn?= =?utf-8?q?fq/UJd16RXmuFfgYwysf2Jx5ugWbEciOfR57ileuO0OJn8ZbpHo4bO4EcCDZ1ca8k?= =?utf-8?q?bmeAzao+OXXxcsvFqz38era3xV6qwdBugY3WhL3YU8BKMxMfEiOXq3dQpf+mNF9Pw?= =?utf-8?q?jH8GWDuN+YFppive0XqIor87H9j4KPglg99EaGV0jsDIMwGRvnAqKI+5XdLerwXoM?= =?utf-8?q?st2vSvr79Az5A4kmEXjDO3U+HLCKFPfT1eh45ce2omj6vGAqeH1sLLcpzSRGeQmqb?= =?utf-8?q?t+CTa7CeIvo+DV70AgxRAtGzGw5DiwxYHmuaFHMQX++PX9HNI8J3khYdZZecmfRNa?= =?utf-8?q?aRbWwtk3B2gTL6vN36aYjEvNo89h8W/Uy8zkUXqqkwBhftHTxOKlKrrzfb1Yt4MSK?= =?utf-8?q?yl3HhxbE2EdodtYhVu0iT7eGP0Oe+CgIwnJw7f7twwJvOWRZ/qoBoniMcztthixXn?= =?utf-8?q?roL/Q2AcJIqCf3T0Y/hfzZ0ld5S2IFRZbm0oEXI4aBBA17zdJdQoTWqbCMMGE50Sb?= =?utf-8?q?ZidAE3xZv31xZLTFrknhYVGPjIhB2uxHn0PvYUppzBQXRxV7sU8nCJ4Il1nGJXK32?= =?utf-8?q?NNMGIx2OztoIrusSPsPOvkDRjWt2yxQLmMKotGwNE/V91ONLeuCfx9FBgblBMkNWN?= =?utf-8?q?9BjedceklaWV78qoqGT01BWC/hQn4LVe3ZGT+4Uqgvpe3rgl0TB70m9C7dSraAIkw?= =?utf-8?q?hhB51IJb/aEYrb2de1xqfyx32yyrlqhvyaNxalyXgQFh+Se+QL9aWE8WJQpoeQtzJ?= =?utf-8?q?8cdw7Y5+geABFdBk/GSMGScEUjbEE4XUiucBQRG0tNjLpgJ13s5e4QeLE7CkdbSYA?= =?utf-8?q?9kAwE0XzbKE2lqhIGi7TI5orgOKPj+PhN7oie8eLeYeqq6DHy9hohm4RyxTEfJguy?= =?utf-8?q?0A51w3d8D15j7jvAu9+vFGj4qQu1Ha/GlLz8OZVTNvmnztHR8VB8ZajGN5PasJ2tQ?= =?utf-8?q?lRr2dNnXu//5l9H7YCfqDJ4IKVTqCCj0q8d1aWVva80jJ62Euhwz9E9U3bgyXBlpX?= =?utf-8?q?62OZwlkLWOAysJTSbC6brB8Z4gtwypCTsZNaW8xtI+HXdoBSOcICwg9WgXnNoY0pB?= =?utf-8?q?3bfs/Bjgr3a5DCsMhcpso7UAHrj+x6u/OY4YadkUuJP7WIyHtJPIBB/7PfiQ+cyvd?= =?utf-8?q?krBW8NLmYvPCvM7TeGpLkcf2GNSF2n9cFDCsoF2W5ttkvWBk/aYZDH0d8Fe/PNbQn?= =?utf-8?q?fz5wQVlJJlMBJRKbPE78+r/2T3csxNpcR3FK2OElEo3JyRLh6vOGjg1c3m+qZb+l2?= =?utf-8?q?6UWHdxi0IUwj?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e88fd03-f01e-4b83-5868-08dbb4c8a287 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2023 02:16:41.7445 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i+v7/a2n4QDxim7hlIDQLTx4Yn++c49oshFfQh1ww21okrGb/e8MHDgbE43zF4RTvKYU4xS20yp312pg+kb4/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7257 Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 13 Sep 2023 19:17:31 -0700 (PDT) X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776989583196678393 X-GMAIL-MSGID: 1776989583196678393 |
Series |
gpio: update i.MX93/8ULP and support i.MX95
|
|
Commit Message
Peng Fan (OSS)
Sept. 14, 2023, 2:20 a.m. UTC
From: Peng Fan <peng.fan@nxp.com> i.MX8ULP supports two interrupts, while i.MX7ULP supports one interrupt. So from hardware perspective, they are not compatible. So add entry for i.MX8ULP. Signed-off-by: Peng Fan <peng.fan@nxp.com> --- drivers/gpio/gpio-vf610.c | 1 + 1 file changed, 1 insertion(+)
Comments
On 14/09/2023 04:20, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > i.MX8ULP supports two interrupts, while i.MX7ULP supports one interrupt. > So from hardware perspective, they are not compatible. > > So add entry for i.MX8ULP. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > drivers/gpio/gpio-vf610.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c > index dbc7ba0ee72c..88f7215cdf4b 100644 > --- a/drivers/gpio/gpio-vf610.c > +++ b/drivers/gpio/gpio-vf610.c > @@ -67,6 +67,7 @@ static const struct fsl_gpio_soc_data imx_data = { > static const struct of_device_id vf610_gpio_dt_ids[] = { > { .compatible = "fsl,vf610-gpio", .data = NULL, }, > { .compatible = "fsl,imx7ulp-gpio", .data = &imx_data, }, > + { .compatible = "fsl,imx8ulp-gpio", .data = &imx_data, }, Why? It is the same as imx7. No need. Best regards, Krzysztof
On Thu, Sep 14, 2023 at 7:48 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 14/09/2023 04:20, Peng Fan (OSS) wrote: > > From: Peng Fan <peng.fan@nxp.com> > > > > i.MX8ULP supports two interrupts, while i.MX7ULP supports one interrupt. > > So from hardware perspective, they are not compatible. > > > > So add entry for i.MX8ULP. > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > drivers/gpio/gpio-vf610.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c > > index dbc7ba0ee72c..88f7215cdf4b 100644 > > --- a/drivers/gpio/gpio-vf610.c > > +++ b/drivers/gpio/gpio-vf610.c > > @@ -67,6 +67,7 @@ static const struct fsl_gpio_soc_data imx_data = { > > static const struct of_device_id vf610_gpio_dt_ids[] = { > > { .compatible = "fsl,vf610-gpio", .data = NULL, }, > > { .compatible = "fsl,imx7ulp-gpio", .data = &imx_data, }, > > + { .compatible = "fsl,imx8ulp-gpio", .data = &imx_data, }, > > Why? It is the same as imx7. No need. Because compatible = "fsl,imx7ulp-gpio" is not what is going to be in the device tree, but compatible = "fsl,imx8ulp-gpio"? What am I missing here? Maybe the commit message is weird. Yours, Linus Walleij
On 14/09/2023 10:48, Linus Walleij wrote: > On Thu, Sep 14, 2023 at 7:48 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> On 14/09/2023 04:20, Peng Fan (OSS) wrote: >>> From: Peng Fan <peng.fan@nxp.com> >>> >>> i.MX8ULP supports two interrupts, while i.MX7ULP supports one interrupt. >>> So from hardware perspective, they are not compatible. >>> >>> So add entry for i.MX8ULP. >>> >>> Signed-off-by: Peng Fan <peng.fan@nxp.com> >>> --- >>> drivers/gpio/gpio-vf610.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c >>> index dbc7ba0ee72c..88f7215cdf4b 100644 >>> --- a/drivers/gpio/gpio-vf610.c >>> +++ b/drivers/gpio/gpio-vf610.c >>> @@ -67,6 +67,7 @@ static const struct fsl_gpio_soc_data imx_data = { >>> static const struct of_device_id vf610_gpio_dt_ids[] = { >>> { .compatible = "fsl,vf610-gpio", .data = NULL, }, >>> { .compatible = "fsl,imx7ulp-gpio", .data = &imx_data, }, >>> + { .compatible = "fsl,imx8ulp-gpio", .data = &imx_data, }, >> >> Why? It is the same as imx7. No need. > > Because compatible = "fsl,imx7ulp-gpio" is not what is going to be in the > device tree, but compatible = "fsl,imx8ulp-gpio"? > > What am I missing here? Maybe the commit message is weird. > If the devices used before and are still going to use same driver data, they look compatible from OS point of view. Therefore usually we express such compatibility and do not add unneeded device_id entries. Now whether the devices are truly compatible or not, I don't know and with some recent emails I am bit confused. Best regards, Krzysztof
> Subject: Re: [PATCH 3/5] gpio: vf610: add i.MX8ULP of_device_id entry > > On 14/09/2023 10:48, Linus Walleij wrote: > > On Thu, Sep 14, 2023 at 7:48 AM Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> On 14/09/2023 04:20, Peng Fan (OSS) wrote: > >>> From: Peng Fan <peng.fan@nxp.com> > >>> > >>> i.MX8ULP supports two interrupts, while i.MX7ULP supports one > interrupt. > >>> So from hardware perspective, they are not compatible. > >>> > >>> So add entry for i.MX8ULP. > >>> > >>> Signed-off-by: Peng Fan <peng.fan@nxp.com> > >>> --- > >>> drivers/gpio/gpio-vf610.c | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c > >>> index dbc7ba0ee72c..88f7215cdf4b 100644 > >>> --- a/drivers/gpio/gpio-vf610.c > >>> +++ b/drivers/gpio/gpio-vf610.c > >>> @@ -67,6 +67,7 @@ static const struct fsl_gpio_soc_data imx_data = { > >>> static const struct of_device_id vf610_gpio_dt_ids[] = { > >>> { .compatible = "fsl,vf610-gpio", .data = NULL, }, > >>> { .compatible = "fsl,imx7ulp-gpio", .data = &imx_data, }, > >>> + { .compatible = "fsl,imx8ulp-gpio", .data = &imx_data, }, > >> > >> Why? It is the same as imx7. No need. > > > > Because compatible = "fsl,imx7ulp-gpio" is not what is going to be in > > the device tree, but compatible = "fsl,imx8ulp-gpio"? > > > > What am I missing here? Maybe the commit message is weird. > > > > If the devices used before and are still going to use same driver data, they > look compatible from OS point of view. Therefore usually we express such > compatibility and do not add unneeded device_id entries. > > Now whether the devices are truly compatible or not, I don't know and with > some recent emails I am bit confused. Some tricks in dtb are made to make the driver could work for both i.MX7ULP, i.MX8ULP, i.MX93 with fsl,imx7ulp-gpio. Such as i.MX8ULP: reg = <0x2d000080 0x1000>, <0x2d000040 0x40>; Actually the two regs are belong to one physical continuous space, <0x2d000000 0x1000> Just to i.MX8ULP could reuse the vf610 gpio driver, the regs are partitioned into two with some offset added So from hw, I think they are not compatible, just some sw tricks to make the linux driver could work for both platform. Thanks, Peng. > > Best regards, > Krzysztof
On 14/09/2023 11:08, Peng Fan wrote: >> Subject: Re: [PATCH 3/5] gpio: vf610: add i.MX8ULP of_device_id entry >> >> On 14/09/2023 10:48, Linus Walleij wrote: >>> On Thu, Sep 14, 2023 at 7:48 AM Krzysztof Kozlowski >>> <krzysztof.kozlowski@linaro.org> wrote: >>>> On 14/09/2023 04:20, Peng Fan (OSS) wrote: >>>>> From: Peng Fan <peng.fan@nxp.com> >>>>> >>>>> i.MX8ULP supports two interrupts, while i.MX7ULP supports one >> interrupt. >>>>> So from hardware perspective, they are not compatible. >>>>> >>>>> So add entry for i.MX8ULP. >>>>> >>>>> Signed-off-by: Peng Fan <peng.fan@nxp.com> >>>>> --- >>>>> drivers/gpio/gpio-vf610.c | 1 + >>>>> 1 file changed, 1 insertion(+) >>>>> >>>>> diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c >>>>> index dbc7ba0ee72c..88f7215cdf4b 100644 >>>>> --- a/drivers/gpio/gpio-vf610.c >>>>> +++ b/drivers/gpio/gpio-vf610.c >>>>> @@ -67,6 +67,7 @@ static const struct fsl_gpio_soc_data imx_data = { >>>>> static const struct of_device_id vf610_gpio_dt_ids[] = { >>>>> { .compatible = "fsl,vf610-gpio", .data = NULL, }, >>>>> { .compatible = "fsl,imx7ulp-gpio", .data = &imx_data, }, >>>>> + { .compatible = "fsl,imx8ulp-gpio", .data = &imx_data, }, >>>> >>>> Why? It is the same as imx7. No need. >>> >>> Because compatible = "fsl,imx7ulp-gpio" is not what is going to be in >>> the device tree, but compatible = "fsl,imx8ulp-gpio"? >>> >>> What am I missing here? Maybe the commit message is weird. >>> >> >> If the devices used before and are still going to use same driver data, they >> look compatible from OS point of view. Therefore usually we express such >> compatibility and do not add unneeded device_id entries. >> >> Now whether the devices are truly compatible or not, I don't know and with >> some recent emails I am bit confused. > > Some tricks in dtb are made to make the driver could work for both i.MX7ULP, > i.MX8ULP, i.MX93 with fsl,imx7ulp-gpio. > > Such as i.MX8ULP: > reg = <0x2d000080 0x1000>, <0x2d000040 0x40>; > Actually the two regs are belong to one physical continuous space, > <0x2d000000 0x1000> > Just to i.MX8ULP could reuse the vf610 gpio driver, the regs are partitioned > into two with some offset added > > So from hw, I think they are not compatible, just some sw tricks to > make the linux driver could work for both platform. OK, that sounds like reason to clean this up - drivers, bindings and finally DTS - all with proper explanation justifying affected DTS users. Best regards, Krzysztof
diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c index dbc7ba0ee72c..88f7215cdf4b 100644 --- a/drivers/gpio/gpio-vf610.c +++ b/drivers/gpio/gpio-vf610.c @@ -67,6 +67,7 @@ static const struct fsl_gpio_soc_data imx_data = { static const struct of_device_id vf610_gpio_dt_ids[] = { { .compatible = "fsl,vf610-gpio", .data = NULL, }, { .compatible = "fsl,imx7ulp-gpio", .data = &imx_data, }, + { .compatible = "fsl,imx8ulp-gpio", .data = &imx_data, }, { /* sentinel */ } };