Message ID | 20230914-vf610-gpio-v1-5-3ed418182a6a@nxp.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp182918vqi; Thu, 14 Sep 2023 00:59:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFzmyt4zxMUpdQkVZVisGQbH3Nq70Nd9Orjl/SE7lFOQcnZ+3q3GNrP6LTF/t6PMsRa/UWG X-Received: by 2002:a4a:c209:0:b0:578:c2af:45b5 with SMTP id z9-20020a4ac209000000b00578c2af45b5mr2702547oop.0.1694678376368; Thu, 14 Sep 2023 00:59:36 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1694678376; cv=pass; d=google.com; s=arc-20160816; b=SZWiRy7YPs0qeRXyHxzrjaIRDxTye2/8VnBgOC7feD8AooQlBs+GELSt320JSuamo/ dtn8pJlWPHyYz50pHQcuCrlb9QFJj34+jNEwRt1oCBG8DGozZY17TDiyO6btrO6TUaWZ s+C/0360N9HiYmPM4VfBUVP6ulxNa2GbDpCH+QDK87aZrge9F3hh0tAoUIAj9yS9h5ns FXTcjREMCNqijXdmxAtMaSIojP1uVEuO6q10+BLyi0wJ3dpi9+pZvoy95wg+3XGFRdQ1 tA7+Uj1PdyoL4L+082zZ+8MThybJZEHstgoKkqPgclN0yX5OSdpSER/b2OHithy6QysG Br9Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:cc:to:in-reply-to:references :message-id:content-transfer-encoding:subject:date:from :dkim-signature; bh=GGZC91X1IV0ho/GK04vC7f1CNuE+p7MQBld+ORMvSM4=; fh=COwI5EyG1DB6D28RaDWbFhDRTTyfVICzJ11TjDY7TVE=; b=AMJqMdAXG68ASBZQkO0VvJyEjaSPoyJyhte9mQqL8Nn9WljVZjN3OzhczHAbIiClpD pBd3RCafIR97yAWxQJXreMroAO8tKEuVHWxnSmc+/7MLI3YCQnndUd21K61RJ7DcdBj5 lkaTCrFYI9SXdtspnRk7ljp38La5zw0fVS8wpdAM3wUI6SZ2Zt+BAVwQNqGA4lDpEVUD OjHqfQHjMaL7U3Y0m4MLvBhWL8IG2h1KoB15+Rl4PRzWh8bQMmKp0N4CENW9IUUqWKD5 woOZeAZebTZ9WIJWzrhGNFH2yevwN/VJaFQ2RlE6vfqm5LTEGsINXA4de6EiDdujVUMd lU7Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@NXP1.onmicrosoft.com header.s=selector2-NXP1-onmicrosoft-com header.b=LnhRTCL4; arc=pass (i=1 spf=pass spfdomain=oss.nxp.com dkim=pass dkdomain=oss.nxp.com dmarc=pass fromdomain=oss.nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id s8-20020a656448000000b0056574d63583si1013443pgv.306.2023.09.14.00.59.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 00:59:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@NXP1.onmicrosoft.com header.s=selector2-NXP1-onmicrosoft-com header.b=LnhRTCL4; arc=pass (i=1 spf=pass spfdomain=oss.nxp.com dkim=pass dkdomain=oss.nxp.com dmarc=pass fromdomain=oss.nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id E761782B9287; Wed, 13 Sep 2023 19:17:26 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234323AbjINCRV (ORCPT <rfc822;chrisfriedt@gmail.com> + 35 others); Wed, 13 Sep 2023 22:17:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233950AbjINCQ7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 13 Sep 2023 22:16:59 -0400 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2057.outbound.protection.outlook.com [40.107.20.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66E8B1FDF; Wed, 13 Sep 2023 19:16:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pvq5Ou+yXHJ1efHOnXdhYzLX8Ts6wZcxibPrNf/I4+wIlQh4Jflni8oyicJjBr8eZx8PSLVlW5bEc6oAqIOnEKO7WxLMarpi0i4WvHcb1ifXLqI2b3DJagPF6qLxIUsBIKgEmXUZCy9iO7IMPJCv5lZsshsLIECQ0QUfPfkD7yPM2QVhYPNVjNZEIxdknuzPSJqypiN+PNzVQiDSj7zDi5ELm9rBPTmCK6viL/+x+GYmWGVUClAFRt4Q/itij0X7hrPs4poOOgP7to3xlWbPxJ89GcOiOB29+RK8IlGEUHL9q7D5TldOizKIcPY2PQnE5hQaXBOfES9cda+YjHDnfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GGZC91X1IV0ho/GK04vC7f1CNuE+p7MQBld+ORMvSM4=; b=F5cVl9+yme20MH+kg7ebzwTzqS6ckoHzOfq+9uRs05KhCQYz7DSXWcWpVnUu7TxlHb4asDvRABGCfwf+C0wUStsYb4bKb+RjQWMHkCrwda2ZDcO+xdzhFHWQoW4gH9+eMada84PTY1o1ldqsokCIsAybbLpbQA8HLvmA+zjZr5uFVvZ+xeVN9S5PaVzjO8pM3MjJLQ05yJxpNksYNaafi/xDKiNczHRczgQPrY8sccsCjzksj87Q5wws4GPMhpXUmlUGWzCLuqWiRJGowS3yzoCN7F5Y6pYERJeh+61sG5Ea3OEiADTV/ERONziGclkS7coJG7oXWHJIhKuMkrFXSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GGZC91X1IV0ho/GK04vC7f1CNuE+p7MQBld+ORMvSM4=; b=LnhRTCL4rXRBFG/RofQ9BdMdg8y/JN6VC3BuMMGfd3BZEVzzU1ZG/9ndLvZY6NIuIMOgkbtZLSGgSFB6wvouAZDmRML4ypIXMcH2eYRYQNLVku82rn/v3tBR4+L0Cqi65lBK36Xh0jRmLNQCrmm1AfOT6YB+ccxGxXmSyLSa/cA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PR3PR04MB7257.eurprd04.prod.outlook.com (2603:10a6:102:93::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.20; Thu, 14 Sep 2023 02:16:52 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::2b3:d8de:95c8:b28b]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::2b3:d8de:95c8:b28b%3]) with mapi id 15.20.6768.029; Thu, 14 Sep 2023 02:16:52 +0000 From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com> Date: Thu, 14 Sep 2023 10:21:01 +0800 Subject: [PATCH 5/5] arm64: dts: imx93: update gpio node Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230914-vf610-gpio-v1-5-3ed418182a6a@nxp.com> References: <20230914-vf610-gpio-v1-0-3ed418182a6a@nxp.com> In-Reply-To: <20230914-vf610-gpio-v1-0-3ed418182a6a@nxp.com> To: Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <brgl@bgdev.pl>, Andy Shevchenko <andy@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Stefan Agner <stefan@agner.ch>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com> Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan <peng.fan@nxp.com> X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1694658076; l=2695; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=lYwaBTu6cwY6bIMf9obxoXYCEK5Y+uWB28zKOkNRXOI=; b=mhA5EyrWw4CMFttxN0uJbPGrla9agD43l0wbBsv4CsJeRaLIVkx4nABVKjXrpO2SmJYyLrtTz JhUySZs/By7DpCt1R5utKvVqzeI3HqYaO60mbt7W8cb8HLShvMOCXFT X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0053.apcprd02.prod.outlook.com (2603:1096:4:1f5::8) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PR3PR04MB7257:EE_ X-MS-Office365-Filtering-Correlation-Id: 96186bb5-0379-4250-042d-08dbb4c8a8af X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EKWyF0RuMKztowH5NV1OmYZGODIgVgt5O3i4ABXj092bk8aT+ZFqIK8JUW60HLKfl35J2HwsmFuEdYyGaRO89SLgRGIuYB7E7EP7EYX007R1anjqOD/yYP5Sq6nbbG+jd/nVYa7tDz1cH9iZ5o2FuM2IeUBqWJrG6TdJBgymoJeNbRafT6406e43ULKmAUnJ4mvIMojU1f5vOVgReIQH0oUk7srSnmc2qlWYy5Bj3+Llk/2qz4JXMLgakbRkJKaj7Zc4mknp1OKYp4Mac2wV7MOcpC61+UZyXDh1gTXNtDphqjxP1i3iK9lrxnmgYWPwxM+VUIhjbgJcG+52gjefT6fUftTrxiOl1X8TKfkbEsHCqI89NArQGEnmIaMsTDLFp+o6Rp8gyeffft/Ro6RaInD8aA/N7FJDQwGZV3ev/Q6B0PVelO7sAqwl2AFRXkdo7rkIDcT6hTYWWD5Pz5pEhYlzyKwcFgPc22wjlKnPUchNJ+Oi3Ld87lBuNNqXwwUD0G7cs23msMBgHsC99MmDWBgYWDfDUIdU4mZy8kxjZJ1U9Hoa1RrieTWMqZmr9KKucwNYvd/HFlulDO7edZEUzUYswktCqryMAazIshxEk6d0Y7QzDS/ltWwzDGscrrtHVooInXgmPvCXffmuVP3JuQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(346002)(136003)(376002)(396003)(366004)(451199024)(1800799009)(186009)(15650500001)(7416002)(2906002)(5660300002)(8676002)(8936002)(41300700001)(4326008)(66556008)(66476007)(26005)(66946007)(110136005)(316002)(478600001)(52116002)(6666004)(9686003)(6506007)(6486002)(6512007)(83380400001)(36756003)(921005)(38350700002)(86362001)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?ByDT2oMYKMDQX9IIL8TLDAToBmmB?= =?utf-8?q?gmm8Gi3e4LxzfuGKTAQyUv0qi+NShYAmUOYs8YuD0p2itqHXA4/hCk4x126Sh6956?= =?utf-8?q?W+A0ezEcVg2luPZQc/PvXw4Nm9sMTQwoRKSGqPpxHeMO72GF2iQ+i/Zm86GDIaKSX?= =?utf-8?q?1JYzcV43/vAS9lX/eOo71/5pwERjSZNr5A7kAIJ+u9nCgjUrKijNFRGy0iG41/VK7?= =?utf-8?q?Sxx0ej2Ll2x04RR/KJgyO/RXRGDt+q+3oDh3S9/H9CnMOz30AneU1fn5AHF4ECKcu?= =?utf-8?q?giGvVZZ8PKX1D8RMiy6eKieXg57UPjp4rplLF5OgagGJoBUMHpjlU+TwOontmsBD5?= =?utf-8?q?9fKJD4e4aHV7AnmGD3hn0q4x0Eez8zzqUdKuMGLAUadwPxWbQY5Jm472nHrM1Iygn?= =?utf-8?q?0VKGw8+GJ91vczBM+VkC5wr9Lto2sdtKY0+Gk6XMiZa7ICWSiyQkZYPxuBPA48evp?= =?utf-8?q?7Gl/fBkt0XJjb0mt5Y/owLCUe2mqW7rrGY+/55nLi1zLrQuUS95TQ3Da6H/ZjFGOc?= =?utf-8?q?e70pO9M9UELGXR8wrzIujySS49/LGj2HSi+8Ht49/i81jPztRo4KDtcIIiB53cf7M?= =?utf-8?q?YHCl0V4mSQpY84uvui6mddzLN+v5wkFo+I02F/HDUiUsMvUc+2Xo9dGmnoF0ZlKsW?= =?utf-8?q?wivvgsstso0cHabtydvhYpp79pQACN42aD0NvFN/wAePoAXGrdACmV6BOUPTBkwqG?= =?utf-8?q?7mRlVq375gvigY7jS4/KHXzVjX0Gi/idVMa956vXE3MDjCnKgp/iY4ylg3c/jhiWb?= =?utf-8?q?edibFUbpNBPjQJgadwoA3WD/O3zeaw9a2DaOJte8687ZkgLgbDXP+z7hGvtD8ViMt?= =?utf-8?q?AQAijq9A9C1K9xDDz/9Mbwd0Ivh6kytT2xuXD/MdbyuM+9mOmNH9GgURkWRcjN7l+?= =?utf-8?q?z1113U8UBF+ln670BP73X8SPMHAMs/Tum9s5ECrrf/+GFBzEpe7DLmx4mTqJ9tx18?= =?utf-8?q?TjZqMOK5c+hUi+HIxjQmHlZIy08wjsqtBtYaZIudOLaVyEdMQbORIli+v3e5bubil?= =?utf-8?q?/lKD3vUk4ORYlfmq64DvpoS4blTPQlXzfNoyJJLtghEapqgDOHsaDnsr9rO7WIXQl?= =?utf-8?q?7pRzjT4/zxYkYfgv2fQ1w9MysTBx7WT3Cluk6Ks4uCWrCSzoWRIg27By8rYPfKvgu?= =?utf-8?q?/h/ke6fxFx5qwK5vEPlJkABkWcJBnc1+eyKQaJ+SaRiAkCYDH3qYzFKj0IxK8lH7J?= =?utf-8?q?v+0X9IRE0jkvovqUtSD+SOwwhHsCzV3/Vc/YuAOrsfEmMR0t3nYtYAa4IC7bSlmy8?= =?utf-8?q?uT5qL8o2TGI/UzxfbeTnXLbikffP5DeSZ59lAxNdGD1eZ2KMN4/+9gK35DGwDOGYj?= =?utf-8?q?bGslBu7TDk68q57DAP0Ar47DHsdoWhfhY9fyqaQHWCcoS8NQKGmE6qkINLyQJV7/R?= =?utf-8?q?k90EimC8Fq9IaAFxMpAdBIE1qzxn887Tlowj8AIbQJEQi91cwcW/NjAaRFCk36UwX?= =?utf-8?q?oVj72JV8SQ1ebKYZhhvIEaLiB7Q1lO8guRlIN32otSVXSqC/1TPv0tLQ5zUfTHIWf?= =?utf-8?q?gIOmq2VV/Vqq?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96186bb5-0379-4250-042d-08dbb4c8a8af X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2023 02:16:52.0584 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EVwDo6yVefj/FkY2bsvwb7zxr9CxAJjGghzFOm6dVuLrAkQLfvCefASPTtZnvjWoNmwCuEB2C6LUfObeyIJoyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7257 Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 13 Sep 2023 19:17:27 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776999068129430019 X-GMAIL-MSGID: 1776999072802006078 |
Series |
gpio: update i.MX93/8ULP and support i.MX95
|
|
Commit Message
Peng Fan (OSS)
Sept. 14, 2023, 2:21 a.m. UTC
From: Peng Fan <peng.fan@nxp.com> Per binding doc, i.MX93 GPIO supports two interrupts, and not compatible with i.MX7ULP. So update the node Signed-off-by: Peng Fan <peng.fan@nxp.com> --- arch/arm64/boot/dts/freescale/imx93.dtsi | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-)
Comments
On 14/09/2023 04:21, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > Per binding doc, i.MX93 GPIO supports two interrupts, and not > compatible with i.MX7ULP. So update the node > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx93.dtsi | 20 ++++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi > index 6f85a05ee7e1..011c34a57c53 100644 > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi > @@ -825,11 +825,12 @@ usdhc3: mmc@428b0000 { > }; > > gpio2: gpio@43810080 { > - compatible = "fsl,imx93-gpio", "fsl,imx7ulp-gpio"; > + compatible = "fsl,imx93-gpio", "fsl,imx8ulp-gpio"; As your driver change points, it is breaking users, so no :( Best regards, Krzysztof
On 14/09/2023 08:04, Peng Fan wrote: >> Subject: Re: [PATCH 5/5] arm64: dts: imx93: update gpio node >> >> On 14/09/2023 04:21, Peng Fan (OSS) wrote: >>> From: Peng Fan <peng.fan@nxp.com> >>> >>> Per binding doc, i.MX93 GPIO supports two interrupts, and not >>> compatible with i.MX7ULP. So update the node >>> >>> Signed-off-by: Peng Fan <peng.fan@nxp.com> >>> --- >>> arch/arm64/boot/dts/freescale/imx93.dtsi | 20 ++++++++++++-------- >>> 1 file changed, 12 insertions(+), 8 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi >>> b/arch/arm64/boot/dts/freescale/imx93.dtsi >>> index 6f85a05ee7e1..011c34a57c53 100644 >>> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi >>> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi >>> @@ -825,11 +825,12 @@ usdhc3: mmc@428b0000 { >>> }; >>> >>> gpio2: gpio@43810080 { >>> - compatible = "fsl,imx93-gpio", "fsl,imx7ulp-gpio"; >>> + compatible = "fsl,imx93-gpio", "fsl,imx8ulp-gpio"; >> >> As your driver change points, it is breaking users, so no :( > > ok. Although i.MX93 GPIO is not compatible with i.MX7ULP from HW > perspective, the compatible string should keep as it is now and binding If it is not compatible, then how could it work before? Best regards, Krzysztof
> Subject: Re: [PATCH 5/5] arm64: dts: imx93: update gpio node > > On 14/09/2023 08:04, Peng Fan wrote: > >> Subject: Re: [PATCH 5/5] arm64: dts: imx93: update gpio node > >> > >> On 14/09/2023 04:21, Peng Fan (OSS) wrote: > >>> From: Peng Fan <peng.fan@nxp.com> > >>> > >>> Per binding doc, i.MX93 GPIO supports two interrupts, and not > >>> compatible with i.MX7ULP. So update the node > >>> > >>> Signed-off-by: Peng Fan <peng.fan@nxp.com> > >>> --- > >>> arch/arm64/boot/dts/freescale/imx93.dtsi | 20 ++++++++++++-------- > >>> 1 file changed, 12 insertions(+), 8 deletions(-) > >>> > >>> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi > >>> b/arch/arm64/boot/dts/freescale/imx93.dtsi > >>> index 6f85a05ee7e1..011c34a57c53 100644 > >>> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi > >>> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi > >>> @@ -825,11 +825,12 @@ usdhc3: mmc@428b0000 { > >>> }; > >>> > >>> gpio2: gpio@43810080 { > >>> - compatible = "fsl,imx93-gpio", "fsl,imx7ulp-gpio"; > >>> + compatible = "fsl,imx93-gpio", "fsl,imx8ulp-gpio"; > >> > >> As your driver change points, it is breaking users, so no :( > > > > ok. Although i.MX93 GPIO is not compatible with i.MX7ULP from HW > > perspective, the compatible string should keep as it is now and > > binding > > If it is not compatible, then how could it work before? i.MX7ULP reg: 0h Port Data Output Register (PDOR) 4h Port Set Output Register (PSOR) 8h Port Clear Output Register (PCOR) Ch Port Toggle Output Register (PTOR) 10h Port Data Input Register (PDIR) 14h Port Data Direction Register (PDDR) i.MX8ULP/93 has different registers address, but i.MX93 registers has 0x40 off as below: 40h Port Data Output (PDOR) Even linux i.MX7ULP gpio driver could work with i.MX8ULP/93 GPIO HW with dts node using an 0x40 offset + base addr for i.MX93 gpio. I think from hw design, they are not compatible. Besides the upper differences, there are other differences. So I think better move to new compatible string. Thanks, Peng. > > > > Best regards, > Krzysztof
On 14/09/2023 08:53, Peng Fan wrote: >> Subject: Re: [PATCH 5/5] arm64: dts: imx93: update gpio node >> >> On 14/09/2023 08:04, Peng Fan wrote: >>>> Subject: Re: [PATCH 5/5] arm64: dts: imx93: update gpio node >>>> >>>> On 14/09/2023 04:21, Peng Fan (OSS) wrote: >>>>> From: Peng Fan <peng.fan@nxp.com> >>>>> >>>>> Per binding doc, i.MX93 GPIO supports two interrupts, and not >>>>> compatible with i.MX7ULP. So update the node >>>>> >>>>> Signed-off-by: Peng Fan <peng.fan@nxp.com> >>>>> --- >>>>> arch/arm64/boot/dts/freescale/imx93.dtsi | 20 ++++++++++++-------- >>>>> 1 file changed, 12 insertions(+), 8 deletions(-) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi >>>>> b/arch/arm64/boot/dts/freescale/imx93.dtsi >>>>> index 6f85a05ee7e1..011c34a57c53 100644 >>>>> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi >>>>> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi >>>>> @@ -825,11 +825,12 @@ usdhc3: mmc@428b0000 { >>>>> }; >>>>> >>>>> gpio2: gpio@43810080 { >>>>> - compatible = "fsl,imx93-gpio", "fsl,imx7ulp-gpio"; >>>>> + compatible = "fsl,imx93-gpio", "fsl,imx8ulp-gpio"; >>>> >>>> As your driver change points, it is breaking users, so no :( >>> >>> ok. Although i.MX93 GPIO is not compatible with i.MX7ULP from HW >>> perspective, the compatible string should keep as it is now and >>> binding >> >> If it is not compatible, then how could it work before? > > i.MX7ULP reg: > 0h Port Data Output Register (PDOR) > 4h Port Set Output Register (PSOR) > 8h Port Clear Output Register (PCOR) > Ch Port Toggle Output Register (PTOR) > 10h Port Data Input Register (PDIR) > 14h Port Data Direction Register (PDDR) > > i.MX8ULP/93 has different registers address, but > i.MX93 registers has 0x40 off as below: > 40h Port Data Output (PDOR) > > Even linux i.MX7ULP gpio driver could work with i.MX8ULP/93 > GPIO HW with dts node using an 0x40 offset + base addr > for i.MX93 gpio. I think from hw design, they are > not compatible. Besides the upper differences, > there are other differences. Sorry, I don't understand it. I asked how could they work before in Linux, if they are not compatible, and you pasted regs. So again - if they are not compatible, how could it work? Or maybe it never worked? But then commit msg would say it. Best regards, Krzysztof
> Subject: Re: [PATCH 5/5] arm64: dts: imx93: update gpio node > > On 14/09/2023 08:53, Peng Fan wrote: > >> Subject: Re: [PATCH 5/5] arm64: dts: imx93: update gpio node > >> > >> On 14/09/2023 08:04, Peng Fan wrote: > >>>> Subject: Re: [PATCH 5/5] arm64: dts: imx93: update gpio node > >>>> > >>>> On 14/09/2023 04:21, Peng Fan (OSS) wrote: > >>>>> From: Peng Fan <peng.fan@nxp.com> > >>>>> > >>>>> Per binding doc, i.MX93 GPIO supports two interrupts, and not > >>>>> compatible with i.MX7ULP. So update the node > >>>>> > >>>>> Signed-off-by: Peng Fan <peng.fan@nxp.com> > >>>>> --- > >>>>> arch/arm64/boot/dts/freescale/imx93.dtsi | 20 > >>>>> ++++++++++++-------- > >>>>> 1 file changed, 12 insertions(+), 8 deletions(-) > >>>>> > >>>>> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi > >>>>> b/arch/arm64/boot/dts/freescale/imx93.dtsi > >>>>> index 6f85a05ee7e1..011c34a57c53 100644 > >>>>> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi > >>>>> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi > >>>>> @@ -825,11 +825,12 @@ usdhc3: mmc@428b0000 { > >>>>> }; > >>>>> > >>>>> gpio2: gpio@43810080 { > >>>>> - compatible = "fsl,imx93-gpio", "fsl,imx7ulp-gpio"; > >>>>> + compatible = "fsl,imx93-gpio", "fsl,imx8ulp-gpio"; > >>>> > >>>> As your driver change points, it is breaking users, so no :( > >>> > >>> ok. Although i.MX93 GPIO is not compatible with i.MX7ULP from HW > >>> perspective, the compatible string should keep as it is now and > >>> binding > >> > >> If it is not compatible, then how could it work before? > > > > i.MX7ULP reg: > > 0h Port Data Output Register (PDOR) > > 4h Port Set Output Register (PSOR) > > 8h Port Clear Output Register (PCOR) > > Ch Port Toggle Output Register (PTOR) 10h Port Data Input Register > > (PDIR) 14h Port Data Direction Register (PDDR) > > > > i.MX8ULP/93 has different registers address, but > > i.MX93 registers has 0x40 off as below: > > 40h Port Data Output (PDOR) > > > > Even linux i.MX7ULP gpio driver could work with i.MX8ULP/93 GPIO HW > > with dts node using an 0x40 offset + base addr for i.MX93 gpio. I > > think from hw design, they are not compatible. Besides the upper > > differences, there are other differences. > > Sorry, I don't understand it. I asked how could they work before in Linux, if > they are not compatible, and you pasted regs. > > So again - if they are not compatible, how could it work? Or maybe it never > worked? But then commit msg would say it. Hm. From hw design perspective they are not compatible, I think. But from programming model perspective, partial of i.MX93/8ULP registers are same as i.MX7ULP, with offset not start from 0. From programming model, we could say they are compatible. Then for i.MX95, I could still use "fsl,imx95-gpio", "fsl,imx7ulp-gpio". Thanks, Peng. > > Best regards, > Krzysztof
diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi index 6f85a05ee7e1..011c34a57c53 100644 --- a/arch/arm64/boot/dts/freescale/imx93.dtsi +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi @@ -825,11 +825,12 @@ usdhc3: mmc@428b0000 { }; gpio2: gpio@43810080 { - compatible = "fsl,imx93-gpio", "fsl,imx7ulp-gpio"; + compatible = "fsl,imx93-gpio", "fsl,imx8ulp-gpio"; reg = <0x43810080 0x1000>, <0x43810040 0x40>; gpio-controller; #gpio-cells = <2>; - interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>; interrupt-controller; #interrupt-cells = <2>; clocks = <&clk IMX93_CLK_GPIO2_GATE>, @@ -839,11 +840,12 @@ gpio2: gpio@43810080 { }; gpio3: gpio@43820080 { - compatible = "fsl,imx93-gpio", "fsl,imx7ulp-gpio"; + compatible = "fsl,imx93-gpio", "fsl,imx8ulp-gpio"; reg = <0x43820080 0x1000>, <0x43820040 0x40>; gpio-controller; #gpio-cells = <2>; - interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>; interrupt-controller; #interrupt-cells = <2>; clocks = <&clk IMX93_CLK_GPIO3_GATE>, @@ -854,11 +856,12 @@ gpio3: gpio@43820080 { }; gpio4: gpio@43830080 { - compatible = "fsl,imx93-gpio", "fsl,imx7ulp-gpio"; + compatible = "fsl,imx93-gpio", "fsl,imx8ulp-gpio"; reg = <0x43830080 0x1000>, <0x43830040 0x40>; gpio-controller; #gpio-cells = <2>; - interrupts = <GIC_SPI 189 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 189 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 190 IRQ_TYPE_LEVEL_HIGH>; interrupt-controller; #interrupt-cells = <2>; clocks = <&clk IMX93_CLK_GPIO4_GATE>, @@ -868,11 +871,12 @@ gpio4: gpio@43830080 { }; gpio1: gpio@47400080 { - compatible = "fsl,imx93-gpio", "fsl,imx7ulp-gpio"; + compatible = "fsl,imx93-gpio", "fsl,imx8ulp-gpio"; reg = <0x47400080 0x1000>, <0x47400040 0x40>; gpio-controller; #gpio-cells = <2>; - interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>; interrupt-controller; #interrupt-cells = <2>; clocks = <&clk IMX93_CLK_GPIO1_GATE>,