Message ID | 12dd5cb49efa7714f8e0389e4c7b3bc829e8a90e.1668289299.git.christophe.jaillet@wanadoo.fr |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1439817wru; Sat, 12 Nov 2022 13:52:22 -0800 (PST) X-Google-Smtp-Source: AA0mqf7XKIcnHhF13/AuoVGnRMd8ZNl3Txl/Se8ollHsw/0lm8u3jB6FGurGRwB0ejn1dC4fQ8uT X-Received: by 2002:a63:ce04:0:b0:46b:2493:14ad with SMTP id y4-20020a63ce04000000b0046b249314admr6643748pgf.274.1668289942275; Sat, 12 Nov 2022 13:52:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668289942; cv=none; d=google.com; s=arc-20160816; b=BF1whQTwDwxURphKiIyL4fGDnzkyPyGSGcsx6OCOjjQ+zvtBU0oc3IBH3eitXAeSkT 8dvJ8dGZL8It97Cmo9ft2rPfPA+x8q22l5T8HtoLu1OInlbx6mrt/DCuVPSQdwl5lspa ZAz40L+mJ0E37L8Uqr/dKgUNZqtIdHRkZ/smtVPP5TjhUcsd09Gq7Of1c6jquLEiaMeD z5J6NmqJOB1gM8xl68uacMRLgVcP+FwXXKTwEkZCnAWxpSVfuTfMMFtUEStll8FSX2SL /U+S/ArluHs3kfOQ0xlFwRGANUy+Xr8J/RdIng9o1SrC6H4eDV7JZtxrpknWPzxHHMoK Dorg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=psbVqcAUdIQ4Tulh/ePd4yD3wd3BpVGx7er+bw3c7Us=; b=BiH+q2rDVYJ+JBsImq/ov9csi/v2ub3ehxEqG21Wag9ad240UFHdNpYr65LItufNcZ JJU9cqMJ3uEhH3DyEnz4v9ZgUOv09LBJ8B3/j0m4HEvYS84zsdnat7KkW6/m0MSurQVR GSatFQUCi7jX+ZndGG0ufHyFwHpc9e6KIyTd8KEh853j0MSpLYwBIJKaIwkA68iaw9bM fCIlkMvCEpt3uEjb7VJnVolq54WZgf23dd5mtoVkCzbJPn9nJ5BsHgbKdyNIE98bn12k f7R/FdUbjCgZdvss5c9A9as3j3wY7kYF6EDbgmEjXoSKWHXfkgIodpSW8QvO1aFMZgN6 43Bg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b3-20020a17090a5a0300b0020a66fc1398si11034253pjd.91.2022.11.12.13.52.08; Sat, 12 Nov 2022 13:52:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235142AbiKLVnN (ORCPT <rfc822;winker.wchi@gmail.com> + 99 others); Sat, 12 Nov 2022 16:43:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234928AbiKLVnL (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 12 Nov 2022 16:43:11 -0500 Received: from smtp.smtpout.orange.fr (smtp-29.smtpout.orange.fr [80.12.242.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98E6716593 for <linux-kernel@vger.kernel.org>; Sat, 12 Nov 2022 13:43:09 -0800 (PST) Received: from pop-os.home ([86.243.100.34]) by smtp.orange.fr with ESMTPA id tyHJoEBHyu8pltyHKom6SK; Sat, 12 Nov 2022 22:43:07 +0100 X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 12 Nov 2022 22:43:07 +0100 X-ME-IP: 86.243.100.34 From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> To: Luca Ceresoli <luca.ceresoli@bootlin.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Neil Armstrong <neil.armstrong@linaro.org>, Jerome Brunet <jbrunet@baylibre.com>, Kevin Hilman <khilman@baylibre.com>, Martin Blumenstingl <martin.blumenstingl@googlemail.com>, Heiko Stuebner <heiko@sntech.de> Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET <christophe.jaillet@wanadoo.fr>, linux-clk@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: [PATCH] clk: Remove a useless include Date: Sat, 12 Nov 2022 22:43:03 +0100 Message-Id: <12dd5cb49efa7714f8e0389e4c7b3bc829e8a90e.1668289299.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749328794749424151?= X-GMAIL-MSGID: =?utf-8?q?1749328794749424151?= |
Series |
clk: Remove a useless include
|
|
Commit Message
Christophe JAILLET
Nov. 12, 2022, 9:43 p.m. UTC
<linux/rational.h> is not needed for these drivers. Remove the
corresponding #include.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/clk/clk-versaclock5.c | 1 -
drivers/clk/meson/clk-pll.c | 1 -
drivers/clk/rockchip/clk.c | 1 -
3 files changed, 3 deletions(-)
Comments
Am Samstag, 12. November 2022, 22:43:03 CET schrieb Christophe JAILLET: > <linux/rational.h> is not needed for these drivers. Remove the > corresponding #include. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/clk/clk-versaclock5.c | 1 - > drivers/clk/meson/clk-pll.c | 1 - > drivers/clk/rockchip/clk.c | 1 - Clock-trees for soc families normally have different sub-maintainers, so depending on how we want to merge this, you might need to split this into 3 patches. But at least for the Rockchip part, I'm also fine with the patch going in as a whole, so (for the Rockchip part): Acked-by: Heiko Stuebner <heiko@sntech.de> Heiko > 3 files changed, 3 deletions(-) > [...] > diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c > index e63d4f20b479..398c427b8e81 100644 > --- a/drivers/clk/rockchip/clk.c > +++ b/drivers/clk/rockchip/clk.c > @@ -21,7 +21,6 @@ > #include <linux/mfd/syscon.h> > #include <linux/regmap.h> > #include <linux/reboot.h> > -#include <linux/rational.h> > > #include "../clk-fractional-divider.h" > #include "clk.h" >
On Sun 13 Nov 2022 at 09:48, Heiko Stübner <heiko@sntech.de> wrote: > Am Samstag, 12. November 2022, 22:43:03 CET schrieb Christophe JAILLET: >> <linux/rational.h> is not needed for these drivers. Remove the >> corresponding #include. >> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> >> --- >> drivers/clk/clk-versaclock5.c | 1 - >> drivers/clk/meson/clk-pll.c | 1 - >> drivers/clk/rockchip/clk.c | 1 - > > Clock-trees for soc families normally have different sub-maintainers, > so depending on how we want to merge this, you might need to split > this into 3 patches. > > But at least for the Rockchip part, I'm also fine with the patch going > in as a whole, so (for the Rockchip part): > > Acked-by: Heiko Stuebner <heiko@sntech.de> > > > Heiko Same for the Amlogic part Acked-by: Jerome Brunet <jbrunet@baylibre.com> > >> 3 files changed, 3 deletions(-) >> > > [...] > >> diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c >> index e63d4f20b479..398c427b8e81 100644 >> --- a/drivers/clk/rockchip/clk.c >> +++ b/drivers/clk/rockchip/clk.c >> @@ -21,7 +21,6 @@ >> #include <linux/mfd/syscon.h> >> #include <linux/regmap.h> >> #include <linux/reboot.h> >> -#include <linux/rational.h> >> >> #include "../clk-fractional-divider.h" >> #include "clk.h" >>
Hello Jerome, On Sun, 13 Nov 2022 20:29:43 +0100 Jerome Brunet <jbrunet@baylibre.com> wrote: > On Sun 13 Nov 2022 at 09:48, Heiko Stübner <heiko@sntech.de> wrote: > > > Am Samstag, 12. November 2022, 22:43:03 CET schrieb Christophe JAILLET: > >> <linux/rational.h> is not needed for these drivers. Remove the > >> corresponding #include. > >> > >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > >> --- > >> drivers/clk/clk-versaclock5.c | 1 - > >> drivers/clk/meson/clk-pll.c | 1 - > >> drivers/clk/rockchip/clk.c | 1 - > > > > Clock-trees for soc families normally have different sub-maintainers, > > so depending on how we want to merge this, you might need to split > > this into 3 patches. > > > > But at least for the Rockchip part, I'm also fine with the patch going > > in as a whole, so (for the Rockchip part): > > > > Acked-by: Heiko Stuebner <heiko@sntech.de> > > > > > > Heiko > > Same for the Amlogic part > > Acked-by: Jerome Brunet <jbrunet@baylibre.com> And the same for Versaclock: Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Quoting Christophe JAILLET (2022-11-12 13:43:03) > <linux/rational.h> is not needed for these drivers. Remove the > corresponding #include. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- Applied to clk-next
diff --git a/drivers/clk/clk-versaclock5.c b/drivers/clk/clk-versaclock5.c index 88689415aff9..e9737969170e 100644 --- a/drivers/clk/clk-versaclock5.c +++ b/drivers/clk/clk-versaclock5.c @@ -20,7 +20,6 @@ #include <linux/module.h> #include <linux/of.h> #include <linux/of_platform.h> -#include <linux/rational.h> #include <linux/regmap.h> #include <linux/slab.h> diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c index 9e55617bc3b4..4b96e1590224 100644 --- a/drivers/clk/meson/clk-pll.c +++ b/drivers/clk/meson/clk-pll.c @@ -32,7 +32,6 @@ #include <linux/io.h> #include <linux/math64.h> #include <linux/module.h> -#include <linux/rational.h> #include "clk-regmap.h" #include "clk-pll.h" diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c index e63d4f20b479..398c427b8e81 100644 --- a/drivers/clk/rockchip/clk.c +++ b/drivers/clk/rockchip/clk.c @@ -21,7 +21,6 @@ #include <linux/mfd/syscon.h> #include <linux/regmap.h> #include <linux/reboot.h> -#include <linux/rational.h> #include "../clk-fractional-divider.h" #include "clk.h"