Message ID | 20230912100727.23197-10-brgl@bgdev.pl |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp302847vqx; Tue, 12 Sep 2023 03:17:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEV9jO6bPY3qKkZP4UmR3ibqgAa5qFMm3ZWIcr+TRB95GVV1smVFrS+1Sui4rx8/s3lKz0x X-Received: by 2002:aa7:8307:0:b0:68c:59cb:2dd9 with SMTP id bk7-20020aa78307000000b0068c59cb2dd9mr2490285pfb.1.1694513829159; Tue, 12 Sep 2023 03:17:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694513829; cv=none; d=google.com; s=arc-20160816; b=l4hmOAo36ncs9RXxWDxWXtgzpON0wM4VBs+0ZV6ATY0UTL/NgTxMy2lGE/RB+YoQVl Y1U9fcu4Nh2mGqaFLTi16oicwMf9V//pZcqUPJRVmBIYaiSHz83JER6AnRONTkl9h5KW 0Bp70zOcZg6CMocFDKQP23XDF9kC1sDnR6bQdHZmvvaFqjnDfKzA1INcKe1TXzIu3ZFf bIQfgSoTV/VMlnkudd9W8LS54kIixq/6LMGE43ws1A+SN2wdE55HMJ57Fg9omOagKRLq r4/28qzi8GWJAOp6s8bQfA4D9WKDDfP8Fgb7ebal4tU8n0JdgcpoBBKl14sGXL47GNsC gvgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vuDRdpEcQdOPJO6ECwwAIvUZv3DHwFUskaWy08I+lxE=; fh=sKfwLbYyGsqFA9J5964tfV31zxizqPhzkdLiyF/udjc=; b=m+5QcgRkFLvhC6tdLG6xV0+qeu7ERpmDnZFe2LmXYUWrg3bMKp6keJos+dfLvWIPyb 71wjZipLOjweIK9vnrYXTk0NK4zReOIZz2yj1UL5cbOiIWqoh7pDXwe8CtfaK9WuAjfU qZdSYwtWHrg2RCbPtBBb/yVwhINIwgYSSCK0oHFSz033IxJZqOF4nN6zVbmsP5W/nJbe teu4pXvzSY9p9UIsNVPwUWOkC1uLClxGS/8P9/g5l4LW4E/QIH0aiG1Sx97KidrwnONQ A/80CZyZsDsHpWhKjCcVXJOKxF/mt/VZzBK9BgrEu8UxyIlkmAyUugmMlwxsPh4kc++x Epsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=R+pdXZJs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id u23-20020a63b557000000b005778df5648asi1787394pgo.319.2023.09.12.03.17.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 03:17:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=R+pdXZJs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 1325881D68FE; Tue, 12 Sep 2023 03:08:58 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233983AbjILKIq (ORCPT <rfc822;pwkd43@gmail.com> + 37 others); Tue, 12 Sep 2023 06:08:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233845AbjILKHt (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 12 Sep 2023 06:07:49 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E247310D8 for <linux-kernel@vger.kernel.org>; Tue, 12 Sep 2023 03:07:44 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-401d2e11dacso40979525e9.0 for <linux-kernel@vger.kernel.org>; Tue, 12 Sep 2023 03:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1694513263; x=1695118063; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vuDRdpEcQdOPJO6ECwwAIvUZv3DHwFUskaWy08I+lxE=; b=R+pdXZJsbg36bQS1IruCjbSCZYbDuBqAePFsDwMNtU+HYxXzxTzsvwl1OO6VhRPnQ4 j9TiBLLmFlzEMZ2Apyz5XnHZJgSkzjPB2vbaT/X5gHDKej6KL0CSdFwYITThK3ojrRoF +keT6Fyg2/WrzL2wuuugSin5ZHdZtCqhbHwFXCAh9gLtreUKHEKO6aRGmeWvAsu3wRzx V1zd3uNPJd6umy4UdJaFbEEWRX3q8ZmefA/aO3mT+Q5eEhAhgOU6ScK/irf+xxUAsjml BHwe2e2QvsW0sN1AIhiYoYhSa7vODFkCXvCXJnfmUD9oPvxaKr7/WOyr+nIn0y7eAqkR EsmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694513263; x=1695118063; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vuDRdpEcQdOPJO6ECwwAIvUZv3DHwFUskaWy08I+lxE=; b=oO1fAZTsa2TDHHWsXvCzkyu3mvothcfzuUgxy3CCydfodyWsuzyBS5g0OahQM54wBK 7SISdbJo3iO/G28vgHVCaJMRy7HZEGBF8SREb5erybirsIQW0lZCjuS+GVFXZK+FQ4+W JetrgtR2ndV4Eix2qK2OVTqwZjkJWxfoVIXmH0eYoXwfhfMMJWVB9TI+ivbogeI5j8BK a/4LjRKJvno6zhAISMcnoFbJJ2y8kCANAvDKOU60v/iWlvg+b6zf7UlVkTcMD6Ln9B89 Ui8vv4UybOY0HWtZ4U4hey3z1aYDzanidC3sYQVX02H6ZN5dktsTvfjjjc/Gw1+ueKjL 1R9w== X-Gm-Message-State: AOJu0YzimcN3y6KCQ2CdnqBNC99UTHOw60WfMSVyqh5eElIpbAD7XSjz sp6VpWNw6OlHA5Um7kh88EnM2A== X-Received: by 2002:a5d:525c:0:b0:318:720c:bb3 with SMTP id k28-20020a5d525c000000b00318720c0bb3mr1373602wrc.20.1694513263436; Tue, 12 Sep 2023 03:07:43 -0700 (PDT) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:907f:4cd7:f0ae:6b2a]) by smtp.gmail.com with ESMTPSA id h5-20020adfe985000000b0031ae8d86af4sm12351417wrm.103.2023.09.12.03.07.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 03:07:43 -0700 (PDT) From: Bartosz Golaszewski <brgl@bgdev.pl> To: Linus Walleij <linus.walleij@linaro.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Mika Westerberg <mika.westerberg@linux.intel.com> Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Subject: [PATCH v2 09/11] gpio: acpi: replace gpiochip_find() with gpio_device_find() Date: Tue, 12 Sep 2023 12:07:25 +0200 Message-Id: <20230912100727.23197-10-brgl@bgdev.pl> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230912100727.23197-1-brgl@bgdev.pl> References: <20230912100727.23197-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 12 Sep 2023 03:08:58 -0700 (PDT) X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776826532927544220 X-GMAIL-MSGID: 1776826532927544220 |
Series |
gpiolib: work towards removing gpiochip_find()
|
|
Commit Message
Bartosz Golaszewski
Sept. 12, 2023, 10:07 a.m. UTC
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> We're porting all users of gpiochip_find() to using gpio_device_find(). Update the ACPI GPIO code. Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/gpio/gpiolib-acpi.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
Comments
On Tue, Sep 12, 2023 at 12:07:25PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > We're porting all users of gpiochip_find() to using gpio_device_find(). > Update the ACPI GPIO code. ... > + /* > + * FIXME: keep track of this reference somehow instead of putting it > + * here. Under "this" you meant gdev? Please, spell it explicitly, I spent a couple of minutes to get what exactly this comment is about. > + */ > + return gpio_device_get_desc(gdev, pin); > }
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c index 17a86bdd9609..ec618962a5cb 100644 --- a/drivers/gpio/gpiolib-acpi.c +++ b/drivers/gpio/gpiolib-acpi.c @@ -143,7 +143,7 @@ static int acpi_gpiochip_find(struct gpio_chip *gc, void *data) */ static struct gpio_desc *acpi_get_gpiod(char *path, unsigned int pin) { - struct gpio_chip *chip; + struct gpio_device *gdev __free(gpio_device_put) = NULL; acpi_handle handle; acpi_status status; @@ -151,11 +151,15 @@ static struct gpio_desc *acpi_get_gpiod(char *path, unsigned int pin) if (ACPI_FAILURE(status)) return ERR_PTR(-ENODEV); - chip = gpiochip_find(handle, acpi_gpiochip_find); - if (!chip) + gdev = gpio_device_find(handle, acpi_gpiochip_find); + if (!gdev) return ERR_PTR(-EPROBE_DEFER); - return gpiochip_get_desc(chip, pin); + /* + * FIXME: keep track of this reference somehow instead of putting it + * here. + */ + return gpio_device_get_desc(gdev, pin); } /**