Message ID | 20230910140710.2167538-1-juzhe.zhong@rivai.ai |
---|---|
State | Unresolved |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ab0a:0:b0:3f2:4152:657d with SMTP id m10csp1604775vqo; Sun, 10 Sep 2023 07:07:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEvr287pkjrqi6VAZczNza5oxkGlpIc4Gop+rROkL/OtN3WgxsZaHXWObO67/WWxgaY7OFW X-Received: by 2002:aa7:c6c8:0:b0:523:2e0e:5462 with SMTP id b8-20020aa7c6c8000000b005232e0e5462mr4957140eds.42.1694354875022; Sun, 10 Sep 2023 07:07:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694354875; cv=none; d=google.com; s=arc-20160816; b=I3/k35rSJl/vCowMCDg6vK2fBEIShOv7ta5D2u2+km2Tg8TUkTg1TVxXXnL5tcdhgY pdzKRohj9hwD0DDhXmy9hPndu2tOMc5DQkXf+lNd9QhgblA6N8aRC8CY4r0BWZzmmhEl 3l68rn3g7/tvr6sZ0XTkEcqP/Buu6LtBuZfmXftoow/vQmT3lYCnL2Cljcg1fwxpj+Ec yMvP7moep9Ee7ynTkOdMsk5mxFHcrfLGSH4R0iBDTyNcTi9r57hyObHEjP8r5zn0P+FP 0zGCxg9YBs7Up2WTQMT9txviptULGbuGzLUa72QNlGNOFzBzDBQnjfMMlbJRdU0ClTyV S0yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:feedback-id :content-transfer-encoding:mime-version:message-id:date:subject:to :from:dmarc-filter:delivered-to; bh=aNYN+uQiZdQ3T2bElY0fZmaNKA6Ug7jQfwCp5Mx1Fmg=; fh=arl273cIQBNH1P6XLxHQvF0scgitfd773vOV+bwQx3o=; b=vsxQH0ViPeLdFf1GVnX03rslxXC+QYzIAZnIYB184E9IpsnFTuvVKjwIk9EcUHzQro DIgo6eSQBM820BDay3dvrkhMZoCUCjz/ucnJjv2s4SLXAaJO3Z15fa2vH6XNfFl6efFQ +RQkGFxJFjcM6VIZSq/qbIyX05CrZaKBdEiXhy0H/Nv7gZo1h7lle0witockRWRs0Uok QjXLzhL3BqdeKwcI3ToIl5XhZ6WvGxn4bJ9vweWT/uAkX6YI0yJqmHcw1joXxXSGSly0 XCHk87FW0UbI1qCBwGTVYbbMEvAGP92cV/+00mrmrq+6QX0FkyyIdU4YO4JOM1PBZ4mv K/+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id m12-20020aa7d34c000000b0052e95776ee9si4815449edr.137.2023.09.10.07.07.54 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Sep 2023 07:07:54 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7FDE73857706 for <ouuuleilei@gmail.com>; Sun, 10 Sep 2023 14:07:47 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtpbgbr1.qq.com (smtpbgbr1.qq.com [54.207.19.206]) by sourceware.org (Postfix) with ESMTPS id 7D8AE3858D33 for <gcc-patches@gcc.gnu.org>; Sun, 10 Sep 2023 14:07:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7D8AE3858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivai.ai Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivai.ai X-QQ-mid: bizesmtp71t1694354833t9bbsbpv Received: from rios-cad122.hadoop.rioslab.org ( [58.60.1.26]) by bizesmtp.qq.com (ESMTP) with id ; Sun, 10 Sep 2023 22:07:12 +0800 (CST) X-QQ-SSF: 01400000000000G0V000000A0000000 X-QQ-FEAT: CR3LFp2JE4n1H/y+htxK/nx7yOwb8u9dCI8kcpGCLkDvKKO9BHUFaf35ql7x9 fVIAl5Gb08Az/Q1oanAVgX2/iBSvrO08JsvcS4hLCGk+/nAIrRhnmIrUI+KZrwfDo8518TZ 4ej8JwcgWzk+CqIy9Y8+ZcDH99qVOwgcwdbuJUKlOjkfAx4AYzXIZYOCM0u1Mf7CLsvyppm 9yS7ZNKbo3I9A5T/pDzFsfconhollqTmmOjvxYc6W5J0iRr1HgZ8P8qve/GwdSzx7fuwh6t bJ0eo3RdNk6DLP2PZCtRUPvyRDjNX1f5FCLTpvV70YN61KWMguODaMTG+bUwvX9WuRgyPAd JWNMrRB0XkhqVa4B1VfmbhQ6i79EhLfd6BgWTfeE9T615nNZqa6y2Qiw4D2km/udTh1vzVf avbT59Xmo/0= X-QQ-GoodBg: 2 X-BIZMAIL-ID: 1288007278807360229 From: Juzhe-Zhong <juzhe.zhong@rivai.ai> To: gcc-patches@gcc.gnu.org Subject: [PATCH V2] RISC-V: Avoid unnecessary slideup in compress pattern of vec_perm Date: Sun, 10 Sep 2023 22:07:10 +0800 Message-Id: <20230910140710.2167538-1-juzhe.zhong@rivai.ai> X-Mailer: git-send-email 2.36.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:rivai.ai:qybglogicsvrgz:qybglogicsvrgz7a-one-0 X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Cc: kito.cheng@sifive.com, kito.cheng@gmail.com, Juzhe-Zhong <juzhe.zhong@rivai.ai> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776659857745921895 X-GMAIL-MSGID: 1776659857745921895 |
Series |
[V2] RISC-V: Avoid unnecessary slideup in compress pattern of vec_perm
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | warning | Git am fail log |
Commit Message
juzhe.zhong@rivai.ai
Sept. 10, 2023, 2:07 p.m. UTC
gcc/ChangeLog: * config/riscv/riscv-v.cc (shuffle_compress_patterns): Avoid unnecessary slideup. --- gcc/config/riscv/riscv-v.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Comments
Address comment: [PATCH V2] RISC-V: Avoid unnecessary slideup in compress pattern of vec_perm (gnu.org)
juzhe.zhong@rivai.ai
From: Juzhe-Zhong
Date: 2023-09-10 22:07
To: gcc-patches
CC: kito.cheng; kito.cheng; jeffreyalaw; rdapp.gcc; Juzhe-Zhong
Subject: [PATCH V2] RISC-V: Avoid unnecessary slideup in compress pattern of vec_perm
gcc/ChangeLog:
* config/riscv/riscv-v.cc (shuffle_compress_patterns): Avoid unnecessary slideup.
---
gcc/config/riscv/riscv-v.cc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gcc/config/riscv/riscv-v.cc b/gcc/config/riscv/riscv-v.cc
index bee60de1d26..3cd1f61de0e 100644
--- a/gcc/config/riscv/riscv-v.cc
+++ b/gcc/config/riscv/riscv-v.cc
@@ -2647,7 +2647,8 @@ shuffle_compress_patterns (struct expand_vec_perm_d *d)
For index = { 0, 2, 5, 6}, we need to slide op1 up before
we apply compress approach. */
- bool need_slideup_p = maybe_ne (d->perm[vlen - 1], 2 * vec_len - 1);
+ bool need_slideup_p = maybe_ne (d->perm[vlen - 1], 2 * vec_len - 1)
+ && !const_vec_duplicate_p (d->op1);
/* If we leave it directly be handled by general gather,
the code sequence will be:
--
2.36.3
On 9/10/23 08:07, Juzhe-Zhong wrote: > gcc/ChangeLog: > > * config/riscv/riscv-v.cc (shuffle_compress_patterns): Avoid unnecessary slideup. OK jeff
Committed, thanks Jeff. Pan -----Original Message----- From: Gcc-patches <gcc-patches-bounces+pan2.li=intel.com@gcc.gnu.org> On Behalf Of Jeff Law via Gcc-patches Sent: Sunday, September 10, 2023 11:25 PM To: Juzhe-Zhong <juzhe.zhong@rivai.ai>; gcc-patches@gcc.gnu.org Cc: kito.cheng@sifive.com; kito.cheng@gmail.com Subject: Re: [PATCH V2] RISC-V: Avoid unnecessary slideup in compress pattern of vec_perm On 9/10/23 08:07, Juzhe-Zhong wrote: > gcc/ChangeLog: > > * config/riscv/riscv-v.cc (shuffle_compress_patterns): Avoid unnecessary slideup. OK jeff
diff --git a/gcc/config/riscv/riscv-v.cc b/gcc/config/riscv/riscv-v.cc index bee60de1d26..3cd1f61de0e 100644 --- a/gcc/config/riscv/riscv-v.cc +++ b/gcc/config/riscv/riscv-v.cc @@ -2647,7 +2647,8 @@ shuffle_compress_patterns (struct expand_vec_perm_d *d) For index = { 0, 2, 5, 6}, we need to slide op1 up before we apply compress approach. */ - bool need_slideup_p = maybe_ne (d->perm[vlen - 1], 2 * vec_len - 1); + bool need_slideup_p = maybe_ne (d->perm[vlen - 1], 2 * vec_len - 1) + && !const_vec_duplicate_p (d->op1); /* If we leave it directly be handled by general gather, the code sequence will be: