[v1] RISC-V: Fix one typo in autovec.md pattern comment

Message ID 20230824073747.315274-1-pan2.li@intel.com
State Unresolved
Headers
Series [v1] RISC-V: Fix one typo in autovec.md pattern comment |

Checks

Context Check Description
snail/gcc-patch-check warning Git am fail log

Commit Message

Li, Pan2 via Gcc-patches Aug. 24, 2023, 7:37 a.m. UTC
  From: Pan Li <pan2.li@intel.com>

Fix below typo for the pattern comment.

vfmsac => vfnmsac
vfmsub => vfnmsub

Signed-off-by: Pan Li <pan2.li@intel.com>

gcc/ChangeLog:

	* config/riscv/autovec.md: Fix typo.
---
 gcc/config/riscv/autovec.md | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
  

Comments

Kito Cheng Aug. 24, 2023, 7:43 a.m. UTC | #1
LGTM

Pan Li via Gcc-patches <gcc-patches@gcc.gnu.org> 於 2023年8月24日 週四 15:41 寫道:

> From: Pan Li <pan2.li@intel.com>
>
> Fix below typo for the pattern comment.
>
> vfmsac => vfnmsac
> vfmsub => vfnmsub
>
> Signed-off-by: Pan Li <pan2.li@intel.com>
>
> gcc/ChangeLog:
>
>         * config/riscv/autovec.md: Fix typo.
> ---
>  gcc/config/riscv/autovec.md | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/config/riscv/autovec.md b/gcc/config/riscv/autovec.md
> index d9f1a10eb66..18950ac7c4f 100644
> --- a/gcc/config/riscv/autovec.md
> +++ b/gcc/config/riscv/autovec.md
> @@ -1258,11 +1258,11 @@ (define_insn_and_split "*fms<VF:mode><P:mode>"
>     (set (attr "frm_mode") (symbol_ref "riscv_vector::FRM_DYN"))])
>
>  ;;
> -------------------------------------------------------------------------
> -;; ---- [FP] VFMSAC and VFMSUB
> +;; ---- [FP] VFNMSAC and VFNMSUB
>  ;;
> -------------------------------------------------------------------------
>  ;; Includes:
> -;; - vfmsac
> -;; - vfmsub
> +;; - vfnmsac
> +;; - vfnmsub
>  ;;
> -------------------------------------------------------------------------
>
>  (define_expand "fnms<mode>4"
> --
> 2.34.1
>
>
  
Li, Pan2 via Gcc-patches Aug. 24, 2023, 7:53 a.m. UTC | #2
Thanks Kito. Looks need some additional change and will send the V2 for this.

Pan

From: Kito Cheng <kito.cheng@gmail.com>
Sent: Thursday, August 24, 2023 3:44 PM
To: Li, Pan2 <pan2.li@intel.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>; 钟居哲 <juzhe.zhong@rivai.ai>; Wang, Yanzhang <yanzhang.wang@intel.com>
Subject: Re: [PATCH v1] RISC-V: Fix one typo in autovec.md pattern comment

LGTM

Pan Li via Gcc-patches <gcc-patches@gcc.gnu.org<mailto:gcc-patches@gcc.gnu.org>> 於 2023年8月24日 週四 15:41 寫道:
From: Pan Li <pan2.li@intel.com<mailto:pan2.li@intel.com>>

Fix below typo for the pattern comment.

vfmsac => vfnmsac
vfmsub => vfnmsub

Signed-off-by: Pan Li <pan2.li@intel.com<mailto:pan2.li@intel.com>>

gcc/ChangeLog:

        * config/riscv/autovec.md: Fix typo.
---
 gcc/config/riscv/autovec.md | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gcc/config/riscv/autovec.md b/gcc/config/riscv/autovec.md
index d9f1a10eb66..18950ac7c4f 100644
--- a/gcc/config/riscv/autovec.md
+++ b/gcc/config/riscv/autovec.md
@@ -1258,11 +1258,11 @@ (define_insn_and_split "*fms<VF:mode><P:mode>"
    (set (attr "frm_mode") (symbol_ref "riscv_vector::FRM_DYN"))])

 ;; -------------------------------------------------------------------------
-;; ---- [FP] VFMSAC and VFMSUB
+;; ---- [FP] VFNMSAC and VFNMSUB
 ;; -------------------------------------------------------------------------
 ;; Includes:
-;; - vfmsac
-;; - vfmsub
+;; - vfnmsac
+;; - vfnmsub
 ;; -------------------------------------------------------------------------

 (define_expand "fnms<mode>4"
--
2.34.1
  

Patch

diff --git a/gcc/config/riscv/autovec.md b/gcc/config/riscv/autovec.md
index d9f1a10eb66..18950ac7c4f 100644
--- a/gcc/config/riscv/autovec.md
+++ b/gcc/config/riscv/autovec.md
@@ -1258,11 +1258,11 @@  (define_insn_and_split "*fms<VF:mode><P:mode>"
    (set (attr "frm_mode") (symbol_ref "riscv_vector::FRM_DYN"))])
 
 ;; -------------------------------------------------------------------------
-;; ---- [FP] VFMSAC and VFMSUB
+;; ---- [FP] VFNMSAC and VFNMSUB
 ;; -------------------------------------------------------------------------
 ;; Includes:
-;; - vfmsac
-;; - vfmsub
+;; - vfnmsac
+;; - vfnmsub
 ;; -------------------------------------------------------------------------
 
 (define_expand "fnms<mode>4"