RISC-V: output Autovec params explicitly in --help ...

Message ID 20230822174031.782900-1-vineetg@rivosinc.com
State Accepted
Headers
Series RISC-V: output Autovec params explicitly in --help ... |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Vineet Gupta Aug. 22, 2023, 5:40 p.m. UTC
  ... otherwise user has no clue what -param to actually change

gcc/ChangeLog:
	* config/riscv/riscv.opt: Add --param names
	  riscv-autovec-preference and riscv-autovec-lmul

Signed-off-by: Vineet Gupta <vineetg@rivosinc.com>
---
 gcc/config/riscv/riscv.opt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Jeff Law Aug. 22, 2023, 5:59 p.m. UTC | #1
On 8/22/23 11:40, Vineet Gupta wrote:
> ... otherwise user has no clue what -param to actually change
> 
> gcc/ChangeLog:
> 	* config/riscv/riscv.opt: Add --param names
> 	  riscv-autovec-preference and riscv-autovec-lmul
OK
jeff
  
Palmer Dabbelt Aug. 22, 2023, 6:07 p.m. UTC | #2
On Tue, 22 Aug 2023 10:59:35 PDT (-0700), gcc-patches@gcc.gnu.org wrote:
>
>
> On 8/22/23 11:40, Vineet Gupta wrote:
>> ... otherwise user has no clue what -param to actually change
>>
>> gcc/ChangeLog:
>> 	* config/riscv/riscv.opt: Add --param names
>> 	  riscv-autovec-preference and riscv-autovec-lmul
> OK

We should probably put them in invoke.texi as well (and anything else 
we're missing that's been added recently).
  
Vineet Gupta Aug. 22, 2023, 6:11 p.m. UTC | #3
On 8/22/23 11:07, Palmer Dabbelt wrote:
> We should probably put them in invoke.texi as well (and anything else 
> we're missing that's been added recently). 

Looks like I'd pushed the patch already.
A whole bunch of them are missing, so guess that can happen seperately.

-Vineet
  

Patch

diff --git a/gcc/config/riscv/riscv.opt b/gcc/config/riscv/riscv.opt
index 6304efebfd50..a962ea8f9d41 100644
--- a/gcc/config/riscv/riscv.opt
+++ b/gcc/config/riscv/riscv.opt
@@ -277,7 +277,7 @@  Always inline subword atomic operations.
 
 Enum
 Name(riscv_autovec_preference) Type(enum riscv_autovec_preference_enum)
-The RISC-V auto-vectorization preference:
+Valid arguments to -param=riscv-autovec-preference=:
 
 EnumValue
 Enum(riscv_autovec_preference) String(none) Value(NO_AUTOVEC)
@@ -294,7 +294,7 @@  Target RejectNegative Joined Enum(riscv_autovec_preference) Var(riscv_autovec_pr
 
 Enum
 Name(riscv_autovec_lmul) Type(enum riscv_autovec_lmul_enum)
-The RVV possible LMUL:
+The RVV possible LMUL (-param=riscv-autovec-lmul=):
 
 EnumValue
 Enum(riscv_autovec_lmul) String(m1) Value(RVV_M1)