diff mbox series

[1/2] f2fs: doc: fix description of max_small_discards

Message ID 20230730142552.3918623-1-chao@kernel.org
State New
Headers
Series [1/2] f2fs: doc: fix description of max_small_discards |

Commit Message

Chao Yu July 30, 2023, 2:25 p.m. UTC 
  The description of max_small_discards is out-of-update in below two
aspects, fix it.
- it is disabled by default
- small discards will be issued during checkpoint

Signed-off-by: Chao Yu <chao@kernel.org>
---
 Documentation/ABI/testing/sysfs-fs-f2fs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Chao Yu Aug. 17, 2023, 3:21 p.m. UTC | #1 
Ping,

On 2023/7/30 22:25, Chao Yu wrote:
> The description of max_small_discards is out-of-update in below two
> aspects, fix it.
> - it is disabled by default
> - small discards will be issued during checkpoint
> 
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
>   Documentation/ABI/testing/sysfs-fs-f2fs | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testing/sysfs-fs-f2fs
> index ad3d76d37c8b..36c3cb547901 100644
> --- a/Documentation/ABI/testing/sysfs-fs-f2fs
> +++ b/Documentation/ABI/testing/sysfs-fs-f2fs
> @@ -102,9 +102,9 @@ What:		/sys/fs/f2fs/<disk>/max_small_discards
>   Date:		November 2013
>   Contact:	"Jaegeuk Kim" <jaegeuk.kim@samsung.com>
>   Description:	Controls the issue rate of discard commands that consist of small
> -		blocks less than 2MB. The candidates to be discarded are cached until
> -		checkpoint is triggered, and issued during the checkpoint.
> -		By default, it is disabled with 0.
> +		blocks less than 2MB. The candidates to be discarded are cached during
> +		checkpoint, and issued by issue_discard thread after checkpoint.
> +		It is enabled by default.
>   
>   What:		/sys/fs/f2fs/<disk>/max_ordered_discard
>   Date:		October 2022
Jaegeuk Kim Aug. 18, 2023, 9:29 p.m. UTC | #2 
Let me apply this and see what'll happen later, since no luck to reproduce.

On 08/17, Chao Yu wrote:
> Ping,
> 
> On 2023/7/30 22:25, Chao Yu wrote:
> > The description of max_small_discards is out-of-update in below two
> > aspects, fix it.
> > - it is disabled by default
> > - small discards will be issued during checkpoint
> > 
> > Signed-off-by: Chao Yu <chao@kernel.org>
> > ---
> >   Documentation/ABI/testing/sysfs-fs-f2fs | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testing/sysfs-fs-f2fs
> > index ad3d76d37c8b..36c3cb547901 100644
> > --- a/Documentation/ABI/testing/sysfs-fs-f2fs
> > +++ b/Documentation/ABI/testing/sysfs-fs-f2fs
> > @@ -102,9 +102,9 @@ What:		/sys/fs/f2fs/<disk>/max_small_discards
> >   Date:		November 2013
> >   Contact:	"Jaegeuk Kim" <jaegeuk.kim@samsung.com>
> >   Description:	Controls the issue rate of discard commands that consist of small
> > -		blocks less than 2MB. The candidates to be discarded are cached until
> > -		checkpoint is triggered, and issued during the checkpoint.
> > -		By default, it is disabled with 0.
> > +		blocks less than 2MB. The candidates to be discarded are cached during
> > +		checkpoint, and issued by issue_discard thread after checkpoint.
> > +		It is enabled by default.
> >   What:		/sys/fs/f2fs/<disk>/max_ordered_discard
> >   Date:		October 2022
patchwork-bot+f2fs@kernel.org Aug. 21, 2023, 7:50 p.m. UTC | #3 
Hello:

This series was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <jaegeuk@kernel.org>:

On Sun, 30 Jul 2023 22:25:51 +0800 you wrote:
> The description of max_small_discards is out-of-update in below two
> aspects, fix it.
> - it is disabled by default
> - small discards will be issued during checkpoint
> 
> Signed-off-by: Chao Yu <chao@kernel.org>
> 
> [...]

Here is the summary with links:
  - [f2fs-dev,1/2] f2fs: doc: fix description of max_small_discards
    https://git.kernel.org/jaegeuk/f2fs/c/726865e69aa3
  - [f2fs-dev,2/2] Revert "f2fs: do not issue small discard commands during checkpoint"
    https://git.kernel.org/jaegeuk/f2fs/c/005abf9e5e0d

You are awesome, thank you!
diff mbox series

Patch

diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testing/sysfs-fs-f2fs
index ad3d76d37c8b..36c3cb547901 100644
--- a/Documentation/ABI/testing/sysfs-fs-f2fs
+++ b/Documentation/ABI/testing/sysfs-fs-f2fs
@@ -102,9 +102,9 @@  What:		/sys/fs/f2fs/<disk>/max_small_discards
 Date:		November 2013
 Contact:	"Jaegeuk Kim" <jaegeuk.kim@samsung.com>
 Description:	Controls the issue rate of discard commands that consist of small
-		blocks less than 2MB. The candidates to be discarded are cached until
-		checkpoint is triggered, and issued during the checkpoint.
-		By default, it is disabled with 0.
+		blocks less than 2MB. The candidates to be discarded are cached during
+		checkpoint, and issued by issue_discard thread after checkpoint.
+		It is enabled by default.
 
 What:		/sys/fs/f2fs/<disk>/max_ordered_discard
 Date:		October 2022