[V4,1/2] arm64: dts: qcom: sc7280: Mark all Qualcomm reference boards as LTE

Message ID 20221110070813.1777-1-quic_sibis@quicinc.com
State New
Headers
Series [V4,1/2] arm64: dts: qcom: sc7280: Mark all Qualcomm reference boards as LTE |

Commit Message

Sibi Sankar Nov. 10, 2022, 7:08 a.m. UTC
  When the modem node was re-located to a separate LTE source file
"sc7280-herobrine-lte-sku.dtsi", some of the previous LTE users
weren't marked appropriately. Fix this by marking all Qualcomm
reference devices as LTE.

Suggested-by: Douglas Anderson <dianders@chromium.org>
Fixes: d42fae738f3a ("arm64: dts: qcom: Add LTE SKUs for sc7280-villager family")
Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
---

v4:
 * Remove duplicate lte source file [Doug]

v3:
 * Fix incorrect tag usage [Krzysztof]

 arch/arm64/boot/dts/qcom/sc7280-idp.dts  | 1 -
 arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)
  

Comments

Doug Anderson Nov. 10, 2022, 4:22 p.m. UTC | #1
Hi,

On Wed, Nov 9, 2022 at 11:08 PM Sibi Sankar <quic_sibis@quicinc.com> wrote:
>
> When the modem node was re-located to a separate LTE source file
> "sc7280-herobrine-lte-sku.dtsi", some of the previous LTE users
> weren't marked appropriately. Fix this by marking all Qualcomm
> reference devices as LTE.
>
> Suggested-by: Douglas Anderson <dianders@chromium.org>
> Fixes: d42fae738f3a ("arm64: dts: qcom: Add LTE SKUs for sc7280-villager family")
> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
> ---
>
> v4:
>  * Remove duplicate lte source file [Doug]
>
> v3:
>  * Fix incorrect tag usage [Krzysztof]
>
>  arch/arm64/boot/dts/qcom/sc7280-idp.dts  | 1 -
>  arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 1 +
>  2 files changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Douglas Anderson <dianders@chromium.org>
  
Bjorn Andersson Nov. 12, 2022, 3:51 a.m. UTC | #2
On Thu, 10 Nov 2022 12:38:12 +0530, Sibi Sankar wrote:
> When the modem node was re-located to a separate LTE source file
> "sc7280-herobrine-lte-sku.dtsi", some of the previous LTE users
> weren't marked appropriately. Fix this by marking all Qualcomm
> reference devices as LTE.
> 
> 

Applied, thanks!

[1/2] arm64: dts: qcom: sc7280: Mark all Qualcomm reference boards as LTE
      commit: 3c800bcf07a5957da01593e8f83d797b285a37e0
[2/2] arm64: dts: qcom: sc7280: Add Google Herobrine WIFI SKU dts fragment
      commit: 87548e54b86e06190e018665bd77528f72038fbe

Best regards,
  

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
index 9ddfdfdd354e..ba64316b4427 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
@@ -10,7 +10,6 @@ 
 #include <dt-bindings/iio/qcom,spmi-adc7-pmr735a.h>
 #include "sc7280-idp.dtsi"
 #include "pmr735a.dtsi"
-#include "sc7280-herobrine-lte-sku.dtsi"
 
 / {
 	model = "Qualcomm Technologies, Inc. sc7280 IDP SKU1 platform";
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
index 1ac7c091e03f..8ca228111681 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
@@ -13,6 +13,7 @@ 
 #include "pmk8350.dtsi"
 
 #include "sc7280-chrome-common.dtsi"
+#include "sc7280-herobrine-lte-sku.dtsi"
 
 / {
 	aliases {