Makefile.in: Make recog.h depend on $(TREE_H)

Message ID 85917744-79f6-2752-98a3-13c19c9fc65c@linux.ibm.com
State Not Applicable
Headers
Series Makefile.in: Make recog.h depend on $(TREE_H) |

Checks

Context Check Description
snail/gcc-patch-check fail Git am fail log

Commit Message

Kewen.Lin Aug. 15, 2023, 3:13 a.m. UTC
  Hi,

Commit r14-3093 introduced a random build failure on
build/gencondmd.cc building.  Since r14-3093 makes recog.h
include tree.h, which further includes (depends on) some
files that are generated during the building, such as:
all-tree.def, tree-check.h etc, when building file
build/gencondmd.cc, the build can fail if these dependencies
are not ready.  So this patch is to teach this dependence.

Thank Jan-Benedict Glaw for testing this!

gcc/ChangeLog:

        * Makefile.in (RECOG_H): Add $(TREE_H) as dependence.
---
 gcc/Makefile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.31.1
  

Comments

Richard Biener Aug. 15, 2023, 7:53 a.m. UTC | #1
On Tue, Aug 15, 2023 at 5:13 AM Kewen.Lin <linkw@linux.ibm.com> wrote:
>
> Hi,
>
> Commit r14-3093 introduced a random build failure on
> build/gencondmd.cc building.  Since r14-3093 makes recog.h
> include tree.h, which further includes (depends on) some
> files that are generated during the building, such as:
> all-tree.def, tree-check.h etc, when building file
> build/gencondmd.cc, the build can fail if these dependencies
> are not ready.  So this patch is to teach this dependence.
>
> Thank Jan-Benedict Glaw for testing this!

OK.

> gcc/ChangeLog:
>
>         * Makefile.in (RECOG_H): Add $(TREE_H) as dependence.
> ---
>  gcc/Makefile.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/Makefile.in b/gcc/Makefile.in
> index 2429128cbf2..9dddb65b45d 100644
> --- a/gcc/Makefile.in
> +++ b/gcc/Makefile.in
> @@ -991,7 +991,7 @@ GIMPLE_H = gimple.h gimple.def gsstruct.def $(VEC_H) \
>         $(GGC_H) $(BASIC_BLOCK_H) $(TREE_H) tree-ssa-operands.h \
>         tree-ssa-alias.h $(INTERNAL_FN_H) $(HASH_TABLE_H) is-a.h
>  GCOV_IO_H = gcov-io.h version.h auto-host.h gcov-counter.def
> -RECOG_H = recog.h
> +RECOG_H = recog.h $(TREE_H)
>  EMIT_RTL_H = emit-rtl.h
>  FLAGS_H = flags.h flag-types.h $(OPTIONS_H)
>  OPTIONS_H = options.h flag-types.h $(OPTIONS_H_EXTRA)
> --
> 2.31.1
  

Patch

diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index 2429128cbf2..9dddb65b45d 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -991,7 +991,7 @@  GIMPLE_H = gimple.h gimple.def gsstruct.def $(VEC_H) \
        $(GGC_H) $(BASIC_BLOCK_H) $(TREE_H) tree-ssa-operands.h \
        tree-ssa-alias.h $(INTERNAL_FN_H) $(HASH_TABLE_H) is-a.h
 GCOV_IO_H = gcov-io.h version.h auto-host.h gcov-counter.def
-RECOG_H = recog.h
+RECOG_H = recog.h $(TREE_H)
 EMIT_RTL_H = emit-rtl.h
 FLAGS_H = flags.h flag-types.h $(OPTIONS_H)
 OPTIONS_H = options.h flag-types.h $(OPTIONS_H_EXTRA)