[1/7] dt-bindings: arm: qcom: Document MSM8x26-based Lumia phones

Message ID 20230811213728.23726-2-rayyan@ansari.sh
State New
Headers
Series Initial support for MSM8x26 Lumias |

Commit Message

Rayyan Ansari Aug. 11, 2023, 9:35 p.m. UTC
  Document MSM8226 and MSM8926 Lumias.

Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 9 +++++++++
 1 file changed, 9 insertions(+)
  

Comments

Konrad Dybcio Aug. 11, 2023, 10:58 p.m. UTC | #1
On 11.08.2023 23:35, Rayyan Ansari wrote:
> Document MSM8226 and MSM8926 Lumias.
> 
> Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 450f616774e0..ea4b1c530461 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -181,9 +181,18 @@ properties:
>  
>        - items:
>            - enum:
> +              - microsoft,dempsey
> +              - microsoft,makepeace
> +              - microsoft,moneypenny
>                - samsung,s3ve3g
>            - const: qcom,msm8226
>  
> +      - items:
> +          - enum:
> +              - microsoft,superman-lte
The '9' in msm8926 means "LTE".. is there a non-LTE superman?

Konrad
  
Rayyan Ansari Aug. 12, 2023, 11:50 a.m. UTC | #2
On 11/08/2023 23:58, Konrad Dybcio wrote:
> On 11.08.2023 23:35, Rayyan Ansari wrote:
>> Document MSM8226 and MSM8926 Lumias.
>>
>> Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
>> ---
>>   Documentation/devicetree/bindings/arm/qcom.yaml | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index 450f616774e0..ea4b1c530461 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -181,9 +181,18 @@ properties:
>>   
>>         - items:
>>             - enum:
>> +              - microsoft,dempsey
>> +              - microsoft,makepeace
>> +              - microsoft,moneypenny
>>                 - samsung,s3ve3g
>>             - const: qcom,msm8226
>>   
>> +      - items:
>> +          - enum:
>> +              - microsoft,superman-lte
> The '9' in msm8926 means "LTE".. is there a non-LTE superman?
Yes, Lumia 730, based on MSM8226.
I didn't just make up this codename, the 735 is called superman_lte in 
internal files.

> 
> Konrad
  
Conor Dooley Aug. 13, 2023, 9:47 a.m. UTC | #3
On Sat, Aug 12, 2023 at 12:50:28PM +0100, Rayyan Ansari wrote:
> On 11/08/2023 23:58, Konrad Dybcio wrote:
> > On 11.08.2023 23:35, Rayyan Ansari wrote:
> > > Document MSM8226 and MSM8926 Lumias.
> > > 
> > > Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
> > > ---
> > >   Documentation/devicetree/bindings/arm/qcom.yaml | 9 +++++++++
> > >   1 file changed, 9 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> > > index 450f616774e0..ea4b1c530461 100644
> > > --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> > > @@ -181,9 +181,18 @@ properties:
> > >         - items:
> > >             - enum:
> > > +              - microsoft,dempsey
> > > +              - microsoft,makepeace
> > > +              - microsoft,moneypenny
> > >                 - samsung,s3ve3g
> > >             - const: qcom,msm8226
> > > +      - items:
> > > +          - enum:
> > > +              - microsoft,superman-lte
> > The '9' in msm8926 means "LTE".. is there a non-LTE superman?
> Yes, Lumia 730, based on MSM8226.
> I didn't just make up this codename, the 735 is called superman_lte in
> internal files.

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
  

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 450f616774e0..ea4b1c530461 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -181,9 +181,18 @@  properties:
 
       - items:
           - enum:
+              - microsoft,dempsey
+              - microsoft,makepeace
+              - microsoft,moneypenny
               - samsung,s3ve3g
           - const: qcom,msm8226
 
+      - items:
+          - enum:
+              - microsoft,superman-lte
+              - microsoft,tesla
+          - const: qcom,msm8926
+
       - items:
           - enum:
               - sony,kanuti-tulip