Message ID | 20230811170049.308866-10-frederic@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b824:0:b0:3f2:4152:657d with SMTP id z4csp1256951vqi; Fri, 11 Aug 2023 10:46:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH50sn5CWN4G4KA7QMkjat9ctv6f72yfI0vskJ6GezBYpfjO2VnO1Is5yN40pX4/r4/zpzJ X-Received: by 2002:a05:6a21:78a6:b0:141:d594:c85d with SMTP id bf38-20020a056a2178a600b00141d594c85dmr3204550pzc.0.1691775976257; Fri, 11 Aug 2023 10:46:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691775976; cv=none; d=google.com; s=arc-20160816; b=tVrGJ5C+OEgTEwD7U2Q5I4tt4dSNzLHCNm2Mda9v9AgU2P7Hx9InhV0x1Q/JXruyIz Ok7Ln2KhK72ItQEirLtrSNsjPsImMu8DxLetzM9ENoyzSzMiYRcXBAwsQ+0mgkYM8UQ8 dHWWQpPUEggQu3dxQ5L7v1Fji5yfBdJVmwQLJ2+JQW9HDipkwOmcMPio7qZY/XrBhfgs AqVnfdflSK8HH8hHt8h9maGy2sAett9Qi4l8e0u8WDG8MP1dPVlroZUt0CyrDRi8wj0X lN7UrEJ06LzYb0erdOzshLGEeWZ1AYU6FB5hSpi73UkXaz+IPKEC0LGjaVu6fXo8fFsW mYAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=IJRHoT4fhes4GgaWroXMPjpCYA8l4Ixor+bhxWQVlig=; fh=B15Ov2cShcY+dslvQFXR3OOrlAZYP5T4L/0y7SElBZE=; b=0mp2UKJGcV1sGjqplTjvlFYti6ZeSe2uIDy15g/eBfQ4BRge3TtmwYFZkab3X3sKVD FpmKm/zVyPm/NyEUQ41mkHO6AXb6pmrnsr6xCDsN9uKN/i3cmACuTPfEfU/zM/XKImG9 JNq84KEO4LMdRvHVOukIKkebZUwUHdb5F+Gw81OsFXc4wRBYKWAl290EBBNaVx7Y9MiJ wh8wqPIZeco/riC9ydcTVW6GvlYGQyjMtgR03edXzEOiMWyGLygV3+FUSbxKgJru65TG 4fj/rI21KJzDdo+1+O1ETuAH5vxaWyw1rkC5V9NPSIgk9dUljUaBHVLkj6Yp2AXUwCiD MIhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tsZvUQ8y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b20-20020a656694000000b00565333417aesi3745785pgw.108.2023.08.11.10.46.01; Fri, 11 Aug 2023 10:46:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tsZvUQ8y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236272AbjHKRBq (ORCPT <rfc822;lanlanxiyiji@gmail.com> + 99 others); Fri, 11 Aug 2023 13:01:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236258AbjHKRBT (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 11 Aug 2023 13:01:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D34C30F4 for <linux-kernel@vger.kernel.org>; Fri, 11 Aug 2023 10:01:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B406B65816 for <linux-kernel@vger.kernel.org>; Fri, 11 Aug 2023 17:01:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A9C4C433CC; Fri, 11 Aug 2023 17:01:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691773275; bh=MZmgDtu6USFXQ4e5nMMY/JREFBhjkYnO2RkDI2BMkjU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tsZvUQ8ySYF4A2/3RW0XnSo8R5YkRZYqdUrubU/I4yprZB7EkuAc8o0ZDWS6CgdIj /pti4fyBFMT4Sv5SBTP1DZ9IRU8YcGYdjcDmsKDoZ/rHHBT5zmVCoPU9Q3MjhOn8/C E9AuFAiCgmS2cl/iDyxSVbPN47DpkxdEM6o8+FBYHd0GnoMFW3PT3fUriTZ71egoNH by8fx8X7n9VDlixdvztUxnZdl4Hwp0qoCeTXDXltjXgxrB/tHMV9Q2f0oVRYsGAPD4 xUhRjxJQ6Bdp+cro5zKPo1PCtBsS9f+d30qWxh2lr1VXdSqk/+Te1ThPAtMV016YG5 4HiBbDkUAESlA== From: Frederic Weisbecker <frederic@kernel.org> To: LKML <linux-kernel@vger.kernel.org> Cc: Frederic Weisbecker <frederic@kernel.org>, Len Brown <lenb@kernel.org>, Peter Zijlstra <peterz@infradead.org>, "Rafael J . Wysocki" <rafael@kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, Thomas Gleixner <tglx@linutronix.de>, Anna-Maria Behnsen <anna-maria@linutronix.de> Subject: [PATCH 09/10] x86: Remove the current_clr_polling() call upon mwait exit Date: Fri, 11 Aug 2023 19:00:48 +0200 Message-Id: <20230811170049.308866-10-frederic@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230811170049.308866-1-frederic@kernel.org> References: <20230811170049.308866-1-frederic@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773955686264732693 X-GMAIL-MSGID: 1773955686264732693 |
Series |
timers/cpuidle: Fixes and cleanups
|
|
Commit Message
Frederic Weisbecker
Aug. 11, 2023, 5 p.m. UTC
mwait_idle_with_hints() is mostly called from cpuidle which already sets
back TIF_NR_POLLING and fold TIF_NEED_RESCHED if necessary.
The only non-cpuidle caller is power_saving_thread() which acts as an idle
loop and is the only reason why mwait_idle_with_hints() carries a costly
fully ordered atomic operation upon idle exit.
Make this overhead proper to power_saving_thread() instead which already
duplicates quite some cpuidle code.
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
---
arch/x86/include/asm/mwait.h | 1 -
drivers/acpi/acpi_pad.c | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
Comments
On Fri, Aug 11, 2023 at 7:01 PM Frederic Weisbecker <frederic@kernel.org> wrote: > > mwait_idle_with_hints() is mostly called from cpuidle which already sets > back TIF_NR_POLLING and fold TIF_NEED_RESCHED if necessary. > > The only non-cpuidle caller is power_saving_thread() which acts as an idle > loop and is the only reason why mwait_idle_with_hints() carries a costly > fully ordered atomic operation upon idle exit. > > Make this overhead proper to power_saving_thread() instead which already > duplicates quite some cpuidle code. > > Signed-off-by: Frederic Weisbecker <frederic@kernel.org> Acked-by: Rafael J. Wysocki <rafael@kernel.org> > --- > arch/x86/include/asm/mwait.h | 1 - > drivers/acpi/acpi_pad.c | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/include/asm/mwait.h b/arch/x86/include/asm/mwait.h > index 920426d691ce..c1be3775b94a 100644 > --- a/arch/x86/include/asm/mwait.h > +++ b/arch/x86/include/asm/mwait.h > @@ -134,7 +134,6 @@ static __always_inline void mwait_idle_with_hints(unsigned long eax, unsigned lo > } > } > } > - current_clr_polling(); > } > > /* > diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c > index 7a453c5ff303..5a44afafe185 100644 > --- a/drivers/acpi/acpi_pad.c > +++ b/drivers/acpi/acpi_pad.c > @@ -174,6 +174,7 @@ static int power_saving_thread(void *data) > stop_critical_timings(); > > mwait_idle_with_hints(power_saving_mwait_eax, 1); > + current_clr_polling(); > > start_critical_timings(); > tick_broadcast_exit(); > -- > 2.34.1 >
diff --git a/arch/x86/include/asm/mwait.h b/arch/x86/include/asm/mwait.h index 920426d691ce..c1be3775b94a 100644 --- a/arch/x86/include/asm/mwait.h +++ b/arch/x86/include/asm/mwait.h @@ -134,7 +134,6 @@ static __always_inline void mwait_idle_with_hints(unsigned long eax, unsigned lo } } } - current_clr_polling(); } /* diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c index 7a453c5ff303..5a44afafe185 100644 --- a/drivers/acpi/acpi_pad.c +++ b/drivers/acpi/acpi_pad.c @@ -174,6 +174,7 @@ static int power_saving_thread(void *data) stop_critical_timings(); mwait_idle_with_hints(power_saving_mwait_eax, 1); + current_clr_polling(); start_critical_timings(); tick_broadcast_exit();