[v2,6/6] arm64: dts: qcom: apq8016-sbc: Enable camss for non-mezzanine cases

Message ID 20230809202343.1098425-7-bryan.odonoghue@linaro.org
State New
Headers
Series apq8016: camss: Update dts with various fixes |

Commit Message

Bryan O'Donoghue Aug. 9, 2023, 8:23 p.m. UTC
  When we have no camera mezzanine attached it is still possible to run the
test-pattern generator of the CSID block.

As an example:

media-ctl --reset

yavta --no-query -w '0x009f0903 1' /dev/v4l-subdev2
yavta --list /dev/v4l-subdev2

media-ctl -d /dev/media0 -V '"msm_csid0":0[fmt:UYVY8_1X16/1920x1080 field:none]'
media-ctl -l '"msm_csid0":1->"msm_ispif0":0[1]'
media-ctl -d /dev/media0 -V '"msm_ispif0":0[fmt:UYVY8_1X16/1920x1080 field:none]'
media-ctl -l '"msm_ispif0":1->"msm_vfe0_rdi0":0[1]'
media-ctl -d /dev/media0 -V '"msm_vfe0_rdi0":0[fmt:UYVY8_1X16/1920x1080]'
media-ctl -d /dev/media0 -p

yavta -B capture-mplane --capture=5 -n 5 -I -f UYVY -s 1920x1080 --file=TPG-UYVU-1920x1080-000-#.bin /dev/video0

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)
  

Comments

Konrad Dybcio Aug. 10, 2023, 1:32 p.m. UTC | #1
On 9.08.2023 22:23, Bryan O'Donoghue wrote:
> When we have no camera mezzanine attached it is still possible to run the
> test-pattern generator of the CSID block.
> 
> As an example:
> 
> media-ctl --reset
> 
> yavta --no-query -w '0x009f0903 1' /dev/v4l-subdev2
> yavta --list /dev/v4l-subdev2
> 
> media-ctl -d /dev/media0 -V '"msm_csid0":0[fmt:UYVY8_1X16/1920x1080 field:none]'
> media-ctl -l '"msm_csid0":1->"msm_ispif0":0[1]'
> media-ctl -d /dev/media0 -V '"msm_ispif0":0[fmt:UYVY8_1X16/1920x1080 field:none]'
> media-ctl -l '"msm_ispif0":1->"msm_vfe0_rdi0":0[1]'
> media-ctl -d /dev/media0 -V '"msm_vfe0_rdi0":0[fmt:UYVY8_1X16/1920x1080]'
> media-ctl -d /dev/media0 -p
> 
> yavta -B capture-mplane --capture=5 -n 5 -I -f UYVY -s 1920x1080 --file=TPG-UYVU-1920x1080-000-#.bin /dev/video0
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
Hm.. perhaps the ports could be just defined in soc dtsi?

Konrad
  
Bryan O'Donoghue Aug. 10, 2023, 2:40 p.m. UTC | #2
On 10/08/2023 14:32, Konrad Dybcio wrote:
> On 9.08.2023 22:23, Bryan O'Donoghue wrote:
>> When we have no camera mezzanine attached it is still possible to run the
>> test-pattern generator of the CSID block.
>>
>> As an example:
>>
>> media-ctl --reset
>>
>> yavta --no-query -w '0x009f0903 1' /dev/v4l-subdev2
>> yavta --list /dev/v4l-subdev2
>>
>> media-ctl -d /dev/media0 -V '"msm_csid0":0[fmt:UYVY8_1X16/1920x1080 field:none]'
>> media-ctl -l '"msm_csid0":1->"msm_ispif0":0[1]'
>> media-ctl -d /dev/media0 -V '"msm_ispif0":0[fmt:UYVY8_1X16/1920x1080 field:none]'
>> media-ctl -l '"msm_ispif0":1->"msm_vfe0_rdi0":0[1]'
>> media-ctl -d /dev/media0 -V '"msm_vfe0_rdi0":0[fmt:UYVY8_1X16/1920x1080]'
>> media-ctl -d /dev/media0 -p
>>
>> yavta -B capture-mplane --capture=5 -n 5 -I -f UYVY -s 1920x1080 --file=TPG-UYVU-1920x1080-000-#.bin /dev/video0
>>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> ---
> Hm.. perhaps the ports could be just defined in soc dtsi?
> 
> Konrad

yeah they should be.
  

Patch

diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
index 84641925f3329..4f9d6f6ec1157 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
@@ -250,6 +250,16 @@  &blsp_uart2 {
 	label = "LS-UART1";
 };
 
+&camss {
+	status = "okay";
+
+	ports {
+		port@0 {
+			reg = <0>;
+		};
+	};
+};
+
 &lpass {
 	status = "okay";
 };