[v1,1/5] dt-bindings: sound: gtm601: Add description

Message ID b6e85fdfaa87d7684a120ccedc1e07d8fe87957f.1691606520.git.agx@sigxcpu.org
State New
Headers
Series Device tree and config updates for the Librem 5 devkit |

Commit Message

Guido Günther Aug. 9, 2023, 6:50 p.m. UTC
  This allows to us to document the channel and sampling
rate requirements.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
 Documentation/devicetree/bindings/sound/option,gtm601.yaml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
  

Comments

David Heidelberg Aug. 10, 2023, 3:59 a.m. UTC | #1
On 09/08/2023 20:50, Guido Günther wrote:
> This allows to us to document the channel and sampling
> rate requirements.
>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>

Thank you!

Reviewed-by: David Heidelberg <david@ixit.cz>

> ---
>   Documentation/devicetree/bindings/sound/option,gtm601.yaml | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
  
Conor Dooley Aug. 10, 2023, 3:41 p.m. UTC | #2
On Wed, Aug 09, 2023 at 08:50:10PM +0200, Guido Günther wrote:
> This allows to us to document the channel and sampling
> rate requirements.
> 
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
>  Documentation/devicetree/bindings/sound/option,gtm601.yaml | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/option,gtm601.yaml b/Documentation/devicetree/bindings/sound/option,gtm601.yaml
> index 69c2ccc79dc5..ff813d97fc59 100644
> --- a/Documentation/devicetree/bindings/sound/option,gtm601.yaml
> +++ b/Documentation/devicetree/bindings/sound/option,gtm601.yaml
> @@ -16,10 +16,12 @@ description: >
>  properties:
>    compatible:
>      oneOf:
> -      - items:  # 48 kHz stereo
> +      - description: Broadmobi BM818 (48Khz stereo)
> +        items:
>            - const: broadmobi,bm818
>            - const: option,gtm601
> -      - const: option,gtm601  # 8 kHz mono
> +      - description: GTM601 (8kHz mono)
> +        const: option,gtm601

Makes little odds IMO which way it is done.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
  

Patch

diff --git a/Documentation/devicetree/bindings/sound/option,gtm601.yaml b/Documentation/devicetree/bindings/sound/option,gtm601.yaml
index 69c2ccc79dc5..ff813d97fc59 100644
--- a/Documentation/devicetree/bindings/sound/option,gtm601.yaml
+++ b/Documentation/devicetree/bindings/sound/option,gtm601.yaml
@@ -16,10 +16,12 @@  description: >
 properties:
   compatible:
     oneOf:
-      - items:  # 48 kHz stereo
+      - description: Broadmobi BM818 (48Khz stereo)
+        items:
           - const: broadmobi,bm818
           - const: option,gtm601
-      - const: option,gtm601  # 8 kHz mono
+      - description: GTM601 (8kHz mono)
+        const: option,gtm601
 
   '#sound-dai-cells':
     const: 0