Message ID | 20230809114906.21866-2-danishanwar@ti.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp2759391vqr; Wed, 9 Aug 2023 05:20:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEsUMzDFqTujFwk/+QIS3XlZz3l1jE27KQ09WGMG8k/qCFIBw68PPjxe5wEH9tsEohOXl0T X-Received: by 2002:a05:6e02:11a4:b0:348:797d:441a with SMTP id 4-20020a056e0211a400b00348797d441amr3168767ilj.8.1691583643248; Wed, 09 Aug 2023 05:20:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691583643; cv=none; d=google.com; s=arc-20160816; b=nlOv0yZU/TViDjw5ODb/c6LDOyqnpanH8bhN8YxvLnoAnb+hOz3dZAGsJJG5v8T2VB urV+G1OsuLAvGhYhBiyIyCBWTJSIynxska80YA5TTr4Qb7caoJWEAdjSar596iXZRUsR FmC6GRIo0k47Z6tZYqW46SfVrgFqfiPnSLIKMQxaTw6tsbZ5oFWyL4s+AH4d4DLk5LnG SvlDfwbc1XzjiMxjHbwqKbPK5jT4ximUz/pBKtiQ9QEqP7ZfIEk+/UzXQWJgJfmtQGGa 0NbE6A9du4DVeH243WiKKtfxCPfPL4Hb7lXsU2pXRarj2USCBdFctKgs6XNQx5EVzYuI 9ZjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tk2tUz70RrGAWnpyBXiARizxW3AgfBuZUmaf/bQMEhY=; fh=TO4fkcEI9b5r/wMetIII7RIVPqbK0XaoWpj6Tf2aW8M=; b=OrQWSOezAY3PTESGl+a3lLoRxcBWMW79JXOsjB/rdw5dLjNNpuUy/HFi4bkVSjj789 25kAbfPggTZZcj1iXkaKhva91s7EsmDWkoc3Ps70cNubv+eGxXAYKabkMkHEm33yTbyr 84fiRS12mfHDaL2BONovSF/wiqRAJKDUcijqivv6Xo+6iqrIdMIOT0LkwGbw/5JaLULi 5uzeJEzqgVhoi0j4h7nudnoRrcVIoC4A4+rEIvj4qtSsAqEzk0punR+ISPZ/zPqoY/lT p0Sfr9QDxHNPzJ3Qh4lfr62P5p9WxXSGh+uGgi0Sntd3ycM2r3LaECkq4c2YQEOhnuNx LJLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=DFu6qkvN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l8-20020a635b48000000b0051b423d966csi8639381pgm.280.2023.08.09.05.20.29; Wed, 09 Aug 2023 05:20:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=DFu6qkvN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232920AbjHILt6 (ORCPT <rfc822;aaronkmseo@gmail.com> + 99 others); Wed, 9 Aug 2023 07:49:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232849AbjHILtl (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 9 Aug 2023 07:49:41 -0400 Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F40818E; Wed, 9 Aug 2023 04:49:39 -0700 (PDT) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 379BnJW0095390; Wed, 9 Aug 2023 06:49:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1691581759; bh=tk2tUz70RrGAWnpyBXiARizxW3AgfBuZUmaf/bQMEhY=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=DFu6qkvNFHnMneA3CcI95d3A3XhFabf7r53mxNgDvIHukpt52zzBjOkvGFVlNusN7 S3yp24lftZwUlU4Jl3cE9N8bjgAIoZe0spJZ5dmvglULstL0MnQVRDPyhWt7hVOpIl +XLL41vU996cAsQw5yKCW9qxwM+wTasXcSJGbddc= Received: from DLEE101.ent.ti.com (dlee101.ent.ti.com [157.170.170.31]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 379BnJKi129540 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 9 Aug 2023 06:49:19 -0500 Received: from DLEE108.ent.ti.com (157.170.170.38) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 9 Aug 2023 06:49:19 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 9 Aug 2023 06:49:19 -0500 Received: from fllv0122.itg.ti.com (fllv0122.itg.ti.com [10.247.120.72]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 379BnJg0007868; Wed, 9 Aug 2023 06:49:19 -0500 Received: from localhost (uda0501179.dhcp.ti.com [172.24.227.217]) by fllv0122.itg.ti.com (8.14.7/8.14.7) with ESMTP id 379BnI9W005125; Wed, 9 Aug 2023 06:49:19 -0500 From: MD Danish Anwar <danishanwar@ti.com> To: Randy Dunlap <rdunlap@infradead.org>, Roger Quadros <rogerq@kernel.org>, Simon Horman <simon.horman@corigine.com>, Vignesh Raghavendra <vigneshr@ti.com>, Andrew Lunn <andrew@lunn.ch>, Richard Cochran <richardcochran@gmail.com>, Conor Dooley <conor+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Rob Herring <robh+dt@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>, Eric Dumazet <edumazet@google.com>, "David S. Miller" <davem@davemloft.net>, MD Danish Anwar <danishanwar@ti.com> CC: <nm@ti.com>, <srk@ti.com>, <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>, <netdev@vger.kernel.org>, <linux-omap@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org> Subject: [PATCH v3 1/5] dt-bindings: net: Add ICSS IEP Date: Wed, 9 Aug 2023 17:19:02 +0530 Message-ID: <20230809114906.21866-2-danishanwar@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230809114906.21866-1-danishanwar@ti.com> References: <20230809114906.21866-1-danishanwar@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773754010506509205 X-GMAIL-MSGID: 1773754010506509205 |
Series |
Introduce IEP driver and packet timestamping support
|
|
Commit Message
MD Danish Anwar
Aug. 9, 2023, 11:49 a.m. UTC
Add DT binding documentation for ICSS IEP module.
Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
---
.../devicetree/bindings/net/ti,icss-iep.yaml | 37 +++++++++++++++++++
1 file changed, 37 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/ti,icss-iep.yaml
Comments
Hey, On Wed, Aug 09, 2023 at 05:19:02PM +0530, MD Danish Anwar wrote: > Add DT binding documentation for ICSS IEP module. > > Signed-off-by: MD Danish Anwar <danishanwar@ti.com> > --- > .../devicetree/bindings/net/ti,icss-iep.yaml | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/ti,icss-iep.yaml > > diff --git a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml > new file mode 100644 > index 000000000000..adae240cfd53 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml > @@ -0,0 +1,37 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/ti,icss-iep.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments ICSS Industrial Ethernet Peripheral (IEP) module Does the module here refer to the hw component or to the linux kernel module? > + > +maintainers: > + - Md Danish Anwar <danishanwar@ti.com> > + > +properties: > + compatible: > + enum: > + - ti,am654-icss-iep # for all TI K3 SoCs *sigh* Please at least give me a chance to reply to the conversation on the previous versions of the series before sending more, that's the second time with this series :/ Right now this looks worse to me than what we started with given the comment is even broader. I have not changed my mind re: what I said on the previous version. Thanks, Conor. > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + description: phandle to the IEP source clock > + > +required: > + - compatible > + - reg > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + icssg0_iep0: iep@2e000 { > + compatible = "ti,am654-icss-iep"; > + reg = <0x2e000 0x1000>; > + clocks = <&icssg0_iepclk_mux>; > + }; > -- > 2.34.1 >
Hi Conor, On 10/08/23 3:07 am, Conor Dooley wrote: > Hey, > > On Wed, Aug 09, 2023 at 05:19:02PM +0530, MD Danish Anwar wrote: >> Add DT binding documentation for ICSS IEP module. >> >> Signed-off-by: MD Danish Anwar <danishanwar@ti.com> >> --- >> .../devicetree/bindings/net/ti,icss-iep.yaml | 37 +++++++++++++++++++ >> 1 file changed, 37 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/ti,icss-iep.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >> new file mode 100644 >> index 000000000000..adae240cfd53 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >> @@ -0,0 +1,37 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/ti,icss-iep.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Texas Instruments ICSS Industrial Ethernet Peripheral (IEP) module > > Does the module here refer to the hw component or to the linux kernel > module? > The module here refers to the hardware component. >> + >> +maintainers: >> + - Md Danish Anwar <danishanwar@ti.com> >> + >> +properties: >> + compatible: >> + enum: >> + - ti,am654-icss-iep # for all TI K3 SoCs > > *sigh* Please at least give me a chance to reply to the conversation on > the previous versions of the series before sending more, that's the > second time with this series :/ My bad, I should have waited for your response. I will hold on posting next version until your response is received. > Right now this looks worse to me than what we started with given the > comment is even broader. I have not changed my mind re: what I said on > the previous version. > OK, so in the previous version [1] your reply was to have specific compatibles as bindings with "ti-am654-icss-iep" as a fall back. I will go with this only. Does the below looks good to you? Here "ti,am642-icss-iep" and "ti,j721e-icss-iep" are different compatibles for different SoCs where as "ti,am654-icss-iep" is the fall back. Compatible "ti,am654-icss-iep" will go in the driver. properties: compatible: oneOf: - items: - enum: - ti,am642-icss-iep - ti,j721e-icss-iep - const: ti,am654-icss-iep - items: - const: ti,am654-icss-iep examples: - | /* AM65x */ icssg0_iep0: iep@2e000 { compatible = "ti,am654-icss-iep"; reg = <0x2e000 0x1000>; clocks = <&icssg0_iepclk_mux>; }; /* J721E */ icssg0_iep0: iep@2f000 { compatible = "ti,j721e-icss-iep","ti,am654-icss-iep"; reg = <0x2e000 0x1000>; clocks = <&icssg0_iepclk_mux>; }; /* AM64x */ icssg0_iep0: iep@2b000 { compatible = "ti,am642-icss-iep", "ti,am654-icss-iep"; reg = <0x2e000 0x1000>; clocks = <&icssg0_iepclk_mux>; }; Please let me know if the compatible property and the example looks OK to you. Also please let me know if some other change is required. I will send next revision after your confirmation. > Thanks, > Conor. > >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + description: phandle to the IEP source clock >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + icssg0_iep0: iep@2e000 { >> + compatible = "ti,am654-icss-iep"; >> + reg = <0x2e000 0x1000>; >> + clocks = <&icssg0_iepclk_mux>; >> + }; >> -- >> 2.34.1 >> [1] https://lore.kernel.org/all/20230808-nutmeg-mashing-543b41e56aa1@spud/
On Thu, Aug 10, 2023 at 03:23:11PM +0530, Md Danish Anwar wrote: > On 10/08/23 3:07 am, Conor Dooley wrote: > > On Wed, Aug 09, 2023 at 05:19:02PM +0530, MD Danish Anwar wrote: > >> Add DT binding documentation for ICSS IEP module. > >> > >> Signed-off-by: MD Danish Anwar <danishanwar@ti.com> > >> --- > >> .../devicetree/bindings/net/ti,icss-iep.yaml | 37 +++++++++++++++++++ > >> 1 file changed, 37 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/net/ti,icss-iep.yaml > >> > >> diff --git a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml > >> new file mode 100644 > >> index 000000000000..adae240cfd53 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml > >> @@ -0,0 +1,37 @@ > >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >> +%YAML 1.2 > >> +--- > >> +$id: http://devicetree.org/schemas/net/ti,icss-iep.yaml# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: Texas Instruments ICSS Industrial Ethernet Peripheral (IEP) module > > > > Does the module here refer to the hw component or to the linux kernel > > module? > > > > The module here refers to the hardware component. Sweet, thanks. > >> + > >> +maintainers: > >> + - Md Danish Anwar <danishanwar@ti.com> > >> + > >> +properties: > >> + compatible: > >> + enum: > >> + - ti,am654-icss-iep # for all TI K3 SoCs > > > > *sigh* Please at least give me a chance to reply to the conversation on > > the previous versions of the series before sending more, that's the > > second time with this series :/ > > My bad, I should have waited for your response. I will hold on posting next > version until your response is received. > > > Right now this looks worse to me than what we started with given the > > comment is even broader. I have not changed my mind re: what I said on > > the previous version. > > > > OK, so in the previous version [1] your reply was to have specific compatibles > as bindings with "ti-am654-icss-iep" as a fall back. I will go with this only. > > Does the below looks good to you? Here "ti,am642-icss-iep" and > "ti,j721e-icss-iep" are different compatibles for different SoCs where as > "ti,am654-icss-iep" is the fall back. Compatible "ti,am654-icss-iep" will go in > the driver. > > properties: > compatible: > oneOf: > - items: > - enum: > - ti,am642-icss-iep > - ti,j721e-icss-iep > - const: ti,am654-icss-iep > > - items: > - const: ti,am654-icss-iep This one doesn't need to be an items list, since there is only one item. It should be able to just be const:. I much prefer this approach. Thanks, Conor.
On 10/08/23 6:22 pm, Conor Dooley wrote: > On Thu, Aug 10, 2023 at 03:23:11PM +0530, Md Danish Anwar wrote: >> On 10/08/23 3:07 am, Conor Dooley wrote: >>> On Wed, Aug 09, 2023 at 05:19:02PM +0530, MD Danish Anwar wrote: >>>> Add DT binding documentation for ICSS IEP module. >>>> >>>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com> >>>> --- >>>> .../devicetree/bindings/net/ti,icss-iep.yaml | 37 +++++++++++++++++++ >>>> 1 file changed, 37 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/net/ti,icss-iep.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >>>> new file mode 100644 >>>> index 000000000000..adae240cfd53 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >>>> @@ -0,0 +1,37 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/net/ti,icss-iep.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Texas Instruments ICSS Industrial Ethernet Peripheral (IEP) module >>> >>> Does the module here refer to the hw component or to the linux kernel >>> module? >>> >> >> The module here refers to the hardware component. > > Sweet, thanks. > >>>> + >>>> +maintainers: >>>> + - Md Danish Anwar <danishanwar@ti.com> >>>> + >>>> +properties: >>>> + compatible: >>>> + enum: >>>> + - ti,am654-icss-iep # for all TI K3 SoCs >>> >>> *sigh* Please at least give me a chance to reply to the conversation on >>> the previous versions of the series before sending more, that's the >>> second time with this series :/ >> >> My bad, I should have waited for your response. I will hold on posting next >> version until your response is received. >> >>> Right now this looks worse to me than what we started with given the >>> comment is even broader. I have not changed my mind re: what I said on >>> the previous version. >>> >> >> OK, so in the previous version [1] your reply was to have specific compatibles >> as bindings with "ti-am654-icss-iep" as a fall back. I will go with this only. >> >> Does the below looks good to you? Here "ti,am642-icss-iep" and >> "ti,j721e-icss-iep" are different compatibles for different SoCs where as >> "ti,am654-icss-iep" is the fall back. Compatible "ti,am654-icss-iep" will go in >> the driver. >> >> properties: >> compatible: >> oneOf: >> - items: >> - enum: >> - ti,am642-icss-iep >> - ti,j721e-icss-iep >> - const: ti,am654-icss-iep >> >> - items: >> - const: ti,am654-icss-iep > > This one doesn't need to be an items list, since there is only one item. > It should be able to just be const:. I much prefer this approach. > > Thanks, > Conor. Sure Conor, I will remove items from the last one and make it just const like below. Please let me know if this is ok. properties: compatible: oneOf: - items: - enum: - ti,am642-icss-iep - ti,j721e-icss-iep - const: ti,am654-icss-iep - const: ti,am654-icss-iep
On Thu, Aug 10, 2023 at 06:27:22PM +0530, Md Danish Anwar wrote: > > Sure Conor, I will remove items from the last one and make it just const like > below. Please let me know if this is ok. Yeah, that looks okay to me, thanks.
diff --git a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml new file mode 100644 index 000000000000..adae240cfd53 --- /dev/null +++ b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml @@ -0,0 +1,37 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/ti,icss-iep.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Texas Instruments ICSS Industrial Ethernet Peripheral (IEP) module + +maintainers: + - Md Danish Anwar <danishanwar@ti.com> + +properties: + compatible: + enum: + - ti,am654-icss-iep # for all TI K3 SoCs + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + description: phandle to the IEP source clock + +required: + - compatible + - reg + - clocks + +additionalProperties: false + +examples: + - | + icssg0_iep0: iep@2e000 { + compatible = "ti,am654-icss-iep"; + reg = <0x2e000 0x1000>; + clocks = <&icssg0_iepclk_mux>; + };