diff mbox series

ASoC: dt-bindings: qcom,wsa883x: Add sound-name-prefix

Message ID 20221111091738.34290-1-krzysztof.kozlowski@linaro.org
State New
Headers
Series ASoC: dt-bindings: qcom,wsa883x: Add sound-name-prefix |

Commit Message

Krzysztof Kozlowski Nov. 11, 2022, 9:17 a.m. UTC 
  For multiple speakers attached, it's useful to give them some name.
Sound core already supports this, so reference name-prefix.yaml.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Mark Brown Nov. 11, 2022, 12:06 p.m. UTC | #1 
On Fri, Nov 11, 2022 at 10:17:38AM +0100, Krzysztof Kozlowski wrote:

> For multiple speakers attached, it's useful to give them some name.
> Sound core already supports this, so reference name-prefix.yaml.

If we need to manually extend the schema like this it should probably be
done for all the CODEC devices.
Krzysztof Kozlowski Nov. 11, 2022, 2:33 p.m. UTC | #2 
On 11/11/2022 13:06, Mark Brown wrote:
> On Fri, Nov 11, 2022 at 10:17:38AM +0100, Krzysztof Kozlowski wrote:
> 
>> For multiple speakers attached, it's useful to give them some name.
>> Sound core already supports this, so reference name-prefix.yaml.
> 
> If we need to manually extend the schema like this it should probably be
> done for all the CODEC devices.

Several files already do it:

  git grep name-prefix.yaml

The trouble for me would be here to identify which devices qualify from
bindings/sound.... everything having #sound-dai-cells?

Best regards,
Krzysztof
Mark Brown Nov. 11, 2022, 4:32 p.m. UTC | #3 
On Fri, Nov 11, 2022 at 03:33:10PM +0100, Krzysztof Kozlowski wrote:
> On 11/11/2022 13:06, Mark Brown wrote:
> > On Fri, Nov 11, 2022 at 10:17:38AM +0100, Krzysztof Kozlowski wrote:

> >> For multiple speakers attached, it's useful to give them some name.
> >> Sound core already supports this, so reference name-prefix.yaml.

> > If we need to manually extend the schema like this it should probably be
> > done for all the CODEC devices.

> Several files already do it:

>   git grep name-prefix.yaml

> The trouble for me would be here to identify which devices qualify from
> bindings/sound.... everything having #sound-dai-cells?

Pretty much anything could potentially do it, it's a system level thing
for when the same device gets instantiated multiple times.  It's most
relevant when something creates user visible controls.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml b/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml
index 99f9c10bbc83..f3fb1de93ba2 100644
--- a/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml
@@ -15,6 +15,9 @@  description: |
   Their primary operating mode uses a SoundWire digital audio
   interface. This binding is for SoundWire interface.
 
+allOf:
+  - $ref: name-prefix.yaml#
+
 properties:
   compatible:
     const: sdw10217020200
@@ -35,6 +38,8 @@  properties:
   '#sound-dai-cells':
     const: 0
 
+  sound-name-prefix: true
+
 required:
   - compatible
   - reg
@@ -61,6 +66,7 @@  examples:
             vdd-supply = <&vreg_s10b_1p8>;
             #thermal-sensor-cells = <0>;
             #sound-dai-cells = <0>;
+            sound-name-prefix = "SpkrLeft";
         };
 
         speaker@0,2 {
@@ -70,6 +76,7 @@  examples:
             vdd-supply = <&vreg_s10b_1p8>;
             #thermal-sensor-cells = <0>;
             #sound-dai-cells = <0>;
+            sound-name-prefix = "SpkrRight";
         };
     };