diff mbox series

[-next] dm: Remove unused declaration dm_get_rq_mapinfo()

Message ID 20230808150301.45196-1-yuehaibing@huawei.com
State New
Headers
Series [-next] dm: Remove unused declaration dm_get_rq_mapinfo() |

Commit Message

Yue Haibing Aug. 8, 2023, 3:03 p.m. UTC 
  Commit ae6ad75e5c3c ("dm: remove unused dm_get_rq_mapinfo()")
removed the implementation but leave declaration.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 include/linux/device-mapper.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Hugo Villeneuve Aug. 8, 2023, 5:03 p.m. UTC | #1 
On Tue, 8 Aug 2023 23:03:01 +0800
Yue Haibing <yuehaibing@huawei.com> wrote:

Hi,

> Commit ae6ad75e5c3c ("dm: remove unused dm_get_rq_mapinfo()")
> removed the implementation but leave declaration.

Maybe change to "removed the implementation but not the declaration."

Hugo Villeneuve.


> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
>  include/linux/device-mapper.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h
> index 69d0435c7ebb..5bc69c6a64e0 100644
> --- a/include/linux/device-mapper.h
> +++ b/include/linux/device-mapper.h
> @@ -502,7 +502,6 @@ int dm_post_suspending(struct dm_target *ti);
>  int dm_noflush_suspending(struct dm_target *ti);
>  void dm_accept_partial_bio(struct bio *bio, unsigned int n_sectors);
>  void dm_submit_bio_remap(struct bio *clone, struct bio *tgt_clone);
> -union map_info *dm_get_rq_mapinfo(struct request *rq);
>  
>  #ifdef CONFIG_BLK_DEV_ZONED
>  struct dm_report_zones_args {
> -- 
> 2.34.1
>
Yue Haibing Aug. 9, 2023, 3:03 a.m. UTC | #2 
On 2023/8/9 1:03, Hugo Villeneuve wrote:
> On Tue, 8 Aug 2023 23:03:01 +0800
> Yue Haibing <yuehaibing@huawei.com> wrote:
> 
> Hi,
> 
>> Commit ae6ad75e5c3c ("dm: remove unused dm_get_rq_mapinfo()")
>> removed the implementation but leave declaration.
> 
> Maybe change to "removed the implementation but not the declaration."

Thanks， will do this in v2.

> 
> Hugo Villeneuve.
> 
> 
>> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>> ---
>>  include/linux/device-mapper.h | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h
>> index 69d0435c7ebb..5bc69c6a64e0 100644
>> --- a/include/linux/device-mapper.h
>> +++ b/include/linux/device-mapper.h
>> @@ -502,7 +502,6 @@ int dm_post_suspending(struct dm_target *ti);
>>  int dm_noflush_suspending(struct dm_target *ti);
>>  void dm_accept_partial_bio(struct bio *bio, unsigned int n_sectors);
>>  void dm_submit_bio_remap(struct bio *clone, struct bio *tgt_clone);
>> -union map_info *dm_get_rq_mapinfo(struct request *rq);
>>  
>>  #ifdef CONFIG_BLK_DEV_ZONED
>>  struct dm_report_zones_args {
>> -- 
>> 2.34.1
>>
> 
> .
>
diff mbox series

Patch

diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h
index 69d0435c7ebb..5bc69c6a64e0 100644
--- a/include/linux/device-mapper.h
+++ b/include/linux/device-mapper.h
@@ -502,7 +502,6 @@  int dm_post_suspending(struct dm_target *ti);
 int dm_noflush_suspending(struct dm_target *ti);
 void dm_accept_partial_bio(struct bio *bio, unsigned int n_sectors);
 void dm_submit_bio_remap(struct bio *clone, struct bio *tgt_clone);
-union map_info *dm_get_rq_mapinfo(struct request *rq);
 
 #ifdef CONFIG_BLK_DEV_ZONED
 struct dm_report_zones_args {