[linux-next-v1,1/3] arm64: dts: rockchip: Fix gmac phy mode to rgmii on Rock 3A sbc
| Message ID | 20221111094238.1640-1-linux.amoon@gmail.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp643571wru;
Fri, 11 Nov 2022 01:45:41 -0800 (PST)
X-Google-Smtp-Source:
AA0mqf5GIPOlQWENb3oWVGIaU8fsqarLL863Q7ZreErJzMQP6nT6KHSMfX0Z7KDCTpEmtJmSnp++
X-Received: by 2002:a17:902:6b89:b0:188:5688:828b with SMTP id
p9-20020a1709026b8900b001885688828bmr1778934plk.129.1668159941339;
Fri, 11 Nov 2022 01:45:41 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1668159941; cv=none;
d=google.com; s=arc-20160816;
b=0N2ZcSv11t+hjnqISTxqk96w8YsB+icnPqVMJ7XgnTztg/uyc1ESxjP6yVpA734wfV
C7z1Ux5t+bA+pe+X5CpwTjfwX4CrcPzUBiinRRwwscUNdvKJ+mrTO5eVT+WZazmG45A7
elf8X5pwgKxWZA9P6M/77z9G8lWbM7FTe2/o9sJGo9IAYFNkfTqqikjN0hQodQL/wsc+
S2i7iaNTgpr9EBqNaTf1zgaBzGgIseLXZTnBFzdSbciORs2hUu4ghSCyCzl+F8Rmqj4K
Yw0Xel6xi30Io/b9O6qZ+ENtTWAbxUXTIL1L95b0UVjrh1T3n04FpX9SBambXWkwMjUz
jebg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=Zy9kRwEDKOwzUuzNDwbNK6Ls9wmAWU8wrTb8CY1ASBM=;
b=i7L4BVDQ0vR6tAuANgQJbMNwq6cjGLp17AJbG9fi+eKAJ0zjuE9qSTbKLyBDKFeRfb
nIDUVYA600tlzAAy8a1Aerj3VRRtS19TeIKvqD301hLCnZIDgYVN15PFHDVwjNEkuTmp
h3EFv7Bpl6VnSNVKXd0cyDox83hgHds7Z9ax1xrDJpZ0RZLr8bxOmwekGqTXd1TY7PO7
GiqcCIQMfFrVBiNCpI/wVG9faQy2jouXLzYQ5mcy/UloQXNWmj7fKQHEPrTGwROceNtK
1GF8oZ1V3wwgrz7BoJFmCdpZDBQl9OKaoTF2g4Xb0qRZAGfqN6Zgzde/mWR3Sew9lRFF
eGXw==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@gmail.com header.s=20210112 header.b=UrYniHry;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
bh8-20020a056a02020800b0046004666d82si1889055pgb.497.2022.11.11.01.45.27;
Fri, 11 Nov 2022 01:45:41 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@gmail.com header.s=20210112 header.b=UrYniHry;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S233528AbiKKJnE (ORCPT <rfc822;winker.wchi@gmail.com>
+ 99 others); Fri, 11 Nov 2022 04:43:04 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57410 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S231235AbiKKJnD (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 11 Nov 2022 04:43:03 -0500
Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com
[IPv6:2607:f8b0:4864:20::102e])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EE02654E3;
Fri, 11 Nov 2022 01:43:02 -0800 (PST)
Received: by mail-pj1-x102e.google.com with SMTP id
v4-20020a17090a088400b00212cb0ed97eso4254438pjc.5;
Fri, 11 Nov 2022 01:43:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20210112;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=Zy9kRwEDKOwzUuzNDwbNK6Ls9wmAWU8wrTb8CY1ASBM=;
b=UrYniHryQrt1oClRFAxO4NM+NTyxw9xTdQt/tkBzCt0JXKQGCjW0kEvDc+g/dhWFxA
kTju6QYgbkEEWUEXYgQ4ASkeuc+fcO/hG8ZLC8HfcQka1+ymUzo8avwj5iUAU6UFlTBZ
SSG9U27np35cWvCXoFcrJIrIFlLmwdf9qTSmPTL1vnD3ZSN0LDFxJuD8GUz/+d0+IYN0
qBgLo1yxsMiSAqS4gh06lPjWLswAlUjSSHP8oxMWb+lkBXfna77cBoSED+JUk9gUQWsG
2220ENr9ojjkMaxJlcRDFuTNaMvyu5jCO61MBbmrkF7vbu5sU8/OVXNoxH5KWGI1sm6w
ZnOA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=Zy9kRwEDKOwzUuzNDwbNK6Ls9wmAWU8wrTb8CY1ASBM=;
b=p6QeYZi04IZrpIx3QzWBro2kUqruG/iC8Q3sV+zosIpz8n9Do/d5Da7wVPid89Plqm
82GbDwfGp3OhJHXMvRXFZEuDFAgOWmjnKS3RBcsyXSjI9B2sLbMjP1wQva/xppRcF3bg
1KA+Y5+NvwjLIG0QZOf+d7d4vBn/ynrhd8js2zG19mCGiTYyWeL91yqL8h1vcZnR0s5l
SMSKG/MTDe+fq79ATuNwbyDTPj7x+pme9IhFnxdw06uQqEzsTsW2J81QfWpT0mk1DzaC
pblCCbQt6Ox+WWWul8CaPnKaflU4Y6fhR4ll8iebgn0ggZN0siINiWZ1wjeXJSaf3zfX
f+2A==
X-Gm-Message-State: ANoB5pkBxuTWI+iawC2JfvG6IIekQHhyX4pZiQQPOlBB7hS6psnTBHPB
SPt8bbJdoF70aDZOGPGOShA=
X-Received: by 2002:a17:902:d18b:b0:186:8568:be82 with SMTP id
m11-20020a170902d18b00b001868568be82mr1510898plb.110.1668159782097;
Fri, 11 Nov 2022 01:43:02 -0800 (PST)
Received: from localhost.localdomain ([103.51.72.74])
by smtp.gmail.com with ESMTPSA id
fa13-20020a17090af0cd00b002086ac07041sm1188450pjb.44.2022.11.11.01.42.58
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 11 Nov 2022 01:43:01 -0800 (PST)
From: Anand Moon <linux.amoon@gmail.com>
To: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: Anand Moon <linux.amoon@gmail.com>,
Chukun Pan <amadeus@jmu.edu.cn>,
Michael Riesch <michael.riesch@wolfvision.net>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [linux-next-v1 1/3] arm64: dts: rockchip: Fix gmac phy mode to rgmii
on Rock 3A sbc
Date: Fri, 11 Nov 2022 09:42:33 +0000
Message-Id: <20221111094238.1640-1-linux.amoon@gmail.com>
X-Mailer: git-send-email 2.38.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,
RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1749192478538931080?=
X-GMAIL-MSGID: =?utf-8?q?1749192478538931080?=
|
| Series |
[linux-next-v1,1/3] arm64: dts: rockchip: Fix gmac phy mode to rgmii on Rock 3A sbc
|
|
Commit Message
Anand Moon
Nov. 11, 2022, 9:42 a.m. UTC
On rk356x ethernet phy support reduced media independent interface (RMII)
and reduced gigabit media independent interface (RGMII).
So set the phy mode to rgmii.
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Anand, On 11/11/22 10:42, Anand Moon wrote: > On rk356x ethernet phy support reduced media independent interface (RMII) > and reduced gigabit media independent interface (RGMII). > So set the phy mode to rgmii. > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > index ea74ba32fbbd..72e410e3aca8 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > @@ -253,7 +253,7 @@ &gmac1 { > assigned-clock-rates = <0>, <125000000>; > clock_in_out = "output"; > phy-handle = <&rgmii_phy1>; > - phy-mode = "rgmii-id"; > + phy-mode = "rgmii"; What are you trying to fix here? If it ain't broken, don't fix it. I would assume if you switch from rgmii-id to rgmii you need to adjust the rx/tx-delays, otherwise this change does not make sense to me. Feel free to point out what I am missing, though. Best regards, Michael > pinctrl-names = "default"; > pinctrl-0 = <&gmac1m1_miim > &gmac1m1_tx_bus2
On Fri, Nov 11, 2022 at 4:43 AM Anand Moon <linux.amoon@gmail.com> wrote: > > On rk356x ethernet phy support reduced media independent interface (RMII) > and reduced gigabit media independent interface (RGMII). > So set the phy mode to rgmii. The RTL8211 supports rgmii-id just fine, you only need to go to rgmii on these boards if you need to tune the delays manually. > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > index ea74ba32fbbd..72e410e3aca8 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > @@ -253,7 +253,7 @@ &gmac1 { > assigned-clock-rates = <0>, <125000000>; > clock_in_out = "output"; > phy-handle = <&rgmii_phy1>; > - phy-mode = "rgmii-id"; > + phy-mode = "rgmii"; You should be setting the delay tuning in this patch as well. > pinctrl-names = "default"; > pinctrl-0 = <&gmac1m1_miim > &gmac1m1_tx_bus2 > -- > 2.38.1 > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip
Hi Petter / Michael. Thanks for your review comments. On Fri, 11 Nov 2022 at 18:26, Peter Geis <pgwipeout@gmail.com> wrote: > > On Fri, Nov 11, 2022 at 4:43 AM Anand Moon <linux.amoon@gmail.com> wrote: > > > > On rk356x ethernet phy support reduced media independent interface (RMII) > > and reduced gigabit media independent interface (RGMII). > > So set the phy mode to rgmii. > > The RTL8211 supports rgmii-id just fine, you only need to go to rgmii > on these boards if you need to tune the delays manually. Ok rgmii supports internal rx and tx clock delay whereas rgmii-id does not supports internal clock delay. > > > > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > > --- > > arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > > index ea74ba32fbbd..72e410e3aca8 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > > +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > > @@ -253,7 +253,7 @@ &gmac1 { > > assigned-clock-rates = <0>, <125000000>; > > clock_in_out = "output"; > > phy-handle = <&rgmii_phy1>; > > - phy-mode = "rgmii-id"; > > + phy-mode = "rgmii"; > > You should be setting the delay tuning in this patch as well. I will try to fix this in the next version. > > > pinctrl-names = "default"; > > pinctrl-0 = <&gmac1m1_miim > > &gmac1m1_tx_bus2 > > -- > > 2.38.1 Thanks -Anand
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts index ea74ba32fbbd..72e410e3aca8 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts @@ -253,7 +253,7 @@ &gmac1 { assigned-clock-rates = <0>, <125000000>; clock_in_out = "output"; phy-handle = <&rgmii_phy1>; - phy-mode = "rgmii-id"; + phy-mode = "rgmii"; pinctrl-names = "default"; pinctrl-0 = <&gmac1m1_miim &gmac1m1_tx_bus2