Message ID | 20230731140712.1204-1-yuehaibing@huawei.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp2058640vqg; Mon, 31 Jul 2023 07:37:53 -0700 (PDT) X-Google-Smtp-Source: APBJJlHsA/jZ9TmM0IQ+jn1C2OsuIVBvAQAxy45R8QIJjOAmMnNtNrDLO875yGRue5LIb+oFT3ni X-Received: by 2002:a2e:9bc3:0:b0:2b6:efa0:7c36 with SMTP id w3-20020a2e9bc3000000b002b6efa07c36mr127945ljj.21.1690814272791; Mon, 31 Jul 2023 07:37:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690814272; cv=none; d=google.com; s=arc-20160816; b=0fIFlD8kw/d0ywfyebYQtS0FC4pmwMtRFaoB8NlZLX7TIVSgfW3+kmx9Ek+26N22Fz /p6E4A3qIhqycJFwhZxNiODAn9pMdmpbq0u2eRPXymFIkCkoGfBWbj39Zu7EKMQb0+lq 5KoZ9+v+TxUmRswYWxhgKU1I/HkYPZShEyXqP+MV0IGx1+9mVcSm/sAvg7vjXk14be+P OV+0cpDS/2WOcr+L69bZQc9mim4LpRHOZ3WjpinjJlwj0K8l17SnpwBICa08RC0bAQyd C1JScJgAMHLoKyyeT2YlrPw8JSKo2Yy/OTehmtxGpJJ5du+2NxOY4omjGGgyqvI0pnzF hprw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=VY/xT2bG8AyI6FlDvEeFTJM2C26Qlr4Oh2oWMkWRGWw=; fh=kHX4XYrZ/ors2RYJ5s+Krg5uDMgWuf0xlrfbZ4pLhlc=; b=s+ESyF/+HGhTISnGHrxsa/x/GWkK3oXBB/4AYY6hTxqFsfiuJvwp6jCHQWzvlwIU0B Fb37JB73k6fgLBYERf99vbM22Q+6XYigtHHzVxdk0ukhlbnkK4poLXrBxPENDE/SFuDX QNeY/QYlDlMqEKox6IHoLL2/CX5KDCOGUdmVsQKrJ7zXVeOYzR6DjSkDjQMWnUssJ8pe vMRmR8bGXY1uwagiKcQf2SoyhCn9HJaDTQMUiwQpJpHEhY0vXOhoPrt3+9/rY9+QHna7 W36WVbXsvLxdQka7vcmxOyShIqjDIW6qoDzaCu18x0D3PhrAjJaG9Ge9e8XOhxR9WerS y9Jw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lu44-20020a170906faec00b0098874379199si6962258ejb.163.2023.07.31.07.37.28; Mon, 31 Jul 2023 07:37:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230399AbjGaOIa (ORCPT <rfc822;dengxinlin2429@gmail.com> + 99 others); Mon, 31 Jul 2023 10:08:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230314AbjGaOIP (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 31 Jul 2023 10:08:15 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04379268A; Mon, 31 Jul 2023 07:07:19 -0700 (PDT) Received: from canpemm500007.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4RF0My0zYlztQwm; Mon, 31 Jul 2023 22:03:58 +0800 (CST) Received: from localhost (10.174.179.215) by canpemm500007.china.huawei.com (7.192.104.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 31 Jul 2023 22:07:17 +0800 From: Yue Haibing <yuehaibing@huawei.com> To: <johannes@sipsolutions.net>, <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>, <nbd@nbd.name>, <pagadala.yesu.anjaneyulu@intel.com> CC: <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Yue Haibing <yuehaibing@huawei.com> Subject: [PATCH] mac80211: mesh: Remove unused function declaration mesh_ids_set_default() Date: Mon, 31 Jul 2023 22:07:12 +0800 Message-ID: <20230731140712.1204-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.174.179.215] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500007.china.huawei.com (7.192.104.62) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772947267093292798 X-GMAIL-MSGID: 1772947267093292798 |
Series |
mac80211: mesh: Remove unused function declaration mesh_ids_set_default()
|
|
Commit Message
Yue Haibing
July 31, 2023, 2:07 p.m. UTC
Commit ccf80ddfe492 ("mac80211: mesh function and data structures definitions")
introducted this but never implemented.
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
net/mac80211/mesh.h | 1 -
1 file changed, 1 deletion(-)
Comments
Yue Haibing <yuehaibing@huawei.com> writes: > Commit ccf80ddfe492 ("mac80211: mesh function and data structures definitions") > introducted this but never implemented. > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> > --- > net/mac80211/mesh.h | 1 - > 1 file changed, 1 deletion(-) The title should have "wifi:" but no need to resend because of this.
On Mon, Jul 31, 2023 at 10:07:12PM +0800, Yue Haibing wrote: > Commit ccf80ddfe492 ("mac80211: mesh function and data structures definitions") > introducted this but never implemented. > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> Reviewed-by: Simon Horman <horms@kernel.org>
On Mon, 2023-07-31 at 22:07 +0800, Yue Haibing wrote: > Commit ccf80ddfe492 ("mac80211: mesh function and data structures definitions") > introducted this but never implemented. > Btw, are you detecting these with some kind of tool? Having the tool would probably be more useful than you sending all these patches all the time ... johannes
On 2023/8/8 16:24, Johannes Berg wrote: > On Mon, 2023-07-31 at 22:07 +0800, Yue Haibing wrote: >> Commit ccf80ddfe492 ("mac80211: mesh function and data structures definitions") >> introducted this but never implemented. >> > > Btw, are you detecting these with some kind of tool? Having the tool > would probably be more useful than you sending all these patches all the > time ... > Just use grep to check like below grep -rP --include=*.c '^(?:\w+\s+){1,3}\*{0,3}\s{0,3}\w+[\t]*\(' * |grep -P -oh '\w+\s*\('|sort| uniq -c| sort -n| grep -P '^\s+1\b'|sed -r -e 's/^\s+1\s+//' -e 's/\(//'|while read line ; do IS=`git grep -w $line |wc -l` ; if [ $IS -eq 1 ];then git grep -wn $line fi done > johannes > . >
diff --git a/net/mac80211/mesh.h b/net/mac80211/mesh.h index 6c94222a9df5..ad8469293d71 100644 --- a/net/mac80211/mesh.h +++ b/net/mac80211/mesh.h @@ -212,7 +212,6 @@ int mesh_rmc_check(struct ieee80211_sub_if_data *sdata, const u8 *addr, struct ieee80211s_hdr *mesh_hdr); bool mesh_matches_local(struct ieee80211_sub_if_data *sdata, struct ieee802_11_elems *ie); -void mesh_ids_set_default(struct ieee80211_if_mesh *mesh); int mesh_add_meshconf_ie(struct ieee80211_sub_if_data *sdata, struct sk_buff *skb); int mesh_add_meshid_ie(struct ieee80211_sub_if_data *sdata,