diff mbox series

[1/2] dt-bindings: rtc: Add Epson RX8111

Message ID 864b398918e99773f6cbd5ffe5b1f0dc33e4d6d1.1691158774.git.waqar.hameed@axis.com
State New
Headers
Series Add a driver for Epson RX8111 RTC |

Commit Message

Waqar Hameed Aug. 4, 2023, 2:19 p.m. UTC 
  Epson RX8111 is an RTC with timestamp functionality. Add devicetree
bindings requiring the compatible string and I2C slave address (reg).

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
 .../devicetree/bindings/rtc/epson,rx8111.yaml | 41 +++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/rtc/epson,rx8111.yaml

Comments

Krzysztof Kozlowski Aug. 5, 2023, 8:28 p.m. UTC | #1 
On 04/08/2023 16:19, Waqar Hameed wrote:
> Epson RX8111 is an RTC with timestamp functionality. Add devicetree
> bindings requiring the compatible string and I2C slave address (reg).


> +
> +maintainers:
> +  - Waqar Hameed <waqar.hameed@axis.com>
> +
> +description: |
> +  RTC with timestamp functionality.
> +
> +  https://support.epson.biz/td/api/doc_check.php?dl=app_RX8111CE&lang=en
> +
> +properties:
> +  compatible:
> +    const: epson,rx8111
> +
> +  reg:
> +    const: 0x32
> +
> +required:
> +  - compatible
> +  - reg

Just add it to trivial-rtc.yaml. You miss here more things than trivial
is providing, so...

Best regards,
Krzysztof
Waqar Hameed Aug. 7, 2023, 9:02 p.m. UTC | #2 
On Sat, Aug 05, 2023 at 22:28 +0200 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 04/08/2023 16:19, Waqar Hameed wrote:
>> Epson RX8111 is an RTC with timestamp functionality. Add devicetree
>> bindings requiring the compatible string and I2C slave address (reg).
>
>
>> +
>> +maintainers:
>> +  - Waqar Hameed <waqar.hameed@axis.com>
>> +
>> +description: |
>> +  RTC with timestamp functionality.
>> +
>> +  https://support.epson.biz/td/api/doc_check.php?dl=app_RX8111CE&lang=en
>> +
>> +properties:
>> +  compatible:
>> +    const: epson,rx8111
>> +
>> +  reg:
>> +    const: 0x32
>> +
>> +required:
>> +  - compatible
>> +  - reg
>
> Just add it to trivial-rtc.yaml. You miss here more things than trivial
> is providing, so...

Oh, I wasn't even aware of that file. I'll add it there instead!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/rtc/epson,rx8111.yaml b/Documentation/devicetree/bindings/rtc/epson,rx8111.yaml
new file mode 100644
index 000000000000..e6f077a32582
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/epson,rx8111.yaml
@@ -0,0 +1,41 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/epson,rx8111.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Epson RX8111 Real-Time Clock
+
+maintainers:
+  - Waqar Hameed <waqar.hameed@axis.com>
+
+description: |
+  RTC with timestamp functionality.
+
+  https://support.epson.biz/td/api/doc_check.php?dl=app_RX8111CE&lang=en
+
+properties:
+  compatible:
+    const: epson,rx8111
+
+  reg:
+    const: 0x32
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        rtc@32 {
+            compatible = "epson,rx8111";
+            reg = <0x32>;
+        };
+    };
+...