Message ID | 20230802174521.236255-3-afd@ti.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp709586vqx; Wed, 2 Aug 2023 13:31:22 -0700 (PDT) X-Google-Smtp-Source: APBJJlHlYRKrKubiFPR/SPGwhDsB8jqjOL16MFqRRCO31f2VpC5qtRGT1nVwp46c7faY5RSoqn0n X-Received: by 2002:a17:90a:8549:b0:268:218b:ad20 with SMTP id a9-20020a17090a854900b00268218bad20mr14473979pjw.7.1691008282331; Wed, 02 Aug 2023 13:31:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691008282; cv=none; d=google.com; s=arc-20160816; b=LctMc2MD4ngVobZn3/9xSAsZ1Z03X5YV27q24QnCGxv3gco5RPyQeiOAz/0HLiktId d3V2dnJU5CybSaE4m0tMew9oFdclkpyn/vvyfe7EgG6qCo1aFj3P4x/OeO0RsQTTwSjT d/KAw0CGlBI1K9WdzzciJOvpK8hD1f7GM7G3tlamPuXlncuzw+nFygxcan/H4S9MXXXf aFHacJr9BEgFe4NbrnI7ZtuKKvbDbJz/B+A2kNngeuqkf470SQbPlHAcfHH73IdlpgiW FuIGX6rP0nzgqb7NXdqEkUGpZXF/UVXQx4jz4x+pq6RdE1B3KJPscXJG35rxV4O9RS6I bc1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=of7S/MjUkq2tSyigj1N8ljJ3RfUoJ69EY7ucFNt5z3A=; fh=878OLI05L9osNW8108hv37bieiY2kkkgXUhCMqaYoVQ=; b=gMbAPILeYNRoEeH2bOlVVFQ6O5jJQAqJjpwVRHcTvsoZQH8vr2qpBRT9J62aDSjMai QS4vQI78drvusU7qYlwOfz5urakFER4PjOUwfX59ULkn0s86UaEM6Alm5uQ9qjvi2z+1 b8A7zt2rBHf67DYtii7G70veWW+O93Rwl/GOtQDTf62gyznxO1ZQWYwhxp0E+Q2T9LsC CNRqNBfmb4Onj6tcLFM7i++wDDh6yX5C5MF2Hh54470v8qV8hj2Hmol/KTvkK+k1uwgN 2bGjBIdRw/7EczJy+tN+zJ0+rJlbBqqO2Cvo1rBk3Nrk+i6Y5csT+enW/LGud8s52TXK Uu0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=HJANRPd9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z17-20020a17090acb1100b00262ffca5a31si1670225pjt.161.2023.08.02.13.31.08; Wed, 02 Aug 2023 13:31:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=HJANRPd9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233884AbjHBRqK (ORCPT <rfc822;maxi.paulin@gmail.com> + 99 others); Wed, 2 Aug 2023 13:46:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230310AbjHBRqC (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 2 Aug 2023 13:46:02 -0400 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4F491FF0; Wed, 2 Aug 2023 10:45:32 -0700 (PDT) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 372HjQpQ053112; Wed, 2 Aug 2023 12:45:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1690998326; bh=of7S/MjUkq2tSyigj1N8ljJ3RfUoJ69EY7ucFNt5z3A=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=HJANRPd9jWW5uB2gCQjXv83Ed1MvZB3hpoXOfmJRDO6iWqT+fJtRwypl7fk4QEj1q EX5sCM8NljU+G1+kjZbtV1BOlhd72nt+rQbQKm0DRurg4jokTDhn+gJRIlbHhZ4bTy YqaMVxq4Ur88q87rpbbJLwmZ/pED6hx6HD3wwIVg= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 372HjQFT115227 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 2 Aug 2023 12:45:26 -0500 Received: from DFLE102.ent.ti.com (10.64.6.23) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 2 Aug 2023 12:45:25 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 2 Aug 2023 12:45:25 -0500 Received: from fllv0040.itg.ti.com (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 372HjN0f027307; Wed, 2 Aug 2023 12:45:24 -0500 From: Andrew Davis <afd@ti.com> To: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>, Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, <linux-arm-kernel@lists.infradead.org> CC: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Andrew Davis <afd@ti.com> Subject: [PATCH 3/3] arm64: dts: ti: k3-am64: Fix epwm_tbclk node name to generic name Date: Wed, 2 Aug 2023 12:45:21 -0500 Message-ID: <20230802174521.236255-3-afd@ti.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230802174521.236255-1-afd@ti.com> References: <20230802174521.236255-1-afd@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773150700539860442 X-GMAIL-MSGID: 1773150700539860442 |
Series |
[1/3] arm64: dts: ti: k3-am62a: Remove syscon compatible from epwm_tbclk
|
|
Commit Message
Andrew Davis
Aug. 2, 2023, 5:45 p.m. UTC
The name "clock" is not allowed for nodes, use "clock-controller" to
remove the DTS check warning.
Signed-off-by: Andrew Davis <afd@ti.com>
---
arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hello Andrew, hello Nishanth On Wed, Aug 02, 2023 at 12:45:21PM -0500, Andrew Davis wrote: > The name "clock" is not allowed for nodes, use "clock-controller" to > remove the DTS check warning. > > Signed-off-by: Andrew Davis <afd@ti.com> > --- > arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi > index e27eb2e585f14..4e3e450e4e4c8 100644 > --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi > @@ -61,7 +61,7 @@ phy_gmii_sel: phy@4044 { > #phy-cells = <1>; > }; > > - epwm_tbclk: clock@4140 { > + epwm_tbclk: clock-controller@4140 { I was asked to do the exact same change here [1] by Nishanth, and I'm sending the updated patch in a short while. However I have one question, according to the devicetree-specification-v0.4.pdf [2] "2.2.2 Generic Names Recommendation", clock is a valid node name. While testing the DT (make CHECK_DTBS=y), I did not have any warning nor error. What am I missing? In addition to that I guess we should also update the example in the dt bindings yaml file. Francesco [1] https://lore.kernel.org/all/20230731142135.108477-2-francesco@dolcini.it/ [2] https://github.com/devicetree-org/devicetree-specification/releases/download/v0.4/devicetree-specification-v0.4.pdf
On 8/6/23 3:33 AM, Francesco Dolcini wrote: > Hello Andrew, hello Nishanth > > On Wed, Aug 02, 2023 at 12:45:21PM -0500, Andrew Davis wrote: >> The name "clock" is not allowed for nodes, use "clock-controller" to >> remove the DTS check warning. >> >> Signed-off-by: Andrew Davis <afd@ti.com> >> --- >> arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi >> index e27eb2e585f14..4e3e450e4e4c8 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi >> @@ -61,7 +61,7 @@ phy_gmii_sel: phy@4044 { >> #phy-cells = <1>; >> }; >> >> - epwm_tbclk: clock@4140 { >> + epwm_tbclk: clock-controller@4140 { > > I was asked to do the exact same change here [1] by Nishanth, and I'm > sending the updated patch in a short while. > > However I have one question, according to the > devicetree-specification-v0.4.pdf [2] "2.2.2 Generic Names > Recommendation", clock is a valid node name. > > While testing the DT (make CHECK_DTBS=y), I did not have any warning nor > error. > > What am I missing? > These nodes are not just any nodes, they are part of "ti,j721e-system-controller" (well not really, we have been just calling these areas that to sneak around the restrictions on "syscon", "simple-mfd" devices), and so can only have the node names specified by that binding [0]. I'm working to convert these areas to normal "simple-bus" nodes, when that is complete then the name "clock" will be fine again here. Andrew [0] https://www.kernel.org/doc/Documentation/devicetree/bindings/mfd/ti%2Cj721e-system-controller.yaml > In addition to that I guess we should also update the example in the dt > bindings yaml file. > > Francesco > > > [1] https://lore.kernel.org/all/20230731142135.108477-2-francesco@dolcini.it/ > [2] https://github.com/devicetree-org/devicetree-specification/releases/download/v0.4/devicetree-specification-v0.4.pdf
diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi index e27eb2e585f14..4e3e450e4e4c8 100644 --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi @@ -61,7 +61,7 @@ phy_gmii_sel: phy@4044 { #phy-cells = <1>; }; - epwm_tbclk: clock@4140 { + epwm_tbclk: clock-controller@4140 { compatible = "ti,am64-epwm-tbclk"; reg = <0x4130 0x4>; #clock-cells = <1>;