Message ID | 20230804102648.78683-1-hch@infradead.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:44a:b0:3f2:4152:657d with SMTP id ez10csp182534vqb; Fri, 4 Aug 2023 04:08:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEiMnzBy2u6xhDdlWX1j1NKX3R3o7nqBH1irzws12WGArlUXCWrd3I5+uD9edwX0Sw7Nb8E X-Received: by 2002:a17:90a:5215:b0:268:1222:6fef with SMTP id v21-20020a17090a521500b0026812226fefmr1119763pjh.23.1691147325647; Fri, 04 Aug 2023 04:08:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691147325; cv=none; d=google.com; s=arc-20160816; b=z08WRrJkpRzLqQYcQOo8Sy01iawnaHGdsxBbRnbshpQg1YU/2iVnBfO/OJMG1NdVnK n6j5SSMHgNoJ+XgsSnh9py9RqNqMeMezUbycmUvcBZmKo59ZQRF9sClN+2aqCFDNoNdo ooIhhVsEYbbaEl8BroiL/8vdSWIoQD4bsYPKpLCgx+qLPL91ike0ecwGs9GT0X67fpAe QOaT87JtGzqIDflLIcNh7l3nD6y+0NFzFU24QX3q4wyTw9Ni+Oy6RS/cCF8EvvZniFX1 IHj4CcboQh/Hi+bPkxqWAKyPZ+4YZhUdVoCdz1kew5WeWwKYQf0Wac57yAXrrPJ5n0Fq GaWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=wnWE9A0pZhmWQ/iig8cD0cvaXnMKj6c4FvYq9RiRE3o=; fh=RW3BeYGkdu0j07VTeKo4rUsUDjmOoTwZGr7M5E9qU3s=; b=msLVMopAgEfFlwoNkCIFfQioRkoQ2H7VTTyHhnTlkMDAc1ZzqTf32oS4/sTNRwZDke NH1mtUpezatVaKKtiEOaRZGpFRMhyhtfjbybQUoRj+ijx9aVq2udkv8bhFGLWy5atxh4 LIIPm+OBqtfu0w7cHC4fb5ZxbOqp+XBIxgdTD8N3L9k4apPVK3mtTfUoGdO2CdGNzErm smCdUBP4hgMuq4X4xecr0r9cRI0BrqNPlbYk4VgLN2VB9Rw3OBHmhTFmOmcx9hR3jrc+ Ceq+K2AtV73vhs/SRJAAt6zPD/o1raBWq1LQfHPLQAOUKoY3FtUxJeM5Rq2n2AZiw3qG N5qw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=LMW8wPAi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x12-20020a17090a530c00b0025979e8c246si1645682pjh.70.2023.08.04.04.08.32; Fri, 04 Aug 2023 04:08:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=LMW8wPAi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231325AbjHDK05 (ORCPT <rfc822;sukrut.bellary@gmail.com> + 99 others); Fri, 4 Aug 2023 06:26:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbjHDK0z (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 4 Aug 2023 06:26:55 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 635F52118; Fri, 4 Aug 2023 03:26:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=wnWE9A0pZhmWQ/iig8cD0cvaXnMKj6c4FvYq9RiRE3o=; b=LMW8wPAijZIexhoKO9XW2JQ+3Y QXJEgjlyjJlCxpMro/f1wYLCu7vv1PxQDFfDnr9e4ZwEAo9z023esGElNhyEXSwtZKGwUyE3XFMAv /I7G7hqQC8cyf1hbMtOy+RZzaRxyojzXpjNtipSw+/NPga3r2kWpAMhiFzJyrNx1nH6ijl5uMH7YZ L55Y3slIorUhz+Phlk7M0NAmPj/4zXHpbo9xNEZE0Ho8saJsYj/faD1DMCv77OMKW+C66NV54Rehl R4ZLcDtC0nrKH7rsp6A2RgMzE0WC7I0GV2iPx8szL8YyZ5nw3EVC/ClkN9GRNR+LG7GcMls6b6pqT vgo/3tQA==; Received: from 2a02-8389-2341-5b80-39d3-4735-9a3c-88d8.cable.dynamic.v6.surfer.at ([2a02:8389:2341:5b80:39d3:4735:9a3c:88d8] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qRs1E-00C7kp-0t; Fri, 04 Aug 2023 10:26:52 +0000 From: Christoph Hellwig <hch@infradead.org> To: axboe@kernel.dk Cc: lizetao1@huawei.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de> Subject: [PATCH] romfs: only select BUFFER_HEAD for the block based path Date: Fri, 4 Aug 2023 12:26:48 +0200 Message-Id: <20230804102648.78683-1-hch@infradead.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773295341853953765 X-GMAIL-MSGID: 1773296498057262889 |
Series |
romfs: only select BUFFER_HEAD for the block based path
|
|
Commit Message
Christoph Hellwig
Aug. 4, 2023, 10:26 a.m. UTC
selecting BUFFER_HEAD unconditionally does not work as romfs can also
be built with only the MTD backend and thus without CONFIG_BLOCK.
Fixes: 0f842210d97a ("fs/Kconfig: Fix compile error for romfs")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/romfs/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Christoph, On 2023/8/4 18:26, Christoph Hellwig wrote: > selecting BUFFER_HEAD unconditionally does not work as romfs can also > be built with only the MTD backend and thus without CONFIG_BLOCK. > > Fixes: 0f842210d97a ("fs/Kconfig: Fix compile error for romfs") > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > fs/romfs/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/romfs/Kconfig b/fs/romfs/Kconfig > index 3f6b550eee6192..f24a96a331af1b 100644 > --- a/fs/romfs/Kconfig > +++ b/fs/romfs/Kconfig > @@ -2,7 +2,6 @@ > config ROMFS_FS > tristate "ROM file system support" > depends on BLOCK || MTD > - select BUFFER_HEAD > help > This is a very small read-only file system mainly intended for > initial ram disks of installation disks, but it could be used for > @@ -58,6 +57,7 @@ endchoice > config ROMFS_ON_BLOCK > bool > default y if ROMFS_BACKED_BY_BLOCK || ROMFS_BACKED_BY_BOTH > + select BUFFER_HEAD > > config ROMFS_ON_MTD > bool I have tested the patch on my environment and it resolves the two compile errors reported by kernel test robot. The links are as follows: Link1: https://lore.kernel.org/oe-kbuild-all/202308031810.pQzGmR1v-lkp@intel.com/ Link2: https://lore.kernel.org/oe-kbuild-all/202308041329.6SK97Asr-lkp@intel.com/ Tested-by: Li Zetao <lizetao1@huawei.com> Thanks, Li Zetao
On 8/4/23 4:26?AM, Christoph Hellwig wrote: > selecting BUFFER_HEAD unconditionally does not work as romfs can also > be built with only the MTD backend and thus without CONFIG_BLOCK. I folded this in with the other one and made a note about that.
diff --git a/fs/romfs/Kconfig b/fs/romfs/Kconfig index 3f6b550eee6192..f24a96a331af1b 100644 --- a/fs/romfs/Kconfig +++ b/fs/romfs/Kconfig @@ -2,7 +2,6 @@ config ROMFS_FS tristate "ROM file system support" depends on BLOCK || MTD - select BUFFER_HEAD help This is a very small read-only file system mainly intended for initial ram disks of installation disks, but it could be used for @@ -58,6 +57,7 @@ endchoice config ROMFS_ON_BLOCK bool default y if ROMFS_BACKED_BY_BLOCK || ROMFS_BACKED_BY_BOTH + select BUFFER_HEAD config ROMFS_ON_MTD bool