Message ID | 20230803140551.970141-1-hugo@hugovil.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp1182694vqx; Thu, 3 Aug 2023 07:21:17 -0700 (PDT) X-Google-Smtp-Source: APBJJlE7YAgHc6tWPZqHDcHGwzWw9kENTfWGhjlkZLHn6Sr6rvgPrN29oOLIl4WrRNj0ZyzT9rzE X-Received: by 2002:a2e:9959:0:b0:2b9:ea17:5580 with SMTP id r25-20020a2e9959000000b002b9ea175580mr7104736ljj.17.1691072477368; Thu, 03 Aug 2023 07:21:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691072477; cv=none; d=google.com; s=arc-20160816; b=w+69KCzzXp2KV95fkmEZRVQ7o4GMv1XFdPQXA+KGTMTvsXynC6B3OM1ZVFU6icyjsO JHoCqin8n+rnlBuct/2sGD4AnnFs/5FAyRxS5uuM0Ey4EiXPiR77L2joAXhcOHrdiXdz hW3OtxcKpNu7bt98e88qO+kB6URLwlpXL/f5zHy+dQN0SR8wuq2G0Pyz8kzBFUJzqJ1D Dwnso6o6Ji31aPB6m0omkzH15tjctYW1IZ9etzh8o5Uq2XMz2vAKjYk4FdQ7GeqUWUVT eiFT8ydXcdxcJ/Xr6EPX3FQBobiVUGQ3uuaX9VczLV84ZtNBTQog31mksXvBITBjis/B A0HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :message-id:date:cc:to:from:dkim-signature; bh=ei2wCQs5a8m/K55enHBWGLUeT7zj3KuxqVqPoZlHPio=; fh=TwxkC3zY+bVEkgFVYro4G7PDIRTr+t75FbIsp7s20C4=; b=eSUhenlFvqhxkOupJ0rwJ8G31+igaXIVWCBeBl5IIi5vx7DijzNeJWD3ffcC5lsMO3 9eEkiGBgn5EdNLKq+Tj0mbLrswECnWqN2QOaCoya0Fy38eO5VrZbP9QWK9usuLXb77b0 kQ2oHzMMvpmgomspMDDLQpqS01Jk7J837UY8QBYJkOMkFT4IYU4Ovb5Kbu+N6ILpzqNF fmmdb+g/ScCtFT4DGg3U6UeD6wB2RUjjUbuIgI4GCAUjFInAmOHp/XMPiFzVZPAjvm3c bQOzVcguDeR7IjEIx+Iura6MMpWkXOGT1pvieFA1QQ2b8wYSEj+Sn8A4DFT1BaiH+abg VSxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=b0BgpSix; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l25-20020a1709066b9900b009888665e53fsi11548725ejr.190.2023.08.03.07.20.47; Thu, 03 Aug 2023 07:21:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=b0BgpSix; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235452AbjHCOHA (ORCPT <rfc822;guoshuai5156@gmail.com> + 99 others); Thu, 3 Aug 2023 10:07:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232999AbjHCOGo (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 3 Aug 2023 10:06:44 -0400 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDD0230E9; Thu, 3 Aug 2023 07:06:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Cc:To :From:Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=ei2wCQs5a8m/K55enHBWGLUeT7zj3KuxqVqPoZlHPio=; b=b 0BgpSixVIJOcmpcWBH6vWBTM1g1yaJTSN4HtX8wh7lf/OB2ViTYXM9e1EJLJGV86gFK+rD52QZEx2 StICkocnRmwFKeAKllQHt6vFv3HsJQXrSn1+p6ra36CSKTuVPs9z6FJh1DAqI/BnaxivPMdyqzrSe cALV3c5uZGY+TYEQ=; Received: from modemcable061.19-161-184.mc.videotron.ca ([184.161.19.61]:46952 helo=localhost.localdomain) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from <hugo@hugovil.com>) id 1qRYxe-0000O1-Vi; Thu, 03 Aug 2023 10:05:55 -0400 From: Hugo Villeneuve <hugo@hugovil.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jirislaby@kernel.org> Cc: hugo@hugovil.com, linux-serial@vger.kernel.org, Hugo Villeneuve <hvilleneuve@dimonoff.com>, linux-kernel@vger.kernel.org Date: Thu, 3 Aug 2023 10:05:51 -0400 Message-Id: <20230803140551.970141-1-hugo@hugovil.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 184.161.19.61 X-SA-Exim-Mail-From: hugo@hugovil.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Subject: [PATCH] serial: max310x: add comments for membase address workaround X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773218014177652251 X-GMAIL-MSGID: 1773218014177652251 |
Series |
serial: max310x: add comments for membase address workaround
|
|
Commit Message
Hugo Villeneuve
Aug. 3, 2023, 2:05 p.m. UTC
From: Hugo Villeneuve <hvilleneuve@dimonoff.com> Add comments about workaround used to configure membase address. This follows suggestions made during review of a sc16is7xx driver patch to add the same workaround. Link: https://lore.kernel.org/lkml/2936e18f-44ea-faed-9fa0-2ddefe7c3194@linux.intel.com Link: https://lore.kernel.org/lkml/20230801131655.80bd8f97f018dda6155d65f6@hugovil.com/ Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> --- drivers/tty/serial/max310x.c | 5 +++++ 1 file changed, 5 insertions(+) base-commit: 426263d5fb400ccde5444748693dc75bda18f01e
Comments
On Thu, Aug 03, 2023 at 10:05:51AM -0400, Hugo Villeneuve wrote: > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > Add comments about workaround used to configure membase address. This > follows suggestions made during review of a sc16is7xx driver patch to > add the same workaround. > > Link: https://lore.kernel.org/lkml/2936e18f-44ea-faed-9fa0-2ddefe7c3194@linux.intel.com > Link: https://lore.kernel.org/lkml/20230801131655.80bd8f97f018dda6155d65f6@hugovil.com/ > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> > --- > drivers/tty/serial/max310x.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c > index 416d553b73a7..5903dd033fd0 100644 > --- a/drivers/tty/serial/max310x.c > +++ b/drivers/tty/serial/max310x.c > @@ -1369,6 +1369,11 @@ static int max310x_probe(struct device *dev, const struct max310x_devtype *devty > s->p[i].port.flags = UPF_FIXED_TYPE | UPF_LOW_LATENCY; > s->p[i].port.iotype = UPIO_PORT; > s->p[i].port.iobase = i; > + /* > + * Use all ones as membase to make sure uart_configure_port() in > + * serial_core.c does not abort for SPI/I2C devices where the > + * membase address is not applicable. > + */ > s->p[i].port.membase = (void __iomem *)~0; > s->p[i].port.uartclk = uartclk; > s->p[i].port.rs485_config = max310x_rs485_config; > > base-commit: 426263d5fb400ccde5444748693dc75bda18f01e > -- > 2.30.2 > Meta-comment, your email system is not correct and is not able to be verified as I get the following when attempting to apply your patch: --- ✗ [PATCH] serial: max310x: add comments for membase address workaround --- ✗ BADSIG: DKIM/hugovil.com Please fix up for future submissions. thanks, greg k-h
On Fri, 4 Aug 2023 15:07:50 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > On Thu, Aug 03, 2023 at 10:05:51AM -0400, Hugo Villeneuve wrote: > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > > > Add comments about workaround used to configure membase address. This > > follows suggestions made during review of a sc16is7xx driver patch to > > add the same workaround. > > > > Link: https://lore.kernel.org/lkml/2936e18f-44ea-faed-9fa0-2ddefe7c3194@linux.intel.com > > Link: https://lore.kernel.org/lkml/20230801131655.80bd8f97f018dda6155d65f6@hugovil.com/ > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > --- > > drivers/tty/serial/max310x.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c > > index 416d553b73a7..5903dd033fd0 100644 > > --- a/drivers/tty/serial/max310x.c > > +++ b/drivers/tty/serial/max310x.c > > @@ -1369,6 +1369,11 @@ static int max310x_probe(struct device *dev, const struct max310x_devtype *devty > > s->p[i].port.flags = UPF_FIXED_TYPE | UPF_LOW_LATENCY; > > s->p[i].port.iotype = UPIO_PORT; > > s->p[i].port.iobase = i; > > + /* > > + * Use all ones as membase to make sure uart_configure_port() in > > + * serial_core.c does not abort for SPI/I2C devices where the > > + * membase address is not applicable. > > + */ > > s->p[i].port.membase = (void __iomem *)~0; > > s->p[i].port.uartclk = uartclk; > > s->p[i].port.rs485_config = max310x_rs485_config; > > > > base-commit: 426263d5fb400ccde5444748693dc75bda18f01e > > -- > > 2.30.2 > > > > Meta-comment, your email system is not correct and is not able to be > verified as I get the following when attempting to apply your patch: > > --- > ✗ [PATCH] serial: max310x: add comments for membase address workaround > --- > ✗ BADSIG: DKIM/hugovil.com > > Please fix up for future submissions. > > thanks, > > greg k-h Hi Greg, I will look into it. Thank you. Hugo.
On Fri, 4 Aug 2023 10:17:22 -0400 Hugo Villeneuve <hugo@hugovil.com> wrote: > On Fri, 4 Aug 2023 15:07:50 +0200 > Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > > On Thu, Aug 03, 2023 at 10:05:51AM -0400, Hugo Villeneuve wrote: > > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > > > > > Add comments about workaround used to configure membase address. This > > > follows suggestions made during review of a sc16is7xx driver patch to > > > add the same workaround. > > > > > > Link: https://lore.kernel.org/lkml/2936e18f-44ea-faed-9fa0-2ddefe7c3194@linux.intel.com > > > Link: https://lore.kernel.org/lkml/20230801131655.80bd8f97f018dda6155d65f6@hugovil.com/ > > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > > --- > > > drivers/tty/serial/max310x.c | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c > > > index 416d553b73a7..5903dd033fd0 100644 > > > --- a/drivers/tty/serial/max310x.c > > > +++ b/drivers/tty/serial/max310x.c > > > @@ -1369,6 +1369,11 @@ static int max310x_probe(struct device *dev, const struct max310x_devtype *devty > > > s->p[i].port.flags = UPF_FIXED_TYPE | UPF_LOW_LATENCY; > > > s->p[i].port.iotype = UPIO_PORT; > > > s->p[i].port.iobase = i; > > > + /* > > > + * Use all ones as membase to make sure uart_configure_port() in > > > + * serial_core.c does not abort for SPI/I2C devices where the > > > + * membase address is not applicable. > > > + */ > > > s->p[i].port.membase = (void __iomem *)~0; > > > s->p[i].port.uartclk = uartclk; > > > s->p[i].port.rs485_config = max310x_rs485_config; > > > > > > base-commit: 426263d5fb400ccde5444748693dc75bda18f01e > > > -- > > > 2.30.2 > > > > > > > Meta-comment, your email system is not correct and is not able to be > > verified as I get the following when attempting to apply your patch: > > > > --- > > ✗ [PATCH] serial: max310x: add comments for membase address workaround > > --- > > ✗ BADSIG: DKIM/hugovil.com > > > > Please fix up for future submissions. > > > > thanks, > > > > greg k-h > > Hi Greg, > I will look into it. Thank you. Hi Greg, I double-checked my DKIM setup, but everything looks fine. If I send emails to gmail or outlook servers, they both report "DKIM signature=pass", and I also checked with an online DKIM validation service and it is also ok. What tool are you using to check the DKIM signature? Thank you, Hugo.
On Mon, Aug 07, 2023 at 11:24:41AM -0400, Hugo Villeneuve wrote: > On Fri, 4 Aug 2023 10:17:22 -0400 > Hugo Villeneuve <hugo@hugovil.com> wrote: > > > On Fri, 4 Aug 2023 15:07:50 +0200 > > Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > > > > On Thu, Aug 03, 2023 at 10:05:51AM -0400, Hugo Villeneuve wrote: > > > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > > > > > > > Add comments about workaround used to configure membase address. This > > > > follows suggestions made during review of a sc16is7xx driver patch to > > > > add the same workaround. > > > > > > > > Link: https://lore.kernel.org/lkml/2936e18f-44ea-faed-9fa0-2ddefe7c3194@linux.intel.com > > > > Link: https://lore.kernel.org/lkml/20230801131655.80bd8f97f018dda6155d65f6@hugovil.com/ > > > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > > > --- > > > > drivers/tty/serial/max310x.c | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c > > > > index 416d553b73a7..5903dd033fd0 100644 > > > > --- a/drivers/tty/serial/max310x.c > > > > +++ b/drivers/tty/serial/max310x.c > > > > @@ -1369,6 +1369,11 @@ static int max310x_probe(struct device *dev, const struct max310x_devtype *devty > > > > s->p[i].port.flags = UPF_FIXED_TYPE | UPF_LOW_LATENCY; > > > > s->p[i].port.iotype = UPIO_PORT; > > > > s->p[i].port.iobase = i; > > > > + /* > > > > + * Use all ones as membase to make sure uart_configure_port() in > > > > + * serial_core.c does not abort for SPI/I2C devices where the > > > > + * membase address is not applicable. > > > > + */ > > > > s->p[i].port.membase = (void __iomem *)~0; > > > > s->p[i].port.uartclk = uartclk; > > > > s->p[i].port.rs485_config = max310x_rs485_config; > > > > > > > > base-commit: 426263d5fb400ccde5444748693dc75bda18f01e > > > > -- > > > > 2.30.2 > > > > > > > > > > Meta-comment, your email system is not correct and is not able to be > > > verified as I get the following when attempting to apply your patch: > > > > > > --- > > > ✗ [PATCH] serial: max310x: add comments for membase address workaround > > > --- > > > ✗ BADSIG: DKIM/hugovil.com > > > > > > Please fix up for future submissions. > > > > > > thanks, > > > > > > greg k-h > > > > Hi Greg, > > I will look into it. Thank you. > > Hi Greg, > I double-checked my DKIM setup, but everything looks fine. If I send > emails to gmail or outlook servers, they both report "DKIM > signature=pass", and I also checked with an online DKIM validation > service and it is also ok. > > What tool are you using to check the DKIM signature? The patatt tool as part of `b4`. I just checked, your direct email to me here passes, BUT the message you sent to the mailing list did not. Check it out yourself, look at the message on lore.kernel.org for this response and see if that passes the DKIM check or not. thanks, greg k-h
On Mon, 7 Aug 2023 17:27:38 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > On Mon, Aug 07, 2023 at 11:24:41AM -0400, Hugo Villeneuve wrote: > > On Fri, 4 Aug 2023 10:17:22 -0400 > > Hugo Villeneuve <hugo@hugovil.com> wrote: > > > > > On Fri, 4 Aug 2023 15:07:50 +0200 > > > Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > > > > > > On Thu, Aug 03, 2023 at 10:05:51AM -0400, Hugo Villeneuve wrote: > > > > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > > > > > > > > > Add comments about workaround used to configure membase address. This > > > > > follows suggestions made during review of a sc16is7xx driver patch to > > > > > add the same workaround. > > > > > > > > > > Link: https://lore.kernel.org/lkml/2936e18f-44ea-faed-9fa0-2ddefe7c3194@linux.intel.com > > > > > Link: https://lore.kernel.org/lkml/20230801131655.80bd8f97f018dda6155d65f6@hugovil.com/ > > > > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > > > > --- > > > > > drivers/tty/serial/max310x.c | 5 +++++ > > > > > 1 file changed, 5 insertions(+) > > > > > > > > > > diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c > > > > > index 416d553b73a7..5903dd033fd0 100644 > > > > > --- a/drivers/tty/serial/max310x.c > > > > > +++ b/drivers/tty/serial/max310x.c > > > > > @@ -1369,6 +1369,11 @@ static int max310x_probe(struct device *dev, const struct max310x_devtype *devty > > > > > s->p[i].port.flags = UPF_FIXED_TYPE | UPF_LOW_LATENCY; > > > > > s->p[i].port.iotype = UPIO_PORT; > > > > > s->p[i].port.iobase = i; > > > > > + /* > > > > > + * Use all ones as membase to make sure uart_configure_port() in > > > > > + * serial_core.c does not abort for SPI/I2C devices where the > > > > > + * membase address is not applicable. > > > > > + */ > > > > > s->p[i].port.membase = (void __iomem *)~0; > > > > > s->p[i].port.uartclk = uartclk; > > > > > s->p[i].port.rs485_config = max310x_rs485_config; > > > > > > > > > > base-commit: 426263d5fb400ccde5444748693dc75bda18f01e > > > > > -- > > > > > 2.30.2 > > > > > > > > > > > > > Meta-comment, your email system is not correct and is not able to be > > > > verified as I get the following when attempting to apply your patch: > > > > > > > > --- > > > > ✗ [PATCH] serial: max310x: add comments for membase address workaround > > > > --- > > > > ✗ BADSIG: DKIM/hugovil.com > > > > > > > > Please fix up for future submissions. > > > > > > > > thanks, > > > > > > > > greg k-h > > > > > > Hi Greg, > > > I will look into it. Thank you. > > > > Hi Greg, > > I double-checked my DKIM setup, but everything looks fine. If I send > > emails to gmail or outlook servers, they both report "DKIM > > signature=pass", and I also checked with an online DKIM validation > > service and it is also ok. > > > > What tool are you using to check the DKIM signature? > > The patatt tool as part of `b4`. I just checked, your direct email to > me here passes, BUT the message you sent to the mailing list did not. > Check it out yourself, look at the message on lore.kernel.org for this > response and see if that passes the DKIM check or not. Hi Greg, if I look on lore.kernel.org for this response, here it is: https://lore.kernel.org/all/2023080738-headcount-jigsaw-efb7@gregkh/raw If I save this raw message and run it thru patatt, I get: $ patatt validate test-lore.kernel.mail NOSIG | Re: [PATCH] serial: max310x: add comments for membase address workaround | no signatures found But if I use another tool, dkimverify (from dkimpy), then it works ok: $ dkimverify < test-lore.kernel.mail signature ok and if I check the original patch: https://lore.kernel.org/all/20230803140551.970141-1-hugo@hugovil.com/raw I also get a similar failure like you did: $ dkimverify < test-lore.kernel-original-patch.mail signature verification failed The only difference between the two is that the original patch was sent using 'git send-email'. But in the end, both messages passed thru the same server (my mail server) running Exim4 v4.92 on a Debian box. I found that by modifying my Exim configuration and adding the following (simpler configuration) seems to solve the problem with 'git send-email' and DKIM: --------------- DKIM_SIGN_HEADERS = content-transfer-encoding:mime-version:message-id:date:subject:to:from:cc:subject:date:message-id:reply-to --------------- I am not an expert in Exim, and I am not sure this is the most elegant solution, but hope this can help others... Thank you, Hugo.
diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c index 416d553b73a7..5903dd033fd0 100644 --- a/drivers/tty/serial/max310x.c +++ b/drivers/tty/serial/max310x.c @@ -1369,6 +1369,11 @@ static int max310x_probe(struct device *dev, const struct max310x_devtype *devty s->p[i].port.flags = UPF_FIXED_TYPE | UPF_LOW_LATENCY; s->p[i].port.iotype = UPIO_PORT; s->p[i].port.iobase = i; + /* + * Use all ones as membase to make sure uart_configure_port() in + * serial_core.c does not abort for SPI/I2C devices where the + * membase address is not applicable. + */ s->p[i].port.membase = (void __iomem *)~0; s->p[i].port.uartclk = uartclk; s->p[i].port.rs485_config = max310x_rs485_config;