Message ID | 20230803211331.140553-2-ilkka@os.amperecomputing.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp1437887vqx; Thu, 3 Aug 2023 15:20:06 -0700 (PDT) X-Google-Smtp-Source: APBJJlGvyhUQF5ASnfA34tqftr16C943rvjGiW6q3+YhN+w27YxaAy2v0AUW5RlwwsopNubFfA14 X-Received: by 2002:a05:6a00:2d23:b0:67f:8ef5:2643 with SMTP id fa35-20020a056a002d2300b0067f8ef52643mr17771435pfb.2.1691101206240; Thu, 03 Aug 2023 15:20:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1691101206; cv=pass; d=google.com; s=arc-20160816; b=rSFyFHgM1DPrmP55cOEQdaXCohNn2jsLV/EfFmosX0JcJUCUV6E2qvD/K2fLf1ShgU X7L8TTOAj1p09jud+rcneeNHX7v+kw2BKRWX1XlCwbT5WG9Cd98Ubmb5fzfnCykaFSEg DBQlHTRP37LsVWzAZyuxPPiD5ZbalgrNaTdC4P36xphKuofd+42267Dtky8ut/w0Zxrs gDBsNV34skDEVLfVlatOgLPM4ovhHAK+QozwnK6nH0DXkQp4wzrt9GOebnyZYmIipfnj dfrBGQz0l87wMmp8aIKzIABBgLUYm7WYsxZcLvnEA+5I6rTcPJ7KC/IngR6ZSUnJRC6h t5dA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=v+noMXr/uwU33h6hP/EjN9EZSjDbRJo9mpYzNp13WN0=; fh=y/Q+fm44QmqbhqhywLeXYhRMDGtmOisRwbQezgRqi+8=; b=idv6MF2BtyPrIMbK+gnNiCXEOP5dj4zcNrUDztSivB2Hq3UauoaNMqLABsbLybxPcz 60j6r+KOw1ingfBE6+bRP9e/NvBhNBe5TKWROk2j4Xsjdbp3ttiDPNTUhGQhKNpjL831 JmDdMkQsq5E76W8+kJwiNYM+aBuSj+uXCi+e8bCLNnOuEynHiL3Pn/qntcMSAV7SJ2iA XPM2Xcs6OLm48yVFxnwBZ51mm3ORaq++SFG37B14kiVb5qaWCnK0NHBVsQE9PtVKzyDy YbRdpcW/IDwFeLYLDEkIQh27fQ+virEvqC1ulMrW2pS48YAEcUlgYlBoWQeQFTY95xeN wIqQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@os.amperecomputing.com header.s=selector2 header.b="i/jk6ZmN"; arc=pass (i=1 spf=pass spfdomain=os.amperecomputing.com dkim=pass dkdomain=os.amperecomputing.com dmarc=pass fromdomain=os.amperecomputing.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amperecomputing.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c4-20020a056a00248400b0067af445c0f0si654095pfv.291.2023.08.03.15.19.53; Thu, 03 Aug 2023 15:20:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@os.amperecomputing.com header.s=selector2 header.b="i/jk6ZmN"; arc=pass (i=1 spf=pass spfdomain=os.amperecomputing.com dkim=pass dkdomain=os.amperecomputing.com dmarc=pass fromdomain=os.amperecomputing.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amperecomputing.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230233AbjHCVOf (ORCPT <rfc822;tertiaryakionsight@gmail.com> + 99 others); Thu, 3 Aug 2023 17:14:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230018AbjHCVOa (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 3 Aug 2023 17:14:30 -0400 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07DCE211E; Thu, 3 Aug 2023 14:14:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E1yvcKsScEWc8DEnfci170o6udQ3o66wHdG+K604lp9ChCpG+gRBsnb48N9Punzt4KG6/8HeDTNhcZcHtNqwzf17gRpQ7hvO5RaBwOhvyHqvV6t4E/jZOz8z07blGUsTVm5cWh3ybk/+nPtaepVLSK8oUgaS/KnQDnGgsdKtQK5FUIHUF6F25N7DXR5aDBzUDCEfEe8PvKszzkKvj/vh4nu8mMeKhH/0IItN1rd/xOHyOQMz51Pow0HZ7d5c/TpxzP9h5DySiQDRDoxpT98PhdE8VePSooXbEFj3WcTxURlIVZIRRPRIfXE0y6DAMmOI7uZ3fH9qDem+Oi44Dqc/RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v+noMXr/uwU33h6hP/EjN9EZSjDbRJo9mpYzNp13WN0=; b=VycSRnxDHXEh+eLLhzlFnzNala1nS0uXgZzbsB2rrRLTOCJWmUjxWnkvGPPh3nvNnwivRqnBOAS7wTbuwDLEdo0TGDPKgVrDVrbyBCFKUXOMX8pagbHTJ2p2vFLXLAnHfn1RuMUP3+Tz3IjFqEvlQePhvgmt4X2AH+XImEOGbKv+lGMEkhF2/4dcRuQz8gxjs1zOQzFLdos5QN3+rW7s8Sy9YUsYpcGjqMmVviMWzZAh3arkIN0w36i4g+UEY7TUv+cL8GCUOKOPAkWl5n8kB7AcfEvAPx8G9UEXjsqD1c7BrSaVEz8V77C5zhjs/CwD9o+IpiuvYBg7hYfNQJhFog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v+noMXr/uwU33h6hP/EjN9EZSjDbRJo9mpYzNp13WN0=; b=i/jk6ZmNsFOIe7fXrOwyClArZweT8smcYeDA59Uk+RV3FqGwm/4LsvnrtPx5rGha4prHqf+OOG7gdODNE/2slpdTrchlbJnlulAtUMidNimJ2RtCAXxm3cm0bkJ98+FmuTqvY6YybU092K3Ysg4Ec/A908RrwbKb1SfwJKqBhMw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from DM5PR0102MB3590.prod.exchangelabs.com (2603:10b6:4:a4::25) by SA3PR01MB8502.prod.exchangelabs.com (2603:10b6:806:39f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 21:14:26 +0000 Received: from DM5PR0102MB3590.prod.exchangelabs.com ([fe80::4e0f:49b:ee39:f08e]) by DM5PR0102MB3590.prod.exchangelabs.com ([fe80::4e0f:49b:ee39:f08e%6]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 21:14:26 +0000 From: Ilkka Koskinen <ilkka@os.amperecomputing.com> To: John Garry <john.g.garry@oracle.com>, Ian Rogers <irogers@google.com>, Arnaldo Carvalho de Melo <acme@kernel.org> Cc: Will Deacon <will@kernel.org>, James Clark <james.clark@arm.com>, Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Mark Rutland <mark.rutland@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>, Adrian Hunter <adrian.hunter@intel.com>, Ilkka Koskinen <ilkka@os.amperecomputing.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Dave Kleikamp <dave.kleikamp@oracle.com> Subject: [PATCH 1/4] perf vendor events arm64: Remove L1D_CACHE_LMISS from AmpereOne list Date: Thu, 3 Aug 2023 14:13:28 -0700 Message-Id: <20230803211331.140553-2-ilkka@os.amperecomputing.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230803211331.140553-1-ilkka@os.amperecomputing.com> References: <20230803211331.140553-1-ilkka@os.amperecomputing.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: CH2PR15CA0006.namprd15.prod.outlook.com (2603:10b6:610:51::16) To DM5PR0102MB3590.prod.exchangelabs.com (2603:10b6:4:a4::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR0102MB3590:EE_|SA3PR01MB8502:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f8f917b-25cb-4cfb-bd57-08db94669e43 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BMpCub7a0PSMjSGHPQI+0p1kyIRoEXYypeIlsrp27hF9gYd71StYvZ7hHM8r5BrVAt7P7QRExvb3Afc0FoIhIQ97U4tnjGpbnugpAGmh6GxOATU7q1yZX0sj8sYkQ2mQdsicbyG+zxzBEm8JLgfBr9XyrUM8/5jb0tTVv2V/1rZ0AQjgAxmy0QTepjwyz/xde1SPGDptvGOjJAcOKWpatgfpvLx5ItxIS+v348jEOcVrPcSz5cbgI5kstlCYWlk0UeDDDcUKFIzAS+cyHrjhxe++cX8RgxBP5JgKb0a6rsFI0RcQG3DF0KViGRuREINw2yeEyBvLix+ERIzeaq4McsHaPUPhoS45/EEap/SXH2eCfQ2dMA5ZFVIh0pcClSEjYOd0qNjIayip8T3Cb9NJDDvepKrgmclSpWUQypJ690K0qqhHkaUZzfPFGThRq9q6hoRjGtdJttmQI6OC6eb7mvT3bwPztKU0vjqq/fQVuxJGVsMvfDRCXvUynrUjml3Q9BDEhT+f8V8HVyh+A4ra+QCuxjMfLbz6BmE+YLIiMDCNgyHTaLoszbpVervbTb1VEG6QWCeCYNE+/ILlsh9fjS11bcnlrFJ8t8Kjc6p725k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR0102MB3590.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39850400004)(396003)(366004)(376002)(136003)(346002)(186005)(451199021)(86362001)(52116002)(54906003)(478600001)(110136005)(38100700002)(38350700002)(8676002)(1076003)(2616005)(6506007)(83380400001)(26005)(41300700001)(7416002)(8936002)(6486002)(6512007)(966005)(2906002)(316002)(66556008)(66476007)(5660300002)(4326008)(66946007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /Q0jBy+1xxmyhqiW7vSx2v7c9wi5lnoCpjfl/kEXz1Cu37jdZhFfx5lK9pj5HsNWXxACMOM/PxOmg3TPlx0T7QQZ3L+Qjj5Mm+CM7au7e0Se8KYxv7fr2Sg0wzykrNwGGMu0NVbMNmy7E0YAJ9aJs9kfkG3hPwBYip08WgsOR4bOmWWKLNml5+A1Fa3LWMf9bY1RiLfs61UbsvQ+BW/rZtzn8aTFEUpF6G5GEOqaeL92mMSto9mqweYrfRI7HQv5+7ECEQS1xKoW6KO+nkygOClwnEkW8OiX7AG8SgstAwiRyQgpHcAgYOqrjt8+4ZcJqP88jgZ2wu7p2cQFChdCYtW4+4lTnDHJPX9ptdV1g723s6QL8XyG49B7tDOyBuLN11eSP7PNjP00niTjS5p++HGajrWFcXMXnAVnfeVgt4YiSzFjmV5Y8ZbymvYGogVaqvEMoCr20N7d8ft+2Sc9pH2+0zGZr/+ZofeaGiYA2OEiKuPEzz4jiM67rltpOynmKZJH7Rf/xcWHieddvN5AgoQ6F7HY9z+wyOfk6L9tCHBWjyS/WSrub8CHd/yJEtJ9gLgPKmYzIQ+SUSFIvlAs0cBUAZo/YfBZseq+8eEv9GqAzaQm3/q5o7ePZQIS9qMUdZTDCfcB/G69hTZDTsOZdwYAHALxYA7uzOvmSENc1obuuOwTgb+/VfxkHJtTXSVyHDfb10iPlM65R720D9lO5QAKZnOuvZ+qfoPTDPej+3cLQ6wHUY8dcsjqkR30mWrLIHL0MKjelPYgTu+B8I4Ue0q++7BpzZ2rfRGieml4FnHAY8j8XPLdcX+uYnnA4SX9ITcTm9qkOQNmPMJBhXovZpI/J1UW7//zSWA+HLS34YTLOUwUAtpdMSN+/JPI8q3LCqin9/GcEeBxacDHCP8lD5xvvyglw1zic6gpfzMpcXTvGd3hXlnBhixSZdGMKc+G5vt2bNOp1fP41jzBL6cCBb4wdBl6H0L6TX/LaZMLNPXopWAjqPkCnaApuXucNgtHAdUX+XLtpRy8DEdLGtHTq8nv8/Jbeb6mfojt4nsQypNEC1piEVhFVP6Tool9zQ15M/UXHfwpSiLZoUCKKKL+DQiUhIOrDr1sBSr91Z5ll1YaVfkU72A+OnQ9ZkESrGaMTerIpOrcK3qR7fiOO2UoZfILZt6UH0LkI+xO8dyC7HrKe5wGHR/VMCL2lICpBfh8JpjFn1oY7zP9LfT8KCo8K/oPCxS7bmk5BMELB3oagO5dE6TW5U0NI6asJVfC1kdq5CEQqks4Jd/gj7VZ7xV8lbTVYbxVb7hWzquOLgY4LLDmg2JVTjZg0Ggks3Ts9Q3bx+0HVUn790JR6x7w7EFXhNNFk5E5TlqWA7tXMLZ7vjCjM2hDR2iIrmQAEshz9nGEPS/ZHK3/+p9i/QCt1rMeMkkxxtO4y+OYap4DfDjCkinK5sGyLf2IUsIxjQh0VKTUng6dAAGu9rhbDPUp3EO1bbnVMXXi0bMLGWjdDf5BbWGBHouEUdcT3SopISfH9vVLK/jK+CXh0numEbVtWCH4svfAS1U7ISwu25IQpEiWP13m/skVn7mjABJZ/eD7uOxYaxGwLvOqKfCn4uzgH6wQ1Q== X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f8f917b-25cb-4cfb-bd57-08db94669e43 X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3590.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 21:14:26.7395 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bMeyP6hxOpk0z7PVgWfP4FBa1SXrHL9oNGOxkRSyf/p4x3dLEEtWpY8qld1NO9+YYsvl/6F4J1DlTJlFataHetJySv703+U9dVOfy0yI6URnuhJij/qyjfsZZFjGOnAI X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR01MB8502 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773248138354999298 X-GMAIL-MSGID: 1773248138354999298 |
Series |
perf vendor events arm64: AmpereOne: Core PMU event update and metrics
|
|
Commit Message
Ilkka Koskinen
Aug. 3, 2023, 9:13 p.m. UTC
amperene/cache.json file tried to include L1D_CACHE_LMISS while it
doesn't exist in common-and-microarch.json. While this bug doesn't seem to
cause issue in newer kernels with jevents.py script, it prevents building
older perf tools with the backported patch.
Fixes: a9650b7f6fc0 ("perf vendor events arm64: Add AmpereOne core PMU events")
Reported-by: Dave Kleikamp <dave.kleikamp@oracle.com>
Closes: https://lore.kernel.org/all/76bb2e47-ce44-76ae-838e-53279047084d@oracle.com/
Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
---
tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json | 3 ---
1 file changed, 3 deletions(-)
Comments
On 03/08/2023 22:13, Ilkka Koskinen wrote: > amperene/cache.json file tried to include L1D_CACHE_LMISS while it > doesn't exist in common-and-microarch.json. While this bug doesn't seem to > cause issue in newer kernels with jevents.py script, it prevents building > older perf tools with the backported patch. jevents.py needs to be improved so it errors on these events which cannot be fixed up, like it used to. I'll look to do that when I get a chance. > > Fixes: a9650b7f6fc0 ("perf vendor events arm64: Add AmpereOne core PMU events") > Reported-by: Dave Kleikamp <dave.kleikamp@oracle.com> > Closes: https://urldefense.com/v3/__https://lore.kernel.org/all/76bb2e47-ce44-76ae-838e-53279047084d@oracle.com/__;!!ACWV5N9M2RV99hQ!IlO3yUW8jhm6wp8BJalODmD7WjzJleyREtTWS2pdn90Af5BD3P7g0fTGldbw15pSn49ycWiKpWDysjXw_ECS4XbbJQ$ > Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com> Reviewed-by: John Garry <john.g.garry@oracle.com> > --- > tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json > index fc0633054211..7a2b7b200f14 100644 > --- a/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json > +++ b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json > @@ -92,9 +92,6 @@ > { > "ArchStdEvent": "L1D_CACHE_LMISS_RD" > }, > - { > - "ArchStdEvent": "L1D_CACHE_LMISS" > - }, > { > "ArchStdEvent": "L1I_CACHE_LMISS" > },
diff --git a/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json index fc0633054211..7a2b7b200f14 100644 --- a/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json +++ b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json @@ -92,9 +92,6 @@ { "ArchStdEvent": "L1D_CACHE_LMISS_RD" }, - { - "ArchStdEvent": "L1D_CACHE_LMISS" - }, { "ArchStdEvent": "L1I_CACHE_LMISS" },