diff mbox series

[v2,-next] misc: hi6421-spmi-pmic: Remove redundant dev_err()

Message ID 20230726180707.2486808-1-ruanjinjie@huawei.com
State New
Headers
Series [v2,-next] misc: hi6421-spmi-pmic: Remove redundant dev_err() |

Commit Message

Jinjie Ruan July 26, 2023, 6:07 p.m. UTC 
  There is no need to call the dev_err() function directly to print a custom
message when handling an error from the platform_get_irq() function as it
is going to display an appropriate error message in case of a failure.

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
---
v2:
- fix the coding style errors
---
 drivers/misc/hi6421v600-irq.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Jinjie Ruan Aug. 4, 2023, 1:14 a.m. UTC | #1 
Ping.

On 2023/7/27 2:07, Ruan Jinjie wrote:
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from the platform_get_irq() function as it
> is going to display an appropriate error message in case of a failure.
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
> ---
> v2:
> - fix the coding style errors
> ---
>  drivers/misc/hi6421v600-irq.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/misc/hi6421v600-irq.c b/drivers/misc/hi6421v600-irq.c
> index caa3de37698b..b075d803a2c2 100644
> --- a/drivers/misc/hi6421v600-irq.c
> +++ b/drivers/misc/hi6421v600-irq.c
> @@ -244,10 +244,8 @@ static int hi6421v600_irq_probe(struct platform_device *pdev)
>  	pmic_pdev = container_of(pmic_dev, struct platform_device, dev);
>  
>  	priv->irq = platform_get_irq(pmic_pdev, 0);
> -	if (priv->irq < 0) {
> -		dev_err(dev, "Error %d when getting IRQs\n", priv->irq);
> +	if (priv->irq < 0)
>  		return priv->irq;
> -	}
>  
>  	platform_set_drvdata(pdev, priv);
>
diff mbox series

Patch

diff --git a/drivers/misc/hi6421v600-irq.c b/drivers/misc/hi6421v600-irq.c
index caa3de37698b..b075d803a2c2 100644
--- a/drivers/misc/hi6421v600-irq.c
+++ b/drivers/misc/hi6421v600-irq.c
@@ -244,10 +244,8 @@  static int hi6421v600_irq_probe(struct platform_device *pdev)
 	pmic_pdev = container_of(pmic_dev, struct platform_device, dev);
 
 	priv->irq = platform_get_irq(pmic_pdev, 0);
-	if (priv->irq < 0) {
-		dev_err(dev, "Error %d when getting IRQs\n", priv->irq);
+	if (priv->irq < 0)
 		return priv->irq;
-	}
 
 	platform_set_drvdata(pdev, priv);