Message ID | 20230724144108.2582917-1-ruanjinjie@huawei.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp1612592vqg; Sun, 23 Jul 2023 23:48:32 -0700 (PDT) X-Google-Smtp-Source: APBJJlEPUR573MBNVzFmRMloXXVbGBnFdymomM+Vznq33x0ZTRZ3SSE98AbU6EHgV063S/YSUu0e X-Received: by 2002:a17:90b:f92:b0:268:13c4:b7fe with SMTP id ft18-20020a17090b0f9200b0026813c4b7femr3382499pjb.5.1690181312347; Sun, 23 Jul 2023 23:48:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690181312; cv=none; d=google.com; s=arc-20160816; b=rb2QVwAoKG4jc6utP7uUV9CkrFzAaHvRzmUTjSvDFJOm+9D6Cpfz4eBpp2bLV3soId v3/1zgg0jaEOV3V2l4euoGsJ6mjcF5Js3LmIJCP7wBM1Pi9kM5FT9vmjNZU3htEZTVAf /ujm46Iu04hRaCvriJpppd8whxThiDCFQby4gIxV/4F5ir8FsEdwL88ZFdBTRzhzCUuR 1XaZzCDrSJqYAZ66JatppFW5w0cxAtWUpCbloSJgoOxxRETPV+myChwh5WE7BXOaeEjM mt+M+LudYII2Jc5twnC8ihJT4ZtgVmKU6uCC2dX+tfGbdFYY/p+n0cmonepLO9Is1/Tj 55vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=82yGxjncFUw20Ufu7eSHiWPbKeWo+ErrobryxnklClE=; fh=ZyGx/N37Q00e0ZmHJsJOXJ16T+NnkQ95VZkoRSEQHGQ=; b=x0CAjuLWCH8cH7iGl+TkrvWOh6GILjGIW5/tgqbtwBc4IWymrLrVe8TG1X429KkvB7 r1P8eNbtKWCVwjIMDmZ8kdGSURM4WEs4Dja0wvjou+QBwJ1uw5COGN8KGfLjBbXXhCmG PM7RT0PfEXSCoBETfBOo2wDHkpomOXj3bKp7Kd8lkIOzDm9F/3CIhsXJV4dYVcezaZiC w6fq8nV7yzW2KOKl/CSNxfFoIYi/h/vAxbR3GoqqboA6rVKYkFF9C9e0HngqYjuuu6pC +n2/Bz/faCw0dIxl7HTp46xa1K7L7N0vNcq38tM8P4WLB64msdUMudp2IePdPz7ccb1j 6OgQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ot1-20020a17090b3b4100b00262f937bf93si9347804pjb.77.2023.07.23.23.48.19; Sun, 23 Jul 2023 23:48:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230517AbjGXGm1 (ORCPT <rfc822;kautuk.consul.80@gmail.com> + 99 others); Mon, 24 Jul 2023 02:42:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230521AbjGXGmX (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 24 Jul 2023 02:42:23 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 062D910FA; Sun, 23 Jul 2023 23:41:47 -0700 (PDT) Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4R8VpZ13ptzHqc2; Mon, 24 Jul 2023 14:37:58 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 24 Jul 2023 14:40:30 +0800 From: Ruan Jinjie <ruanjinjie@huawei.com> To: <linus.walleij@linaro.org>, <vkoul@kernel.org>, <akpm@linux-foundation.org>, <dan.j.williams@intel.com>, <srinidhi.kasagar@stericsson.com>, <linux-arm-kernel@lists.infradead.org>, <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org> CC: <ruanjinjie@huawei.com> Subject: [PATCH -next] dmaengine: ste_dma40: Add missing IRQ check in d40_probe Date: Mon, 24 Jul 2023 14:41:08 +0000 Message-ID: <20230724144108.2582917-1-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772283559484831931 X-GMAIL-MSGID: 1772283559484831931 |
Series |
[-next] dmaengine: ste_dma40: Add missing IRQ check in d40_probe
|
|
Commit Message
Jinjie Ruan
July 24, 2023, 2:41 p.m. UTC
From: ruanjinjie <ruanjinjie@huawei.com> Check for the return value of platform_get_irq(): if no interrupt is specified, it wouldn't make sense to call request_irq(). Fixes: 8d318a50b3d7 ("DMAENGINE: Support for ST-Ericssons DMA40 block v3") Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> --- drivers/dma/ste_dma40.c | 4 ++++ 1 file changed, 4 insertions(+)
Comments
Ping. On 2023/7/24 22:41, Ruan Jinjie wrote: > From: ruanjinjie <ruanjinjie@huawei.com> > > Check for the return value of platform_get_irq(): if no interrupt > is specified, it wouldn't make sense to call request_irq(). > > Fixes: 8d318a50b3d7 ("DMAENGINE: Support for ST-Ericssons DMA40 block v3") > Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> > --- > drivers/dma/ste_dma40.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c > index 825001bde42c..89e82508c133 100644 > --- a/drivers/dma/ste_dma40.c > +++ b/drivers/dma/ste_dma40.c > @@ -3590,6 +3590,10 @@ static int __init d40_probe(struct platform_device *pdev) > spin_lock_init(&base->lcla_pool.lock); > > base->irq = platform_get_irq(pdev, 0); > + if (base->irq < 0) { > + ret = base->irq; > + goto destroy_cache; > + } > > ret = request_irq(base->irq, d40_handle_interrupt, 0, D40_NAME, base); > if (ret) {
On Mon, Jul 24, 2023 at 8:40 AM Ruan Jinjie <ruanjinjie@huawei.com> wrote: > From: ruanjinjie <ruanjinjie@huawei.com> > > Check for the return value of platform_get_irq(): if no interrupt > is specified, it wouldn't make sense to call request_irq(). > > Fixes: 8d318a50b3d7 ("DMAENGINE: Support for ST-Ericssons DMA40 block v3") > Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c index 825001bde42c..89e82508c133 100644 --- a/drivers/dma/ste_dma40.c +++ b/drivers/dma/ste_dma40.c @@ -3590,6 +3590,10 @@ static int __init d40_probe(struct platform_device *pdev) spin_lock_init(&base->lcla_pool.lock); base->irq = platform_get_irq(pdev, 0); + if (base->irq < 0) { + ret = base->irq; + goto destroy_cache; + } ret = request_irq(base->irq, d40_handle_interrupt, 0, D40_NAME, base); if (ret) {